152428 2015-12-18 09:16:24 -0800 [GTK] jquery.min.js violates DFSG 2015-12-21 01:05:10 -0800 1 1 1 Unclassified WebKit Web Inspector Other PC All RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bburg berto cgarcia commit-queue graouts joepeck mattbaker mcatanzaro nvasilyev timothy webkit-bug-importer oldest_to_newest 1150292 0 mcatanzaro 2015-12-18 09:16:24 -0800 Debian is repackaging our tarballs with Source/WebInspectorUI/Tools/PrettyPrinting/populate/jquery.min.js removed, since it is a violation of the Debian Free Software Guidelines to distribute compressed code without the original source. A straightforward solution for GTK would be to simply not distribute Source/WebInspectorUI/Tools. I doubt we need any of that for the build, anyway, right? 1150330 1 joepeck 2015-12-18 10:40:36 -0800 Correct, Source/WebInspectorUI/Tools is not needed for the WebInspectorUI project to build. They are only debugging tools. Currently only one for pretty printing. WebInspectorUI's pretty printing debugging tool just loads the jquery.min.js text for testing JavaScript pretty printing. It was chosen because jquery.min.js was already in the LayoutTests directory. We could probably replace it with any significantly complex and minified JavaScript. 1150348 2 mcatanzaro 2015-12-18 11:10:19 -0800 Well the issue is that it is minified; Debian requires us to ship the original source, not the minified source, and build the minified source from the original source. I think Fedora requires this too; we just didn't notice. Anyway, since it's just a debugging tool that has no value in tarballs, let's just not distribute it. Problem solved. :) 1150352 3 267644 mcatanzaro 2015-12-18 11:14:49 -0800 Created attachment 267644 Patch 1150354 4 mcatanzaro 2015-12-18 11:18:11 -0800 Although arguably, we could say this is a false-positive, in that even though it is source code, it's not source code that's intended to be run.... 1150359 5 267644 joepeck 2015-12-18 11:29:40 -0800 Comment on attachment 267644 Patch r=me 1150402 6 mcatanzaro 2015-12-18 15:27:32 -0800 Thanks for the review. I'll wait a few days for Carlos to make sure he's OK with this. 1150697 7 267644 cgarcia 2015-12-21 00:17:08 -0800 Comment on attachment 267644 Patch Yes, we only build files under UserInterface directory (and Localizations), so we don't need those files in the tarball at all. 1150698 8 267644 commit-queue 2015-12-21 01:05:06 -0800 Comment on attachment 267644 Patch Clearing flags on attachment: 267644 Committed r194327: <http://trac.webkit.org/changeset/194327> 1150699 9 commit-queue 2015-12-21 01:05:10 -0800 All reviewed patches have been landed. Closing bug. 267644 2015-12-18 11:14:49 -0800 2015-12-21 01:05:06 -0800 Patch bug-152428-20151218131410.patch text/plain 1415 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0Mjc2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjc1MDhmZjg1MmVhN2JhOWMyZThkMGFiNmY2N2FiOWJm OWVkNzE1NS4uZTc2ZDJmOWU2Yjk2NDQzMGI1ZWEwMTIzY2YyYjFiZjFkYTZjMGE0OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3 IEBACiAyMDE1LTEyLTE4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KIAorICAgICAgICBbR1RLXSBqcXVlcnkubWluLmpzIHZpb2xhdGVzIERGU0cKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjQyOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgZGlzdHJpYnV0aW5n IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Ub29scy4gSXQgaXMgbm90IG5lZWRlZCBpbiB0YXJiYWxs cy4gVGhpcyBicmluZ3MgdXMKKyAgICAgICAgaW50byBjb21wbGlhbmNlIHdpdGggREZTRyBieSBy ZW1vdmluZyBhIGJ1bmRsZWQsIG1pbmlmaWVkIGNvcHkgb2YgalF1ZXJ5IGZyb20gb3VyIHRhcmJh bGwuCisKKyAgICAgICAgKiBndGsvbWFuaWZlc3QudHh0LmluOgorCisyMDE1LTEyLTE4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJldmll d2VkLCBhZGQgV2ViS2l0R1RLKyBCdWd6aWxsYSBlbWFpbCB0byBjb21taXR0ZXJzIGxpc3QKIAog ICAgICAgICBUaGlzIGlzIHRvIG1ha2UgaXQgZWFzeSB0byBDQyBpdCBvbiBCdWd6aWxsYS4KZGlm ZiAtLWdpdCBhL1Rvb2xzL2d0ay9tYW5pZmVzdC50eHQuaW4gYi9Ub29scy9ndGsvbWFuaWZlc3Qu dHh0LmluCmluZGV4IGU4MDIwMzBjY2E2MTI4MmIxM2M0OTA5YzJlNmM4MTFkMWE3ZWRhZWQuLjg0 YjM5ZWYwYTFlZjgwYmJkYmE0NjlkNTk5MDlmYmRiODNiZjVhMzkgMTAwNjQ0Ci0tLSBhL1Rvb2xz L2d0ay9tYW5pZmVzdC50eHQuaW4KKysrIGIvVG9vbHMvZ3RrL21hbmlmZXN0LnR4dC5pbgpAQCAt NTUsNiArNTUsNyBAQCBleGNsdWRlIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luZG93cy5jbWFrZSQK IGV4Y2x1ZGUgU291cmNlL2NtYWtlL09wdGlvbnNBcHBsZVdpbi5jbWFrZSQKIGV4Y2x1ZGUgU291 cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UkCiBleGNsdWRlIFNvdXJjZS9jbWFrZS9lZmxzeW1i b2xzLmZpbHRlciQKK2V4Y2x1ZGUgU291cmNlL1dlYkluc3BlY3RvclVJL1Rvb2xzCiBleGNsdWRl IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0ltYWdlcwogCiBkaXJlY3Rvcnkg U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvSW1hZ2VzL2d0awo=