152423 2015-12-18 05:46:09 -0800 [WinCairo] Empty context menu item. 2015-12-19 00:38:26 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue oldest_to_newest 1150257 0 peavo 2015-12-18 05:46:09 -0800 The context menu contains a submenu item with no text. 1150258 1 267625 peavo 2015-12-18 05:51:14 -0800 Created attachment 267625 Patch 1150337 2 267625 achristensen 2015-12-18 10:53:01 -0800 Comment on attachment 267625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267625&action=review > Source/WebCore/page/ContextMenuController.cpp:801 > +#if PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(WIN_CAIRO) > ContextMenuItem ShareMenuItem; My guess is that all windows ports need this if WinCairo does. How do I see this particular context menu? 1150361 3 peavo 2015-12-18 11:36:08 -0800 (In reply to comment #2) > Comment on attachment 267625 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267625&action=review > > > Source/WebCore/page/ContextMenuController.cpp:801 > > +#if PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(WIN_CAIRO) > > ContextMenuItem ShareMenuItem; > > My guess is that all windows ports need this if WinCairo does. How do I see > this particular context menu? Good point :) I see the context menu with the empty item when I right-click any web page element in MiniBrowser. 1150363 4 267645 peavo 2015-12-18 11:38:23 -0800 Created attachment 267645 Patch 1150440 5 267645 commit-queue 2015-12-18 16:25:58 -0800 Comment on attachment 267645 Patch Clearing flags on attachment: 267645 Committed r194305: <http://trac.webkit.org/changeset/194305> 1150441 6 commit-queue 2015-12-18 16:26:02 -0800 All reviewed patches have been landed. Closing bug. 1150518 7 peavo 2015-12-19 00:38:26 -0800 Thanks for reviewing :) 267625 2015-12-18 05:51:14 -0800 2015-12-18 11:38:13 -0800 Patch bug-152423-20151218145055.patch text/plain 1356 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDI2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIEVtcHR5 IGNvbnRleHQgbWVudSBpdGVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyNDIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIGNvbnRleHQgbWVudSBjb250YWlucyBhIHN1Ym1lbnUgaXRlbSB3aXRo IG5vIHRleHQuCisKKyAgICAgICAgKiBwYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDb250ZXh0TWVudUNvbnRyb2xsZXI6OnBvcHVsYXRlKToKKwogMjAx NS0xMi0xNyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9k ZXJuIElEQjogUmVmYWN0b3Igb3Blbi9kZWxldGUgcmVxdWVzdHMgdG8gZXhpc3QgaW4gdGhlIHNh bWUgcXVldWUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRy b2xsZXIuY3BwCShyZXZpc2lvbiAxOTQyNjcpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRl eHRNZW51Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc5Nyw3ICs3OTcsNyBAQCB2 b2lkIENvbnRleHRNZW51Q29udHJvbGxlcjo6cG9wdWxhdGUoKQogICAgIENvbnRleHRNZW51SXRl bSBTZWxlY3RBbGxJdGVtKEFjdGlvblR5cGUsIENvbnRleHRNZW51SXRlbVRhZ1NlbGVjdEFsbCwg Y29udGV4dE1lbnVJdGVtVGFnU2VsZWN0QWxsKCkpOwogI2VuZGlmCiAKLSNpZiBQTEFURk9STShH VEspIHx8IFBMQVRGT1JNKEVGTCkKKyNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKEVGTCkg fHwgUExBVEZPUk0oV0lOX0NBSVJPKQogICAgIENvbnRleHRNZW51SXRlbSBTaGFyZU1lbnVJdGVt OwogI2Vsc2UKICAgICBDb250ZXh0TWVudUl0ZW0gU2hhcmVNZW51SXRlbShTdWJtZW51VHlwZSwg Q29udGV4dE1lbnVJdGVtVGFnU2hhcmVNZW51LCBlbXB0eVN0cmluZygpKTsK 267645 2015-12-18 11:38:23 -0800 2015-12-18 16:25:58 -0800 Patch bug-152423-20151218203805.patch text/plain 1350 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDI2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIEVtcHR5 IGNvbnRleHQgbWVudSBpdGVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyNDIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIGNvbnRleHQgbWVudSBjb250YWlucyBhIHN1Ym1lbnUgaXRlbSB3aXRo IG5vIHRleHQuCisKKyAgICAgICAgKiBwYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDb250ZXh0TWVudUNvbnRyb2xsZXI6OnBvcHVsYXRlKToKKwogMjAx NS0xMi0xNyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9k ZXJuIElEQjogUmVmYWN0b3Igb3Blbi9kZWxldGUgcmVxdWVzdHMgdG8gZXhpc3QgaW4gdGhlIHNh bWUgcXVldWUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRy b2xsZXIuY3BwCShyZXZpc2lvbiAxOTQyNjcpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRl eHRNZW51Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc5Nyw3ICs3OTcsNyBAQCB2 b2lkIENvbnRleHRNZW51Q29udHJvbGxlcjo6cG9wdWxhdGUoKQogICAgIENvbnRleHRNZW51SXRl bSBTZWxlY3RBbGxJdGVtKEFjdGlvblR5cGUsIENvbnRleHRNZW51SXRlbVRhZ1NlbGVjdEFsbCwg Y29udGV4dE1lbnVJdGVtVGFnU2VsZWN0QWxsKCkpOwogI2VuZGlmCiAKLSNpZiBQTEFURk9STShH VEspIHx8IFBMQVRGT1JNKEVGTCkKKyNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKEVGTCkg fHwgUExBVEZPUk0oV0lOKQogICAgIENvbnRleHRNZW51SXRlbSBTaGFyZU1lbnVJdGVtOwogI2Vs c2UKICAgICBDb250ZXh0TWVudUl0ZW0gU2hhcmVNZW51SXRlbShTdWJtZW51VHlwZSwgQ29udGV4 dE1lbnVJdGVtVGFnU2hhcmVNZW51LCBlbXB0eVN0cmluZygpKTsK