152409 2015-12-17 17:19:13 -0800 Web Inspector: Remove "local" scope type from the protocol 2015-12-17 20:18:32 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1150150 0 joepeck 2015-12-17 17:19:13 -0800 * SUMMARY Remove "local" scope from the protocol. After r194251, it is no longer sent from the backend to the frontend. The frontend should be able to determine was is "local" to the current selected call frame or not. Do that in a follow-up. 1150151 1 267599 joepeck 2015-12-17 17:21:47 -0800 Created attachment 267599 [PATCH] Proposed Fix 1150152 2 commit-queue 2015-12-17 17:22:24 -0800 Attachment 267599 did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:75: WITH_SCOPE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:76: CLOSURE_SCOPE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:77: CATCH_SCOPE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:78: FUNCTION_NAME_SCOPE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:79: GLOBAL_LEXICAL_ENVIRONMENT_SCOPE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:80: NESTED_LEXICAL_SCOPE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 6 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1150184 3 267599 commit-queue 2015-12-17 20:18:28 -0800 Comment on attachment 267599 [PATCH] Proposed Fix Clearing flags on attachment: 267599 Committed r194259: <http://trac.webkit.org/changeset/194259> 1150185 4 commit-queue 2015-12-17 20:18:32 -0800 All reviewed patches have been landed. Closing bug. 267599 2015-12-17 17:21:47 -0800 2015-12-17 20:18:28 -0800 [PATCH] Proposed Fix remove-local.patch text/plain 6683 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDkyYWM5NDQuLmRhYmRkZjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTEyLTE3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl ICJsb2NhbCIgc2NvcGUgdHlwZSBmcm9tIHRoZSBwcm90b2NvbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNDA5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgcjE5NDI1MSB0aGUgYmFja2VuZCBu byBsb25nZXIgc2VuZHMgdGhpcyBzY29wZSB0eXBlLgorICAgICAgICBTbyByZW1vdmUgaXQgZnJv bSB0aGUgcHJvdG9jb2wuCisKKyAgICAgICAgVGhlIGNvbmNlcHQgb2YgYSBMb2NhbCBTY29wZSBz aG91bGQgYmUgY2FsY3VsYXRhYmxlIGJ5IHRoZQorICAgICAgICBmcm9udGVuZC4gSW4gZmFjdCB0 aGUgd2F5IHRoZSBiYWNrZW5kIHVzZWQgdG8gZG8gdGhpcyBjb3VsZAorICAgICAgICBlYXNpbHkg YmUgZG9uZSBieSB0aGUgZnJvbnRlbmQuIFRvIGJlIGRvbmUgaW4gYSBmb2xsb3ctdXAuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanM6CisgICAgICAgICogaW5z cGVjdG9yL0pTSmF2YVNjcmlwdENhbGxGcmFtZS5oOgorICAgICAgICAqIGluc3BlY3Rvci9wcm90 b2NvbC9EZWJ1Z2dlci5qc29uOgorCisyMDE1LTEyLTE3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNv cmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgUHJvdmlkZSBhIHdheSB0byBkaXN0aW5ndWlzaCBh IG5lc3RlZCBsZXhpY2FsIGJsb2NrIGZyb20gYSBmdW5jdGlvbidzIGxleGljYWwgYmxvY2sKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjM2MQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0 U291cmNlLmpzIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlw dFNvdXJjZS5qcwppbmRleCA3Yzk2Yjk5Li5lNjQ3OWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKQEAgLTEz NjMsMTMgKzEzNjMsMTIgQEAgSW5qZWN0ZWRTY3JpcHQuQ2FsbEZyYW1lUHJveHkucHJvdG90eXBl ID0gewogCiBJbmplY3RlZFNjcmlwdC5DYWxsRnJhbWVQcm94eS5fc2NvcGVUeXBlTmFtZXMgPSB7 CiAgICAgMDogImdsb2JhbCIsIC8vIEdMT0JBTF9TQ09QRQotICAgIDE6ICJsb2NhbCIsIC8vIExP Q0FMX1NDT1BFCi0gICAgMjogIndpdGgiLCAvLyBXSVRIX1NDT1BFCi0gICAgMzogImNsb3N1cmUi LCAvLyBDTE9TVVJFX1NDT1BFCi0gICAgNDogImNhdGNoIiwgLy8gQ0FUQ0hfU0NPUEUKLSAgICA1 OiAiZnVuY3Rpb25OYW1lIiwgLy8gRlVOQ1RJT05fTkFNRV9TQ09QRQotICAgIDY6ICJnbG9iYWxM ZXhpY2FsRW52aXJvbm1lbnQiLCAvLyBHTE9CQUxfTEVYSUNBTF9FTlZJUk9OTUVOVF9TQ09QRQot ICAgIDc6ICJuZXN0ZWRMZXhpY2FsIiwgLy8gTkVTVEVEX0xFWElDQUxfU0NPUEUKKyAgICAxOiAi d2l0aCIsIC8vIFdJVEhfU0NPUEUKKyAgICAyOiAiY2xvc3VyZSIsIC8vIENMT1NVUkVfU0NPUEUK KyAgICAzOiAiY2F0Y2giLCAvLyBDQVRDSF9TQ09QRQorICAgIDQ6ICJmdW5jdGlvbk5hbWUiLCAv LyBGVU5DVElPTl9OQU1FX1NDT1BFCisgICAgNTogImdsb2JhbExleGljYWxFbnZpcm9ubWVudCIs IC8vIEdMT0JBTF9MRVhJQ0FMX0VOVklST05NRU5UX1NDT1BFCisgICAgNjogIm5lc3RlZExleGlj YWwiLCAvLyBORVNURURfTEVYSUNBTF9TQ09QRQogfQogCiBJbmplY3RlZFNjcmlwdC5DYWxsRnJh bWVQcm94eS5fY3JlYXRlU2NvcGVKc29uID0gZnVuY3Rpb24oc2NvcGVUeXBlQ29kZSwgc2NvcGVP YmplY3QsIGdyb3VwSWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL0pTSmF2YVNjcmlwdENhbGxGcmFtZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9KU0phdmFTY3JpcHRDYWxsRnJhbWUuaAppbmRleCBiNmNmNThhLi4zMjQ2MjdmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTSmF2YVNjcmlwdENhbGxG cmFtZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNKYXZhU2NyaXB0 Q2FsbEZyYW1lLmgKQEAgLTcyLDEzICs3MiwxMiBAQCBwdWJsaWM6CiAKICAgICAvLyBDb25zdGFu dHMuCiAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHNob3J0IEdMT0JBTF9TQ09QRSA9IDA7Ci0g ICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHNob3J0IExPQ0FMX1NDT1BFID0gMTsKLSAgICBzdGF0 aWMgY29uc3QgdW5zaWduZWQgc2hvcnQgV0lUSF9TQ09QRSA9IDI7Ci0gICAgc3RhdGljIGNvbnN0 IHVuc2lnbmVkIHNob3J0IENMT1NVUkVfU0NPUEUgPSAzOwotICAgIHN0YXRpYyBjb25zdCB1bnNp Z25lZCBzaG9ydCBDQVRDSF9TQ09QRSA9IDQ7Ci0gICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHNo b3J0IEZVTkNUSU9OX05BTUVfU0NPUEUgPSA1OwotICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBz aG9ydCBHTE9CQUxfTEVYSUNBTF9FTlZJUk9OTUVOVF9TQ09QRSA9IDY7Ci0gICAgc3RhdGljIGNv bnN0IHVuc2lnbmVkIHNob3J0IE5FU1RFRF9MRVhJQ0FMX1NDT1BFID0gNzsKKyAgICBzdGF0aWMg Y29uc3QgdW5zaWduZWQgc2hvcnQgV0lUSF9TQ09QRSA9IDE7CisgICAgc3RhdGljIGNvbnN0IHVu c2lnbmVkIHNob3J0IENMT1NVUkVfU0NPUEUgPSAyOworICAgIHN0YXRpYyBjb25zdCB1bnNpZ25l ZCBzaG9ydCBDQVRDSF9TQ09QRSA9IDM7CisgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHNob3J0 IEZVTkNUSU9OX05BTUVfU0NPUEUgPSA0OworICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzaG9y dCBHTE9CQUxfTEVYSUNBTF9FTlZJUk9OTUVOVF9TQ09QRSA9IDU7CisgICAgc3RhdGljIGNvbnN0 IHVuc2lnbmVkIHNob3J0IE5FU1RFRF9MRVhJQ0FMX1NDT1BFID0gNjsKIAogcHJvdGVjdGVkOgog ICAgIHZvaWQgZmluaXNoQ3JlYXRpb24oSlNDOjpWTSYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9EZWJ1Z2dlci5qc29uIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9EZWJ1Z2dlci5qc29uCmluZGV4IDJjM2Ez MzcuLmQwZjlkYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv cHJvdG9jb2wvRGVidWdnZXIuanNvbgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL3Byb3RvY29sL0RlYnVnZ2VyLmpzb24KQEAgLTgxLDcgKzgxLDcgQEAKICAgICAgICAgICAg ICJpZCI6ICJTY29wZSIsCiAgICAgICAgICAgICAidHlwZSI6ICJvYmplY3QiLAogICAgICAgICAg ICAgInByb3BlcnRpZXMiOiBbCi0gICAgICAgICAgICAgICAgeyAibmFtZSI6ICJ0eXBlIiwgInR5 cGUiOiAic3RyaW5nIiwgImVudW0iOiBbImdsb2JhbCIsICJsb2NhbCIsICJ3aXRoIiwgImNsb3N1 cmUiLCAiY2F0Y2giLCAiZnVuY3Rpb25OYW1lIiwgImdsb2JhbExleGljYWxFbnZpcm9ubWVudCIs ICJuZXN0ZWRMZXhpY2FsIl0sICJkZXNjcmlwdGlvbiI6ICJTY29wZSB0eXBlLiIgfSwKKyAgICAg ICAgICAgICAgICB7ICJuYW1lIjogInR5cGUiLCAidHlwZSI6ICJzdHJpbmciLCAiZW51bSI6IFsi Z2xvYmFsIiwgIndpdGgiLCAiY2xvc3VyZSIsICJjYXRjaCIsICJmdW5jdGlvbk5hbWUiLCAiZ2xv YmFsTGV4aWNhbEVudmlyb25tZW50IiwgIm5lc3RlZExleGljYWwiXSwgImRlc2NyaXB0aW9uIjog IlNjb3BlIHR5cGUuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAib2JqZWN0IiwgIiRy ZWYiOiAiUnVudGltZS5SZW1vdGVPYmplY3QiLCAiZGVzY3JpcHRpb24iOiAiT2JqZWN0IHJlcHJl c2VudGluZyB0aGUgc2NvcGUuIEZvciA8Y29kZT5nbG9iYWw8L2NvZGU+IGFuZCA8Y29kZT53aXRo PC9jb2RlPiBzY29wZXMgaXQgcmVwcmVzZW50cyB0aGUgYWN0dWFsIG9iamVjdDsgZm9yIHRoZSBy ZXN0IG9mIHRoZSBzY29wZXMsIGl0IGlzIGFydGlmaWNpYWwgdHJhbnNpZW50IG9iamVjdCBlbnVt ZXJhdGluZyBzY29wZSB2YXJpYWJsZXMgYXMgaXRzIHByb3BlcnRpZXMuIiB9CiAgICAgICAgICAg ICBdLAogICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlNjb3BlIGRlc2NyaXB0aW9uLiIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI2ZTFlYjUuLmE5ODVjMDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE1LTEyLTE3ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlICJs b2NhbCIgc2NvcGUgdHlwZSBmcm9tIHRoZSBwcm90b2NvbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNDA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0Rl YnVnZ2VyTWFuYWdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZWJ1Z2dlck1hbmFnZXIu cHJvdG90eXBlLl9zY29wZUNoYWluTm9kZUZyb21QYXlsb2FkKToKKworMjAxNS0xMi0xNyAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFByb3ZpZGUgYSB3 YXkgdG8gZGlzdGluZ3Vpc2ggYSBuZXN0ZWQgbGV4aWNhbCBibG9jayBmcm9tIGEgZnVuY3Rpb24n cyBsZXhpY2FsIGJsb2NrCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTIzNjEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzCmluZGV4 IDk4MGMwY2QuLmI4MTBhNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanMK QEAgLTU4NSw5ICs1ODUsNiBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyID0gY2xhc3Mg RGVidWdnZXJNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgIHsKICAgICAg ICAgdmFyIHR5cGUgPSBudWxsOwogICAgICAgICBzd2l0Y2ggKHBheWxvYWQudHlwZSkgewotICAg ICAgICBjYXNlIERlYnVnZ2VyQWdlbnQuU2NvcGVUeXBlLkxvY2FsOgotICAgICAgICAgICAgdHlw ZSA9IFdlYkluc3BlY3Rvci5TY29wZUNoYWluTm9kZS5UeXBlLkxvY2FsOwotICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIGNhc2UgRGVidWdnZXJBZ2VudC5TY29wZVR5cGUuR2xvYmFsOgogICAg ICAgICAgICAgdHlwZSA9IFdlYkluc3BlY3Rvci5TY29wZUNoYWluTm9kZS5UeXBlLkdsb2JhbDsK ICAgICAgICAgICAgIGJyZWFrOwpAQCAtNjA5LDYgKzYwNiwxMyBAQCBXZWJJbnNwZWN0b3IuRGVi dWdnZXJNYW5hZ2VyID0gY2xhc3MgRGVidWdnZXJNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9y Lk9iamVjdAogICAgICAgICBjYXNlIERlYnVnZ2VyQWdlbnQuU2NvcGVUeXBlLkdsb2JhbExleGlj YWxFbnZpcm9ubWVudDoKICAgICAgICAgICAgIHR5cGUgPSBXZWJJbnNwZWN0b3IuU2NvcGVDaGFp bk5vZGUuVHlwZS5HbG9iYWxMZXhpY2FsRW52aXJvbm1lbnQ7CiAgICAgICAgICAgICBicmVhazsK KworICAgICAgICAvLyBDT01QQVRJQklMSVRZIChpT1MgOSk6IERlYnVnZ2VyLlNjb3BlVHlwZS5M b2NhbCB1c2VkIHRvIGJlIHByb3ZpZGVkIGJ5IHRoZSBiYWNrZW5kLgorICAgICAgICAvLyBOZXdl ciBiYWNrZW5kcyBubyBsb25nZXIgc2VuZCB0aGlzIGVudW0gdmFsdWUsIGl0IHNob3VsZCBiZSBj b21wdXRlZCBieSB0aGUgZnJvbnRlbmQuCisgICAgICAgIGNhc2UgRGVidWdnZXJBZ2VudC5TY29w ZVR5cGUuTG9jYWw6CisgICAgICAgICAgICB0eXBlID0gV2ViSW5zcGVjdG9yLlNjb3BlQ2hhaW5O b2RlLlR5cGUuTG9jYWw7CisgICAgICAgICAgICBicmVhazsKKwogICAgICAgICBkZWZhdWx0Ogog ICAgICAgICAgICAgY29uc29sZS5lcnJvcigiVW5rbm93biB0eXBlOiAiICsgcGF5bG9hZC50eXBl KTsKICAgICAgICAgfQo=