152402 2015-12-17 15:38:44 -0800 Web Inspector: improve pre-filled bugzilla link on Uncaught Exception reporter sheet 2015-12-27 19:01:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1150107 0 bburg 2015-12-17 15:38:44 -0800 - Include the inspected page URL - Include a better bug template 1150119 1 267592 bburg 2015-12-17 16:01:39 -0800 Created attachment 267592 Proposed Fix 1150120 2 bburg 2015-12-17 16:04:05 -0800 New pre-filled bugzilla description looks like: ------- Auto-generated details: Inspected URL: https://www.mozilla.org/en-US/firefox/new/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/602.1.15+ (KHTML, like Gecko) Uncaught exceptions: - TypeError: InspectorFrontendHost.zoomFactor is not a function. (In 'InspectorFrontendHost.zoomFactor()', 'InspectorFrontendHost.zoomFactor' is an instance of Object) (at Main.js:1907:55) ------- * STEPS TO REPRODUCE 1. What were you doing? Include setup or other preparations to reproduce the exception. 2. Include explicit, accurate, and minimal steps taken. Do not include extraneous or irrelevant steps. * NOTES Document any additional information that might be useful in resolving the problem, such as screen shots or other included attachments. 1150132 3 267592 joepeck 2015-12-17 16:29:44 -0800 Comment on attachment 267592 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=267592&action=review r=me > Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:150 > +Loading completed: ${loadCompleted ? "true" : "false"} This can just be ${!!loadCompleted}. The boolean will stringily as expected. > Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:151 > +Frontend User Agent: ${window.navigator.userAgent} I'm not sure the user agent gives much value. 1150179 4 267592 timothy 2015-12-17 19:21:48 -0800 Comment on attachment 267592 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=267592&action=review >> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:151 >> +Frontend User Agent: ${window.navigator.userAgent} > > I'm not sure the user agent gives much value. It lets us know the Safari/WebKit version. Though window.navigator.appVersion is likely better as it leave out some of the cruft. 1151431 5 webkit-bug-importer 2015-12-27 14:55:00 -0800 <rdar://problem/24012866> 1151437 6 bburg 2015-12-27 19:01:28 -0800 Committed r194427: <http://trac.webkit.org/changeset/194427> 267592 2015-12-17 16:01:39 -0800 2015-12-27 14:54:47 -0800 Proposed Fix bug-152402-20151217160101.patch text/plain 3567 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl ZTUwODNlYjRmYjg3MjZjZTlmYjBmMGE3ZTY2MjI1YTBjODY4MjhlLi5jYzM2Y2QzMTVkNmJlYTEz ZDUyNThiODg5ZDUzMzM3M2E2NDU1OTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0xMi0xNyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbXByb3ZlIHByZS1maWxsZWQgYnVnemlsbGEgbGluayBv biBVbmNhdWdodCBFeGNlcHRpb24gcmVwb3J0ZXIgc2hlZXQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjQwMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY2x1ZGUgdGhlIFVBIHN0cmluZywgaW5zcGVj dGVkIHBhZ2UgVVJMLCBhbmQgYSB0ZW1wbGF0ZSB0aGF0IGluY2x1ZGVzCisgICAgICAgIHN0ZXBz IHRvIHJlcHJvZHVjZSBhbmQgbm90ZXMuIE90aGVyIGNvbW1vbiBoZWFkaW5ncyAocmVncmVzc2lv biwgZXhwZWN0ZWQsCisgICAgICAgIHJlc3VsdHMsIHN1bW1hcnkpIGFyZSBvbWl0dGVkIGJlY2F1 c2UgdGhleSBhcmUgdW5saWtlbHkgdG8gYmUga25vd24gd2hlbgorICAgICAgICBhbiB1bmNhdWdo dCBleGNlcHRpb24gb2NjdXJzLCBvciBhcmUgb2J2aW91cyAoInNob3VsZG4ndCB0aHJvdyBleGNl cHRpb24iKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRGVidWcvVW5jYXVnaHRFeGNlcHRp b25SZXBvcnRlci5qczoKKwogMjAxNS0xMi0xNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjE5MzkxMyk6IFBv cG92ZXIgY292ZXJzIGNvbXBsZXRpb24gc3VnZ2VzdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnL1VuY2F1Z2h0RXhjZXB0aW9uUmVwb3J0 ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Zy9VbmNhdWdo dEV4Y2VwdGlvblJlcG9ydGVyLmpzCmluZGV4IDBjNTMxMmM4MGU4MGRmZDg3MTBlYTQ3MjAyMjlm ZjA0MTUxYzhlYjIuLmU0Y2NlZTRkNTg0YWQwMmI2MjVhZTE5OGZhYzFlMTk3MWNmMjE0M2EgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnL1VuY2F1 Z2h0RXhjZXB0aW9uUmVwb3J0ZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvRGVidWcvVW5jYXVnaHRFeGNlcHRpb25SZXBvcnRlci5qcwpAQCAtMTM2LDkgKzEz NiwzMCBAQCBmdW5jdGlvbiBjcmVhdGVFcnJvclNoZWV0KCkgewogICAgICAgICAgICAgZGlzbWlz c0Vycm9yU2hlZXQoKTsKICAgICB9CiAKKyAgICBsZXQgaW5zcGVjdGVkUGFnZVVSTCA9ICIodW5r bm93bikiOworICAgIHRyeSB7CisgICAgICAgIGluc3BlY3RlZFBhZ2VVUkwgPSBXZWJJbnNwZWN0 b3IuZnJhbWVSZXNvdXJjZU1hbmFnZXIubWFpbkZyYW1lLnVybDsKKyAgICB9IGNhdGNoIChlKSB7 IH0KKwogICAgIGxldCBmb3JtYXR0ZWRFcnJvckRldGFpbHMgPSB3aW5kb3cuX191bmNhdWdodEV4 Y2VwdGlvbnMubWFwKChlbnRyeSkgPT4gYCR7ZW50cnkubWVzc2FnZX0gKGF0ICR7ZW50cnkudXJs fToke2VudHJ5LmxpbmVOdW1iZXJ9OiR7ZW50cnkuY29sdW1uTnVtYmVyfSlgKTsKICAgICBsZXQg ZGV0YWlsc0ZvckJ1Z1JlcG9ydCA9IGZvcm1hdHRlZEVycm9yRGV0YWlscy5tYXAoKGxpbmUpID0+ IGAgLSAke2xpbmV9YCkuam9pbigiXG4iKTsKLSAgICBsZXQgZW5jb2RlZEJ1Z0Rlc2NyaXB0aW9u ID0gZW5jb2RlVVJJQ29tcG9uZW50KGBMb2FkaW5nIGNvbXBsZXRlZDogJHtsb2FkQ29tcGxldGVk ID8gInRydWUiIDogImZhbHNlIn1cblVuY2F1Z2h0IGV4Y2VwdGlvbnM6XG4ke2RldGFpbHNGb3JC dWdSZXBvcnR9YCk7CisgICAgbGV0IGVuY29kZWRCdWdEZXNjcmlwdGlvbiA9IGVuY29kZVVSSUNv bXBvbmVudChgLS0tLS0tLQorQXV0by1nZW5lcmF0ZWQgZGV0YWlsczoKKworSW5zcGVjdGVkIFVS TDogICAgICAgICR7aW5zcGVjdGVkUGFnZVVSTH0KK0xvYWRpbmcgY29tcGxldGVkOiAgICAke2xv YWRDb21wbGV0ZWQgPyAidHJ1ZSIgOiAiZmFsc2UifQorRnJvbnRlbmQgVXNlciBBZ2VudDogICR7 d2luZG93Lm5hdmlnYXRvci51c2VyQWdlbnR9CitVbmNhdWdodCBleGNlcHRpb25zOgorJHtkZXRh aWxzRm9yQnVnUmVwb3J0fQorLS0tLS0tLQorCisqIFNURVBTIFRPIFJFUFJPRFVDRQorMS4gV2hh dCB3ZXJlIHlvdSBkb2luZz8gSW5jbHVkZSBzZXR1cCBvciBvdGhlciBwcmVwYXJhdGlvbnMgdG8g cmVwcm9kdWNlIHRoZSBleGNlcHRpb24uCisyLiBJbmNsdWRlIGV4cGxpY2l0LCBhY2N1cmF0ZSwg YW5kIG1pbmltYWwgc3RlcHMgdGFrZW4uIERvIG5vdCBpbmNsdWRlIGV4dHJhbmVvdXMgb3IgaXJy ZWxldmFudCBzdGVwcy4KKworKiBOT1RFUworRG9jdW1lbnQgYW55IGFkZGl0aW9uYWwgaW5mb3Jt YXRpb24gdGhhdCBtaWdodCBiZSB1c2VmdWwgaW4gcmVzb2x2aW5nIHRoZSBwcm9ibGVtLCBzdWNo IGFzIHNjcmVlbiBzaG90cyBvciBvdGhlciBpbmNsdWRlZCBhdHRhY2htZW50cy4KK2ApOwogICAg IGxldCBlbmNvZGVkQnVnVGl0bGUgPSBlbmNvZGVVUklDb21wb25lbnQoYFVuY2F1Z2h0IEV4Y2Vw dGlvbjogJHtmaXJzdEV4Y2VwdGlvbi5tZXNzYWdlfWApOwogICAgIGxldCBwcmVmaWxsZWRCdWdS ZXBvcnRMaW5rID0gYGh0dHBzOi8vYnVncy53ZWJraXQub3JnL2VudGVyX2J1Zy5jZ2k/YWxpYXM9 JmFzc2lnbmVkX3RvPXdlYmtpdC11bmFzc2lnbmVkJTQwbGlzdHMud2Via2l0Lm9yZyZhdHRhY2hf dGV4dD0mYmxvY2tlZD0mYnVnX2ZpbGVfbG9jPWh0dHAlM0ElMkYlMkYmYnVnX3NldmVyaXR5PU5v cm1hbCZidWdfc3RhdHVzPU5FVyZjb21tZW50PSR7ZW5jb2RlZEJ1Z0Rlc2NyaXB0aW9ufSZjb21w b25lbnQ9V2ViJTIwSW5zcGVjdG9yJmNvbnRlbnR0eXBlZW50cnk9JmNvbnRlbnR0eXBlbWV0aG9k PWF1dG9kZXRlY3QmY29udGVudHR5cGVzZWxlY3Rpb249dGV4dCUyRnBsYWluJmRhdGE9JmRlcGVu ZHNvbj0mZGVzY3JpcHRpb249JmZsYWdfdHlwZS0xPVgmZmxhZ190eXBlLTM9WCZmb3JtX25hbWU9 ZW50ZXJfYnVnJmtleXdvcmRzPSZvcF9zeXM9QWxsJnByaW9yaXR5PVAyJnByb2R1Y3Q9V2ViS2l0 JnJlcF9wbGF0Zm9ybT1BbGwmc2hvcnRfZGVzYz0ke2VuY29kZWRCdWdUaXRsZX0mdmVyc2lvbj1X ZWJLaXQlMjBOaWdodGx5JTIwQnVpbGRgOwogICAgIGxldCBkZXRhaWxzRm9ySFRNTCA9IGZvcm1h dHRlZEVycm9yRGV0YWlscy5tYXAoKGxpbmUpID0+IGA8bGk+JHtpbnNlcnRXb3JkQnJlYWtDaGFy YWN0ZXJzKGxpbmUpfTwvbGk+YCkuam9pbigiXG4iKTsK