152394 2015-12-17 13:25:00 -0800 [Win] Prevent flashing/strobe repaints on certain hardware 2015-12-17 14:26:46 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build PC All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1150047 0 bfulgham 2015-12-17 13:25:00 -0800 Further testing on a variety of Windows hardware shows that the changes in Bug 151001 seemed to cause a "flashing" repaint to occur on certain web content under Accelerated Compositing on certain Windows configurations. We eventually tracked this down to my change in WKCACFViewLayerTreeHostcpp, which I changed to be more pessimistic about when repaints were needed. Once this change was reverted, the strobing problem went away. 1150052 1 bfulgham 2015-12-17 13:28:53 -0800 <rdar://problem/23875302> 1150055 2 267581 bfulgham 2015-12-17 13:33:56 -0800 Created attachment 267581 Patch 1150076 3 267581 commit-queue 2015-12-17 14:26:43 -0800 Comment on attachment 267581 Patch Clearing flags on attachment: 267581 Committed r194235: <http://trac.webkit.org/changeset/194235> 1150077 4 commit-queue 2015-12-17 14:26:46 -0800 All reviewed patches have been landed. Closing bug. 267581 2015-12-17 13:33:56 -0800 2015-12-17 14:26:43 -0800 Patch bug-152394-20151217135254.patch text/plain 1511 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDIyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTEyLTE3ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFByZXZlbnQgZmxh c2hpbmcvc3Ryb2JpbmcgcmVwYWludHMgb24gY2VydGFpbiBoYXJkd2FyZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyMzk0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yMzg3NTMwMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIHBhdGNoIHJldmVydHMgYSBjaGFuZ2UgSSBtYWRlIGluIHIxOTIx NjYsIHdoZXJlIEkgYWx3YXlzIHNldCB0aGUKKyAgICAgICAgbV92aWV3TmVlZHNVcGRhdGUgZmxh ZyB0byB0cnVlIHdoZW4gYSAnZmx1c2hDb250ZXh0JyBjYWxsIHdhcyBtYWRlLiBJbnN0ZWFkLAor ICAgICAgICB3ZSBzaG91bGQgZ28gYmFjayB0byBsZXR0aW5nIHRoZSB2aWV3IGRlY2lkZSB3aGVu IGl0IG5lZWRzIHRvIHBhaW50LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2lu L1dLQ0FDRlZpZXdMYXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldLQ0FDRlZp ZXdMYXllclRyZWVIb3N0OjpmbHVzaENvbnRleHQpOiBEb24ndCBqdXN0IGNsYWltIHRoYXQKKyAg ICAgICAgdGhlIHZpZXcgbmVlZHMgdG8gYmUgdXBkYXRlZCBhbnkgdGltZSB3ZSBhcmUgYXNrZWQg dG8gZmx1c2guIAorCiAyMDE1LTExLTE2ICBCYWJhayBTaGFmaWVpICA8YnNoYWZpZWlAYXBwbGUu Y29tPgogCiAgICAgICAgIE1lcmdlIHIxOTIxNjYuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS93aW4vV0tDQUNGVmlld0xheWVyVHJlZUhvc3QuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9XS0NBQ0ZWaWV3 TGF5ZXJUcmVlSG9zdC5jcHAJKHJldmlzaW9uIDE5NDExOSkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9XS0NBQ0ZWaWV3TGF5ZXJUcmVlSG9zdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE1NCw3ICsxNTQsNiBAQCBDRlRpbWVJbnRlcnZhbCBXS0NBQ0ZWaWV3TGF5 ZXJUcmVlSG9zdDo6CiAKIHZvaWQgV0tDQUNGVmlld0xheWVyVHJlZUhvc3Q6OmZsdXNoQ29udGV4 dCgpCiB7Ci0gICAgbV92aWV3TmVlZHNVcGRhdGUgPSB0cnVlOwogICAgIFdLQ0FDRlZpZXdGbHVz aENvbnRleHQobV92aWV3LmdldCgpKTsKIH0KIAo=