152392 2015-12-17 11:55:01 -0800 [WinCairo][MediaFoundation] Release Direct3D swap chain object earlier. 2015-12-17 12:57:51 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue oldest_to_newest 1150020 0 peavo 2015-12-17 11:55:01 -0800 Since we don't use the swap chain object to render the video to a window, but render frames to Cairo bitmaps, we can let go of the swap chain object earlier than we currently do. 1150021 1 267574 peavo 2015-12-17 11:59:42 -0800 Created attachment 267574 Patch 1150022 2 267574 achristensen 2015-12-17 12:10:08 -0800 Comment on attachment 267574 Patch Hooray! Less code! 1150028 3 peavo 2015-12-17 12:37:04 -0800 (In reply to comment #2) > Comment on attachment 267574 [details] > Patch > > Hooray! Less code! Yes, I'll keep my eyes open for more things we can delete :) Thanks for reviewing :) 1150031 4 267574 commit-queue 2015-12-17 12:57:47 -0800 Comment on attachment 267574 Patch Clearing flags on attachment: 267574 Committed r194227: <http://trac.webkit.org/changeset/194227> 1150032 5 commit-queue 2015-12-17 12:57:51 -0800 All reviewed patches have been landed. Closing bug. 267574 2015-12-17 11:59:42 -0800 2015-12-17 12:57:47 -0800 Patch bug-152392-20151217205922.patch text/plain 3075 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDIyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTE3ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dW01lZGlh Rm91bmRhdGlvbl0gUmVsZWFzZSBEaXJlY3QzRCBzd2FwIGNoYWluIG9iamVjdCBlYXJsaWVyLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyMzkyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2Ugd2Ug ZG9uJ3QgdXNlIHRoZSBzd2FwIGNoYWluIG9iamVjdCB0byByZW5kZXIgdGhlIHZpZGVvIHRvIGEg d2luZG93LAorICAgICAgICBidXQgcmVuZGVyIGZyYW1lcyB0byBDYWlybyBiaXRtYXBzLCB3ZSBj YW4gbGV0IGdvIG9mIHRoZSBzd2FwIGNoYWluIG9iamVjdAorICAgICAgICBlYXJsaWVyIHRoYW4g d2UgY3VycmVudGx5IGRvLiAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRp YVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2xl YXJEZXNpcmVkU2FtcGxlVGltZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZh dGVNZWRpYUZvdW5kYXRpb246OkRpcmVjdDNEUHJlc2VudGVyOjpjcmVhdGVWaWRlb1NhbXBsZXMp OgorCiAyMDE1LTEyLTE3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTk0MjAxLgpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91 bmRhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAJKHJldmlzaW9uIDE5 NDIxNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXll clByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCwxMyArNzgs NiBAQCBTT0ZUX0xJTktfT1BUSU9OQUwoRDNkOSwgRGlyZWN0M0RDcmVhdGU5CiBzdGF0aWMgY29u c3QgR1VJRCBNRlNhbXBsZVByZXNlbnRlclNhbXBsZUNvdW50ZXIgPQogeyAweDg2OWYxZjdjLCAw eDM0OTYsIDB4NDhhOSwgeyAweDg4LCAweGUzLCAweDY5LCAweDg1LCAweDc5LCAweGQwLCAweDhj LCAweGI2IH0gfTsKIAotLy8gTUZTYW1wbGVQcmVzZW50ZXJTYW1wbGVTd2FwQ2hhaW4KLS8vIERh dGEgdHlwZTogSVVOS05PV04KLS8vIAotLy8gUG9pbnRlciB0byBhIERpcmVjdDNEIHN3YXAgY2hh aW4uCi1zdGF0aWMgY29uc3QgR1VJRCBNRlNhbXBsZVByZXNlbnRlclNhbXBsZVN3YXBDaGFpbiA9 Ci17IDB4MjRhMmUwNzYsIDB4MzY3MywgMHg0MzNkLCB7IDB4ODcsIDB4NCwgMHg1NSwgMHgyYiwg MHgxZiwgMHg1YywgMHgxNiwgMHg4YyB9IH07Ci0KIHN0YXRpYyBjb25zdCBkb3VibGUgdGVuTWVn YWhlcnR6ID0gMTAwMDAwMDA7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTE4NTcsOSArMTg1 MCw2IEBAIHN0YXRpYyBIUkVTVUxUIGNsZWFyRGVzaXJlZFNhbXBsZVRpbWUoSU0KIAogICAgIFVJ TlQzMiBjb3VudGVyID0gTUZHZXRBdHRyaWJ1dGVVSU5UMzIoc2FtcGxlLCBNRlNhbXBsZVByZXNl bnRlclNhbXBsZUNvdW50ZXIsIChVSU5UMzIpLTEpOwogCi0gICAgQ09NUHRyPElVbmtub3duPiBz d2FwQ2hhaW47Ci0gICAgc2FtcGxlLT5HZXRVbmtub3duKE1GU2FtcGxlUHJlc2VudGVyU2FtcGxl U3dhcENoYWluLCBJSURfSVVua25vd24sICh2b2lkKiopJnN3YXBDaGFpbik7Ci0KICAgICBDT01Q dHI8SU1GRGVzaXJlZFNhbXBsZT4gZGVzaXJlZDsKICAgICBIUkVTVUxUIGhyID0gc2FtcGxlLT5R dWVyeUludGVyZmFjZShfX3V1aWRvZihJTUZEZXNpcmVkU2FtcGxlKSwgKHZvaWQqKikmZGVzaXJl ZCk7CiAgICAgaWYgKFNVQ0NFRURFRChocikpIHsKQEAgLTE4NjgsMTIgKzE4NTgsNiBAQCBzdGF0 aWMgSFJFU1VMVCBjbGVhckRlc2lyZWRTYW1wbGVUaW1lKElNCiAgICAgICAgIGhyID0gc2FtcGxl LT5TZXRVSU5UMzIoTUZTYW1wbGVQcmVzZW50ZXJTYW1wbGVDb3VudGVyLCBjb3VudGVyKTsKICAg ICAgICAgaWYgKEZBSUxFRChocikpCiAgICAgICAgICAgICByZXR1cm4gaHI7Ci0KLSAgICAgICAg aWYgKHN3YXBDaGFpbikgewotICAgICAgICAgICAgaHIgPSBzYW1wbGUtPlNldFVua25vd24oTUZT YW1wbGVQcmVzZW50ZXJTYW1wbGVTd2FwQ2hhaW4sIHN3YXBDaGFpbi5nZXQoKSk7Ci0gICAgICAg ICAgICBpZiAoRkFJTEVEKGhyKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gaHI7Ci0gICAgICAg IH0KICAgICB9CiAKICAgICByZXR1cm4gaHI7CkBAIC0yNjA3LDEzICsyNTkxLDYgQEAgSFJFU1VM VCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpbwogICAgICAgICB9CiAKICAgICAgICAg dmlkZW9TYW1wbGVRdWV1ZS5hcHBlbmQodmlkZW9TYW1wbGUpOwotCi0gICAgICAgIC8vIEtlZXAg dGhlIHN3YXAgY2hhaW4gYWxpdmUgYnkgc2V0dGluZyBpdCBhcyBhIGN1c3RvbSBhdHRyaWJ1dGUg b24gdGhlIHNhbXBsZS4KLSAgICAgICAgaHIgPSB2aWRlb1NhbXBsZS0+U2V0VW5rbm93bihNRlNh bXBsZVByZXNlbnRlclNhbXBsZVN3YXBDaGFpbiwgc3dhcENoYWluLmdldCgpKTsKLSAgICAgICAg aWYgKEZBSUxFRChocikpIHsKLSAgICAgICAgICAgIHJlbGVhc2VSZXNvdXJjZXMoKTsKLSAgICAg ICAgICAgIHJldHVybiBocjsKLSAgICAgICAgfQogICAgIH0KIAogICAgIHJldHVybiBocjsK