152382 2015-12-17 02:42:28 -0800 JSC generator scripts shouldn't have verbose output 2016-01-04 08:09:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy commit-queue keith_miller mark.lam msaboff ossy saam oldest_to_newest 1149952 0 ossy 2015-12-17 02:42:28 -0800 Almost all commands of build-webkit don't have any output. These scripts are quite stable, I don't think if it is useful to have verbose outputs. output of build-jsc now: (EFL with ninja) ------------------------------------------ various configure options [ snip ] -- Configuring done -- Generating done -- Build files have been written to: /home/ossy/WebKit/WebKitBuild/Release [108/915] Generating ../../DerivedSources/JavaScriptCore/Bytecodes.h, ../../DerivedSources/JavaScriptCore/InitBytecodes.asm Generating /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/Bytecodes.h and /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InitBytecodes.asm from /home/ossy/WebKit/Source/JavaScriptCore/bytecode/BytecodeList.json [109/915] Generating ../../DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h offlineasm: Parsing /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and creating offset extractor /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h. offlineasm: Including file /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore//InitBytecodes.asm offlineasm: Including file /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm offlineasm: Including file /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm offlineasm: offset extractor /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h successfully generated. [152/915] Generating ../../DerivedSources/JavaScriptCore/AirOpcode.h, ../../DerivedSources/JavaScriptCore/AirOpcodeGenerated.h Generating code for /home/ossy/WebKit/Source/JavaScriptCore/b3/air/AirOpcode.opcodes. [152/915] Generating ../../DerivedSources/JavaScriptCore/LLIntAssembly.h offlineasm: Parsing /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and /home/ossy/WebKit/WebKitBuild/Release/bin/LLIntOffsetsExtractor and creating assembly file /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntAssembly.h. offlineasm: Including file /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore//InitBytecodes.asm offlineasm: Including file /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm offlineasm: Including file /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm offlineasm: Assembly file /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntAssembly.h successfully generated. [915/915] Linking CXX executable bin/jsc ==================================================================== JavaScriptCore is now built (03m:14s). ==================================================================== output after the proposed fix: ------------------------------- ... -- Configuring done -- Generating done -- Build files have been written to: /home/ossy/WebKit/WebKitBuild/Release [915/915] Linking CXX executable bin/jsc ==================================================================== JavaScriptCore is now built (03m:07s). ==================================================================== 1149954 1 267551 ossy 2015-12-17 02:43:42 -0800 Created attachment 267551 Patch 1151776 2 267551 mcatanzaro 2015-12-31 14:27:51 -0800 Comment on attachment 267551 Patch Excellent! I agree, to make our build shine, these should not print anything, at least not by default. 1152314 3 267551 commit-queue 2016-01-04 08:09:34 -0800 Comment on attachment 267551 Patch Clearing flags on attachment: 267551 Committed r194531: <http://trac.webkit.org/changeset/194531> 1152315 4 commit-queue 2016-01-04 08:09:37 -0800 All reviewed patches have been landed. Closing bug. 267551 2015-12-17 02:43:42 -0800 2016-01-04 08:09:34 -0800 Patch bug-152382-20151217114303.patch text/plain 4735 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NDlhZjFkYWJiYzkxZTFmMzM0Y2U3ODBhZjdiM2I0Yzg2MDc4NmMyLi45MzQwNjFhNDVhMmY5YzU5 ZGE3NDNkZTdkNzZhODE5N2I0ZmUwMjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0xMi0xNyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEpTQyBnZW5lcmF0b3Igc2NyaXB0cyBzaG91bGRuJ3QgaGF2ZSB2ZXJi b3NlIG91dHB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTUyMzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBiMy9haXIvb3Bjb2RlX2dlbmVyYXRvci5yYjoKKyAgICAgICAgKiBnZW5lcmF0ZS1ieXRl Y29kZS1maWxlczoKKyAgICAgICAgKiBvZmZsaW5lYXNtL2FzbS5yYjoKKyAgICAgICAgKiBvZmZs aW5lYXNtL2dlbmVyYXRlX29mZnNldF9leHRyYWN0b3IucmI6CisgICAgICAgICogb2ZmbGluZWFz bS9wYXJzZXIucmI6CisKIDIwMTUtMTItMTYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBs ZS5jb20+CiAKICAgICAgICAgQVJNNjQgTWFjcm9Bc3NlbWJsZXIgaW1wcm9wZXJseSByZXVzZXMg ZGF0YSB0ZW1wIHJlZ2lzdGVyIGluIHRlc3QzMigpIGFuZCB0ZXN0OCgpIGNhbGxzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL29wY29kZV9nZW5lcmF0b3IucmIgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL29wY29kZV9nZW5lcmF0b3IucmIKaW5kZXggNDJh ZDRiNjQ1N2VkNDkzYzIwZmEyN2I3NmJkMDFhNjIyMjY5ZGQxZi4uY2MwYmIyZDRhMGNlODlmOWY5 MmJhYjIxNDU1ZmI1YzU3ZTFiYmNjMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2IzL2Fpci9vcGNvZGVfZ2VuZXJhdG9yLnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i My9haXIvb3Bjb2RlX2dlbmVyYXRvci5yYgpAQCAtNDM0LDggKzQzNCw2IEBAICRmaWxlTmFtZSA9 IEFSR1ZbMF0KIHBhcnNlciA9IFBhcnNlci5uZXcoSU86OnJlYWQoJGZpbGVOYW1lKSwgJGZpbGVO YW1lKQogJG9wY29kZXMgPSBwYXJzZXIucGFyc2UKIAotJHN0ZGVyci5wdXRzICJHZW5lcmF0aW5n IGNvZGUgZm9yICN7JGZpbGVOYW1lfS4iCi0KIGRlZiB3cml0ZUgoZmlsZW5hbWUpCiAgICAgRmls ZS5vcGVuKCJBaXIje2ZpbGVuYW1lfS5oIiwgInciKSB7CiAgICAgICAgIHwgb3V0cCB8CmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ2VuZXJhdGUtYnl0ZWNvZGUtZmlsZXMgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZ2VuZXJhdGUtYnl0ZWNvZGUtZmlsZXMKaW5kZXggOGUxYWRh MGRhODZmZTQ4OGNiMjRlMTUwMDM5MjE1YmEzMjI2NGU3YS4uNTY2NmEzZjkyNGMxMTliMjE2ZDNm ZjBmZmU5YzY3MmI3YzcxYmI3OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2dl bmVyYXRlLWJ5dGVjb2RlLWZpbGVzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9nZW5lcmF0 ZS1ieXRlY29kZS1maWxlcwpAQCAtMTU0LDIzICsxNTQsMTMgQEAgaWYgX19uYW1lX18gPT0gIl9f bWFpbl9fIjoKICAgICAgICAgICAgIGluaXRCeXRlY29kZXNSZWFkRmlsZS5jbG9zZSgpCiAKICAg ICBpZiBub3QgbmVlZFRvR2VuZXJhdGU6Ci0gICAgICAgIHByaW50ICJOb3RoaW5nIGNoYW5nZWQu XG4iCiAgICAgICAgIGV4aXQoMCkKIAotICAgIGdlblN0cmluZyA9ICJHZW5lcmF0aW5nICIKLQog ICAgIGlmIGJ5dGVjb2RlSEZpbGVuYW1lOgogICAgICAgICBieXRlY29kZUhGaWxlID0gb3Blbk9y RXhpdChieXRlY29kZUhGaWxlbmFtZSwgIndiIikKLSAgICAgICAgZ2VuU3RyaW5nID0gZ2VuU3Ry aW5nICsgInswfSAiLmZvcm1hdChieXRlY29kZUhGaWxlbmFtZSkKIAogICAgIGlmIGluaXRBU01G aWxlTmFtZToKICAgICAgICAgaW5pdEJ5dGVjb2Rlc0ZpbGUgPSBvcGVuT3JFeGl0KGluaXRBU01G aWxlTmFtZSwgIndiIikKLSAgICAgICAgaWYgYnl0ZWNvZGVIRmlsZW5hbWU6Ci0gICAgICAgICAg ICBnZW5TdHJpbmcgPSBnZW5TdHJpbmcgKyAiYW5kICIKLSAgICAgICAgZ2VuU3RyaW5nID0gZ2Vu U3RyaW5nICsgInswfSAiLmZvcm1hdChpbml0QVNNRmlsZU5hbWUpCi0KLSAgICBwcmludCAiezB9 ZnJvbSB7MX1cbiIuZm9ybWF0KGdlblN0cmluZywgYnl0ZWNvZGVKU09ORmlsZSkKLQogCiAgICAg dHJ5OgogICAgICAgICBieXRlY29kZVNlY3Rpb25zID0ganNvbi5sb2FkKGJ5dGVjb2RlRmlsZSwg ZW5jb2RpbmcgPSAidXRmLTgiKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29m ZmxpbmVhc20vYXNtLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXNtLnJi CmluZGV4IDg4YzdkN2FiYjZkOTdhNTk0NjM0ZGE1MzUyZjlkMGQyMzZmODU1NjEuLjE4OTQ1NzQ2 MjdlZjFjZTkyYzViM2JkZGE3YjFmMjhmODliYjA4ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzbS5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv b2ZmbGluZWFzbS9hc20ucmIKQEAgLTI4Miw4ICsyODIsNiBAQCBhc21GaWxlID0gQVJHVi5zaGlm dAogb2Zmc2V0c0ZpbGUgPSBBUkdWLnNoaWZ0CiBvdXRwdXRGbG5tID0gQVJHVi5zaGlmdAogCi0k c3RkZXJyLnB1dHMgIm9mZmxpbmVhc206IFBhcnNpbmcgI3thc21GaWxlfSBhbmQgI3tvZmZzZXRz RmlsZX0gYW5kIGNyZWF0aW5nIGFzc2VtYmx5IGZpbGUgI3tvdXRwdXRGbG5tfS4iCi0KIGJlZ2lu CiAgICAgY29uZmlndXJhdGlvbkxpc3QgPSBvZmZzZXRzQW5kQ29uZmlndXJhdGlvbkluZGV4KG9m ZnNldHNGaWxlKQogcmVzY3VlIE1pc3NpbmdNYWdpY1ZhbHVlc0V4Y2VwdGlvbgpAQCAtMzM1LDYg KzMzMywzIEBAIEZpbGUub3BlbihvdXRwdXRGbG5tLCAidyIpIHsKICAgICAgICAgfQogICAgIH0K IH0KLQotJHN0ZGVyci5wdXRzICJvZmZsaW5lYXNtOiBBc3NlbWJseSBmaWxlICN7b3V0cHV0Rmxu bX0gc3VjY2Vzc2Z1bGx5IGdlbmVyYXRlZC4iCi0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9vZmZsaW5lYXNtL2dlbmVyYXRlX29mZnNldF9leHRyYWN0b3IucmIgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9nZW5lcmF0ZV9vZmZzZXRfZXh0cmFjdG9yLnJiCmlu ZGV4IGZjNDU3OWMxNzMzNTI3M2I2YjUwNTI1ZDZiNWEyMTE0ZGMyZDljNGYuLmFhZmE5MzQxNjhk ZWY1OTQ0Y2M2MzcyNjIyMzczNTM5NTM4ODE5MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9vZmZsaW5lYXNtL2dlbmVyYXRlX29mZnNldF9leHRyYWN0b3IucmIKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vZ2VuZXJhdGVfb2Zmc2V0X2V4dHJhY3Rvci5y YgpAQCAtNDUsOCArNDUsNiBAQCBpZiB2YWxpZEJhY2tlbmRzCiAgICAgaW5jbHVkZU9ubHlCYWNr ZW5kcyh2YWxpZEJhY2tlbmRzLnNwbGl0KCIsIikpCiBlbmQKIAotJHN0ZGVyci5wdXRzICJvZmZs aW5lYXNtOiBQYXJzaW5nICN7aW5wdXRGbG5tfSBhbmQgY3JlYXRpbmcgb2Zmc2V0IGV4dHJhY3Rv ciAje291dHB1dEZsbm19LiIKLQogZGVmIGVtaXRNYWdpY051bWJlcgogICAgIE9GRlNFVF9NQUdJ Q19OVU1CRVJTLmVhY2ggewogICAgICAgICB8IG51bWJlciB8CkBAIC0xNDksNiArMTQ3LDMgQEAg RmlsZS5vcGVuKG91dHB1dEZsbm0sICJ3IikgewogICAgIH0KICAgICBvdXRwLnB1dHMgIn07Igog fQotCi0kc3RkZXJyLnB1dHMgIm9mZmxpbmVhc206IG9mZnNldCBleHRyYWN0b3IgI3tvdXRwdXRG bG5tfSBzdWNjZXNzZnVsbHkgZ2VuZXJhdGVkLiIKLQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL29mZmxpbmVhc20vcGFyc2VyLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29m ZmxpbmVhc20vcGFyc2VyLnJiCmluZGV4IGExMjJhNjhjNGMzYWQ4ZTZhZTIwZTg4MTlkNTNjZWIy MTIwZjQ1YTguLmIwY2FkMThhMDg4NmI3MzQ2ZGVjOGJiYzc1YWFhNGI4YmRmNDlmNGUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3BhcnNlci5yYgorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9wYXJzZXIucmIKQEAgLTc0NCw3ICs3NDQs NiBAQCBjbGFzcyBQYXJzZXIKICAgICAgICAgICAgICAgICBtb2R1bGVOYW1lID0gQHRva2Vuc1tA aWR4XS5zdHJpbmcKICAgICAgICAgICAgICAgICBmaWxlTmFtZSA9IEluY2x1ZGVGaWxlLm5ldyht b2R1bGVOYW1lLCBAdG9rZW5zW0BpZHhdLmNvZGVPcmlnaW4uZmlsZU5hbWUuZGlybmFtZSkuZmls ZU5hbWUKICAgICAgICAgICAgICAgICBAaWR4ICs9IDEKLSAgICAgICAgICAgICAgICAkc3RkZXJy LnB1dHMgIm9mZmxpbmVhc206IEluY2x1ZGluZyBmaWxlICN7ZmlsZU5hbWV9IgogICAgICAgICAg ICAgICAgIGxpc3QgPDwgcGFyc2UoZmlsZU5hbWUpCiAgICAgICAgICAgICBlbHNlCiAgICAgICAg ICAgICAgICAgcGFyc2VFcnJvciAiRXhwZWN0aW5nIHRlcm1pbmFsICN7ZmluYWx9ICN7Y29tbWVu dH0iCg==