152370 2015-12-16 17:55:29 -0800 ARM64 MacroAssembler improperly reuses data temp register in test32() and test8() calls 2015-12-17 15:22:57 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build iPhone / iPad All RESOLVED FIXED P2 Normal --- 151839 1 msaboff msaboff commit-queue keith_miller mark.lam saam oldest_to_newest 1149825 0 msaboff 2015-12-16 17:55:29 -0800 The void test32(ResultCondition cond, Address address, TrustedImm32 mask, RegisterID dest) and the similar test8() use the dataTempRegister with the value loaded from "address" and then call void test32(ResultCondition cond, RegisterID src, TrustedImm32 mask, RegisterID dest). The two register version of test32 can use the dataTempRegister to materialize the immediate mask. 1149829 1 267516 msaboff 2015-12-16 18:03:55 -0800 Created attachment 267516 Patch 1149871 2 267516 commit-queue 2015-12-16 21:03:16 -0800 Comment on attachment 267516 Patch Clearing flags on attachment: 267516 Committed r194208: <http://trac.webkit.org/changeset/194208> 1149872 3 commit-queue 2015-12-16 21:03:19 -0800 All reviewed patches have been landed. Closing bug. 1150064 4 267516 ggaren 2015-12-17 14:02:20 -0800 Comment on attachment 267516 Patch Does this work? Keith told me this doesn't work. 1150066 5 msaboff 2015-12-17 14:06:22 -0800 (In reply to comment #4) > Comment on attachment 267516 [details] > Patch > > Does this work? Keith told me this doesn't work. From my discussion with Keith, this is what he tried and it work. He was concerned that there were other issues, but I couldn't find any. 1150100 6 keith_miller 2015-12-17 15:22:57 -0800 My patch is working with this patch applied so this should be sufficient. 267516 2015-12-16 18:03:55 -0800 2015-12-16 21:03:16 -0800 Patch 152370.patch text/plain 2065 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0MjAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE1LTEyLTE2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFSTTY0IE1hY3JvQXNzZW1ibGVyIGltcHJvcGVybHkgcmV1c2VzIGRhdGEgdGVtcCByZWdp c3RlciBpbiB0ZXN0MzIoKSBhbmQgdGVzdDgoKSBjYWxscworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyMzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCB0aGUgdGVzdDgvMzIoQWRkcmVzcywg UmVnaXN0ZXIpIGZsYXZvcnMgdG8gdXNlIHRoZSBtZW1vcnlUZW1wUmVnaXN0ZXIgZm9yIGxvYWRp bmcgdGhlIHZhbHVlCisgICAgICAgIGF0dCBBZGRyZXNzIHNvIHRoYXQgaXQgZG9lc24ndCBjb2xs aWRlIHdpdGggdGhlIHN1YnNlcXVlbnQgdXNlIG9mIGRhdGFUZW1wUmVnaXN0ZXIgYnkgdGhlCisg ICAgICAgIHRlc3QzMihSZWdpc3RlciwgUmVnaXN0ZXIpIGZ1bmN0aW9uLgorCisgICAgICAgICog YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJBUk02NDo6dGVzdDMyKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6 dGVzdDgpOgorCiAyMDE1LTEyLTE2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgRlRMIEIzIHNob3VsZCBzdXBwb3J0IHN3aXRjaGVzCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAko cmV2aXNpb24gMTk0MTU5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTTY0LmgJKHdvcmtpbmcgY29weSkKQEAgLTIzMjgsMTQgKzIzMjgsMTQgQEAg cHVibGljOgogCiAgICAgdm9pZCB0ZXN0MzIoUmVzdWx0Q29uZGl0aW9uIGNvbmQsIEFkZHJlc3Mg YWRkcmVzcywgVHJ1c3RlZEltbTMyIG1hc2ssIFJlZ2lzdGVySUQgZGVzdCkKICAgICB7Ci0gICAg ICAgIGxvYWQzMihhZGRyZXNzLCBnZXRDYWNoZWREYXRhVGVtcFJlZ2lzdGVySURBbmRJbnZhbGlk YXRlKCkpOwotICAgICAgICB0ZXN0MzIoY29uZCwgZGF0YVRlbXBSZWdpc3RlciwgbWFzaywgZGVz dCk7CisgICAgICAgIGxvYWQzMihhZGRyZXNzLCBnZXRDYWNoZWRNZW1vcnlUZW1wUmVnaXN0ZXJJ REFuZEludmFsaWRhdGUoKSk7CisgICAgICAgIHRlc3QzMihjb25kLCBtZW1vcnlUZW1wUmVnaXN0 ZXIsIG1hc2ssIGRlc3QpOwogICAgIH0KIAogICAgIHZvaWQgdGVzdDgoUmVzdWx0Q29uZGl0aW9u IGNvbmQsIEFkZHJlc3MgYWRkcmVzcywgVHJ1c3RlZEltbTMyIG1hc2ssIFJlZ2lzdGVySUQgZGVz dCkKICAgICB7Ci0gICAgICAgIGxvYWQ4KGFkZHJlc3MsIGdldENhY2hlZERhdGFUZW1wUmVnaXN0 ZXJJREFuZEludmFsaWRhdGUoKSk7Ci0gICAgICAgIHRlc3QzMihjb25kLCBkYXRhVGVtcFJlZ2lz dGVyLCBtYXNrLCBkZXN0KTsKKyAgICAgICAgbG9hZDgoYWRkcmVzcywgZ2V0Q2FjaGVkTWVtb3J5 VGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRlKCkpOworICAgICAgICB0ZXN0MzIoY29uZCwgbWVt b3J5VGVtcFJlZ2lzdGVyLCBtYXNrLCBkZXN0KTsKICAgICB9CiAKICAgICB2b2lkIHRlc3Q2NChS ZXN1bHRDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJRCBvcDEsIFJlZ2lzdGVySUQgb3AyLCBSZWdp c3RlcklEIGRlc3QpCg==