152330 2015-12-16 00:28:13 -0800 Web Inspector: Improve copy of console messages with multiple arguments - console.log(obj1, obj2) 2015-12-16 09:44:40 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1149551 0 joepeck 2015-12-16 00:28:13 -0800 * SUMMARY Improve copy of console messages with multiple arguments - console.log(obj1, obj2) * TEST <script> console.log("Message", 1, "string", /regex/); console.log("Message", [1, 2], {x:10, y:20}); </script> * STEPS TO REPRODUCE 1. Inspect test case 2. Reload (to ensure previews) 3. Select console messages 4. Copy => The actual data in the copy is missing! BEFORE: > [Log] Message (3) (copy.html, line 2) > [Log] Message (2) (copy.html, line 3) AFTER: > [Log] Message (3) (copy.html, line 2) > 1 > "string" > /regex/ > > [Log] Message (2) (copy.html, line 3) > [1, 2] (2) > {x: 10, y: 20} 1149552 1 webkit-bug-importer 2015-12-16 00:28:26 -0800 <rdar://problem/23916726> 1149553 2 joepeck 2015-12-16 00:40:05 -0800 Another case: multiple arguments with call stack: <script> function foo() { console.error("Message", [1, 2], {x:10, y:20}); } foo(); </script> EXPECTED: > [Error] Message (2) > [1, 2] (2) > {x: 10, y: 20} > foo (copy.html:9) > Global Code (copy.html:11) Note the call stack coming after the arguments matches the UI here. 1149554 3 267447 joepeck 2015-12-16 00:42:04 -0800 Created attachment 267447 [PATCH] Proposed Fix 1149646 4 267447 commit-queue 2015-12-16 09:44:37 -0800 Comment on attachment 267447 [PATCH] Proposed Fix Clearing flags on attachment: 267447 Committed r194151: <http://trac.webkit.org/changeset/194151> 1149647 5 commit-queue 2015-12-16 09:44:40 -0800 All reviewed patches have been landed. Closing bug. 267447 2015-12-16 00:42:04 -0800 2015-12-16 09:44:37 -0800 [PATCH] Proposed Fix extra-args.patch text/plain 3109 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyMzllYzQuLjkwMTFhMjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTEyLTE2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wcm92 ZSBjb3B5IG9mIGNvbnNvbGUgbWVzc2FnZXMgd2l0aCBtdWx0aXBsZSBhcmd1bWVudHMgLSBjb25z b2xlLmxvZyhvYmoxLCBvYmoyKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyMzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZVZpZXcucHJvdG90eXBlLnRvQ2xp cGJvYXJkU3RyaW5nKToKKyAgICAgICAgQ29weSB0aGUgaW5uZXIgdGV4dCBvZiB0aGUgZXh0cmEg YXJndW1lbnRzIGxpc3QgYXMgd2VsbCwgZm9yCisgICAgICAgIGNvbnNvbGUgbWVzc2FnZXMgd2l0 aCBtdWx0aXBsZSBvYmplY3RzLiBSZWFycmFuZ2UgdGhlIHNlY3Rpb25zCisgICAgICAgIHRoYXQs IGlmIHRoZXJlIGlzIGEgc3RhY2sgdHJhY2UgaXQgY29tZXMgYXQgdGhlIGVuZCBhZnRlcgorICAg ICAgICBtdWx0aXBsZSBhcmd1bWVudHMuIElmIHRoZXJlIGlzIG5vIHN0YWNrIHRyYWNlLCBpbmNs dWRlIHRoZQorICAgICAgICBsb2NhdGlvbiBpbmZvIG5leHQgdG8gdGhlIHRvcCBsaW5lLCBiZWZv cmUgbXVsdGlwbGUgYXJndW1lbnRzLgorCisyMDE1LTEyLTE2ICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wcm92ZSBjb3B5 IG9mIGNvbnNvbGUgbWVzc2FnZSBjb250YWluaW5nIEFycmF5IGFuZCBNYXAgb3V0cHV0CiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIzMjkKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29s ZU1lc3NhZ2VWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQ29uc29sZU1lc3NhZ2VWaWV3LmpzCmluZGV4IDZlYWZiMzAuLmY2MjdmMmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNz YWdlVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Db25zb2xlTWVzc2FnZVZpZXcuanMKQEAgLTE5MywxMyArMTkzLDcgQEAgV2ViSW5zcGVjdG9y LkNvbnNvbGVNZXNzYWdlVmlldyA9IGNsYXNzIENvbnNvbGVNZXNzYWdlVmlldyBleHRlbmRzIFdl Ykluc3BlY3Rvci4KICAgICAgICAgICAgIGNsaXBib2FyZFN0cmluZyA9ICJjb25zb2xlLnRyYWNl KCkiOwogCiAgICAgICAgIGxldCBoYXNTdGFja1RyYWNlID0gdGhpcy5fc2hvdWxkU2hvd1N0YWNr VHJhY2UoKTsKLSAgICAgICAgaWYgKGhhc1N0YWNrVHJhY2UpIHsKLSAgICAgICAgICAgIHRoaXMu X21lc3NhZ2Uuc3RhY2tUcmFjZS5jYWxsRnJhbWVzLmZvckVhY2goZnVuY3Rpb24oZnJhbWUpIHsK LSAgICAgICAgICAgICAgICBjbGlwYm9hcmRTdHJpbmcgKz0gIlxuXHQiICsgKGZyYW1lLmZ1bmN0 aW9uTmFtZSB8fCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIihhbm9ueW1vdXMgZnVuY3Rpb24pIikp OwotICAgICAgICAgICAgICAgIGlmIChmcmFtZS5zb3VyY2VDb2RlTG9jYXRpb24pCi0gICAgICAg ICAgICAgICAgICAgIGNsaXBib2FyZFN0cmluZyArPSAiICgiICsgZnJhbWUuc291cmNlQ29kZUxv Y2F0aW9uLm9yaWdpbmFsTG9jYXRpb25TdHJpbmcoKSArICIpIjsKLSAgICAgICAgICAgIH0pOwot ICAgICAgICB9IGVsc2UgeworICAgICAgICBpZiAoIWhhc1N0YWNrVHJhY2UpIHsKICAgICAgICAg ICAgIGxldCByZXBlYXRTdHJpbmcgPSB0aGlzLnJlcGVhdENvdW50ID4gMSA/ICJ4IiArIHRoaXMu cmVwZWF0Q291bnQgOiAiIjsKICAgICAgICAgICAgIGxldCB1cmxMaW5lID0gIiI7CiAgICAgICAg ICAgICBpZiAodGhpcy5fbWVzc2FnZS51cmwpIHsKQEAgLTIxNyw2ICsyMTEsMTcgQEAgV2ViSW5z cGVjdG9yLkNvbnNvbGVNZXNzYWdlVmlldyA9IGNsYXNzIENvbnNvbGVNZXNzYWdlVmlldyBleHRl bmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAgICAgIH0KICAgICAgICAgfQogCisgICAgICAgIGlm ICh0aGlzLl9leHRyYUVsZW1lbnRzTGlzdCkKKyAgICAgICAgICAgIGNsaXBib2FyZFN0cmluZyAr PSAiXG4iICsgdGhpcy5fZXh0cmFFbGVtZW50c0xpc3QuaW5uZXJUZXh0LnJlbW92ZVdvcmRCcmVh a0NoYXJhY3RlcnMoKS50cmltKCk7CisKKyAgICAgICAgaWYgKGhhc1N0YWNrVHJhY2UpIHsKKyAg ICAgICAgICAgIHRoaXMuX21lc3NhZ2Uuc3RhY2tUcmFjZS5jYWxsRnJhbWVzLmZvckVhY2goZnVu Y3Rpb24oZnJhbWUpIHsKKyAgICAgICAgICAgICAgICBjbGlwYm9hcmRTdHJpbmcgKz0gIlxuXHQi ICsgKGZyYW1lLmZ1bmN0aW9uTmFtZSB8fCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIihhbm9ueW1v dXMgZnVuY3Rpb24pIikpOworICAgICAgICAgICAgICAgIGlmIChmcmFtZS5zb3VyY2VDb2RlTG9j YXRpb24pCisgICAgICAgICAgICAgICAgICAgIGNsaXBib2FyZFN0cmluZyArPSAiICgiICsgZnJh bWUuc291cmNlQ29kZUxvY2F0aW9uLm9yaWdpbmFsTG9jYXRpb25TdHJpbmcoKSArICIpIjsKKyAg ICAgICAgICAgIH0pOworICAgICAgICB9CisKICAgICAgICAgaWYgKCFpc1ByZWZpeE9wdGlvbmFs IHx8IHRoaXMuX2VuZm9yY2VzQ2xpcGJvYXJkUHJlZml4U3RyaW5nKCkpCiAgICAgICAgICAgICBy ZXR1cm4gdGhpcy5fY2xpcGJvYXJkUHJlZml4U3RyaW5nKCkgKyBjbGlwYm9hcmRTdHJpbmc7CiAg ICAgICAgIHJldHVybiBjbGlwYm9hcmRTdHJpbmc7Cg==