15228 2007-09-17 15:48:19 -0700 Missing flex, bison, or gperf produces a failing build 2007-09-19 09:20:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) PC Linux RESOLVED FIXED P2 Normal --- 1 Tuukka.Hastrup webkit-unassigned aroben ddkilzer oldest_to_newest 410 0 Tuukka.Hastrup 2007-09-17 15:48:19 -0700 If a build for Gdk or Qt is started with flex, bison, or gperf unavailable, the build will fail with non-obvious error messages even after those tools are later installed. 395 1 16309 Tuukka.Hastrup 2007-09-17 15:52:25 -0700 Created attachment 16309 Proposed fix Attached a proposed fix for this bug, requesting review. 360 2 16309 ddkilzer 2007-09-18 09:48:43 -0700 Comment on attachment 16309 Proposed fix >+ } elsif (isGdk() or isQt()) { >+ my @cmds = qw(flex bison gperf); >+ foreach my $cmd (@cmds) { >+ if (not `$cmd --version`) { >+ die ((join ", ", @cmds) . " required to build WebKit.\n"); >+ } >+ } > } Thanks for taking the time to file a bug and create a patch! This looks good, but I'd like to see the code changed to test for all three commands and report only the ones that are missing. For example if flex and bison are installed but not gperf, the developer gets a message about all three being required to build instead of a message about "gperf" missing. 336 3 16317 Tuukka.Hastrup 2007-09-18 13:41:18 -0700 Created attachment 16317 Updated fix Actually the initial patch prints an error message for the first command that can't be executed, followed by the message about the list of all required commands. But why not take one more step towards usability indeed. I've updated the patch according to the feedback, requesting a new review. Example output: ~/svn/WebKit$ WebKitTools/Scripts/build-webkit --gdk Can't exec "flex": No such file or directory at /home/tuukka/svn/WebKit/WebKitTools/Scripts/webkitdirs.pm line 497. Can't exec "gperf": No such file or directory at /home/tuukka/svn/WebKit/WebKitTools/Scripts/webkitdirs.pm line 497. flex, gperf missing but required to build WebKit. ~/svn/WebKit$ 307 4 16317 ddkilzer 2007-09-19 09:14:56 -0700 Comment on attachment 16317 Updated fix Looks good! r=me 308 5 ddkilzer 2007-09-19 09:20:10 -0700 Committed revision 25639. Added "ERROR: " to the die() statement to make it clearer that this is an error. 16309 2007-09-17 15:52:25 -0700 2007-09-18 13:41:18 -0700 Proposed fix webkitgdk-checkcmds.patch text/plain 1227 Tuukka.Hastrup SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1NjAwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwNy0wOS0xNyAgVHV1a2thIEhhc3RydXAgIDxU dXVra2EuSGFzdHJ1cEBpa2kuZmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06IE9uIEdkayBhbmQgUXQsIGNo ZWNrIHRoYXQgZmxleCwgYmlzb24sIGdwZXJmIGFyZSBhdmFpbGFibGUuCisKIDIwMDctMDktMTcg IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IFJvYmVuLgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMjU1OTMp CisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAg LTQ5MCw2ICs0OTAsMTMgQEAgc3ViIGNoZWNrUmVxdWlyZWRTeXN0ZW1Db25maWcKICAgICAgICAg ICAgIHByaW50ICJodHRwOi8vZGV2ZWxvcGVyLmFwcGxlLmNvbS90b29scy94Y29kZVxuIjsKICAg ICAgICAgICAgIHByaW50ICIqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqXG4iOwogICAgICAgICB9CisgICAgfSBlbHNpZiAoaXNHZGso KSBvciBpc1F0KCkpIHsKKyAgICAgICAgbXkgQGNtZHMgPSBxdyhmbGV4IGJpc29uIGdwZXJmKTsK KyAgICAgICAgZm9yZWFjaCBteSAkY21kIChAY21kcykgeworICAgICAgICAgICAgaWYgKG5vdCBg JGNtZCAtLXZlcnNpb25gKSB7CisgICAgICAgICAgICAgICAgZGllICgoam9pbiAiLCAiLCBAY21k cykgLiAiIHJlcXVpcmVkIHRvIGJ1aWxkIFdlYktpdC5cbiIpOworICAgICAgICAgICAgfQorICAg ICAgICB9CiAgICAgfQogICAgICMgV2luMzIgYW5kIG90aGVyIHBsYXRmb3JtcyBtYXkgd2FudCB0 byBjaGVjayBmb3IgbWluaW11bSBjb25maWcKIH0K 16317 2007-09-18 13:41:18 -0700 2007-09-19 09:14:56 -0700 Updated fix webkitgdk-checkcmds-2.patch text/plain 1320 Tuukka.Hastrup SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1NjE1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwNy0wOS0xNyAgVHV1a2thIEhhc3RydXAgIDxU dXVra2EuSGFzdHJ1cEBpa2kuZmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06IE9uIEdkayBhbmQgUXQsIGNo ZWNrIHRoYXQgZmxleCwgYmlzb24sIGdwZXJmIGFyZSBhdmFpbGFibGUuCisKIDIwMDctMDktMTcg IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXguCkluZGV4 OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCShyZXZpc2lvbiAyNTYxNSkKKysrIFdlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtNDkwLDYgKzQ5MCwx OCBAQAogICAgICAgICAgICAgcHJpbnQgImh0dHA6Ly9kZXZlbG9wZXIuYXBwbGUuY29tL3Rvb2xz L3hjb2RlXG4iOwogICAgICAgICAgICAgcHJpbnQgIioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKipcbiI7CiAgICAgICAgIH0KKyAgICB9 IGVsc2lmIChpc0dkaygpIG9yIGlzUXQoKSkgeworICAgICAgICBteSBAY21kcyA9IHF3KGZsZXgg Ymlzb24gZ3BlcmYpOworICAgICAgICBteSBAbWlzc2luZyA9ICgpOworICAgICAgICBmb3JlYWNo IG15ICRjbWQgKEBjbWRzKSB7CisgICAgICAgICAgICBpZiAobm90IGAkY21kIC0tdmVyc2lvbmAp IHsKKyAgICAgICAgICAgICAgICBwdXNoIEBtaXNzaW5nLCAkY21kOworICAgICAgICAgICAgfQor ICAgICAgICB9CisgICAgICAgIGlmIChAbWlzc2luZykgeworICAgICAgICAgICAgbXkgJGxpc3Qg PSBqb2luICIsICIsIEBtaXNzaW5nOworICAgICAgICAgICAgZGllICIkbGlzdCBtaXNzaW5nIGJ1 dCByZXF1aXJlZCB0byBidWlsZCBXZWJLaXQuXG4iOworICAgICAgICB9CiAgICAgfQogICAgICMg V2luMzIgYW5kIG90aGVyIHBsYXRmb3JtcyBtYXkgd2FudCB0byBjaGVjayBmb3IgbWluaW11bSBj b25maWcKIH0K