152270 2015-12-14 14:05:29 -0800 Web Inspector: Copy message from console with a stack trace does not include source code locations 2015-12-14 15:10:50 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1149102 0 joepeck 2015-12-14 14:05:29 -0800 * SUMMARY Copy message from console with a stack trace does not include source code locations. * STEPS TO REPRODUCE 1. Load test case 2. Select both console messages 3. Copy 4. Paste somewhere => Missing source code locations for frames * ACTUAL RESULTS > [Log] console.trace() > bar > foo > (anonymous function) > [Error] TypeError: undefined is not an object (evaluating '({}).x.x') > bar2 > foo2 > (anonymous function) * EXPECTED RESULTS > [Log] console.trace() > bar (trace.html:7) > foo (trace.html:3) > (anonymous function) (trace.html:11) > [Error] TypeError: undefined is not an object (evaluating '({}).x.x') > bar2 (trace.html:18) > foo2 (trace.html:14) > (anonymous function) (trace.html:22) * TEST <script> function foo() { bar(); } function bar() { console.trace(); } // Trace foo(); function foo2() { bar2(); } function bar2() { ({}).x.x; } // Exception foo2(); </script> 1149103 1 webkit-bug-importer 2015-12-14 14:06:00 -0800 <rdar://problem/23888682> 1149105 2 267320 joepeck 2015-12-14 14:10:25 -0800 Created attachment 267320 [PATCH] Proposed Fix 1149122 3 267320 commit-queue 2015-12-14 15:10:47 -0800 Comment on attachment 267320 [PATCH] Proposed Fix Clearing flags on attachment: 267320 Committed r194066: <http://trac.webkit.org/changeset/194066> 1149123 4 commit-queue 2015-12-14 15:10:50 -0800 All reviewed patches have been landed. Closing bug. 267320 2015-12-14 14:10:25 -0800 2015-12-14 15:10:47 -0800 [PATCH] Proposed Fix copy-trace.patch text/plain 1946 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEyMmQwZDkuLmZlOWQ3ZDUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTE0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29weSBt ZXNzYWdlIGZyb20gY29uc29sZSB3aXRoIGEgc3RhY2sgdHJhY2UgZG9lcyBub3QgaW5jbHVkZSBz b3VyY2UgY29kZSBsb2NhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1MjI3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2VWaWV3LnByb3RvdHlwZS50b0Ns aXBib2FyZFN0cmluZyk6CisgICAgICAgIFdoZW4gdGhlIHRoZSBTdGFja1RyYWNlIHdhcyB1cGdy YWRlZCB0byBhIHJlYWwgY29sbGVjdGlvbiBvZiBDYWxsRnJhbWUKKyAgICAgICAgb2JqZWN0J3Mg dGhlIENhbGxGcmFtZSdzIGdvdCByZWFsIFNvdXJjZUNvZGVMb2NhdGlvbiBwcm9wZXJ0aWVzLgor CiAyMDE1LTEyLTEyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjE5MTYxMyk6IFdlYiBJbnNwZWN0b3I6IENhbid0IHR5cGUgc3Bh Y2VzIHdoZW4gZWRpdGluZyBET00gbm9kZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcwpp bmRleCAzM2RiNzRmLi4wZGY0OTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZU1lc3NhZ2VWaWV3LmpzCkBA IC0xOTYsOCArMTk2LDggQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlVmlldyA9IGNsYXNz IENvbnNvbGVNZXNzYWdlVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAgaWYgKGhh c1N0YWNrVHJhY2UpIHsKICAgICAgICAgICAgIHRoaXMuX21lc3NhZ2Uuc3RhY2tUcmFjZS5jYWxs RnJhbWVzLmZvckVhY2goZnVuY3Rpb24oZnJhbWUpIHsKICAgICAgICAgICAgICAgICBjbGlwYm9h cmRTdHJpbmcgKz0gIlxuXHQiICsgKGZyYW1lLmZ1bmN0aW9uTmFtZSB8fCBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIihhbm9ueW1vdXMgZnVuY3Rpb24pIikpOwotICAgICAgICAgICAgICAgIGlmIChm cmFtZS51cmwpCi0gICAgICAgICAgICAgICAgICAgIGNsaXBib2FyZFN0cmluZyArPSAiICgiICsg V2ViSW5zcGVjdG9yLmRpc3BsYXlOYW1lRm9yVVJMKGZyYW1lLnVybCkgKyAiLCBsaW5lICIgKyBm cmFtZS5saW5lTnVtYmVyICsgIikiOworICAgICAgICAgICAgICAgIGlmIChmcmFtZS5zb3VyY2VD b2RlTG9jYXRpb24pCisgICAgICAgICAgICAgICAgICAgIGNsaXBib2FyZFN0cmluZyArPSAiICgi ICsgZnJhbWUuc291cmNlQ29kZUxvY2F0aW9uLm9yaWdpbmFsTG9jYXRpb25TdHJpbmcoKSArICIp IjsKICAgICAgICAgICAgIH0pOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgbGV0IHJl cGVhdFN0cmluZyA9IHRoaXMucmVwZWF0Q291bnQgPiAxID8gIngiICsgdGhpcy5yZXBlYXRDb3Vu dCA6ICIiOwo=