152199 2015-12-11 16:07:57 -0800 Removed some dead code, and simplified some code in the baseline JIT. 2015-12-11 17:33:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1148591 0 mark.lam 2015-12-11 16:07:57 -0800 Patch coming. 1148594 1 267200 mark.lam 2015-12-11 16:11:18 -0800 Created attachment 267200 proposed patch. 1148608 2 267200 benjamin 2015-12-11 16:42:23 -0800 Comment on attachment 267200 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=267200&action=review > Source/JavaScriptCore/jit/JITArithmetic.cpp:603 > + JITRightShiftGenerator::SignedShift : JITRightShiftGenerator::UnsignedShift; The normal names are ArithmeticShift and LogicalShift. 1148624 3 267200 commit-queue 2015-12-11 17:33:06 -0800 Comment on attachment 267200 proposed patch. Clearing flags on attachment: 267200 Committed r193998: <http://trac.webkit.org/changeset/193998> 1148625 4 commit-queue 2015-12-11 17:33:09 -0800 All reviewed patches have been landed. Closing bug. 267200 2015-12-11 16:11:18 -0800 2015-12-11 17:33:06 -0800 proposed patch. bug-152199.patch text/plain 5074 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkzOTkxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTEyLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmVkIHNvbWUgZGVhZCBjb2RlLCBhbmQgc2ltcGxpZmllZCBzb21lIGNvZGUgaW4gdGhlIGJh c2VsaW5lIEpJVC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1MjE5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogaml0L0pJVC5oOgorICAgICAgICAqIGppdC9KSVRBcml0aG1ldGljLmNwcDoKKyAgICAg ICAgKEpTQzo6SklUOjplbWl0Qml0QmluYXJ5T3BGYXN0UGF0aCk6CisgICAgICAgIChKU0M6OkpJ VDo6ZW1pdF9vcF9iaXRhbmQpOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRTbG93X29wX2xzaGlm dCk6CisgICAgICAgIChKU0M6OkpJVDo6ZW1pdFJpZ2h0U2hpZnRGYXN0UGF0aCk6CisgICAgICAg IChKU0M6OkpJVDo6ZW1pdF9vcF9yc2hpZnQpOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRTbG93 X29wX3JzaGlmdCk6CisgICAgICAgIChKU0M6OkpJVDo6ZW1pdF9vcF91cnNoaWZ0KToKKyAgICAg ICAgKEpTQzo6SklUOjplbWl0U2xvd19vcF91cnNoaWZ0KToKKwogMjAxNS0xMi0xMSAgQmVuamFt aW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0pTQ10gQWRkIGFu IGltcGxlbWVudGF0aW9uIG9mIHBvdygpIHRha2luZyBhbiBpbnRlZ2VyIGV4cG9uZW50IHRvIEIz CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgJKHJldmlzaW9uIDE5Mzk4NCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTgzMywxMSArODMz LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIFNuaXBwZXRH ZW5lcmF0b3I+CiAgICAgICAgIHZvaWQgZW1pdEJpdEJpbmFyeU9wRmFzdFBhdGgoSW5zdHJ1Y3Rp b24qIGN1cnJlbnRJbnN0cnVjdGlvbik7CiAKLSAgICAgICAgZW51bSBSaWdodFNoaWZ0VHlwZSB7 Ci0gICAgICAgICAgICBTaWduZWRTaGlmdCwKLSAgICAgICAgICAgIFVuc2lnbmVkU2hpZnQKLSAg ICAgICAgfTsKLSAgICAgICAgdm9pZCBlbWl0UmlnaHRTaGlmdEZhc3RQYXRoKEluc3RydWN0aW9u KiBjdXJyZW50SW5zdHJ1Y3Rpb24sIFJpZ2h0U2hpZnRUeXBlKTsKKyAgICAgICAgdm9pZCBlbWl0 UmlnaHRTaGlmdEZhc3RQYXRoKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24sIE9wY29k ZUlEKTsKIAogICAgICAgICBKdW1wIGNoZWNrU3RydWN0dXJlKFJlZ2lzdGVySUQgcmVnLCBTdHJ1 Y3R1cmUqIHN0cnVjdHVyZSk7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU QXJpdGhtZXRpYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRBcml0aG1ldGljLmNwcAkocmV2aXNpb24gMTkzOTg0KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRBcml0aG1ldGljLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTM2LDE3ICs1MzYs MTEgQEAgdm9pZCBKSVQ6OmVtaXRCaXRCaW5hcnlPcEZhc3RQYXRoKEluc3RydQogCiAgICAgZ2Vu LmdlbmVyYXRlRmFzdFBhdGgoKnRoaXMpOwogCi0gICAgaWYgKGdlbi5kaWRFbWl0RmFzdFBhdGgo KSkgewotICAgICAgICBnZW4uZW5kSnVtcExpc3QoKS5saW5rKHRoaXMpOwotICAgICAgICBlbWl0 UHV0VmlydHVhbFJlZ2lzdGVyKHJlc3VsdCwgcmVzdWx0UmVncyk7CisgICAgQVNTRVJUKGdlbi5k aWRFbWl0RmFzdFBhdGgoKSk7CisgICAgZ2VuLmVuZEp1bXBMaXN0KCkubGluayh0aGlzKTsKKyAg ICBlbWl0UHV0VmlydHVhbFJlZ2lzdGVyKHJlc3VsdCwgcmVzdWx0UmVncyk7CiAKLSAgICAgICAg YWRkU2xvd0Nhc2UoZ2VuLnNsb3dQYXRoSnVtcExpc3QoKSk7Ci0gICAgfSBlbHNlIHsKLSAgICAg ICAgQVNTRVJUKGdlbi5lbmRKdW1wTGlzdCgpLmVtcHR5KCkpOwotICAgICAgICBBU1NFUlQoZ2Vu LnNsb3dQYXRoSnVtcExpc3QoKS5lbXB0eSgpKTsKLSAgICAgICAgSklUU2xvd1BhdGhDYWxsIHNs b3dQYXRoQ2FsbCh0aGlzLCBjdXJyZW50SW5zdHJ1Y3Rpb24sIHNsb3dfcGF0aF9hZGQpOwotICAg ICAgICBzbG93UGF0aENhbGwuY2FsbCgpOwotICAgIH0KKyAgICBhZGRTbG93Q2FzZShnZW4uc2xv d1BhdGhKdW1wTGlzdCgpKTsKIH0KIAogdm9pZCBKSVQ6OmVtaXRfb3BfYml0YW5kKEluc3RydWN0 aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24pCkBAIC02MDEsOCArNTk1LDEzIEBAIHZvaWQgSklUOjpl bWl0U2xvd19vcF9sc2hpZnQoSW5zdHJ1Y3Rpb24KICAgICBzbG93UGF0aENhbGwuY2FsbCgpOwog fQogCi12b2lkIEpJVDo6ZW1pdFJpZ2h0U2hpZnRGYXN0UGF0aChJbnN0cnVjdGlvbiogY3VycmVu dEluc3RydWN0aW9uLCBSaWdodFNoaWZ0VHlwZSByaWdodFNoaWZ0VHlwZSkKK3ZvaWQgSklUOjpl bWl0UmlnaHRTaGlmdEZhc3RQYXRoKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24sIE9w Y29kZUlEIG9wY29kZUlEKQogeworICAgIEFTU0VSVChvcGNvZGVJRCA9PSBvcF9yc2hpZnQgfHwg b3Bjb2RlSUQgPT0gb3BfdXJzaGlmdCk7CisKKyAgICBKSVRSaWdodFNoaWZ0R2VuZXJhdG9yOjpT aGlmdFR5cGUgc25pcHBldFNoaWZ0VHlwZSA9IG9wY29kZUlEID09IG9wX3JzaGlmdCA/CisgICAg ICAgIEpJVFJpZ2h0U2hpZnRHZW5lcmF0b3I6OlNpZ25lZFNoaWZ0IDogSklUUmlnaHRTaGlmdEdl bmVyYXRvcjo6VW5zaWduZWRTaGlmdDsKKwogICAgIGludCByZXN1bHQgPSBjdXJyZW50SW5zdHJ1 Y3Rpb25bMV0udS5vcGVyYW5kOwogICAgIGludCBvcDEgPSBjdXJyZW50SW5zdHJ1Y3Rpb25bMl0u dS5vcGVyYW5kOwogICAgIGludCBvcDIgPSBjdXJyZW50SW5zdHJ1Y3Rpb25bM10udS5vcGVyYW5k OwpAQCAtNjM2LDMwICs2MzUsMjEgQEAgdm9pZCBKSVQ6OmVtaXRSaWdodFNoaWZ0RmFzdFBhdGgo SW5zdHJ1YwogICAgIGlmICghcmlnaHRPcGVyYW5kLmlzQ29uc3QoKSkKICAgICAgICAgZW1pdEdl dFZpcnR1YWxSZWdpc3RlcihvcDIsIHJpZ2h0UmVncyk7CiAKLSAgICBKSVRSaWdodFNoaWZ0R2Vu ZXJhdG9yOjpTaGlmdFR5cGUgc25pcHBldFNoaWZ0VHlwZSA9Ci0gICAgICAgIChyaWdodFNoaWZ0 VHlwZSA9PSBTaWduZWRTaGlmdCkgPyBKSVRSaWdodFNoaWZ0R2VuZXJhdG9yOjpTaWduZWRTaGlm dCA6IEpJVFJpZ2h0U2hpZnRHZW5lcmF0b3I6OlVuc2lnbmVkU2hpZnQ7Ci0KICAgICBKSVRSaWdo dFNoaWZ0R2VuZXJhdG9yIGdlbihsZWZ0T3BlcmFuZCwgcmlnaHRPcGVyYW5kLCByZXN1bHRSZWdz LCBsZWZ0UmVncywgcmlnaHRSZWdzLAogICAgICAgICBmcFJlZ1QwLCBzY3JhdGNoR1BSLCBzY3Jh dGNoRlBSLCBzbmlwcGV0U2hpZnRUeXBlKTsKIAogICAgIGdlbi5nZW5lcmF0ZUZhc3RQYXRoKCp0 aGlzKTsKIAotICAgIGlmIChnZW4uZGlkRW1pdEZhc3RQYXRoKCkpIHsKLSAgICAgICAgZ2VuLmVu ZEp1bXBMaXN0KCkubGluayh0aGlzKTsKLSAgICAgICAgZW1pdFB1dFZpcnR1YWxSZWdpc3Rlcihy ZXN1bHQsIHJlc3VsdFJlZ3MpOworICAgIEFTU0VSVChnZW4uZGlkRW1pdEZhc3RQYXRoKCkpOwor ICAgIGdlbi5lbmRKdW1wTGlzdCgpLmxpbmsodGhpcyk7CisgICAgZW1pdFB1dFZpcnR1YWxSZWdp c3RlcihyZXN1bHQsIHJlc3VsdFJlZ3MpOwogCi0gICAgICAgIGFkZFNsb3dDYXNlKGdlbi5zbG93 UGF0aEp1bXBMaXN0KCkpOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIEFTU0VSVChnZW4uZW5kSnVt cExpc3QoKS5lbXB0eSgpKTsKLSAgICAgICAgQVNTRVJUKGdlbi5zbG93UGF0aEp1bXBMaXN0KCku ZW1wdHkoKSk7Ci0gICAgICAgIEpJVFNsb3dQYXRoQ2FsbCBzbG93UGF0aENhbGwodGhpcywgY3Vy cmVudEluc3RydWN0aW9uLCBzbG93X3BhdGhfYWRkKTsKLSAgICAgICAgc2xvd1BhdGhDYWxsLmNh bGwoKTsKLSAgICB9CisgICAgYWRkU2xvd0Nhc2UoZ2VuLnNsb3dQYXRoSnVtcExpc3QoKSk7CiB9 CiAKIHZvaWQgSklUOjplbWl0X29wX3JzaGlmdChJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0 aW9uKQogewotICAgIGVtaXRSaWdodFNoaWZ0RmFzdFBhdGgoY3VycmVudEluc3RydWN0aW9uLCBS aWdodFNoaWZ0VHlwZTo6U2lnbmVkU2hpZnQpOworICAgIGVtaXRSaWdodFNoaWZ0RmFzdFBhdGgo Y3VycmVudEluc3RydWN0aW9uLCBvcF9yc2hpZnQpOwogfQogCiB2b2lkIEpJVDo6ZW1pdFNsb3df b3BfcnNoaWZ0KEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24sIFZlY3RvcjxTbG93Q2Fz ZUVudHJ5Pjo6aXRlcmF0b3ImIGl0ZXIpCkBAIC02NzIsNyArNjYyLDcgQEAgdm9pZCBKSVQ6OmVt aXRTbG93X29wX3JzaGlmdChJbnN0cnVjdGlvbgogCiB2b2lkIEpJVDo6ZW1pdF9vcF91cnNoaWZ0 KEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24pCiB7Ci0gICAgZW1pdFJpZ2h0U2hpZnRG YXN0UGF0aChjdXJyZW50SW5zdHJ1Y3Rpb24sIFJpZ2h0U2hpZnRUeXBlOjpVbnNpZ25lZFNoaWZ0 KTsKKyAgICBlbWl0UmlnaHRTaGlmdEZhc3RQYXRoKGN1cnJlbnRJbnN0cnVjdGlvbiwgb3BfdXJz aGlmdCk7CiB9CiAKIHZvaWQgSklUOjplbWl0U2xvd19vcF91cnNoaWZ0KEluc3RydWN0aW9uKiBj dXJyZW50SW5zdHJ1Y3Rpb24sIFZlY3RvcjxTbG93Q2FzZUVudHJ5Pjo6aXRlcmF0b3ImIGl0ZXIp Cg==