152196 2015-12-11 15:52:58 -0800 Perf dashboard's buildbot sync config JSON duplicates too much information 2016-02-16 13:53:33 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu jond rniwa slewis timothy oldest_to_newest 1148581 0 rniwa 2015-12-11 15:52:58 -0800 Consolidate the duplicated entries. 1148584 1 267196 rniwa 2015-12-11 15:56:31 -0800 Created attachment 267196 Added shared configurations 1148586 2 267196 dewei_zhu 2015-12-11 15:59:46 -0800 Comment on attachment 267196 Added shared configurations This will definitely simplify the process of enabling a new test. Is the data format documented anywhere? 1148590 3 267196 slewis 2015-12-11 16:07:40 -0800 Comment on attachment 267196 Added shared configurations View in context: https://bugs.webkit.org/attachment.cgi?id=267196&action=review > Websites/perf.webkit.org/tools/sync-with-buildbot.py:78 > + config[key].update(value) Would we ever have a list? 1148596 4 267196 rniwa 2015-12-11 16:11:54 -0800 Comment on attachment 267196 Added shared configurations View in context: https://bugs.webkit.org/attachment.cgi?id=267196&action=review >> Websites/perf.webkit.org/tools/sync-with-buildbot.py:78 >> + config[key].update(value) > > Would we ever have a list? If we did have a list, then overriding the old list with the new one (not merging is the right approach so the code below (config[key] = value) will suffice. 1148597 5 rniwa 2015-12-11 16:12:00 -0800 Committed r193992: <http://trac.webkit.org/changeset/193992> 267196 2015-12-11 15:56:31 -0800 2015-12-11 16:07:40 -0800 Added shared configurations bug-152196-20151211155559.patch text/plain 2154 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTkzOTkwKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE1LTEyLTExICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBlcmYgZGFzaGJvYXJkJ3MgYnVpbGRib3Qgc3luYyBjb25maWcgSlNPTiBkdXBs aWNhdGVzIHRvbyBtdWNoIGluZm9ybWF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIxOTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRlZCBzaGFyZWQsIHBlci1idWlsZGVyLCBhbmQgcGVyLXRl c3QgKGNhbGxlZCB0eXBlKSBjb25maWd1cmF0aW9ucy4KKworICAgICAgICAqIHRvb2xzL3N5bmMt d2l0aC1idWlsZGJvdC5weToKKyAgICAgICAgKGxvYWRfY29uZmlnKToKKyAgICAgICAgKGxvYWRf Y29uZmlnLm1lcmdlKToKKwogMjAxNS0xMi0wMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBQZXJmIGRhc2hib2FyZCBzaG91bGQgYXZvaWQgb3ZlcmZsb3cgZHVy aW5nIGdlb21ldHJpYyBtZWFuIGNvbXB1dGF0aW9uCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvdG9vbHMvc3luYy13aXRoLWJ1aWxkYm90LnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy90b29scy9zeW5jLXdpdGgtYnVpbGRib3QucHkJKHJldmlzaW9uIDE5 Mzk4OSkKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy90b29scy9zeW5jLXdpdGgtYnVpbGRi b3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTY1LDkgKzY1LDI3IEBAIGRlZiBtYWluKCk6CiAKIGRl ZiBsb2FkX2NvbmZpZyhjb25maWdfanNvbl9wYXRoLCBidWlsZGJvdF91cmwpOgogICAgIHdpdGgg b3Blbihjb25maWdfanNvbl9wYXRoKSBhcyBjb25maWdfanNvbjoKLSAgICAgICAgY29uZmlndXJh dGlvbnMgPSBqc29uLmxvYWQoY29uZmlnX2pzb24pCisgICAgICAgIG9wdGlvbnMgPSBqc29uLmxv YWQoY29uZmlnX2pzb24pCiAKKyAgICBzaGFyZWRfY29uZmlnID0gb3B0aW9uc1snc2hhcmVkJ10K KyAgICB0eXBlX2NvbmZpZyA9IG9wdGlvbnNbJ3R5cGVzJ10KKyAgICBidWlsZGVyX2NvbmZpZyA9 IG9wdGlvbnNbJ2J1aWxkZXJzJ10KKworICAgIGRlZiBtZXJnZShjb25maWcsIGNvbmZpZ190b19t ZXJnZSk6CisgICAgICAgIGZvciBrZXksIHZhbHVlIGluIGNvbmZpZ190b19tZXJnZS5pdGVyaXRl bXMoKToKKyAgICAgICAgICAgIGlmIGlzaW5zdGFuY2UodmFsdWUsIGRpY3QpOgorICAgICAgICAg ICAgICAgIGNvbmZpZy5zZXRkZWZhdWx0KGtleSwge30pCisgICAgICAgICAgICAgICAgY29uZmln W2tleV0udXBkYXRlKHZhbHVlKQorICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAgICBj b25maWdba2V5XSA9IHZhbHVlCisKKyAgICBjb25maWd1cmF0aW9ucyA9IG9wdGlvbnNbJ2NvbmZp Z3VyYXRpb25zJ10KICAgICBmb3IgY29uZmlnIGluIGNvbmZpZ3VyYXRpb25zOgorCisgICAgICAg IG1lcmdlKGNvbmZpZywgc2hhcmVkX2NvbmZpZykKKyAgICAgICAgbWVyZ2UoY29uZmlnLCB0eXBl X2NvbmZpZ1tjb25maWcucG9wKCd0eXBlJyldKQorICAgICAgICBtZXJnZShjb25maWcsIGJ1aWxk ZXJfY29uZmlnW2NvbmZpZy5wb3AoJ2J1aWxkZXInKV0pCisKICAgICAgICAgZXNjYXBlZF9idWls ZGVyX25hbWUgPSB1cmxsaWIucXVvdGUoY29uZmlnWydidWlsZGVyJ10pCiAgICAgICAgIGNvbmZp Z1sndXJsJ10gPSAnJXMvYnVpbGRlcnMvJXMvJyAlIChidWlsZGJvdF91cmwsIGVzY2FwZWRfYnVp bGRlcl9uYW1lKQogICAgICAgICBjb25maWdbJ2pzb25VUkwnXSA9ICclcy9qc29uL2J1aWxkZXJz LyVzLycgJSAoYnVpbGRib3RfdXJsLCBlc2NhcGVkX2J1aWxkZXJfbmFtZSkK