152175 2015-12-11 09:28:03 -0800 Modern IDB: storage/indexeddb/index-count.html fails 2015-12-11 15:55:21 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 150882 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1148472 0 beidson 2015-12-11 09:28:03 -0800 Modern IDB: storage/indexeddb/index-count.html fails This is basically the IDBIndex version of https://bugs.webkit.org/show_bug.cgi?id=152167 1148478 1 267171 beidson 2015-12-11 09:47:04 -0800 Created attachment 267171 Patch v1 1148489 2 267171 commit-queue 2015-12-11 11:14:00 -0800 Comment on attachment 267171 Patch v1 Clearing flags on attachment: 267171 Committed r193968: <http://trac.webkit.org/changeset/193968> 1148490 3 commit-queue 2015-12-11 11:14:03 -0800 All reviewed patches have been landed. Closing bug. 1148573 4 267171 darin 2015-12-11 15:36:15 -0800 Comment on attachment 267171 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=267171&action=review > Source/WebCore/Modules/indexeddb/client/IDBIndexImpl.cpp:142 > + return doCount(*context, IDBKeyRangeData::allKeys(), ec);} I suggest moving the end brace to the next line. 1148583 5 beidson 2015-12-11 15:55:21 -0800 (In reply to comment #4) > Comment on attachment 267171 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267171&action=review > > > Source/WebCore/Modules/indexeddb/client/IDBIndexImpl.cpp:142 > > + return doCount(*context, IDBKeyRangeData::allKeys(), ec);} > > I suggest moving the end brace to the next line. Yikes! By saying "I suggest..." you're being too kind. :) Fixed in https://trac.webkit.org/changeset/193991 267171 2015-12-11 09:47:04 -0800 2015-12-11 11:14:00 -0800 Patch v1 patch text/plain 5583 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhMzkwYTE2Li43ZTUwNTlmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMTIt MTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVybiBJ REI6IHN0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWNvdW50Lmh0bWwgZmFpbHMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIxNzUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy13azEv VGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9pbmRleC1jb3Vu dC1leHBlY3RlZC50eHQ6CisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2luZGV4 LWdldC1jb3VudC1mYWlsdXJlcy1leHBlY3RlZC50eHQ6CisKIDIwMTUtMTItMTAgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIE1vZGVybiBJREI6IHN0b3JhZ2Uv aW5kZXhlZGRiL29iamVjdHN0b3JlLWNvdW50Lmh0bWwgZmFpbHMuCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggY2Q4YzdmNC4uZGRmM2Y1MiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucwpAQCAt OTYsNyArOTYsNiBAQCBzdG9yYWdlL2luZGV4ZWRkYi9jdXJzb3ItY29udGludWUuaHRtbCBbIEZh aWx1cmUgXQogc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtZGVsZXRlcGVuZGluZy1mbGFnLmh0 bWwgWyBGYWlsdXJlIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZS1jbG9zZWQtZGF0YWJhc2Ut b2JqZWN0Lmh0bWwgWyBGYWlsdXJlIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWJhc2ljcy5o dG1sIFsgRmFpbHVyZSBdCi1zdG9yYWdlL2luZGV4ZWRkYi9pbmRleC1jb3VudC5odG1sIFsgRmFp bHVyZSBdCiBzdG9yYWdlL2luZGV4ZWRkYi9pbmRleC1kdXBsaWNhdGUta2V5cGF0aHMuaHRtbCBb IEZhaWx1cmUgXQogc3RvcmFnZS9pbmRleGVkZGIvaW50dmVyc2lvbi1hYm9ydC1pbi1pbml0aWFs LXVwZ3JhZGVuZWVkZWQuaHRtbCBbIEZhaWx1cmUgXQogc3RvcmFnZS9pbmRleGVkZGIvaW50dmVy c2lvbi1jbG9zZS1pbi1vbmNvbXBsZXRlLmh0bWwgWyBGYWlsdXJlIF0KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWNvdW50LWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWNvdW50LWV4cGVjdGVkLnR4dAppbmRl eCA4MGMxYzBmLi5mMTkxNmQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4 ZWRkYi9pbmRleC1jb3VudC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvaW5kZXgtY291bnQtZXhwZWN0ZWQudHh0CkBAIC04OCwxNyArODgsMTcgQEAgRXhw ZWN0aW5nIGV4Y2VwdGlvbiBmcm9tIGluZGV4LmNvdW50KE5hTikKIFBBU1MgRXhjZXB0aW9uIHdh cyB0aHJvd24uCiBQQVNTIGNvZGUgaXMgMAogUEFTUyBlbmFtZSBpcyAnRGF0YUVycm9yJwotRXhj ZXB0aW9uIG1lc3NhZ2U6IERhdGFFcnJvcjogRE9NIElEQkRhdGFiYXNlIEV4Y2VwdGlvbiAwCitF eGNlcHRpb24gbWVzc2FnZTogRmFpbGVkIHRvIGV4ZWN1dGUgJ2NvdW50JyBvbiAnSURCSW5kZXgn OiBUaGUgcGFyYW1ldGVyIGlzIG5vdCBhIHZhbGlkIGtleS4KIEV4cGVjdGluZyBleGNlcHRpb24g ZnJvbSBpbmRleC5jb3VudCh7fSkKIFBBU1MgRXhjZXB0aW9uIHdhcyB0aHJvd24uCiBQQVNTIGNv ZGUgaXMgMAogUEFTUyBlbmFtZSBpcyAnRGF0YUVycm9yJwotRXhjZXB0aW9uIG1lc3NhZ2U6IERh dGFFcnJvcjogRE9NIElEQkRhdGFiYXNlIEV4Y2VwdGlvbiAwCitFeGNlcHRpb24gbWVzc2FnZTog RmFpbGVkIHRvIGV4ZWN1dGUgJ2NvdW50JyBvbiAnSURCSW5kZXgnOiBUaGUgcGFyYW1ldGVyIGlz IG5vdCBhIHZhbGlkIGtleS4KIEV4cGVjdGluZyBleGNlcHRpb24gZnJvbSBpbmRleC5jb3VudCgv cmVnZXgvKQogUEFTUyBFeGNlcHRpb24gd2FzIHRocm93bi4KIFBBU1MgY29kZSBpcyAwCiBQQVNT IGVuYW1lIGlzICdEYXRhRXJyb3InCi1FeGNlcHRpb24gbWVzc2FnZTogRGF0YUVycm9yOiBET00g SURCRGF0YWJhc2UgRXhjZXB0aW9uIDAKK0V4Y2VwdGlvbiBtZXNzYWdlOiBGYWlsZWQgdG8gZXhl Y3V0ZSAnY291bnQnIG9uICdJREJJbmRleCc6IFRoZSBwYXJhbWV0ZXIgaXMgbm90IGEgdmFsaWQg a2V5LgogCiB0ZXN0ID0geyJrZXkiOjAsImV4cGVjdGVkIjoxfQogcmVxdWVzdCA9IGluZGV4LmNv dW50KHRlc3Qua2V5KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIv bW9kZXJuL2luZGV4LWdldC1jb3VudC1mYWlsdXJlcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaW5kZXgtZ2V0LWNvdW50LWZhaWx1cmVzLWV4cGVj dGVkLnR4dAppbmRleCBmNzY0NmQ0Li4wZTE3MDNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaW5kZXgtZ2V0LWNvdW50LWZhaWx1cmVzLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaW5kZXgtZ2V0 LWNvdW50LWZhaWx1cmVzLWV4cGVjdGVkLnR4dApAQCAtMiw3ICsyLDYgQEAgVGhpcyB0ZXN0cyBz b21lIG9idmlvdXMgZmFpbHVyZXMgdGhhdCBjYW4gaGFwcGVuIHdoaWxlIGNhbGxpbmcgdGhlIElE QkluZGV4IG1ldGgKIEluaXRpYWwgdXBncmFkZSBuZWVkZWQ6IE9sZCB2ZXJzaW9uIC0gMCBOZXcg dmVyc2lvbiAtIDEKIEZhaWxlZCB0byBnZXQgd2l0aCBhIG51bGwga2V5CiBGYWlsZWQgdG8gZ2V0 S2V5IHdpdGggYSBudWxsIGtleQotRmFpbGVkIHRvIGNvdW50IHdpdGggYSBudWxsIHJhbmdlCiBG YWlsZWQgdG8gZ2V0IHdpdGggZGVsZXRlZCBJREJJbmRleAogRmFpbGVkIHRvIGdldEtleSB3aXRo IGRlbGV0ZWQgSURCSW5kZXgKIEZhaWxlZCB0byBjb3VudCB3aXRoIGRlbGV0ZWQgSURCSW5kZXgK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYTNmZjkzLi40YzI2OGNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTUtMTItMTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1vZGVybiBJREI6IHN0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWNvdW50Lmh0bWwgZmFpbHMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIxNzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgKEF0IGxlYXN0IG9uZSBmYWlsaW5nIHRlc3Qgbm93IHBhc3NlcykuCisKKyAgICAgICAg KiBNb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCSW5kZXhJbXBsLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OklEQkNsaWVudDo6SURCSW5kZXg6OmNvdW50KTogSWYgdGhlIHBhc3NlZCBpbiBJREJL ZXlSYW5nZSogaXMgbnVsbHB0ciwgdXNlIElEQktleVJhbmdlRGF0YTo6YWxsS2V5cy4KKyAgICAg ICAgKFdlYkNvcmU6OklEQkNsaWVudDo6SURCSW5kZXg6OmRvQ291bnQpOiBDaGFuZ2UgYW4gaXNO dWxsIGNoZWNrIHRvIGEgbW9yZSBjb3JyZWN0ICFpc1ZhbGlkKCkgY2hlY2suCisKIDIwMTUtMTIt MTAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIE1vZGVybiBJ REI6IHN0b3JhZ2UvaW5kZXhlZGRiL29iamVjdHN0b3JlLWNvdW50Lmh0bWwgZmFpbHMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCSW5kZXhJ bXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJJbmRl eEltcGwuY3BwCmluZGV4IDdmNDI3ZDAuLjgwMDdiMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJJbmRleEltcGwuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJJbmRleEltcGwuY3BwCkBAIC0x MzksOSArMTM5LDcgQEAgUmVmUHRyPFdlYkNvcmU6OklEQlJlcXVlc3Q+IElEQkluZGV4Ojpjb3Vu dChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBFeGMKICAgICAgICAgcmV0dXJuIG51 bGxwdHI7CiAgICAgfQogCi0gICAgSURCS2V5UmFuZ2VEYXRhIHJhbmdlOwotICAgIHJhbmdlLmlz TnVsbCA9IGZhbHNlOwotICAgIHJldHVybiBkb0NvdW50KCpjb250ZXh0LCByYW5nZSwgZWMpO30K KyAgICByZXR1cm4gZG9Db3VudCgqY29udGV4dCwgSURCS2V5UmFuZ2VEYXRhOjphbGxLZXlzKCks IGVjKTt9CiAKIFJlZlB0cjxXZWJDb3JlOjpJREJSZXF1ZXN0PiBJREJJbmRleDo6Y291bnQoU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgSURCS2V5UmFuZ2UqIHJhbmdlLCBFeGNlcHRp b25Db2RlV2l0aE1lc3NhZ2UmIGVjKQogewpAQCAtMTUyLDcgKzE1MCw3IEBAIFJlZlB0cjxXZWJD b3JlOjpJREJSZXF1ZXN0PiBJREJJbmRleDo6Y291bnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCog Y29udGV4dCwgSURCCiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KIAotICAgIHJldHVy biBkb0NvdW50KCpjb250ZXh0LCBJREJLZXlSYW5nZURhdGEocmFuZ2UpLCBlYyk7CisgICAgcmV0 dXJuIGRvQ291bnQoKmNvbnRleHQsIHJhbmdlID8gSURCS2V5UmFuZ2VEYXRhKHJhbmdlKSA6IElE QktleVJhbmdlRGF0YTo6YWxsS2V5cygpLCBlYyk7CiB9CiAKIFJlZlB0cjxXZWJDb3JlOjpJREJS ZXF1ZXN0PiBJREJJbmRleDo6Y291bnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwg Y29uc3QgRGVwcmVjYXRlZDo6U2NyaXB0VmFsdWUmIGtleSwgRXhjZXB0aW9uQ29kZVdpdGhNZXNz YWdlJiBlYykKQEAgLTE4Miw3ICsxODAsNyBAQCBSZWZQdHI8V2ViQ29yZTo6SURCUmVxdWVzdD4g SURCSW5kZXg6OmRvQ291bnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCwgYwogICAg ICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CiAKLSAgICBpZiAocmFuZ2UuaXNOdWxsKSB7Cisg ICAgaWYgKCFyYW5nZS5pc1ZhbGlkKCkpIHsKICAgICAgICAgZWMuY29kZSA9IElEQkRhdGFiYXNl RXhjZXB0aW9uOjpEYXRhRXJyb3I7CiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0K