152173 2015-12-11 06:50:37 -0800 REGRESSION (r191613): Web Inspector: Can't type spaces when editing DOM nodes 2015-12-12 20:01:31 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Mac OS X 10.11 VERIFIED FIXED InRadar P2 Normal --- 1 bugzilla joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1148458 0 bugzilla 2015-12-11 06:50:37 -0800 At some point recently, I stopped being able to type spaces when editing DOM nodes in the Web Inspector's "Elements" tab. Typing any other character works, and I can work around the issue by copying and pasting spaces. STR: 1. Open the Web Inspector to the "Elements" tab. 2. Double click any element or text node to edit its contents. 3. Press the space bar. Expected: Spaces should be typed into the selected field. Actual: Nothing happens. This works as expected in Safari 9.0.2 (11601.3.9), but is broken in WebKit r193949. I think it broke within the last couple weeks. 1148459 1 webkit-bug-importer 2015-12-11 06:51:04 -0800 <rdar://problem/23857868> 1148657 2 nvasilyev 2015-12-11 22:01:15 -0800 Bisecting tells me that the regression was introduced by: http://trac.webkit.org/changeset/191613 1148667 3 joepeck 2015-12-11 23:00:12 -0800 (In reply to comment #2) > Bisecting tells me that the regression was introduced by: > http://trac.webkit.org/changeset/191613 Really? Hah. I wonder if the keyboard shortcuts should start out disabled, since they are only meant to be enabled / disabled when the TabContentView is shown, but they don't look disabled when created. 1148684 4 267228 joepeck 2015-12-12 00:06:31 -0800 Created attachment 267228 [PATCH] Proposed Fix 1148708 5 267228 commit-queue 2015-12-12 09:37:58 -0800 Comment on attachment 267228 [PATCH] Proposed Fix Clearing flags on attachment: 267228 Committed r194009: <http://trac.webkit.org/changeset/194009> 1148709 6 commit-queue 2015-12-12 09:38:02 -0800 All reviewed patches have been landed. Closing bug. 1148771 7 bugzilla 2015-12-12 20:01:31 -0800 Looks good in the r194012 nightly. Thanks! 267228 2015-12-12 00:06:31 -0800 2015-12-12 09:37:58 -0800 [PATCH] Proposed Fix space-fix.patch text/plain 2054 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVjMDg1NDIuLjEyMmQwZDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTEyLTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE5MTYxMyk6 IFdlYiBJbnNwZWN0b3I6IENhbid0IHR5cGUgc3BhY2VzIHdoZW4gZWRpdGluZyBET00gbm9kZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjE3Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZVNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbCk6CisgICAgICAgIERpc2FibGUgdGhlIGtleWJvYXJk IHNob3J0Y3V0cyB3aGVuIHRoZXkgYXJlIGNyZWF0ZWQuIFRoZXkgd2lsbCBiZQorICAgICAgICBl bmFibGVkIHdoZW4gdGhlIHBhbmVsIGlzIHNob3duIC8gaGlkZGVuLiBJdCBkb2Vzbid0IHJlYWxs eSBtYWtlIHNlbnNlCisgICAgICAgIHRoYXQgdGhlc2UgYXJlIG9uIHRoZSBzaWRlYmFyIHBhbmVs IGluc3RlYWQgb2YgdGhlIHRhYiwgYnV0IHRoaW5ncworICAgICAgICB3aWxsIGJlIGNoYW5naW5n IGluIFRpbWVsaW5lcyBzb29uIGFueXdheXMgc28ganVzdCBmaXggdGhpcyBub3cuCisKIDIwMTUt MTItMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBBZGQgSlNDb250ZXh0IFNjcmlwdCBQcm9maWxpbmcKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lkZWJh clBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVTaWRlYmFyUGFuZWwuanMKaW5kZXggMzA3NDYxNi4uYTczODFlOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFy UGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVTaWRlYmFyUGFuZWwuanMKQEAgLTE3NSw5ICsxNzUsMTEgQEAgV2ViSW5zcGVjdG9y LlRpbWVsaW5lU2lkZWJhclBhbmVsID0gY2xhc3MgVGltZWxpbmVTaWRlYmFyUGFuZWwgZXh0ZW5k cyBXZWJJbnNwZWMKIAogICAgICAgICB0aGlzLl90b2dnbGVSZWNvcmRpbmdTaG9ydGN1dCA9IG5l dyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChudWxsLCBXZWJJbnNwZWN0b3IuS2V5Ym9h cmRTaG9ydGN1dC5LZXkuU3BhY2UsIHRoaXMuX3RvZ2dsZVJlY29yZGluZ09uU3BhY2ViYXIuYmlu ZCh0aGlzKSk7CiAgICAgICAgIHRoaXMuX3RvZ2dsZVJlY29yZGluZ1Nob3J0Y3V0LmltcGxpY2l0 bHlQcmV2ZW50c0RlZmF1bHQgPSBmYWxzZTsKKyAgICAgICAgdGhpcy5fdG9nZ2xlUmVjb3JkaW5n U2hvcnRjdXQuZGlzYWJsZWQgPSB0cnVlOwogCiAgICAgICAgIHRoaXMuX3RvZ2dsZU5ld1JlY29y ZGluZ1Nob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3Bl Y3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLlNoaWZ0LCBXZWJJbnNwZWN0b3IuS2V5Ym9h cmRTaG9ydGN1dC5LZXkuU3BhY2UsIHRoaXMuX3RvZ2dsZU5ld1JlY29yZGluZ09uU3BhY2ViYXIu YmluZCh0aGlzKSk7CiAgICAgICAgIHRoaXMuX3RvZ2dsZU5ld1JlY29yZGluZ1Nob3J0Y3V0Lmlt cGxpY2l0bHlQcmV2ZW50c0RlZmF1bHQgPSBmYWxzZTsKKyAgICAgICAgdGhpcy5fdG9nZ2xlTmV3 UmVjb3JkaW5nU2hvcnRjdXQuZGlzYWJsZWQgPSB0cnVlOwogICAgIH0KIAogICAgIC8vIFN0YXRp Ywo=