15215 2007-09-14 08:57:19 -0700 [gtk] Remove dead code 2007-09-16 14:02:06 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) PC OS X 10.4 RESOLVED FIXED P2 Normal --- 0 sven webkit-unassigned richard oldest_to_newest 478 0 sven 2007-09-14 08:57:19 -0700 The GTK+ backend contains some dead code in the FontPlatformData, will provide a patch. 476 1 16293 sven 2007-09-14 09:01:52 -0700 Created attachment 16293 Proposed Patch v1 477 2 16294 sven 2007-09-14 09:06:51 -0700 Created attachment 16294 Proposed Patch v2 Removes the declaration of the function as well. 435 3 16294 aroben 2007-09-16 13:25:36 -0700 Comment on attachment 16294 Proposed Patch v2 + Reviewed by . Please leave the "NOBODY (OOPS!)" part of this line in patches you submit in the future. r=me 436 4 zecke 2007-09-16 14:02:06 -0700 Landed in r25590. 16293 2007-09-14 09:01:52 -0700 2007-09-14 09:06:51 -0700 Proposed Patch v1 fix-15215.patch text/plain 1979 sven ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWNmOWQ4Mi4uODFhNWMwOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTE3LDYgKzE3LDE2IEBACiAKIDIwMDctMDktMTQgIFN2ZW4gSGVy emJlcmcgIDxzdmVuQGltZW5kaW8uY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IC4KKworICAg ICAgICBEb24ndCBtYWludGFpbiBvYnNvbGV0ZSBjb2RlLCBmaXhlczoKKyAgICAgICAgaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyMTUKKworICAgICAgICAqIHBsYXRm b3JtL2dkay9Gb250UGxhdGZvcm1EYXRhLmNwcDogcmVtb3ZlIHN0YXRpYworICAgICAgICBGb250 UGxhdGZvcm1EYXRhOjpsaXN0KCkgKGlzbid0IHVzZWQgYXQgYW55IHBsYWNlKQorCisyMDA3LTA5 LTE0ICBTdmVuIEhlcnpiZXJnICA8c3ZlbkBpbWVuZGlvLmNvbT4KKwogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIFJvYmVuLgogCiAgICAgICAgIERvbid0IHVzZSBmb250Y29uZmlnIHR5cGVzIGlm IG5lY2Vzc2FyeSwgZml4ZXM6CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dkay9Gb250 UGxhdGZvcm1EYXRhR2RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0Zm9ybURh dGFHZGsuY3BwCmluZGV4IGFkOGEyMjkuLjZmZjFlYzkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ2RrL0ZvbnRQbGF0Zm9ybURhdGFHZGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Z2RrL0ZvbnRQbGF0Zm9ybURhdGFHZGsuY3BwCkBAIC0xMzgsMzUgKzEzOCw2IEBAIGJvb2wgRm9u dFBsYXRmb3JtRGF0YTo6aXNGaXhlZFBpdGNoKCkKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLS8v IGxlbmd0aCBpcyBhIG91dCB2YWx1ZSBnaXZpbmcgdGhlIGxlbmd0aCBvZiB0aGUgbGlzdAotY2Fp cm9fZm9udF9mYWNlX3QqKiBGb250UGxhdGZvcm1EYXRhOjpsaXN0KEZvbnREZXNjcmlwdGlvbiYg Zm9udERlc2NyaXB0aW9uLCBjb25zdCBBdG9taWNTdHJpbmcmIGZhbWlseU5hbWUsIGludCogbGVu Z3RoKQotewotICAgIGluaXQoKTsKLQotICAgIEZjUGF0dGVybiogcGF0dGVybiA9IEZjUGF0dGVy bkNyZWF0ZSgpOwotICAgIGlmICghcGF0dGVybikKLSAgICAgICAgcmV0dXJuIE5VTEw7Ci0KLSAg ICBGY09iamVjdFNldCogb3MgPSBGY09iamVjdFNldENyZWF0ZSgpOwotICAgIEZjT2JqZWN0U2V0 QWRkKG9zLCBGQ19GQU1JTFkpOwotICAgIEZjT2JqZWN0U2V0QWRkKG9zLCBGQ19TVFlMRSk7Ci0g ICAgRmNGb250U2V0KiBmcyA9IEZjRm9udExpc3QoMCwgcGF0dGVybiwgb3MpOwotICAgIGlmIChs ZW5ndGgpCi0gICAgICAgICpsZW5ndGggPSBmcy0+bmZvbnQ7Ci0gICAgaWYgKHBhdHRlcm4pCi0g ICAgICAgIEZjUGF0dGVybkRlc3Ryb3kocGF0dGVybik7Ci0gICAgaWYgKG9zKQotICAgICAgICBG Y09iamVjdFNldERlc3Ryb3kgKG9zKTsKLSAgICBjYWlyb19mb250X2ZhY2VfdCoqIHJlc3VsdCA9 IHJlaW50ZXJwcmV0X2Nhc3Q8Y2Fpcm9fZm9udF9mYWNlX3QqKj4obWFsbG9jKChmcy0+bmZvbnQg KyAxKSAqIHNpemVvZihjYWlyb19mb250X2ZhY2VfdCopKSk7Ci0gICAgZm9yIChpbnQgaSA9IDA7 IGkgPCBmcy0+bmZvbnQ7IGkrKykgewotICAgICAgICBGY0NoYXI4KiBmb250ID0gRmNOYW1lVW5w YXJzZShmcy0+Zm9udHNbaV0pOwotICAgICAgICBwcmludGYoIiVzXG4iLCBmb250KTsKLSAgICAg ICAgcmVzdWx0W2ldID0gY2Fpcm9fZnRfZm9udF9mYWNlX2NyZWF0ZV9mb3JfcGF0dGVybihmcy0+ Zm9udHNbaV0pOwotICAgIH0KLSAgICByZXN1bHRbZnMtPm5mb250XSA9IE5VTEw7Ci0gICAgcmV0 dXJuIHJlc3VsdDsKLX0KLQogdm9pZCBGb250UGxhdGZvcm1EYXRhOjpzZXRGb250KGNhaXJvX3Qq IGNyKSBjb25zdAogewogICAgIEFTU0VSVChtX3NjYWxlZEZvbnQpOwo= 16294 2007-09-14 09:06:51 -0700 2007-09-16 13:25:36 -0700 Proposed Patch v2 fix-15215.patch text/plain 2417 sven ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWNmOWQ4Mi4uODFhNWMwOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTE3LDYgKzE3LDE2IEBACiAKIDIwMDctMDktMTQgIFN2ZW4gSGVy emJlcmcgIDxzdmVuQGltZW5kaW8uY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IC4KKworICAg ICAgICBEb24ndCBtYWludGFpbiBvYnNvbGV0ZSBjb2RlLCBmaXhlczoKKyAgICAgICAgaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyMTUKKworICAgICAgICAqIHBsYXRm b3JtL2dkay9Gb250UGxhdGZvcm1EYXRhLmNwcDogcmVtb3ZlIHN0YXRpYworICAgICAgICBGb250 UGxhdGZvcm1EYXRhOjpsaXN0KCkgKGlzbid0IHVzZWQgYXQgYW55IHBsYWNlKQorCisyMDA3LTA5 LTE0ICBTdmVuIEhlcnpiZXJnICA8c3ZlbkBpbWVuZGlvLmNvbT4KKwogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIFJvYmVuLgogCiAgICAgICAgIERvbid0IHVzZSBmb250Y29uZmlnIHR5cGVzIGlm IG5lY2Vzc2FyeSwgZml4ZXM6CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dkay9Gb250 UGxhdGZvcm1EYXRhLmggYi9XZWJDb3JlL3BsYXRmb3JtL2dkay9Gb250UGxhdGZvcm1EYXRhLmgK aW5kZXggNmVkOWNkYy4uMWRiM2JkZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9nZGsv Rm9udFBsYXRmb3JtRGF0YS5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0Zm9y bURhdGEuaApAQCAtNTMsOCArNTMsNiBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgYm9vbCBpbml0 KCk7CiAKLSAgICBzdGF0aWMgY2Fpcm9fZm9udF9mYWNlX3QqKiBsaXN0KEZvbnREZXNjcmlwdGlv biYsIGNvbnN0IEF0b21pY1N0cmluZyYgZmFtaWx5TmFtZSwgaW50KiBsZW5ndGgpOwotCiAgICAg Ym9vbCBpc0ZpeGVkUGl0Y2goKTsKIAogICAgIHZvaWQgc2V0Rm9udChjYWlyb190KikgY29uc3Q7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dkay9Gb250UGxhdGZvcm1EYXRhR2RrLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0Zm9ybURhdGFHZGsuY3BwCmluZGV4IGFk OGEyMjkuLjZmZjFlYzkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0 Zm9ybURhdGFHZGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0Zm9ybURh dGFHZGsuY3BwCkBAIC0xMzgsMzUgKzEzOCw2IEBAIGJvb2wgRm9udFBsYXRmb3JtRGF0YTo6aXNG aXhlZFBpdGNoKCkKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLS8vIGxlbmd0aCBpcyBhIG91dCB2 YWx1ZSBnaXZpbmcgdGhlIGxlbmd0aCBvZiB0aGUgbGlzdAotY2Fpcm9fZm9udF9mYWNlX3QqKiBG b250UGxhdGZvcm1EYXRhOjpsaXN0KEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uLCBj b25zdCBBdG9taWNTdHJpbmcmIGZhbWlseU5hbWUsIGludCogbGVuZ3RoKQotewotICAgIGluaXQo KTsKLQotICAgIEZjUGF0dGVybiogcGF0dGVybiA9IEZjUGF0dGVybkNyZWF0ZSgpOwotICAgIGlm ICghcGF0dGVybikKLSAgICAgICAgcmV0dXJuIE5VTEw7Ci0KLSAgICBGY09iamVjdFNldCogb3Mg PSBGY09iamVjdFNldENyZWF0ZSgpOwotICAgIEZjT2JqZWN0U2V0QWRkKG9zLCBGQ19GQU1JTFkp OwotICAgIEZjT2JqZWN0U2V0QWRkKG9zLCBGQ19TVFlMRSk7Ci0gICAgRmNGb250U2V0KiBmcyA9 IEZjRm9udExpc3QoMCwgcGF0dGVybiwgb3MpOwotICAgIGlmIChsZW5ndGgpCi0gICAgICAgICps ZW5ndGggPSBmcy0+bmZvbnQ7Ci0gICAgaWYgKHBhdHRlcm4pCi0gICAgICAgIEZjUGF0dGVybkRl c3Ryb3kocGF0dGVybik7Ci0gICAgaWYgKG9zKQotICAgICAgICBGY09iamVjdFNldERlc3Ryb3kg KG9zKTsKLSAgICBjYWlyb19mb250X2ZhY2VfdCoqIHJlc3VsdCA9IHJlaW50ZXJwcmV0X2Nhc3Q8 Y2Fpcm9fZm9udF9mYWNlX3QqKj4obWFsbG9jKChmcy0+bmZvbnQgKyAxKSAqIHNpemVvZihjYWly b19mb250X2ZhY2VfdCopKSk7Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBmcy0+bmZvbnQ7IGkr KykgewotICAgICAgICBGY0NoYXI4KiBmb250ID0gRmNOYW1lVW5wYXJzZShmcy0+Zm9udHNbaV0p OwotICAgICAgICBwcmludGYoIiVzXG4iLCBmb250KTsKLSAgICAgICAgcmVzdWx0W2ldID0gY2Fp cm9fZnRfZm9udF9mYWNlX2NyZWF0ZV9mb3JfcGF0dGVybihmcy0+Zm9udHNbaV0pOwotICAgIH0K LSAgICByZXN1bHRbZnMtPm5mb250XSA9IE5VTEw7Ci0gICAgcmV0dXJuIHJlc3VsdDsKLX0KLQog dm9pZCBGb250UGxhdGZvcm1EYXRhOjpzZXRGb250KGNhaXJvX3QqIGNyKSBjb25zdAogewogICAg IEFTU0VSVChtX3NjYWxlZEZvbnQpOwo=