152146 2015-12-10 11:50:47 -0800 Remove additional simulator checks before running layout-tests 2017-03-15 17:17:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=141718 https://bugs.webkit.org/show_bug.cgi?id=151243 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates glenn lforschler oldest_to_newest 1148264 0 aakash_jain 2015-12-10 11:50:47 -0800 Some of the checks like booting up and shutting down the simulator device are no longer required. Now we are creating a new simulator device and new copy of Simulator app in each run, as opposed to earlier setup in which we were reusing the old Simulator. These additional checks takes a lot of time (especially in multi-simulator environment) and doesn't add much values. We should remove these checks. 1148267 1 267117 aakash_jain 2015-12-10 11:59:01 -0800 Created attachment 267117 Proposed patch 1148276 2 267117 commit-queue 2015-12-10 12:45:17 -0800 Comment on attachment 267117 Proposed patch Clearing flags on attachment: 267117 Committed r193923: <http://trac.webkit.org/changeset/193923> 1148277 3 commit-queue 2015-12-10 12:45:21 -0800 All reviewed patches have been landed. Closing bug. 267117 2015-12-10 11:59:01 -0800 2015-12-10 12:45:17 -0800 Proposed patch patch_remove_sim_checks text/plain 3459 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MzkyMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE1LTEyLTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgYWRkaXRpb25hbCBzaW11bGF0b3IgY2hlY2tzIGJlZm9yZSBy dW5uaW5nIGxheW91dC10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyMTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5OgorICAgICAgICAoSU9T U2ltdWxhdG9yUG9ydC5jaGVja19zeXNfZGVwcyk6IFJlbW92ZWQgYWRkaXRpb25hbCBzaW11bGF0 b3JzIHZlcmlmaWNhdGlvbnMuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11 bGF0b3IucHk6CisgICAgICAgIChTaW11bGF0b3IuX2Jvb3RfYW5kX3NodXRkb3duX3NpbXVsYXRv cl9kZXZpY2UpOiBEZWxldGVkLgorICAgICAgICAoU2ltdWxhdG9yLmNoZWNrX3NpbXVsYXRvcl9k ZXZpY2VfYW5kX2VyYXNlX2lmX25lZWRlZCk6IERlbGV0ZWQuCisKIDIwMTUtMTItMDkgIEFha2Fz aCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJ1biBhdGxlYXN0IG9u ZSBzaW11bGF0b3IgZXZlbiBpZiBtYXggcHJvY2VzcyBsaW1pdCBpcyBsb3cKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L2lvcy5weQkocmV2aXNpb24gMTkzOTIxKQorKysgVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L2lvcy5weQkod29ya2luZyBjb3B5KQpAQCAtMjgyLDEzICsyODIsNiBA QCBjbGFzcyBJT1NTaW11bGF0b3JQb3J0KFBvcnQpOgogICAgICAgICBmb3IgaSBpbiB4cmFuZ2Uo c2VsZi5jaGlsZF9wcm9jZXNzZXMoKSk6CiAgICAgICAgICAgICAjIEZJWE1FOiBUaGlzIGNyZWF0 ZXMgdGhlIGRldmljZXMgc2VxdWVudGlhbGx5LCBkb2luZyB0aGlzIGluIHBhcmFsbGVsIGNhbiBp bXByb3ZlIHBlcmZvcm1hbmNlLgogICAgICAgICAgICAgdGVzdGluZ19kZXZpY2UgPSBzZWxmLnRl c3RpbmdfZGV2aWNlKGkpCi0gICAgICAgICAgICBfbG9nLmRlYnVnKCdWZXJpZnlpbmcgU2ltdWxh dG9yezB9IHdpdGggVURJRCB7MX0uJy5mb3JtYXQoaSwgdGVzdGluZ19kZXZpY2UudWRpZCkpCi0K LSAgICAgICAgICAgICMgRklYTUU6IFRoaXMgaXMgdmVyeSBzbG93LCBlc3BlY2lhbGx5IGZvciBt dWxpdHBsZSBzaW11bGF0b3JzLCB3ZSBwcm9iYWJseSBkbyBub3QgbmVlZAotICAgICAgICAgICAg IyB0aGlzIGNoZWNraW5nIGFzIHdlIGFyZSByZS1jcmVhdGluZyBuZXcgc2ltdWxhdG9yIGFwcHMg YW5kIGRldmljZXMgaW4gZXZlcnkgcnVuLgotICAgICAgICAgICAgaWYgbm90IFNpbXVsYXRvci5j aGVja19zaW11bGF0b3JfZGV2aWNlX2FuZF9lcmFzZV9pZl9uZWVkZWQoc2VsZi5ob3N0LCB0ZXN0 aW5nX2RldmljZS51ZGlkKToKLSAgICAgICAgICAgICAgICBfbG9nLmVycm9yKCdVbmFibGUgdG8g Ym9vdCB0aGUgc2ltdWxhdG9yIGRldmljZSB3aXRoIFVESUQgezB9LicuZm9ybWF0KHRlc3Rpbmdf ZGV2aWNlLnVkaWQpKQotICAgICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICByZXR1 cm4gc3VwZXIoSU9TU2ltdWxhdG9yUG9ydCwgc2VsZikuY2hlY2tfc3lzX2RlcHMobmVlZHNfaHR0 cCkKIAogICAgIGRlZiBjaGVja19mb3JfbGVha3Moc2VsZiwgcHJvY2Vzc19uYW1lLCBwcm9jZXNz X3BpZCk6CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQko cmV2aXNpb24gMTkzOTIxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0 b3IucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5OSwyNCArMjk5LDYgQEAgY2xhc3MgU2ltdWxhdG9y KG9iamVjdCk6CiAgICAgZGVmIGRldmljZV9kaXJlY3RvcnkodWRpZCk6CiAgICAgICAgIHJldHVy biBvcy5wYXRoLnJlYWxwYXRoKG9zLnBhdGguZXhwYW5kdXNlcihvcy5wYXRoLmpvaW4oJ34vTGli cmFyeS9EZXZlbG9wZXIvQ29yZVNpbXVsYXRvci9EZXZpY2VzJywgdWRpZCkpKQogCi0gICAgQHN0 YXRpY21ldGhvZAotICAgIGRlZiBfYm9vdF9hbmRfc2h1dGRvd25fc2ltdWxhdG9yX2RldmljZSho b3N0LCB1ZGlkKToKLSAgICAgICAgZXhpdF9jb2RlID0gaG9zdC5leGVjdXRpdmUucnVuX2NvbW1h bmQoWyd4Y3J1bicsICdzaW1jdGwnLCAnYm9vdCcsIHVkaWRdLCByZXR1cm5fZXhpdF9jb2RlPVRy dWUpCi0gICAgICAgIGlmIGV4aXRfY29kZToKLSAgICAgICAgICAgIHJldHVybiBleGl0X2NvZGUK LSAgICAgICAgZXhpdF9jb2RlID0gaG9zdC5leGVjdXRpdmUucnVuX2NvbW1hbmQoWyd4Y3J1bics ICdzaW1jdGwnLCAnc2h1dGRvd24nLCB1ZGlkXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKQotICAg ICAgICByZXR1cm4gZXhpdF9jb2RlCi0KLSAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIGNoZWNr X3NpbXVsYXRvcl9kZXZpY2VfYW5kX2VyYXNlX2lmX25lZWRlZChob3N0LCB1ZGlkKToKLSAgICAg ICAgZXhpdF9jb2RlID0gU2ltdWxhdG9yLl9ib290X2FuZF9zaHV0ZG93bl9zaW11bGF0b3JfZGV2 aWNlKGhvc3QsIHVkaWQpCi0gICAgICAgIGlmIG5vdCBleGl0X2NvZGU6Ci0gICAgICAgICAgICBy ZXR1cm4gVHJ1ZSAgIyBDYW4gYm9vdCBkZXZpY2UKLSAgICAgICAgIyBUcnkgZXJhc2luZyB0aGUg c2ltdWxhdG9yIGRldmljZSB0byByZXN0b3JlIGl0IHRvIGEga25vd24gZ29vZCBzdGF0ZS4KLSAg ICAgICAgaWYgbm90IGhvc3QuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsneGNydW4nLCAnc2ltY3Rs JywgJ2VyYXNlJywgdWRpZF0sIHJldHVybl9leGl0X2NvZGU9VHJ1ZSk6Ci0gICAgICAgICAgICBy ZXR1cm4gU2ltdWxhdG9yLl9ib290X2FuZF9zaHV0ZG93bl9zaW11bGF0b3JfZGV2aWNlKGhvc3Qs IHVkaWQpID09IDAgICMgQ2FuIGJvb3QgZGV2aWNlCi0gICAgICAgIHJldHVybiBGYWxzZSAgIyBD YW5ub3QgYm9vdCBvciBlcmFzZSBkZXZpY2UKLQogICAgIGRlZiBkZWxldGVfZGV2aWNlKHNlbGYs IHVkaWQpOgogICAgICAgICBEZXZpY2UuZGVsZXRlKHVkaWQpCiAK