15214 2007-09-14 08:44:52 -0700 SVG link with target="_top" opens new window 2007-09-25 13:15:36 -0700 1 1 1 Unclassified WebKit SVG 523.x (Safari 3) PC Windows XP RESOLVED FIXED http://www.codedread.com/test-safari-link.svg HasReduction P2 Normal --- 1 jeffschiller webkit-unassigned oldest_to_newest 482 0 jeffschiller 2007-09-14 08:44:52 -0700 Safari 3.0.3 Beta Clicking the link opens a new window (target="_top" should replace the top-most frame as Firefox, Opera and IE+ASV3 do. 481 1 16292 jeffschiller 2007-09-14 08:45:35 -0700 Created attachment 16292 Simple test case 377 2 ddkilzer 2007-09-18 08:10:37 -0700 Confirmed difference in behavior between Firefox 2.0.0.6 and Opera 9.22 versus a local debug build of WebKit r25545 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218). 3 3 eric 2007-09-25 07:22:23 -0700 As part of fixing this, I made sure we passed all the SVG WG test cases. This one is relevant to this code change, but the test seems wrong: http://www.w3.org/Graphics/SVG/Test/20061213/htmlEmbedHarness/full-linking-a-07-t.html specifically: The bottom-most (blue) arrows links to the same external SVG file, but with xlink:show="replace". Both the left and the right blue arrows should produce the image of the linkingToc-t.svg in a new frame. The left arrow should not open a new window, as xlink:replace behaves like target="_self" according to the xlink spec. http://www.w3.org/TR/xlink/#show-att 56986 4 eric 2007-09-25 07:23:51 -0700 One remaining question is "who wins?" when you have conflicting attributes, such as target="_self" and xlink:show="new". Currently I've coded things so that target always wins. 56987 5 16386 eric 2007-09-25 07:28:18 -0700 Created attachment 16386 a fix 56994 6 16386 rwlbuis 2007-09-25 07:58:03 -0700 Comment on attachment 16386 a fix r=me 57022 7 eric 2007-09-25 13:15:36 -0700 Landed on the feature branch as r25729. You should be able to verify once the build shows up at: http://nightly.webkit.org/builds/mac-feature-branch/1 16292 2007-09-14 08:45:35 -0700 2007-09-14 08:45:35 -0700 Simple test case test-safari-link.svg image/svg+xml 442 jeffschiller PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9Im5vIj8+DQo8 IURPQ1RZUEUgc3ZnIFBVQkxJQyAiLS8vVzNDLy9EVEQgU1ZHIDEuMS8vRU4iICJodHRwOi8vd3d3 LnczLm9yZy9HcmFwaGljcy9TVkcvMS4xL0RURC9zdmcxMS5kdGQiPg0KPHN2ZyB3aWR0aD0iMTAw JSIgaGVpZ2h0PSIxMDAlIiB2ZXJzaW9uPSIxLjEiIHZpZXdCb3g9IjAgMCA1MDAgODAiDQogICAg eG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiANCiAgICB4bWxuczp4bGluaz0iaHR0 cDovL3d3dy53My5vcmcvMTk5OS94bGluayINCiAgICA+DQo8YSB4bGluazpocmVmPSJodHRwOi8v d3d3LmNvZGVkcmVhZC5jb20vc3ZndGVzdC5zdmciIHRhcmdldD0iX3RvcCI+DQogICAgPHRleHQg eD0iMjAiIHk9IjU1Ij5DbGljayBNZTwvdGV4dD4NCjwvYT4NCjwvc3ZnPg== 16386 2007-09-25 07:28:18 -0700 2007-09-25 07:58:03 -0700 a fix link.patch text/plain 1369 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI1NzIz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDkt MjUgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFscmVhZHkgdGVzdGVkIGJ5IFNWRy9XM0MtU1ZH LTEuMS9saW5raW5nLWEtMDctdC5zdmcKKworICAgICAgICAqIGtzdmcyL3N2Zy9TVkdBRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdBRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl cik6IHByb3Blcmx5IHBhc3MgYWxvbmcgdGFyZ2V0IHZhbHVlcworCiAyMDA3LTA5LTIyICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChCdWlsZCBmaXgpLgpJbmRleDoga3N2ZzIvc3ZnL1NWR0FFbGVtZW50LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBrc3ZnMi9zdmcvU1ZHQUVsZW1lbnQuY3BwCShyZXZpc2lvbiAyNTcxNSkKKysrIGtzdmcy L3N2Zy9TVkdBRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNywxMCArMTI3LDggQEAg dm9pZCBTVkdBRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdgogICAgICAgICBTdHJpbmcg eGxpbmt0YXJnZXQgPSBnZXRBdHRyaWJ1dGUoWExpbmtOYW1lczo6c2hvd0F0dHIpOwogICAgICAg ICBpZiAoZSAmJiBlLT5idXR0b24oKSA9PSBNaWRkbGVCdXR0b24pCiAgICAgICAgICAgICB0YXJn ZXQgPSAiX2JsYW5rIjsKLSAgICAgICAgZWxzZSBpZiAoeGxpbmt0YXJnZXQgPT0gIm5ldyIgfHwg ISh0YXJnZXQuaXNFbXB0eSgpIHx8IHRhcmdldCA9PSAiX3NlbGYiKSkKLSAgICAgICAgICAgIHRh cmdldCA9ICJfYmxhbmsiOwotICAgICAgICBlbHNlIC8vIGRlZmF1bHQgaXMgcmVwbGFjZS9fc2Vs ZgotICAgICAgICAgICAgdGFyZ2V0ID0gIl9zZWxmIjsKKyAgICAgICAgZWxzZSBpZiAodGFyZ2V0 LmlzRW1wdHkoKSkgLy8gaWYgdGFyZ2V0IGlzIGVtcHR5LCBkZWZhdWx0IHRvICJfc2VsZiIgb3Ig dXNlIHhsaW5rOnRhcmdldCBpZiBzZXQKKyAgICAgICAgICAgIHRhcmdldCA9ICh4bGlua3Rhcmdl dCA9PSAibmV3IikgPyAiX2JsYW5rIiA6ICJfc2VsZiI7CiAKICAgICAgICAgU3RyaW5nIHVybCA9 IHBhcnNlVVJMKGhyZWYoKSk7CiAgICAgICAgIGlmICghZXZ0LT5kZWZhdWx0UHJldmVudGVkKCkp Cg==