152103 2015-12-09 19:32:50 -0800 REGRESSION: code-review-tests.html fails with error "Received an error at line 214" 2015-12-09 19:43:09 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates aestes ddkilzer joepeck lforschler oldest_to_newest 1148044 0 dbates 2015-12-09 19:32:50 -0800 The unit tests in the file code-review-tests.html fail due to a JavaScript TypeError. Steps to reproduce: 1. Open the page Websites/bugs.webkit.org/code-review-test.html, <http://trac.webkit.org/export/193888/trunk/Websites/bugs.webkit.org/code-review-test.html>. Then the following text can be seen on the page: "FAIL: Received an error at line 214" And in the console we see the following error: [Error] TypeError: undefined is not an object (evaluating '$('.overallComments textarea').val().trim') _json (code-review.js:213) save (code-review.js:253) saveDraftComments (code-review.js:333) acceptComment (code-review.js:1450) testSaveCommentsWithMissingLineIds (code-review-test.html:445) (anonymous function) (code-review-test.html:460) I am using Safari Version 9.0.2 (11601.3.9) on OS X 10.11.2 (15C49). 1148047 1 267065 dbates 2015-12-09 19:36:02 -0800 Created attachment 267065 Patch 1148053 2 dbates 2015-12-09 19:43:09 -0800 Committed r193889: <http://trac.webkit.org/changeset/193889> 267065 2015-12-09 19:36:02 -0800 2015-12-09 19:37:41 -0800 Patch bug-152103-20151209193531.patch text/plain 3870 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzODg1CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA0NWFmYWFkMzY5NjBjODdhMTllNjE0MTI3NTBiYzg4NDdiNTExYTZjLi42NzM2ZDJmMjdh ODI5ZjE2MmNkNTUxMDBkNTMzY2VlNzVjYTliNGM2IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdz LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxNS0xMi0wOSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRl c0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogQ29kZS1yZXZpZXcgdW5pdCB0ZXN0 IGZhaWwgd2l0aCBlcnJvciAiUmVjZWl2ZWQgYW4gZXJyb3IgYXQgbGluZSAyMTQiCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIxMDMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBhbiBpc3N1ZSB3 aGVyZSBvcGVuaW5nIHRoZSBmaWxlIGNvZGUtcmV2aWV3LXRlc3QuaHRtbCBpbiBTYWZhcmkgc2hv d3MgdGhlIGVycm9yIG1lc3NhZ2UKKyAgICAgICAgIkZBSUw6IFJlY2VpdmVkIGFuIGVycm9yIGF0 IGxpbmUgMjE0IiBhbmQgaW4gdGhlIGNvbnNvbGUgdGhlcmUgaXMgYSBKYXZhU2NyaXB0IFR5cGVF cnJvcjoKKyAgICAgICAgICAgIHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5n ICckKCcub3ZlcmFsbENvbW1lbnRzIHRleHRhcmVhJykudmFsKCkudHJpbScpCisKKyAgICAgICAg Tm90aWNlIHRoYXQgdGVzdCB0ZXN0UmVhZGREaXNjYXJkZWRDb21tZW50V2l0aFByZXZpb3VzQ29t bWVudCgpIGlzIHRoZSBvbmx5IHRlc3QgdGhhdCBhcHBlbmRzCisgICAgICAgIHRoZSB0b29sYmFy LCB3aGljaCBpbnNlcnRzIHRoZSBvdmVyYWxsIGNvbW1lbnRzIHRleHRhcmVhLiBUaGUgdGVzdCB0 ZXN0U2F2ZUNvbW1lbnRzV2l0aE1pc3NpbmdMaW5lSWRzKCkKKyAgICAgICAgYXNzdW1lcyB0aGF0 IHRoZSBvd24gcHJvcGVydGllcyBvZiB0aGUgd2luZG93IG9iamVjdCBhcmUgZW51bWVyYXRlZCBp biB0aGUgc2FtZSBvcmRlciBhcyB0aGV5CisgICAgICAgIHdlcmUgZGVmaW5lZCBpbiB0aGUgZmls ZSBjb2RlLXJldmlldy10ZXN0Lmh0bWwgc3VjaCB0aGF0IHRoZSB0ZXN0IHRlc3RSZWFkZERpc2Nh cmRlZENvbW1lbnRXaXRoUHJldmlvdXNDb21tZW50KCkKKyAgICAgICAgaXMgZXhlY3V0ZWQgYmVm b3JlIHRlc3QgdGVzdFNhdmVDb21tZW50c1dpdGhNaXNzaW5nTGluZUlkcygpLiBUaGUgYmVoYXZp b3Igb2YgSmF2YVNjcmlwdENvcmUgd2l0aAorICAgICAgICByZXNwZWN0IHRvIHRoZSBlbnVtZXJh dGlvbiBvcmRlciBvZiBwcm9wZXJ0aWVzIG9uIHRoZSB3aW5kb3cgb2JqZWN0IGhhdmUgY2hhbmdl ZCBzaW5jZSB0aGUKKyAgICAgICAgdGVzdCB0ZXN0U2F2ZUNvbW1lbnRzV2l0aE1pc3NpbmdMaW5l SWRzKCkgd2FzIHdyaXR0ZW4gc3VjaCB0aGF0IHRoZSBvcmRlciBvZiB0aGUgb3duIHByb3BlcnRp ZXMKKyAgICAgICAgb24gdGhlIHdpbmRvdyBvYmplY3QgZG8gbm90IHJlZmxlY3QgdGhlIG9yZGVy IGluIHdoaWNoIHRoZXkgd2VyZSBkZWZpbmVkIGluIHRoZSBmaWxlLiBXZSBzaG91bGQKKyAgICAg ICAgYXBwZW5kIHRoZSB0b29sYmFyIGJlZm9yZSBydW5uaW5nIHRoZSB0ZXN0cyBhbmQgZXhwbGlj aXRseSBleGVjdXRlIHRoZSB0ZXN0cyBpbiBjaG9zZW4gb3JkZXIgc28KKyAgICAgICAgYXMgdG8g YmUgYWJsZSB0byByZWFzb24gb2YgdGhlIHRlc3QgcmVzdWx0cyByZWdhcmRsZXNzIG9mIHRoZSBl bnVtZXJhdGlvbiBvcmRlcmluZyBvZiB0aGUKKyAgICAgICAgcHJvcGVydGllcyBpbiB0aGUgRE9N IHdpbmRvdyBvYmplY3QuCisKKyAgICAgICAgQWxzbywgcmVtb3ZlZCBkdXBsaWNhdGUgJ2QnIGlu IHRoZSBuYW1lIG9mIGZ1bmN0aW9uICJ0ZXN0UmVhZGREaXNjYXJkZWRDb21tZW50V2l0aFByZXZp b3VzQ29tbWVudCIKKyAgICAgICAgc3VjaCB0aGF0IGl0IHJlYWRzICJ0ZXN0UmVhZERpc2NhcmRl ZENvbW1lbnRXaXRoUHJldmlvdXNDb21tZW50Ii4KKworICAgICAgICAqIGNvZGUtcmV2aWV3LXRl c3QuaHRtbDoKKwogMjAxNS0xMS0xNyAgTHVjYXMgRm9yc2NobGVyICA8bGZvcnNjaGxlckBhcHBs ZS5jb20+CiAKICAgICAgICAgYnVncy53ZWJraXQub3JnIGlzIHJ1bm5pbmcgd2l0aCBjaGFuZ2Vz IHRoYXQgYXJlIG5vdCBjaGVja2VkIGluLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJr aXQub3JnL2NvZGUtcmV2aWV3LXRlc3QuaHRtbCBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9j b2RlLXJldmlldy10ZXN0Lmh0bWwKaW5kZXggZDI0NjliYTYwYTdkMTMyM2FiNjg1ZDU2YzViZjcw MzM3ZjM3NmE0NS4uYjU5ZmE0YzQzZDNmMzg5NTk4M2FhNDlmY2FiZWExZTU5YjY3M2UwMSAxMDA2 NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LXRlc3QuaHRtbAor KysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXctdGVzdC5odG1sCkBAIC0y MTgsNyArMjE4LDcgQEAgZnVuY3Rpb24gc3luY1NsaWRlVXAodHlwZSwgaGFuZGxlcikgewogICBo YW5kbGVyLmNhbGwodGhpcyk7CiB9CiAKLWZ1bmN0aW9uIHRlc3RSZWFkZERpc2NhcmRlZENvbW1l bnRXaXRoUHJldmlvdXNDb21tZW50KCkgeworZnVuY3Rpb24gdGVzdFJlYWREaXNjYXJkZWRDb21t ZW50V2l0aFByZXZpb3VzQ29tbWVudCgpIHsKICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Rp ZmYtY29udGVudCcpLmlubmVySFRNTCA9CiAgICAgICAnPGRpdiBjbGFzcz0iRmlsZURpZmYiPicg KwogICAgICAgICAnPGgxPjxhIGhyZWY9Imh0dHA6Ly90cmFjLndlYmtpdC5vcmcvYnJvd3Nlci90 cnVuay9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2ciPlNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZzwv YT48L2gxPicgKwpAQCAtMjQ3LDcgKzI0Nyw2IEBAIGZ1bmN0aW9uIHRlc3RSZWFkZERpc2NhcmRl ZENvbW1lbnRXaXRoUHJldmlvdXNDb21tZW50KCkgewogCiAgIGVyYXNlRHJhZnRDb21tZW50cygp OwogICBjcmF3bERpZmYoKTsKLSAgYXBwZW5kVG9vbGJhcigpOwogCiAgIHZhciBsaW5lID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xpbmUwJyk7CiAgIHZhciBhdXRob3IgPSAib2phbkBjaHJv bWl1bS5vcmciOwpAQCAtNDU2LDkgKzQ1NSwxNyBAQCBmdW5jdGlvbiB0ZXN0U2F2ZUNvbW1lbnRz V2l0aE1pc3NpbmdMaW5lSWRzKCkgewogfQogCiAKLWZvciAodmFyIHByb3BlcnR5IGluIHdpbmRv dykgewotICBpZiAocHJvcGVydHkuaW5kZXhPZigndGVzdCcpID09IDApIHsKLSAgICB3aW5kb3db cHJvcGVydHldKCk7Ci0gIH0KLX0KK3ZhciB0ZXN0c190b19ydW4gPSBbCisgICAgd2luZG93LnRl c3RUcmFjTGlua3MsCisgICAgd2luZG93LnRlc3REcmFmdENvbW1lbnRTYXZlciwKKyAgICB3aW5k b3cudGVzdFJlYWREaXNjYXJkZWRDb21tZW50V2l0aFByZXZpb3VzQ29tbWVudCwKKyAgICB3aW5k b3cudGVzdFNpZGVCeVNpZGVEaWZmV2l0aFByZXZpb3VzQ29tbWVudHNPblNoYXJlZExpbmUsCisg ICAgd2luZG93LnRlc3RTYW5pdGl6ZUZyYWdtZW50Rm9yQ29weSwKKyAgICB3aW5kb3cudGVzdElz Q2hhbmdlTG9nLAorICAgIHdpbmRvdy50ZXN0U2F2ZUNvbW1lbnRzV2l0aE1pc3NpbmdMaW5lSWRz LAorXTsKKworYXBwZW5kVG9vbGJhcigpOworZm9yICh2YXIgaSA9IDA7IGkgPCB0ZXN0c190b19y dW4ubGVuZ3RoOyArK2kpCisgICAgdGVzdHNfdG9fcnVuW2ldKCk7CiA8L3NjcmlwdD4K