15210 2007-09-13 17:39:14 -0700 Draw image outline for broken images 2007-10-14 05:09:21 -0700 1 1 1 Unclassified WebKit Images 523.x (Safari 3) All All RESOLVED FIXED HasReduction P2 Enhancement --- 1 pkasting webkit-unassigned oldest_to_newest 513 0 pkasting 2007-09-13 17:39:14 -0700 In Firefox, a broken image is displayed as a hollow outline the size of the image (when known), with a broken image icon in the upper left. In Safari, a broken image is displayed as an icon centered where the image would go, but with no border. The lack of a border can make it harder to figure out what images on a page, exactly, are broken, and with very large images means it's easy to miss the icon entirely. It would be nice to extend RenderImage.cpp to show a border in this case. 506 1 16286 pkasting 2007-09-13 18:11:40 -0700 Created attachment 16286 patch v1 Simple patch. Some archaeology in trac tells me that this code dates from almost the very beginning of WebCore, back when all the commits were huge "land all the changes in SNAZZY_WEBKIT_BRANCH_3" affairs. 505 2 16286 hyatt 2007-09-13 20:24:47 -0700 Comment on attachment 16286 patch v1 You need to adjust the usableWidth/Height to exclude the drawn outline, since the error image will potentially draw on top of the outline otherwise. We'll need to discuss this change I think, since it constitutes a UI change to Safari. It's definitely too late to make a change like this for Leopard, so it will have to wait for a bit. 502 3 hyatt 2007-09-13 20:26:19 -0700 alt text has the same bug (already). That should be fixed too. 500 4 pkasting 2007-09-13 22:44:58 -0700 Honestly it seems OK if the error image draws over the outline (as long as the two aren't crazily alpha-blended), but I'll take a look at making that change for both the broken image icon and the alt text in the next iteration of the patch. Waiting for the trunk to go to some post-Leopard-branch state is fine with me, but I'm not totally clear on what the schedule for such things is. Maybe there's already a wiki page explaining such things? 468 5 16295 pkasting 2007-09-14 13:44:04 -0700 Created attachment 16295 patch v2 This subtracts off the outline pixels when calculating the usable dimensions. It might be good to go even further and subtract 4 in each direction instead of 2, to leave a 1 px buffer inside the outline. Another possible change to this patch is that, when there's an error, we could avoid drawing the outline if the error image would fit without it but not with it (since if you have to pick one or the other, the error image is probably better than the outline). Input welcome. 378 6 16311 ddkilzer 2007-09-18 07:50:29 -0700 Created attachment 16311 Test case (broken image) 57399 7 mjs 2007-09-29 19:34:13 -0700 I asked some of the more UI-oriented people on the Safari team what they think of this change. 57412 8 16295 mjs 2007-09-29 23:25:58 -0700 Comment on attachment 16295 patch v2 r=me for feature-branch (or after feature-branch is merged back). 58496 9 mrowe 2007-10-14 05:09:21 -0700 Landed in r26591. 16286 2007-09-13 18:11:40 -0700 2007-09-14 13:44:04 -0700 patch v1 patch text/plain 1658 pkasting SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTU1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDctMDktMTMgIFBldGVyIEthc3RpbmcgIDx6ZXJvZHB4QGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIxMAorICAgICAgICBEcmF3 IHRoZSBpbWFnZSBvdXRsaW5lIGV2ZW4gZm9yIGJyb2tlbiBpbWFnZXMuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW1hZ2U6 OnBhaW50KToKKwogMjAwNy0wOS0xMyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUnViYmVyc3RhbXBlZCBieSBHZW9mZiBhbmQgTWFjaWVqCkluZGV4OiBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVySW1hZ2UuY3BwCShyZXZpc2lvbiAyNTU1MykKKysrIFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckltYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIzLDEyICsyMjMsMTEgQEAg dm9pZCBSZW5kZXJJbWFnZTo6cGFpbnQoUGFpbnRJbmZvJiBwYWludAogICAgICAgICAgICAgcmV0 dXJuOwogCiAgICAgICAgIGlmIChjV2lkdGggPiAyICYmIGNIZWlnaHQgPiAyKSB7Ci0gICAgICAg ICAgICBpZiAoIWVycm9yT2NjdXJyZWQoKSkgewotICAgICAgICAgICAgICAgIGNvbnRleHQtPnNl dFN0cm9rZVN0eWxlKFNvbGlkU3Ryb2tlKTsKLSAgICAgICAgICAgICAgICBjb250ZXh0LT5zZXRT dHJva2VDb2xvcihDb2xvcjo6bGlnaHRHcmF5KTsKLSAgICAgICAgICAgICAgICBjb250ZXh0LT5z ZXRGaWxsQ29sb3IoQ29sb3I6OnRyYW5zcGFyZW50KTsKLSAgICAgICAgICAgICAgICBjb250ZXh0 LT5kcmF3UmVjdChJbnRSZWN0KHR4ICsgbGVmdEJvcmRlciArIGxlZnRQYWQsIHR5ICsgdG9wQm9y ZGVyICsgdG9wUGFkLCBjV2lkdGgsIGNIZWlnaHQpKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAg ICAgIC8vIERyYXcgYW4gb3V0bGluZSByZWN0IHdoZXJlIHRoZSBpbWFnZSBzaG91bGQgYmUuCisg ICAgICAgICAgICBjb250ZXh0LT5zZXRTdHJva2VTdHlsZShTb2xpZFN0cm9rZSk7CisgICAgICAg ICAgICBjb250ZXh0LT5zZXRTdHJva2VDb2xvcihDb2xvcjo6bGlnaHRHcmF5KTsKKyAgICAgICAg ICAgIGNvbnRleHQtPnNldEZpbGxDb2xvcihDb2xvcjo6dHJhbnNwYXJlbnQpOworICAgICAgICAg ICAgY29udGV4dC0+ZHJhd1JlY3QoSW50UmVjdCh0eCArIGxlZnRCb3JkZXIgKyBsZWZ0UGFkLCB0 eSArIHRvcEJvcmRlciArIHRvcFBhZCwgY1dpZHRoLCBjSGVpZ2h0KSk7CiAKICAgICAgICAgICAg IGJvb2wgZXJyb3JQaWN0dXJlRHJhd24gPSBmYWxzZTsKICAgICAgICAgICAgIGludCBpbWFnZVgg PSAwOwo= 16295 2007-09-14 13:44:04 -0700 2007-09-29 23:25:58 -0700 patch v2 patch text/plain 2228 pkasting SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTU1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDctMDktMTMgIFBldGVyIEthc3RpbmcgIDx6ZXJvZHB4QGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIxMAorICAgICAgICBEcmF3 IHRoZSBpbWFnZSBvdXRsaW5lIGV2ZW4gZm9yIGJyb2tlbiBpbWFnZXMuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW1hZ2U6 OnBhaW50KToKKwogMjAwNy0wOS0xMyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUnViYmVyc3RhbXBlZCBieSBHZW9mZiBhbmQgTWFjaWVqCkluZGV4OiBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVySW1hZ2UuY3BwCShyZXZpc2lvbiAyNTU1MykKKysrIFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckltYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIzLDE4ICsyMjMsMTkgQEAg dm9pZCBSZW5kZXJJbWFnZTo6cGFpbnQoUGFpbnRJbmZvJiBwYWludAogICAgICAgICAgICAgcmV0 dXJuOwogCiAgICAgICAgIGlmIChjV2lkdGggPiAyICYmIGNIZWlnaHQgPiAyKSB7Ci0gICAgICAg ICAgICBpZiAoIWVycm9yT2NjdXJyZWQoKSkgewotICAgICAgICAgICAgICAgIGNvbnRleHQtPnNl dFN0cm9rZVN0eWxlKFNvbGlkU3Ryb2tlKTsKLSAgICAgICAgICAgICAgICBjb250ZXh0LT5zZXRT dHJva2VDb2xvcihDb2xvcjo6bGlnaHRHcmF5KTsKLSAgICAgICAgICAgICAgICBjb250ZXh0LT5z ZXRGaWxsQ29sb3IoQ29sb3I6OnRyYW5zcGFyZW50KTsKLSAgICAgICAgICAgICAgICBjb250ZXh0 LT5kcmF3UmVjdChJbnRSZWN0KHR4ICsgbGVmdEJvcmRlciArIGxlZnRQYWQsIHR5ICsgdG9wQm9y ZGVyICsgdG9wUGFkLCBjV2lkdGgsIGNIZWlnaHQpKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAg ICAgIC8vIERyYXcgYW4gb3V0bGluZSByZWN0IHdoZXJlIHRoZSBpbWFnZSBzaG91bGQgYmUuCisg ICAgICAgICAgICBjb250ZXh0LT5zZXRTdHJva2VTdHlsZShTb2xpZFN0cm9rZSk7CisgICAgICAg ICAgICBjb250ZXh0LT5zZXRTdHJva2VDb2xvcihDb2xvcjo6bGlnaHRHcmF5KTsKKyAgICAgICAg ICAgIGNvbnRleHQtPnNldEZpbGxDb2xvcihDb2xvcjo6dHJhbnNwYXJlbnQpOworICAgICAgICAg ICAgY29udGV4dC0+ZHJhd1JlY3QoSW50UmVjdCh0eCArIGxlZnRCb3JkZXIgKyBsZWZ0UGFkLCB0 eSArIHRvcEJvcmRlciArIHRvcFBhZCwgY1dpZHRoLCBjSGVpZ2h0KSk7CiAKICAgICAgICAgICAg IGJvb2wgZXJyb3JQaWN0dXJlRHJhd24gPSBmYWxzZTsKICAgICAgICAgICAgIGludCBpbWFnZVgg PSAwOwogICAgICAgICAgICAgaW50IGltYWdlWSA9IDA7Ci0gICAgICAgICAgICBpbnQgdXNhYmxl V2lkdGggPSBjV2lkdGg7Ci0gICAgICAgICAgICBpbnQgdXNhYmxlSGVpZ2h0ID0gY0hlaWdodDsK KyAgICAgICAgICAgIC8vIFdoZW4gY2FsY3VsYXRpbmcgdGhlIHVzYWJsZSBkaW1lbnNpb25zLCBl eGNsdWRlIHRoZSBwaXhlbHMgb2YKKyAgICAgICAgICAgIC8vIHRoZSBvdWxpbmUgcmVjdCBzbyB0 aGUgZXJyb3IgaW1hZ2UvYWx0IHRleHQgZG9lc24ndCBkcmF3IG9uIGl0LgorICAgICAgICAgICAg aW50IHVzYWJsZVdpZHRoID0gY1dpZHRoIC0gMjsKKyAgICAgICAgICAgIGludCB1c2FibGVIZWln aHQgPSBjSGVpZ2h0IC0gMjsKIAogICAgICAgICAgICAgaWYgKGVycm9yT2NjdXJyZWQoKSAmJiAh aW1hZ2UoKS0+aXNOdWxsKCkgJiYgKHVzYWJsZVdpZHRoID49IGltYWdlKCktPndpZHRoKCkpICYm ICh1c2FibGVIZWlnaHQgPj0gaW1hZ2UoKS0+aGVpZ2h0KCkpKSB7CiAgICAgICAgICAgICAgICAg Ly8gQ2VudGVyIHRoZSBlcnJvciBpbWFnZSwgYWNjb3VudGluZyBmb3IgYm9yZGVyIGFuZCBwYWRk aW5nLgo= 16311 2007-09-18 07:50:29 -0700 2007-09-18 07:50:29 -0700 Test case (broken image) bug-15210-test.html text/html 45 ddkilzer PGltZyBzcmM9ImZvby5naWYiIHdpZHRoPSI1MDAiIGhlaWdodD0iNTAwIj4K