152090 2015-12-09 12:43:10 -0800 <video>/<audio> should make use of the parsed media attribute on sources 2016-01-05 00:53:18 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt eric.carlson hyatt jer.noble mcatanzaro ossy oldest_to_newest 1147909 0 hyatt 2015-12-09 12:43:10 -0800 <video>/<audio> should make use of the parsed media attribute on sources now that we have cached it in a parsed form for <picture> support. See https://bugs.webkit.org/show_bug.cgi?id=152013 1148271 1 267118 hyatt 2015-12-10 12:09:29 -0800 Created attachment 267118 Patch 1148273 2 267118 darin 2015-12-10 12:13:02 -0800 Comment on attachment 267118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267118&action=review > Source/WebCore/html/HTMLMediaElement.cpp:4150 > + RefPtr<MediaQuerySet> media = source->mediaQuerySet(); Does this need to go into a local variable at all? Can’t we just use this below directly? > Source/WebCore/html/HTMLSourceElement.cpp:34 > +#if ENABLE(VIDEO) > #include "HTMLMediaElement.h" > +#endif If we are making this conditional we should put it in a separate paragraph below. Does the include itself need to be conditional? 1152476 3 hyatt 2016-01-04 13:18:58 -0800 Fix landed in r194549. 1152679 4 ossy 2016-01-05 00:53:18 -0800 (In reply to comment #3) > Fix landed in r194549. The commit log was repeated 47 times. :( Dave, could you check your script? 267118 2015-12-10 12:09:29 -0800 2015-12-10 12:13:02 -0800 Patch patch.txt text/plain 3349 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MzkyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTEyLTEwICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBWaWRlby9hdWRpby1yZWxhdGVkIGNs ZWFudXAgYWZ0ZXIgY2hhbmdlcyB0byB0aGUgc291cmNlIGVsZW1lbnQgZm9yIHBpY3R1cmUgc3Vw cG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 MjA5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICAq IGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFF bGVtZW50OjpzZWxlY3ROZXh0U291cmNlQ2hpbGQpOgorICAgICAgICBVc2UgdGhlIHBhcnNlZCBN ZWRpYVF1ZXJ5TGlzdCBmb3IgdmlkZW8vYXVkaW8sIHNpbmNlIHdlIG5vdyBjYWNoZSB0aGF0IG9u IHRoZSBzb3VyY2UgZWxlbWVudHMgZm9yIHBpY3R1cmUuCisKKyAgICAgICAgKiBodG1sL0hUTUxT b3VyY2VFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTb3VyY2VFbGVtZW50Ojpp bnNlcnRlZEludG8pOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFNvdXJjZUVsZW1lbnQ6OnJlbW92 ZWRGcm9tKToKKyAgICAgICAgQWRkIGd1YXJkcyB0byBmaXggdGhlIGJ1aWxkIHdoZW4gdmlkZW8g aXMgbm90IGVuYWJsZWQuCisKIDIwMTUtMTItMTAgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1 ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxOTM1MDAu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9u IDE5Mzg1OCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQxNDcsNyArNDE0Nyw3IEBAIFVSTCBIVE1MTWVkaWFFbGVtZW50Ojpz ZWxlY3ROZXh0U291cmNlQ2gKICAgICAgICAgCiAgICAgICAgIGlmIChzb3VyY2UtPmZhc3RIYXNB dHRyaWJ1dGUobWVkaWFBdHRyKSkgewogICAgICAgICAgICAgTWVkaWFRdWVyeUV2YWx1YXRvciBz Y3JlZW5FdmFsKCJzY3JlZW4iLCBkb2N1bWVudCgpLmZyYW1lKCksIHJlbmRlcmVyKCkgPyAmcmVu ZGVyZXIoKS0+c3R5bGUoKSA6IG51bGxwdHIpOwotICAgICAgICAgICAgUmVmUHRyPE1lZGlhUXVl cnlTZXQ+IG1lZGlhID0gTWVkaWFRdWVyeVNldDo6Y3JlYXRlQWxsb3dpbmdEZXNjcmlwdGlvblN5 bnRheChzb3VyY2UtPm1lZGlhKCkpOworICAgICAgICAgICAgUmVmUHRyPE1lZGlhUXVlcnlTZXQ+ IG1lZGlhID0gc291cmNlLT5tZWRpYVF1ZXJ5U2V0KCk7CiAjaWYgIUxPR19ESVNBQkxFRAogICAg ICAgICAgICAgaWYgKHNob3VsZExvZykKICAgICAgICAgICAgICAgICBMT0coTWVkaWEsICJIVE1M TWVkaWFFbGVtZW50OjpzZWxlY3ROZXh0U291cmNlQ2hpbGQoJXApIC0gJ21lZGlhJyBpcyAlcyIs IHRoaXMsIHNvdXJjZS0+bWVkaWEoKS51dGY4KCkuZGF0YSgpKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFNvdXJjZUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFNvdXJjZUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxOTM4NTkpCisrKyBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxTb3VyY2VFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjksNyArMjksOSBAQAogI2luY2x1ZGUgIkV2ZW50LmgiCiAjaW5jbHVkZSAiRXZlbnROYW1lcy5o IgogI2luY2x1ZGUgIkhUTUxEb2N1bWVudC5oIgorI2lmIEVOQUJMRShWSURFTykKICNpbmNsdWRl ICJIVE1MTWVkaWFFbGVtZW50LmgiCisjZW5kaWYKICNpbmNsdWRlICJIVE1MTmFtZXMuaCIKICNp bmNsdWRlICJIVE1MUGljdHVyZUVsZW1lbnQuaCIKICNpbmNsdWRlICJMb2dnaW5nLmgiCkBAIC01 OSw5ICs2MSwxMiBAQCBOb2RlOjpJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IEhUTUxTCiAg ICAgSFRNTEVsZW1lbnQ6Omluc2VydGVkSW50byhpbnNlcnRpb25Qb2ludCk7CiAgICAgRWxlbWVu dCogcGFyZW50ID0gcGFyZW50RWxlbWVudCgpOwogICAgIGlmIChwYXJlbnQpIHsKKyNpZiBFTkFC TEUoVklERU8pCiAgICAgICAgIGlmIChpczxIVE1MTWVkaWFFbGVtZW50PigqcGFyZW50KSkKICAg ICAgICAgICAgIGRvd25jYXN0PEhUTUxNZWRpYUVsZW1lbnQ+KCpwYXJlbnQpLnNvdXJjZVdhc0Fk ZGVkKHRoaXMpOwotICAgICAgICBlbHNlIGlmIChpczxIVE1MUGljdHVyZUVsZW1lbnQ+KCpwYXJl bnQpKQorICAgICAgICBlbHNlCisjZW5kaWYKKyAgICAgICAgaWYgKGlzPEhUTUxQaWN0dXJlRWxl bWVudD4oKnBhcmVudCkpCiAgICAgICAgICAgICBkb3duY2FzdDxIVE1MUGljdHVyZUVsZW1lbnQ+ KCpwYXJlbnQpLnNvdXJjZXNDaGFuZ2VkKCk7CiAgICAgfQogICAgIHJldHVybiBJbnNlcnRpb25E b25lOwpAQCAtNzMsOSArNzgsMTIgQEAgdm9pZCBIVE1MU291cmNlRWxlbWVudDo6cmVtb3ZlZEZy b20oQ29udAogICAgIGlmICghcGFyZW50ICYmIGlzPEVsZW1lbnQ+KHJlbW92YWxSb290KSkKICAg ICAgICAgcGFyZW50ID0gJmRvd25jYXN0PEVsZW1lbnQ+KHJlbW92YWxSb290KTsKICAgICBpZiAo cGFyZW50KSB7CisjaWYgRU5BQkxFKFZJREVPKQogICAgICAgICBpZiAoaXM8SFRNTE1lZGlhRWxl bWVudD4oKnBhcmVudCkpCiAgICAgICAgICAgICBkb3duY2FzdDxIVE1MTWVkaWFFbGVtZW50Pigq cGFyZW50KS5zb3VyY2VXYXNSZW1vdmVkKHRoaXMpOwotICAgICAgICBlbHNlIGlmIChpczxIVE1M UGljdHVyZUVsZW1lbnQ+KCpwYXJlbnQpKQorICAgICAgICBlbHNlCisjZW5kaWYKKyAgICAgICAg aWYgKGlzPEhUTUxQaWN0dXJlRWxlbWVudD4oKnBhcmVudCkpCiAgICAgICAgICAgICBkb3duY2Fz dDxIVE1MUGljdHVyZUVsZW1lbnQ+KCpwYXJlbnQpLnNvdXJjZXNDaGFuZ2VkKCk7CiAgICAgfQog ICAgIEhUTUxFbGVtZW50OjpyZW1vdmVkRnJvbShyZW1vdmFsUm9vdCk7Cg==