152078 2015-12-09 10:42:09 -0800 Modern IDB: storage/indexeddb/createIndex-after-failure.html fails 2015-12-09 14:22:50 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 150882 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1147843 0 beidson 2015-12-09 10:42:09 -0800 Modern IDB: storage/indexeddb/createIndex-after-failure.html fails The test was actually bogus - Our behavior of aborting the transaction once a createIndex fails due to constraint errors was actually correct. However, there will be some source changes to get the right error installed. 1147920 1 beidson 2015-12-09 13:09:47 -0800 (In reply to comment #0) > Modern IDB: storage/indexeddb/createIndex-after-failure.html fails > > The test was actually bogus - Our behavior of aborting the transaction once > a createIndex fails due to constraint errors was actually correct. > > However, there will be some source changes to get the right error installed. Never mind, the error is right - I was misreading the test + results. LayoutTests-only patch on its way. 1147928 2 267039 beidson 2015-12-09 13:24:17 -0800 Created attachment 267039 Patch v1 1147950 3 267039 commit-queue 2015-12-09 14:22:47 -0800 Comment on attachment 267039 Patch v1 Clearing flags on attachment: 267039 Committed r193865: <http://trac.webkit.org/changeset/193865> 1147951 4 commit-queue 2015-12-09 14:22:50 -0800 All reviewed patches have been landed. Closing bug. 267039 2015-12-09 13:24:17 -0800 2015-12-09 14:22:47 -0800 Patch v1 patch text/plain 5038 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMjk3YzZlLi43OTgxMzJjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMTIt MDkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVybiBJ REI6IHN0b3JhZ2UvaW5kZXhlZGRiL2NyZWF0ZUluZGV4LWFmdGVyLWZhaWx1cmUuaHRtbCBmYWls cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjA3 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhl ZGRiL2NyZWF0ZUluZGV4LWFmdGVyLWZhaWx1cmUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHN0 b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9jcmVhdGVJbmRleC1hZnRlci1mYWlsdXJlLmpzOgor CiAyMDE1LTEyLTA5ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAogICAg ICAgICBBWDogW0dUS10gUmVtb3ZlIGR1cGxpY2F0ZS9wbGF0Zm9ybSBtZWRpYS1lbWl0cy1vYmpl Y3QtcmVwbGFjZW1lbnQuaHRtbCBhbmQgbW92ZSBleHBlY3RhdGlvbnMgd2hlcmUgdGhleSBiZWxv bmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRl eCAzMWRmYTA3Li43MTYwODljIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMt d2sxL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9U ZXN0RXhwZWN0YXRpb25zCkBAIC05Miw3ICs5Miw2IEBAIHN0b3JhZ2UvaW5kZXhlZGRiL3RyYW5z YWN0aW9uLXN0YXJ2YXRpb24uaHRtbCBbIFNraXAgXQogc3RvcmFnZS9pbmRleGVkZGIvdW5ibG9j a2VkLXZlcnNpb24tY2hhbmdlcy5odG1sIFsgU2tpcCBdCiAKICMgSURCIHRlc3RzIHdpdGggdGV4 dCBmYWlsdXJlcyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAKLXN0b3JhZ2UvaW5kZXhlZGRiL2NyZWF0ZUluZGV4LWFmdGVyLWZhaWx1 cmUuaHRtbCBbIEZhaWx1cmUgXQogc3RvcmFnZS9pbmRleGVkZGIvY3Vyc29yLWNvbnRpbnVlLmh0 bWwgWyBGYWlsdXJlIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLWNsb3NlcGVuZGluZy1m bGFnLmh0bWwgWyBGYWlsdXJlIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLWRlbGV0ZXBl bmRpbmctZmxhZy5odG1sIFsgRmFpbHVyZSBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9y YWdlL2luZGV4ZWRkYi9jcmVhdGVJbmRleC1hZnRlci1mYWlsdXJlLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2NyZWF0ZUluZGV4LWFmdGVyLWZhaWx1cmUtZXhw ZWN0ZWQudHh0CmluZGV4IDFlYzU0NjEuLjM5NzgwOWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL2NyZWF0ZUluZGV4LWFmdGVyLWZhaWx1cmUtZXhwZWN0ZWQudHh0 CisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2NyZWF0ZUluZGV4LWFmdGVyLWZh aWx1cmUtZXhwZWN0ZWQudHh0CkBAIC0xLDQgKzEsNCBAQAotVGVzdCBJbmRleGVkREIncyBiYXNp Y3MuCitUZXN0IGNyZWF0ZUluZGV4IGZhaWxpbmcgZHVlIHRvIGEgQ29uc3RyYWludEVycm9yCiAK IE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIApAQCAtMTcsMTcgKzE3LDggQEAgUEFTUyBlbmFt ZSBpcyAnTm90Rm91bmRFcnJvcicKIEV4Y2VwdGlvbiBtZXNzYWdlOiBGYWlsZWQgdG8gZXhlY3V0 ZSAnZGVsZXRlSW5kZXgnIG9uICdJREJPYmplY3RTdG9yZSc6IFRoZSBzcGVjaWZpZWQgaW5kZXgg d2FzIG5vdCBmb3VuZC4KIE5vdyByZXF1ZXN0aW5nIG9iamVjdDIKIG5vdyB3ZSB3YWl0LgotZGVs ZXRlSW5kZXhBZnRlckdldCgpCi1FeHBlY3RpbmcgZXhjZXB0aW9uIGZyb20gb2JqZWN0U3RvcmUu ZGVsZXRlSW5kZXgoJ2luZGV4JykKLVBBU1MgRXhjZXB0aW9uIHdhcyB0aHJvd24uCi1QQVNTIGNv ZGUgaXMgRE9NRXhjZXB0aW9uLk5PVF9GT1VORF9FUlIKLVBBU1MgZW5hbWUgaXMgJ05vdEZvdW5k RXJyb3InCi1FeGNlcHRpb24gbWVzc2FnZTogRmFpbGVkIHRvIGV4ZWN1dGUgJ2RlbGV0ZUluZGV4 JyBvbiAnSURCT2JqZWN0U3RvcmUnOiBUaGUgc3BlY2lmaWVkIGluZGV4IHdhcyBub3QgZm91bmQu Ci1FeHBlY3RpbmcgZXhjZXB0aW9uIGZyb20gb2JqZWN0U3RvcmUuZGVsZXRlSW5kZXgoJ2luZGV4 JykKLVBBU1MgRXhjZXB0aW9uIHdhcyB0aHJvd24uCi1QQVNTIGNvZGUgaXMgRE9NRXhjZXB0aW9u Lk5PVF9GT1VORF9FUlIKLVBBU1MgZW5hbWUgaXMgJ05vdEZvdW5kRXJyb3InCi1FeGNlcHRpb24g bWVzc2FnZTogRmFpbGVkIHRvIGV4ZWN1dGUgJ2RlbGV0ZUluZGV4JyBvbiAnSURCT2JqZWN0U3Rv cmUnOiBUaGUgc3BlY2lmaWVkIGluZGV4IHdhcyBub3QgZm91bmQuCitFcnJvciBmdW5jdGlvbiBj YWxsZWQ6IChBYm9ydEVycm9yKSB1bmRlZmluZWQKK1BBU1MgQWJvcnQgZnVuY3Rpb24gY2FsbGVk OiAoQ29uc3RyYWludEVycm9yKSB1bmRlZmluZWQKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvcmVzb3VyY2VzL2NyZWF0ZUluZGV4LWFmdGVyLWZhaWx1cmUuanMgYi9MYXlvdXRU ZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvY3JlYXRlSW5kZXgtYWZ0ZXItZmFpbHVy ZS5qcwppbmRleCAyNzA0ZjE5Li4wY2RhMjJjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9y YWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvY3JlYXRlSW5kZXgtYWZ0ZXItZmFpbHVyZS5qcworKysg Yi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvY3JlYXRlSW5kZXgtYWZ0 ZXItZmFpbHVyZS5qcwpAQCAtMywxMiArMywxMyBAQCBpZiAodGhpcy5pbXBvcnRTY3JpcHRzKSB7 CiAgICAgaW1wb3J0U2NyaXB0cygnc2hhcmVkLmpzJyk7CiB9CiAKLWRlc2NyaXB0aW9uKCJUZXN0 IEluZGV4ZWREQidzIGJhc2ljcy4iKTsKK2Rlc2NyaXB0aW9uKCJUZXN0IGNyZWF0ZUluZGV4IGZh aWxpbmcgZHVlIHRvIGEgQ29uc3RyYWludEVycm9yIik7CiAKIGluZGV4ZWREQlRlc3QocHJlcGFy ZURhdGFiYXNlKTsKIGZ1bmN0aW9uIHByZXBhcmVEYXRhYmFzZShldmVudCkKIHsKICAgICB0cmFu cyA9IGV2ZW50LnRhcmdldC50cmFuc2FjdGlvbjsKKyAgICB0cmFucy5vbmFib3J0ID0gYWJvcnRD YWxsYmFjazsKICAgICBkYiA9IGV2ZW50LnRhcmdldC5yZXN1bHQ7CiAKICAgICBkYi5jcmVhdGVP YmplY3RTdG9yZSgib2JqZWN0U3RvcmUiKTsKQEAgLTI5LDE4ICszMCwyMCBAQCBmdW5jdGlvbiBj cmVhdGVJbmRleCgpIHsKICAgICAvLyBjb25mdXNlZCBhbmQgY3Jhc2gsIG9yIHRoaW5rIHRoZSBp bmRleCBzdGlsbCBleGlzdHMuCiAgICAgZXZhbEFuZEV4cGVjdEV4Y2VwdGlvbigib2JqZWN0U3Rv cmUuZGVsZXRlSW5kZXgoJ2luZGV4JykiLCAiRE9NRXhjZXB0aW9uLk5PVF9GT1VORF9FUlIiLCAi J05vdEZvdW5kRXJyb3InIik7CiAgICAgZGVidWcoIk5vdyByZXF1ZXN0aW5nIG9iamVjdDIiKTsK KyAgICAKKyAgICAvLyBOb25lIG9mIHRoZSBmb2xsb3dpbmcgMyBsaW5lcyB3aWxsIGFjdHVhbGx5 IGRvIGFueXRoaW5nIGJlY2F1c2UgdGhlIGNhbGwgdG8gY3JlYXRlSW5kZXggd2lsbCBmb3JjZWZ1 bGx5IGFib3J0IHRoZSB0cmFuc2FjdGlvbi4KICAgICB2YXIgcmVxMyA9IG9iamVjdFN0b3JlLmdl dCgib2JqZWN0MiIpOwotICAgIHJlcTMub25zdWNjZXNzID0gZGVsZXRlSW5kZXhBZnRlckdldDsK LSAgICByZXEzLm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKKyAgICByZXEzLm9u c3VjY2VzcyA9IHVuZXhwZWN0ZWRTdWNjZXNzQ2FsbGJhY2s7CisgICAgcmVxMy5vbmVycm9yID0g ZXJyb3JDYWxsYmFjazsKKyAgICAKICAgICBkZWJ1Zygibm93IHdlIHdhaXQuIik7CiB9CiAKLWZ1 bmN0aW9uIGRlbGV0ZUluZGV4QWZ0ZXJHZXQoKSB7Ci0gICAgLy8gc28gd2Ugd2lsbCBkZWxldGUg aXQgbmV4dCwgYnV0IGl0IHNob3VsZCBhbHJlYWR5IGJlIGdvbmUuLi4gcmlnaHQ/Ci0gICAgZGVi dWcoImRlbGV0ZUluZGV4QWZ0ZXJHZXQoKSIpOwotICAgIC8vIHRoZSBpbmRleCBzaG91bGQgc3Rp bGwgYmUgZ29uZSwgYW5kIHRoaXMgc2hvdWxkIG5vdCBjcmFzaC4KLSAgICBldmFsQW5kRXhwZWN0 RXhjZXB0aW9uKCJvYmplY3RTdG9yZS5kZWxldGVJbmRleCgnaW5kZXgnKSIsICJET01FeGNlcHRp b24uTk9UX0ZPVU5EX0VSUiIsICInTm90Rm91bmRFcnJvciciKTsKLSAgICBldmFsQW5kRXhwZWN0 RXhjZXB0aW9uKCJvYmplY3RTdG9yZS5kZWxldGVJbmRleCgnaW5kZXgnKSIsICJET01FeGNlcHRp b24uTk9UX0ZPVU5EX0VSUiIsICInTm90Rm91bmRFcnJvciciKTsKK2Z1bmN0aW9uIGVycm9yQ2Fs bGJhY2soKSB7CisgICAgZGVidWcoIkVycm9yIGZ1bmN0aW9uIGNhbGxlZDogKCIgKyBldmVudC50 YXJnZXQuZXJyb3IubmFtZSArICIpICIgKyBldmVudC50YXJnZXQuZXJyb3IubWVzc2FnZSk7Cit9 CiAKK2Z1bmN0aW9uIGFib3J0Q2FsbGJhY2soKSB7CisgICAgdGVzdFBhc3NlZCgiQWJvcnQgZnVu Y3Rpb24gY2FsbGVkOiAoIiArIGV2ZW50LnRhcmdldC5lcnJvci5uYW1lICsgIikgIiArIGV2ZW50 LnRhcmdldC5lcnJvci5tZXNzYWdlKTsKICAgICBmaW5pc2hKU1Rlc3QoKTsKLX0KXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCit9Cg==