152076 2015-12-09 10:29:30 -0800 Web Inspector: zoom with Ctrl +/- doesn't work correctly when inspector is docked 2015-12-09 16:20:42 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 149590 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev s.alkhalfa timothy webkit-bug-importer oldest_to_newest 1147837 0 bburg 2015-12-09 10:29:30 -0800 From a comment in bug 149590: If the Developer tools are docked at the bottom of my browser and I'm either zoomed-in or out and then I try to resize the Dev Tools vertically by pulling it up or down, it doesn't work at all. If I restore Dev Tools to their original resolution by typing Command-0, then yes I can resize the tools vertically without any issues. I've included a brief "steps to reproduce" list below: 1. Bring up the Developer Tools in Webkit. 2. Make sure that they are docked at the bottom of the browser window. 3. Either zoom in or out of the Developer tools. 4. Attempt to resize Developer Tools by dragging its top menu bar either upwards or downwards. Expected Results: The Developer Tools would resize vertically. Actual Result: Developer Tools do not resize, in fact opposite behaviour was observed whereby they shrinked vertically when the user attempted to lengthen them vertically. 1147839 1 webkit-bug-importer 2015-12-09 10:30:06 -0800 <rdar://problem/23823393> 1147875 2 267027 bburg 2015-12-09 11:28:23 -0800 Created attachment 267027 Proposed Fix 1147878 3 267027 joepeck 2015-12-09 11:31:58 -0800 Comment on attachment 267027 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=267027&action=review > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:145 > + if (self.ignoreNextViewFrameDidChangeNotification) { > + self.ignoreNextViewFrameDidChangeNotification = NO; > + return; > + } Matt recently removed something like this. Check with him to see if he has a counter-example for why this may not be correct. > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:727 > + [m_inspectorProxyObjCAdapter.get() setIgnoreNextViewFrameDidChangeNotification:YES]; I think the `.get()` is actually not needed here, due to magic. 1147894 4 267027 bburg 2015-12-09 12:08:43 -0800 Comment on attachment 267027 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=267027&action=review >> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:145 >> + } > > Matt recently removed something like this. Check with him to see if he has a counter-example for why this may not be correct. You are right. I'll revert it. https://bugs.webkit.org/show_bug.cgi?id=146994 1147898 5 267034 bburg 2015-12-09 12:14:21 -0800 Created attachment 267034 Proposed Fix (simpler) 1147933 6 267034 commit-queue 2015-12-09 13:35:13 -0800 Comment on attachment 267034 Proposed Fix (simpler) Clearing flags on attachment: 267034 Committed r193858: <http://trac.webkit.org/changeset/193858> 1147934 7 commit-queue 2015-12-09 13:35:16 -0800 All reviewed patches have been landed. Closing bug. 1147997 8 nvasilyev 2015-12-09 16:20:42 -0800 *** Bug 149946 has been marked as a duplicate of this bug. *** 267027 2015-12-09 11:28:23 -0800 2015-12-09 12:14:17 -0800 Proposed Fix bug-152076-20151209112752.patch text/plain 4910 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz YTY2NzgwM2Q3NzdkZGRhMmY1YmI4Mzg2ZDJkYjk0MWU1ODMzZDI2Li4xNTI3ODhmNjYxMzM0NmY2 ZTk0NjJhNzAxNTEwZTZlOWNjNmMyMmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0xMi0wOSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiB6b29tIHdpdGggQ3RybCArLy0gZG9lc24ndCB3b3JrIGNv cnJlY3RseSB3aGVuIGluc3BlY3RvciBpcyBkb2NrZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY29tcHV0aW5nIHRoZSBuZXcgd2lkdGggb3Ig aGVpZ2h0IG9mIHRoZSBpbnNwZWN0b3IsIHRha2UgdGhlIHpvb20gbGV2ZWwgaW50bworICAgICAg ICBhY2NvdW50LiB3aW5kb3cuaW5uZXJ7V2lkdGgsSGVpZ2h0fSBhcmUgaW4gZG9jdW1lbnQgcGl4 ZWxzLCBidXQgd2UgbmVlZCB0byBzcGVjaWZ5CisgICAgICAgIGRldmljZSBwaXhlbHMgdG8gSW5z cGVjdG9yRnJvbnRlbmRIb3N0LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4u anM6CisKIDIwMTUtMTItMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXb3JrYXJvdW5kIGFycm93IGZ1bmN0aW9uIGlzc3Vl IGluIFRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDA4MzM0OWZiOTZmZjEw MTEyNDU1YmY1NGVkNTE1ZDVhZTE1ZTFiYmEuLmIxZWY4ZTc1NjVmMjMyYmNhMzcwMDI5NTVmMDBh MDI2ZjZkZmEyMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNS0xMi0wOSAgQnJp YW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB6b29t IHdpdGggQ3RybCArLy0gZG9lc24ndCB3b3JrIGNvcnJlY3RseSB3aGVuIGluc3BlY3RvciBpcyBk b2NrZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 MjA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo aWxlIGRlYnVnZ2luZyB0aGlzIGlzc3VlLCBJIG5vdGljZWQgd2UgYXJlIGhhbmRsaW5nIG1vcmUg bm90aWZpY2F0aW9ucyB0aGFuCisgICAgICAgIHdlIG5lZWQgdG8uIElmIG91ciBvd24gY2FsbCB0 byBzZXRGcmFtZSBjYXVzZWQgTlNWaWV3RnJhbWVEaWRDaGFuZ2UgdG8gYmUgZGlzcGF0Y2hlZCwK KyAgICAgICAgdGhlbiBpZ25vcmUgdGhlIGNhbGwgYW5kIGRvbid0IGJvdGhlciByZWNvbXB1dGlu ZyBmcmFtZSBzaXplczsgd2Ugd291bGQgYmFpbCBhbnl3YXkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoLVtXS1dlYkluc3BlY3Rv clByb3h5T2JqQ0FkYXB0ZXIgaW5zcGVjdGVkVmlld0ZyYW1lRGlkQ2hhbmdlOl0pOgorICAgICAg ICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6aW5zcGVjdGVkVmlld0ZyYW1lRGlkQ2hhbmdl KToKKwogMjAxNS0xMi0wOSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAbmF2ZXJjb3JwLmNvbT4K IAogICAgICAgICBbQ29vcmRpbmF0ZWRHcmFwaGljc10gUmVtb3ZlIHVubmVjZXNzYXJ5IGd1YXJk cyBpbiBDb29yZGluYXRlZERyYXdpbmdBcmVhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggZGE5YTEzMWJmNjJkNjNjMWU2NWQzNTBh YjgwZWI0NDUyZDU1M2EzNC4uZjhiODFiOWIyZWY3MDdhYjdjY2I5NzdiZDdiZGU3NmE4YzBhZTcy YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9N YWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qcwpAQCAtMTU4Niw3ICsxNTg2LDEwIEBAIFdlYkluc3BlY3Rvci5fZG9ja2VkUmVzaXplck1v dXNlRG93biA9IGZ1bmN0aW9uKGV2ZW50KQogICAgICAgICBpZiAoZGVsdGEgPCAwICYmIGNsaWVu dFBvc2l0aW9uID4gZmlyc3RDbGllbnRQb3NpdGlvbikKICAgICAgICAgICAgIHJldHVybjsKIAot ICAgICAgICB2YXIgZGltZW5zaW9uID0gTWF0aC5tYXgoMCwgd2luZG93W3dpbmRvd1Byb3BlcnR5 XSAtIGRlbHRhKTsKKyAgICAgICAgbGV0IGRpbWVuc2lvbiA9IE1hdGgubWF4KDAsIHdpbmRvd1t3 aW5kb3dQcm9wZXJ0eV0gLSBkZWx0YSk7CisgICAgICAgIC8vIElmIHpvb21lZCBpbi9vdXQsIHRo ZXJlIGJlIGdyZWF0ZXIvZmV3ZXIgZG9jdW1lbnQgcGl4ZWxzIHNob3duLCBidXQgdGhlIGluc3Bl Y3RvcidzCisgICAgICAgIC8vIHdpZHRoIG9yIGhlaWdodCBzaG91bGQgYmUgdGhlIHNhbWUgaW4g ZGV2aWNlIHBpeGVscyByZWdhcmRsZXNzIG9mIHRoZSBkb2N1bWVudCB6b29tLgorICAgICAgICBk aW1lbnNpb24gKj0gSW5zcGVjdG9yRnJvbnRlbmRIb3N0Lnpvb21GYWN0b3IoKTsKIAogICAgICAg ICBpZiAodGhpcy5fZG9ja1NpZGUgPT09ICJib3R0b20iKQogICAgICAgICAgICAgSW5zcGVjdG9y RnJvbnRlbmRIb3N0LnNldEF0dGFjaGVkV2luZG93SGVpZ2h0KGRpbWVuc2lvbik7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1t IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQpp bmRleCA4ZjQwNmI0OTEwNDcxZDU5ZTRjNDg2MjRiMzgyNzIwNjJlZWZlMzA5Li4zZTU1ZTM1MjI4 MjI1ZjJhZDNiYjIyNzIzZmNhMGM1ZWMwMjI2NDYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KQEAgLTc1LDYgKzc1LDgg QEAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHdlYlZpZXdDbG9zZVRpbWVvdXQgPSA2MDsKIAogQGlu dGVyZmFjZSBXS1dlYkluc3BlY3RvclByb3h5T2JqQ0FkYXB0ZXIgKCkKIAorQHByb3BlcnR5IChu b25hdG9taWMsIGFzc2lnbikgQk9PTCBpZ25vcmVOZXh0Vmlld0ZyYW1lRGlkQ2hhbmdlTm90aWZp Y2F0aW9uOworCiAtIChpZClpbml0V2l0aFdlYkluc3BlY3RvclByb3h5OihXZWJJbnNwZWN0b3JQ cm94eSopaW5zcGVjdG9yUHJveHk7CiAtICh2b2lkKWNsb3NlOwogLSAodm9pZClkaWRSZWxhdW5j aFByb2Nlc3M7CkBAIC0xMzcsNiArMTM5LDExIEBAIC0gKHZvaWQpd2luZG93RGlkRXhpdEZ1bGxT Y3JlZW46KE5TTm90aWZpY2F0aW9uICopbm90aWZpY2F0aW9uCiAKIC0gKHZvaWQpaW5zcGVjdGVk Vmlld0ZyYW1lRGlkQ2hhbmdlOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlvbgogeworICAg IGlmIChzZWxmLmlnbm9yZU5leHRWaWV3RnJhbWVEaWRDaGFuZ2VOb3RpZmljYXRpb24pIHsKKyAg ICAgICAgc2VsZi5pZ25vcmVOZXh0Vmlld0ZyYW1lRGlkQ2hhbmdlTm90aWZpY2F0aW9uID0gTk87 CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICAvLyBSZXNpemluZyB0aGUgdmlld3Mgd2hp bGUgaW5zaWRlIHRoaXMgbm90aWZpY2F0aW9uIGNhbiBsZWFkIHRvIGJhZCByZXN1bHRzIHdoZW4g ZW50ZXJpbmcKICAgICAvLyBvciBleGl0aW5nIGZ1bGwgc2NyZWVuLiBUbyBhdm9pZCB0aGF0IHdl IG5lZWQgdG8gcGVyZm9ybSB0aGUgd29yayBhZnRlciBhIGRlbGF5LiBXZSBvbmx5CiAgICAgLy8g ZGVwZW5kIG9uIHRoaXMgZm9yIGVuZm9yY2luZyB0aGUgaGVpZ2h0IGNvbnN0cmFpbnRzLCBzbyBh IHNtYWxsIGRlbGF5IGlzbid0IHRlcnJpYmxlLiBNb3N0CkBAIC03MTUsNiArNzIyLDEwIEBAIHZv aWQgV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RlZFZpZXdGcmFtZURpZENoYW5nZShDR0Zsb2F0 IGN1cnJlbnREaW1lbnNpb24pCiAgICAgaWYgKE5TRXF1YWxSZWN0cyhbbV9pbnNwZWN0b3JWaWV3 IGZyYW1lXSwgaW5zcGVjdG9yRnJhbWUpICYmIE5TRXF1YWxSZWN0cyhbaW5zcGVjdGVkVmlldyBm cmFtZV0sIGluc3BlY3RlZFZpZXdGcmFtZSkpCiAgICAgICAgIHJldHVybjsKIAorICAgIC8vIENh bGxpbmcgc2V0RnJhbWUgd2lsbCBjYXVzZSBOU1ZpZXdGcmFtZURpZENoYW5nZSB0byBiZSBkaXNw YXRjaGVkLCBidXQgd2UgZG9uJ3QKKyAgICAvLyBuZWVkIHRvIGRvIGFueXRoaW5nIHNpbmNlIHdl IGluaXRpYXRlZCBpdC4gU28sIGlnbm9yZSB0aGUgbmV4dCBub3RpZmljYXRpb24uCisgICAgW21f aW5zcGVjdG9yUHJveHlPYmpDQWRhcHRlci5nZXQoKSBzZXRJZ25vcmVOZXh0Vmlld0ZyYW1lRGlk Q2hhbmdlTm90aWZpY2F0aW9uOllFU107CisKICAgICAvLyBEaXNhYmxlIHNjcmVlbiB1cGRhdGVz IHRvIG1ha2Ugc3VyZSB0aGUgbGF5ZXJzIGZvciBib3RoIHZpZXdzIHJlc2l6ZSBpbiBzeW5jLgog ICAgIFtbbV9pbnNwZWN0b3JWaWV3IHdpbmRvd10gZGlzYWJsZVNjcmVlblVwZGF0ZXNVbnRpbEZs dXNoXTsKIAo= 267034 2015-12-09 12:14:21 -0800 2015-12-09 13:35:13 -0800 Proposed Fix (simpler) bug-152076-20151209121350.patch text/plain 1931 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz YTY2NzgwM2Q3NzdkZGRhMmY1YmI4Mzg2ZDJkYjk0MWU1ODMzZDI2Li4xNTI3ODhmNjYxMzM0NmY2 ZTk0NjJhNzAxNTEwZTZlOWNjNmMyMmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0xMi0wOSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiB6b29tIHdpdGggQ3RybCArLy0gZG9lc24ndCB3b3JrIGNv cnJlY3RseSB3aGVuIGluc3BlY3RvciBpcyBkb2NrZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY29tcHV0aW5nIHRoZSBuZXcgd2lkdGggb3Ig aGVpZ2h0IG9mIHRoZSBpbnNwZWN0b3IsIHRha2UgdGhlIHpvb20gbGV2ZWwgaW50bworICAgICAg ICBhY2NvdW50LiB3aW5kb3cuaW5uZXJ7V2lkdGgsSGVpZ2h0fSBhcmUgaW4gZG9jdW1lbnQgcGl4 ZWxzLCBidXQgd2UgbmVlZCB0byBzcGVjaWZ5CisgICAgICAgIGRldmljZSBwaXhlbHMgdG8gSW5z cGVjdG9yRnJvbnRlbmRIb3N0LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4u anM6CisKIDIwMTUtMTItMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXb3JrYXJvdW5kIGFycm93IGZ1bmN0aW9uIGlzc3Vl IGluIFRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IGRhOWExMzFiZjYyZDYzYzFlNjVkMzUw YWI4MGViNDQ1MmQ1NTNhMzQuLmY4YjgxYjliMmVmNzA3YWI3Y2NiOTc3YmQ3YmRlNzZhOGMwYWU3 MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2Uv TWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01h aW4uanMKQEAgLTE1ODYsNyArMTU4NiwxMCBAQCBXZWJJbnNwZWN0b3IuX2RvY2tlZFJlc2l6ZXJN b3VzZURvd24gPSBmdW5jdGlvbihldmVudCkKICAgICAgICAgaWYgKGRlbHRhIDwgMCAmJiBjbGll bnRQb3NpdGlvbiA+IGZpcnN0Q2xpZW50UG9zaXRpb24pCiAgICAgICAgICAgICByZXR1cm47CiAK LSAgICAgICAgdmFyIGRpbWVuc2lvbiA9IE1hdGgubWF4KDAsIHdpbmRvd1t3aW5kb3dQcm9wZXJ0 eV0gLSBkZWx0YSk7CisgICAgICAgIGxldCBkaW1lbnNpb24gPSBNYXRoLm1heCgwLCB3aW5kb3db d2luZG93UHJvcGVydHldIC0gZGVsdGEpOworICAgICAgICAvLyBJZiB6b29tZWQgaW4vb3V0LCB0 aGVyZSBiZSBncmVhdGVyL2Zld2VyIGRvY3VtZW50IHBpeGVscyBzaG93biwgYnV0IHRoZSBpbnNw ZWN0b3IncworICAgICAgICAvLyB3aWR0aCBvciBoZWlnaHQgc2hvdWxkIGJlIHRoZSBzYW1lIGlu IGRldmljZSBwaXhlbHMgcmVnYXJkbGVzcyBvZiB0aGUgZG9jdW1lbnQgem9vbS4KKyAgICAgICAg ZGltZW5zaW9uICo9IEluc3BlY3RvckZyb250ZW5kSG9zdC56b29tRmFjdG9yKCk7CiAKICAgICAg ICAgaWYgKHRoaXMuX2RvY2tTaWRlID09PSAiYm90dG9tIikKICAgICAgICAgICAgIEluc3BlY3Rv ckZyb250ZW5kSG9zdC5zZXRBdHRhY2hlZFdpbmRvd0hlaWdodChkaW1lbnNpb24pOwo=