152049 2015-12-09 02:06:09 -0800 Make AudioBusGtk implementation GLib-specific 2015-12-09 02:36:27 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue pnormand oldest_to_newest 1147643 0 zan 2015-12-09 02:06:09 -0800 Make AudioBusGtk implementation GLib-specific 1147644 1 266979 zan 2015-12-09 02:08:36 -0800 Created attachment 266979 Patch 1147647 2 commit-queue 2015-12-09 02:10:33 -0800 Attachment 266979 did not pass style-queue: ERROR: Source/WebCore/platform/audio/glib/AudioBusGLib.cpp:23: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1147654 3 266979 zan 2015-12-09 02:36:14 -0800 Comment on attachment 266979 Patch Clearing flags on attachment: 266979 Committed r193814: <http://trac.webkit.org/changeset/193814> 1147655 4 zan 2015-12-09 02:36:27 -0800 All reviewed patches have been landed. Closing bug. 266979 2015-12-09 02:08:36 -0800 2015-12-09 02:36:14 -0800 Patch bug-152049-20151209020805.patch text/plain 5759 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU5Mzc2MTZkYmRmMzgw MGE2ZDIxNmNmMjY3YTAwZTVhZmVkZjU4ZS4uMTAxMDdhYWI1NGNhZjEwODUwM2RmNjZiODU3NGI0 Yjg5MGI3OThmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTEyLTA5ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBNYWtlIEF1ZGlvQnVz R3RrIGltcGxlbWVudGF0aW9uIEdMaWItc3BlY2lmaWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjA0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEF1ZGlvQnVzR3RrIG9ubHkgZGVwZW5kcyBvbiBHTGli LCBzbyBpdCBzaG91bGQgYmUgbW92ZWQgdG8KKyAgICAgICAgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vZ2xpYiBhbmQgdGhlIGltcGxlbWVudGF0aW9uIGZpbGUKKyAgICAgICAgcmVuYW1l ZCB0byBBdWRpb0J1c0dMaWIuY3BwLgorCisgICAgICAgIFRoZSBoYXJkLWNvZGVkIHdlYmtpdGd0 ayBwYXRoIGNvbXBvbmVudCBjYW4gYmUgYWRkcmVzc2VkIGxhdGVyLgorCisgICAgICAgICogUGxh dGZvcm1HVEsuY21ha2U6IFVwZGF0ZSB0aGUgYnVpbGQgdGFyZ2V0LgorICAgICAgICAqIHBsYXRm b3JtL2F1ZGlvL2dsaWIvQXVkaW9CdXNHTGliLmNwcDogUmVuYW1lZCBmcm9tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2F1ZGlvL2d0ay9BdWRpb0J1c0d0ay5jcHAuCisgICAgICAgIChXZWJDb3Jl OjpBdWRpb0J1czo6bG9hZFBsYXRmb3JtUmVzb3VyY2UpOgorICAgICAgICAqIHBsYXRmb3JtL2F1 ZGlvL2d0ay9BdWRpb0J1c0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0J1czo6bG9h ZFBsYXRmb3JtUmVzb3VyY2UpOiBEZWxldGVkLgorCiAyMDE1LTEyLTA4ICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENvbnZlcnQgcmVzZXRBbmltVmFs VG9CYXNlVmFsIHRha2UgYSByZWZlcmVuY2UgdG8gYSBTVkdBbmltYXRlZFR5cGUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxh dGZvcm1HVEsuY21ha2UKaW5kZXggOGM4ZmQyYmY3YTk5ZTQ3OWI2ZmNiZDY0Yzg4OTU4OTRhNWM0 NmEzNi4uMGIwNzA0ZGEyYzM2MDE5ZWY1YjU2YzcxNGYwYjZmYmVjMDZhYmQxYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUv UGxhdGZvcm1HVEsuY21ha2UKQEAgLTc3LDE0ICs3NywxNCBAQCBsaXN0KEFQUEVORCBXZWJDb3Jl X1NPVVJDRVMKICAgICBwbGF0Zm9ybS9LaWxsUmluZ05vbmUuY3BwCiAgICAgcGxhdGZvcm0vUGxh dGZvcm1TdHJhdGVnaWVzLmNwcAogCisgICAgcGxhdGZvcm0vYXVkaW8vZ2xpYi9BdWRpb0J1c0dM aWIuY3BwCisKICAgICBwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9EZXN0aW5hdGlvbkdT dHJlYW1lci5jcHAKICAgICBwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVy R1N0cmVhbWVyLmNwcAogICAgIHBsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb1NvdXJjZVBy b3ZpZGVyR1N0cmVhbWVyLmNwcAogICAgIHBsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9GRlRGcmFt ZUdTdHJlYW1lci5jcHAKICAgICBwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVk aW9Tb3VyY2VHU3RyZWFtZXIuY3BwCiAKLSAgICBwbGF0Zm9ybS9hdWRpby9ndGsvQXVkaW9CdXNH dGsuY3BwCi0KICAgICBwbGF0Zm9ybS9nZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9jbHVl MS5jcHAKICAgICBwbGF0Zm9ybS9nZW9jbHVlL0dlb2xvY2F0aW9uUHJvdmlkZXJHZW9jbHVlMi5j cHAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ2xpYi9BdWRp b0J1c0dMaWIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ2xpYi9BdWRpb0J1 c0dMaWIuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc5MWJmYTM5NjM2MDE1YzZhOTk4ZWI3ODM4ZTk4ZDA0ZTNj MjYwNWUKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9n bGliL0F1ZGlvQnVzR0xpYi5jcHAKQEAgLTAsMCArMSw0MiBAQAorLyoKKyAqICBDb3B5cmlnaHQg KEMpIDIwMTEgSWdhbGlhIFMuTAorICoKKyAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2Fy ZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiAgbW9kaWZ5IGl0IHVuZGVyIHRo ZSB0ZXJtcyBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICogIExpY2Vuc2UgYXMg cHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICogIHZl cnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVy c2lvbi4KKyAqCisgKiAgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRo YXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgKiAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRo b3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqICBNRVJDSEFOVEFCSUxJVFkgb3Ig RklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICogIExlc3Nl ciBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICogIFlvdSBz aG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJs aWMKKyAqICBMaWNlbnNlIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBpZiBub3QsIHdyaXRlIHRv IHRoZSBGcmVlIFNvZnR3YXJlCisgKiAgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmtsaW4gU3Ry ZWV0LCBGaWZ0aCBGbG9vciwgQm9zdG9uLCBNQSAgMDIxMTAtMTMwMSAgVVNBCisgKi8KKworI2lu Y2x1ZGUgImNvbmZpZy5oIgorCisjaWYgRU5BQkxFKFdFQl9BVURJTykKKworI2luY2x1ZGUgIkF1 ZGlvQnVzLmgiCisKKyNpbmNsdWRlICJBdWRpb0ZpbGVSZWFkZXIuaCIKKyNpbmNsdWRlIDxnaW8v Z2lvLmg+CisjaW5jbHVkZSA8d3RmL2dsaWIvR1JlZlB0ci5oPgorI2luY2x1ZGUgPHd0Zi9nbGli L0dVbmlxdWVQdHIuaD4KKworbmFtZXNwYWNlIFdlYkNvcmUgeworCitQYXNzUmVmUHRyPEF1ZGlv QnVzPiBBdWRpb0J1czo6bG9hZFBsYXRmb3JtUmVzb3VyY2UoY29uc3QgY2hhciogbmFtZSwgZmxv YXQgc2FtcGxlUmF0ZSkKK3sKKyAgICBHVW5pcXVlUHRyPGNoYXI+IHBhdGgoZ19zdHJkdXBfcHJp bnRmKCIvb3JnL3dlYmtpdGd0ay9yZXNvdXJjZXMvYXVkaW8vJXMiLCBuYW1lKSk7CisgICAgR1Jl ZlB0cjxHQnl0ZXM+IGRhdGEgPSBhZG9wdEdSZWYoZ19yZXNvdXJjZXNfbG9va3VwX2RhdGEocGF0 aC5nZXQoKSwgR19SRVNPVVJDRV9MT09LVVBfRkxBR1NfTk9ORSwgbnVsbHB0cikpOworICAgIEFT U0VSVChkYXRhKTsKKyAgICByZXR1cm4gY3JlYXRlQnVzRnJvbUluTWVtb3J5QXVkaW9GaWxlKGdf Ynl0ZXNfZ2V0X2RhdGEoZGF0YS5nZXQoKSwgbnVsbHB0ciksIGdfYnl0ZXNfZ2V0X3NpemUoZGF0 YS5nZXQoKSksIGZhbHNlLCBzYW1wbGVSYXRlKTsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQorCisjZW5kaWYgLy8gRU5BQkxFKFdFQl9BVURJTykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2F1ZGlvL2d0ay9BdWRpb0J1c0d0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9hdWRpby9ndGsvQXVkaW9CdXNHdGsuY3BwCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCA3OTFiZmEzOTYzNjAxNWM2YTk5OGViNzgzOGU5OGQwNGUzYzI2MDVlLi4wMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2F1ZGlvL2d0ay9BdWRpb0J1c0d0ay5jcHAKKysrIC9kZXYvbnVsbApAQCAtMSw0MiAr MCwwIEBACi0vKgotICogIENvcHlyaWdodCAoQykgMjAxMSBJZ2FsaWEgUy5MCi0gKgotICogIFRo aXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQv b3IKLSAqICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVy YWwgUHVibGljCi0gKiAgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUg Rm91bmRhdGlvbjsgZWl0aGVyCi0gKiAgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQg eW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgotICoKLSAqICBUaGlzIGxpYnJhcnkgaXMg ZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKLSAqICBidXQg V0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBv ZgotICogIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9T RS4gIFNlZSB0aGUgR05VCi0gKiAgTGVzc2VyIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1v cmUgZGV0YWlscy4KLSAqCi0gKiAgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0 aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwotICogIExpY2Vuc2UgYWxvbmcgd2l0aCB0aGlz IGxpYnJhcnk7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUKLSAqICBGb3VuZGF0 aW9uLCBJbmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLCBCb3N0b24sIE1BICAw MjExMC0xMzAxICBVU0EKLSAqLwotCi0jaW5jbHVkZSAiY29uZmlnLmgiCi0KLSNpZiBFTkFCTEUo V0VCX0FVRElPKQotCi0jaW5jbHVkZSAiQXVkaW9CdXMuaCIKLQotI2luY2x1ZGUgIkF1ZGlvRmls ZVJlYWRlci5oIgotI2luY2x1ZGUgPGdpby9naW8uaD4KLSNpbmNsdWRlIDx3dGYvZ2xpYi9HUmVm UHRyLmg+Ci0jaW5jbHVkZSA8d3RmL2dsaWIvR1VuaXF1ZVB0ci5oPgotCi1uYW1lc3BhY2UgV2Vi Q29yZSB7Ci0KLVBhc3NSZWZQdHI8QXVkaW9CdXM+IEF1ZGlvQnVzOjpsb2FkUGxhdGZvcm1SZXNv dXJjZShjb25zdCBjaGFyKiBuYW1lLCBmbG9hdCBzYW1wbGVSYXRlKQotewotICAgIEdVbmlxdWVQ dHI8Y2hhcj4gcGF0aChnX3N0cmR1cF9wcmludGYoIi9vcmcvd2Via2l0Z3RrL3Jlc291cmNlcy9h dWRpby8lcyIsIG5hbWUpKTsKLSAgICBHUmVmUHRyPEdCeXRlcz4gZGF0YSA9IGFkb3B0R1JlZihn X3Jlc291cmNlc19sb29rdXBfZGF0YShwYXRoLmdldCgpLCBHX1JFU09VUkNFX0xPT0tVUF9GTEFH U19OT05FLCBudWxscHRyKSk7Ci0gICAgQVNTRVJUKGRhdGEpOwotICAgIHJldHVybiBjcmVhdGVC dXNGcm9tSW5NZW1vcnlBdWRpb0ZpbGUoZ19ieXRlc19nZXRfZGF0YShkYXRhLmdldCgpLCBudWxs cHRyKSwgZ19ieXRlc19nZXRfc2l6ZShkYXRhLmdldCgpKSwgZmFsc2UsIHNhbXBsZVJhdGUpOwot fQotCi19IC8vIG5hbWVzcGFjZSBXZWJDb3JlCi0KLSNlbmRpZiAvLyBFTkFCTEUoV0VCX0FVRElP KQo=