152048 2015-12-09 02:00:09 -0800 [CoordinatedGraphics][EFL] Fix unhandled web process message when launching MiniBrowser 2015-12-09 06:00:26 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1147640 0 ryuan.choi 2015-12-09 02:00:09 -0800 When launched MiniBrowser, there is below error message. ERROR: Unhandled web process message 'WebPage:PreferencesDidChange' It's because EwkView update preferences before initializing WebPage in WebView constructor. 1147642 1 266978 ryuan.choi 2015-12-09 02:03:32 -0800 Created attachment 266978 Patch 1147657 2 266978 gyuyoung.kim 2015-12-09 02:40:12 -0800 Comment on attachment 266978 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266978&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] Fix unhandled web process message when launching MiniBrowser Please add [CoordinatedGrahics] for more clarity as well. > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:334 > + WKViewSetIsActive(wkView(), true); If we don't need to initialize view here, it seems to me "WKViewSetIsActive()" is also unnecessary work. I think this work should be done in Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:60 line. Why can't we do it in WebView::WebView() ? 1147660 3 ryuan.choi 2015-12-09 02:51:04 -0800 (In reply to comment #2) > Comment on attachment 266978 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266978&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL] Fix unhandled web process message when launching MiniBrowser > > Please add [CoordinatedGrahics] for more clarity as well. > OK. > > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:334 > > + WKViewSetIsActive(wkView(), true); > > If we don't need to initialize view here, it seems to me > "WKViewSetIsActive()" is also unnecessary work. I think this work should be > done in Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:60 line. > Why can't we do it in WebView::WebView() ? No. WebPage can be initialized without active state in CoordinatedGraphics system although EFL port initializes WebView with active state. 1147667 4 266978 gyuyoung.kim 2015-12-09 03:02:02 -0800 Comment on attachment 266978 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266978&action=review >>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:334 >>> + WKViewSetIsActive(wkView(), true); >> >> If we don't need to initialize view here, it seems to me "WKViewSetIsActive()" is also unnecessary work. I think this work should be done in Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:60 line. Why can't we do it in WebView::WebView() ? > > No. WebPage can be initialized without active state in CoordinatedGraphics system although EFL port initializes WebView with active state. I mean why we should call WKViewSetIsActive() here even though you remove WKViewInitialize(). Your patch delegates the initialization to the WebView ctor. I wonder why we still need to call WKViewSetIsActive() here. Can't we delegate this to the WebView ctor as well ? 1147673 5 266978 gyuyoung.kim 2015-12-09 03:18:54 -0800 Comment on attachment 266978 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266978&action=review >>>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:334 >>>> + WKViewSetIsActive(wkView(), true); >>> >>> If we don't need to initialize view here, it seems to me "WKViewSetIsActive()" is also unnecessary work. I think this work should be done in Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:60 line. Why can't we do it in WebView::WebView() ? >> >> No. WebPage can be initialized without active state in CoordinatedGraphics system although EFL port initializes WebView with active state. > > I mean why we should call WKViewSetIsActive() here even though you remove WKViewInitialize(). Your patch delegates the initialization to the WebView ctor. I wonder why we still need to call WKViewSetIsActive() here. Can't we delegate this to the WebView ctor as well ? Though I still don't like to call WKViewSetIsActive() again, I don't object to call it to go ahead to refactor. But please mention why we still have to call WKviewSetIsActive() in ChangeLog. 1147674 6 gyuyoung.kim 2015-12-09 03:19:34 -0800 rs=me. 1147714 7 266990 ryuan.choi 2015-12-09 04:24:55 -0800 Created attachment 266990 Patch 1147715 8 ryuan.choi 2015-12-09 04:25:52 -0800 (In reply to comment #5) > Comment on attachment 266978 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266978&action=review > > >>>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:334 > >>>> + WKViewSetIsActive(wkView(), true); > >>> > >>> If we don't need to initialize view here, it seems to me "WKViewSetIsActive()" is also unnecessary work. I think this work should be done in Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:60 line. Why can't we do it in WebView::WebView() ? > >> > >> No. WebPage can be initialized without active state in CoordinatedGraphics system although EFL port initializes WebView with active state. > > > > I mean why we should call WKViewSetIsActive() here even though you remove WKViewInitialize(). Your patch delegates the initialization to the WebView ctor. I wonder why we still need to call WKViewSetIsActive() here. Can't we delegate this to the WebView ctor as well ? > > Though I still don't like to call WKViewSetIsActive() again, I don't object > to call it to go ahead to refactor. But please mention why we still have to > call WKviewSetIsActive() in ChangeLog. I don't like it too. Because of it, we can't make an inactive ewk_view. Then, how about adding FIXME to move it to some better place in the different bug? Anyway, I think that initializing ewk_view without active state is different issue from this bug. 1147717 9 gyuyoung.kim 2015-12-09 04:28:42 -0800 (In reply to comment #8) > (In reply to comment #5) > > Comment on attachment 266978 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=266978&action=review > > > > >>>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:334 > > >>>> + WKViewSetIsActive(wkView(), true); > > >>> > > >>> If we don't need to initialize view here, it seems to me "WKViewSetIsActive()" is also unnecessary work. I think this work should be done in Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:60 line. Why can't we do it in WebView::WebView() ? > > >> > > >> No. WebPage can be initialized without active state in CoordinatedGraphics system although EFL port initializes WebView with active state. > > > > > > I mean why we should call WKViewSetIsActive() here even though you remove WKViewInitialize(). Your patch delegates the initialization to the WebView ctor. I wonder why we still need to call WKViewSetIsActive() here. Can't we delegate this to the WebView ctor as well ? > > > > Though I still don't like to call WKViewSetIsActive() again, I don't object > > to call it to go ahead to refactor. But please mention why we still have to > > call WKviewSetIsActive() in ChangeLog. > > I don't like it too. > Because of it, we can't make an inactive ewk_view. > Then, how about adding FIXME to move it to some better place in the > different bug? > > Anyway, I think that initializing ewk_view without active state is different > issue from this bug. Ok, I see. 1147737 10 266990 commit-queue 2015-12-09 06:00:23 -0800 Comment on attachment 266990 Patch Clearing flags on attachment: 266990 Committed r193827: <http://trac.webkit.org/changeset/193827> 1147738 11 commit-queue 2015-12-09 06:00:26 -0800 All reviewed patches have been landed. Closing bug. 266978 2015-12-09 02:03:32 -0800 2015-12-09 04:24:47 -0800 Patch bug-152048-20151209190301.patch text/plain 6279 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODA3MDI0NDFmODFmZTMy MGUxM2ExZmFjYzIzZDE3NjI1YjAyZWUyOS4uNDI4ZWUyNmU1OWVkYThiNzk2NzE0ZmJjNGZlZDUz MWNiMzk1NWNkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE1LTEyLTA5ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgogCisgICAgICAgIFtFRkxdIEZpeCB1 bmhhbmRsZWQgd2ViIHByb2Nlc3MgbWVzc2FnZSB3aGVuIGxhdW5jaGluZyBNaW5pQnJvd3Nlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyMDQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViUGFnZSBz aG91bGQgYmUgaW5pdGlhbGl6ZWQgYmVmb3JlIHVwZGF0aW5nIHByZWZlcmVuY2VzLgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9DL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV0tWaWV3LmNwcDoKKyAg ICAgICAgKFdLVmlld0luaXRpYWxpemUpOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvQy9Db29yZGluYXRlZEdyYXBoaWNzL1dLVmlldy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL0V3a1ZpZXcuY3BwOgorICAgICAgICAoRXdrVmlldzo6RXdrVmlldyk6CisgICAgICAg ICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlZpZXc6OldlYlZpZXcpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Ojppbml0 aWFsaXplKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGlj cy9XZWJWaWV3Lmg6CisKKzIwMTUtMTItMDkgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQG5hdmVy Y29ycC5jb20+CisKICAgICAgICAgW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIGxheWVyVHJlZUhvc3Qg YWx3YXlzIGV4aXN0IGluIENvb3JkaW5hdGVkRHJhd2luZ0FyZWEKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTk4NwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XS1ZpZXcuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV0tW aWV3LmNwcAppbmRleCA5NjU0ZDVlZmFkZjNhZWQ1NzEzYTlhMGYyZGU0MTg0NmI0MWZmOGU1Li5i MTRiOTk1MDM4MWM5ZWYzYTY0M2RkMTRiZTk3N2JhMjc0MTg2YTJhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XS1ZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9Db29yZGluYXRlZEdyYXBoaWNz L1dLVmlldy5jcHAKQEAgLTM2LDExICszNiw2IEBAIFdLVmlld1JlZiBXS1ZpZXdDcmVhdGUoV0tD b250ZXh0UmVmIGNvbnRleHQsIFdLUGFnZUNvbmZpZ3VyYXRpb25SZWYgcGFnZUNvbmZpZ3VyCiAg ICAgcmV0dXJuIHRvQVBJKHdlYlZpZXcucmVsZWFzZSgpLmxlYWtSZWYoKSk7CiB9CiAKLXZvaWQg V0tWaWV3SW5pdGlhbGl6ZShXS1ZpZXdSZWYgdmlld1JlZikKLXsKLSAgICB0b0ltcGwodmlld1Jl ZiktPmluaXRpYWxpemUoKTsKLX0KLQogV0tTaXplIFdLVmlld0dldFNpemUoV0tWaWV3UmVmIHZp ZXdSZWYpCiB7CiAgICAgcmV0dXJuIHRvQVBJKHRvSW1wbCh2aWV3UmVmKS0+c2l6ZSgpKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9Db29yZGluYXRlZEdyYXBo aWNzL1dLVmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL0Nvb3JkaW5hdGVk R3JhcGhpY3MvV0tWaWV3LmgKaW5kZXggMzE4NDI1ODA5N2JkNWQ2Y2E3ZDg3NWUxY2IyYjI5MDEz ZDZmMmRiZi4uNjBmNDIzOWUwZjZiMDUwNzI1NDY1NzllYTQwMGM3ZDJlODhlNmQ0MSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv V0tWaWV3LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL0Nvb3JkaW5hdGVk R3JhcGhpY3MvV0tWaWV3LmgKQEAgLTY2LDggKzY2LDYgQEAgdHlwZWRlZiBzdHJ1Y3QgV0tWaWV3 Q2xpZW50VjAgewogCiBXS19FWFBPUlQgV0tWaWV3UmVmIFdLVmlld0NyZWF0ZShXS0NvbnRleHRS ZWYgY29udGV4dCwgV0tQYWdlQ29uZmlndXJhdGlvblJlZiBwYWdlQ29uZmlndXJhdGlvbik7CiAK LVdLX0VYUE9SVCB2b2lkIFdLVmlld0luaXRpYWxpemUoV0tWaWV3UmVmKTsKLQogV0tfRVhQT1JU IFdLU2l6ZSBXS1ZpZXdHZXRTaXplKFdLVmlld1JlZik7CiBXS19FWFBPUlQgdm9pZCBXS1ZpZXdT ZXRTaXplKFdLVmlld1JlZiwgV0tTaXplIHNpemUpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCmluZGV4IGM2M2I5ZjIxMWNjYWZiOGI2Y2UzNTQ0ZWE3 ZDdhNGVlYzBlZWZiNzkuLmRmNTQ2MDk4ZDhlNGRjMGMwMTFjMjA2ODNjZDI2MmU2YzFiM2NhMWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCkBAIC0z MzEsNyArMzMxLDcgQEAgRXdrVmlldzo6RXdrVmlldyhXS1ZpZXdSZWYgdmlldywgRXZhc19PYmpl Y3QqIGV2YXNPYmplY3QpCiAgICAgfQogCiAgICAgbV9wZW5kaW5nU3VyZmFjZVJlc2l6ZSA9IG1f aXNBY2NlbGVyYXRlZDsKLSAgICBXS1ZpZXdJbml0aWFsaXplKHdrVmlldygpKTsKKyAgICBXS1Zp ZXdTZXRJc0FjdGl2ZSh3a1ZpZXcoKSwgdHJ1ZSk7CiAKICAgICBtX3BhZ2VVSUNsaWVudCA9IHN0 ZDo6bWFrZV91bmlxdWU8UGFnZVVJQ2xpZW50RWZsPih0aGlzKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcApp bmRleCA4MGJjNzA1YzVjOGU3ZDNjYTgwYzNiOWZmOTJjZjBhOGZmYmZkNjdjLi4xYzhhZGUxMzYw ZmM1ZmExNTEzMjIxZGNlN2E4NDUxMzI0YjhiMDFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcApAQCAtNTYs NiArNTYsNyBAQCBXZWJWaWV3OjpXZWJWaWV3KFdlYlByb2Nlc3NQb29sKiBjb250ZXh0LCBBUEk6 OlBhZ2VDb25maWd1cmF0aW9uJiBwYWdlQ29uZmlndXJhdAogewogICAgIC8vIE5lZWQgdG8gY2Fs bCBjcmVhdGVXZWJQYWdlIGFmdGVyIG90aGVyIGRhdGEgbWVtYmVycywgc3BlY2lmaWNhbGx5IG1f dmlzaWJsZSwgYXJlIGluaXRpYWxpemVkLgogICAgIG1fcGFnZSA9IGNvbnRleHQtPmNyZWF0ZVdl YlBhZ2UoKnRoaXMsIHBhZ2VDb25maWd1cmF0aW9uLmNvcHkoKSk7CisgICAgbV9wYWdlLT5pbml0 aWFsaXplV2ViUGFnZSgpOwogCiAgICAgbV9wYWdlLT5wYWdlR3JvdXAoKS5wcmVmZXJlbmNlcygp LnNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKHRydWUpOwogICAgIG1fcGFnZS0+cGFn ZUdyb3VwKCkucHJlZmVyZW5jZXMoKS5zZXRGb3JjZUNvbXBvc2l0aW5nTW9kZSh0cnVlKTsKQEAg LTc0LDEyICs3NSw2IEBAIFdlYlZpZXc6On5XZWJWaWV3KCkKICAgICBtX3BhZ2UtPmNsb3NlKCk7 CiB9CiAKLXZvaWQgV2ViVmlldzo6aW5pdGlhbGl6ZSgpCi17Ci0gICAgbV9wYWdlLT5pbml0aWFs aXplV2ViUGFnZSgpOwotICAgIHNldEFjdGl2ZSh0cnVlKTsKLX0KLQogdm9pZCBXZWJWaWV3Ojpz ZXRDb250ZW50U2NhbGVGYWN0b3IoZmxvYXQgc2NhbGVGYWN0b3IpCiB7CiAgICAgbV9wYWdlLT5z Y2FsZVBhZ2Uoc2NhbGVGYWN0b3IsIHJvdW5kZWRJbnRQb2ludChjb250ZW50UG9zaXRpb24oKSkp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvV2ViVmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvV2ViVmlldy5oCmluZGV4IDc2YWQ2NzdmMDIxYWQ1ODU3OWRlMzRlMjUwMjlhYmM3NzIzMTQy MjYuLjgzZGU2ZWZlNTc3M2U5MzFmZjBlMDViOGZmNGIxOWNjNDQwYmJjNjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3 LmgKQEAgLTU2LDggKzU2LDYgQEAgcHVibGljOgogCiAgICAgc3RhdGljIFJlZjxXZWJWaWV3PiBj cmVhdGUoV2ViUHJvY2Vzc1Bvb2wqLCBBUEk6OlBhZ2VDb25maWd1cmF0aW9uJik7CiAKLSAgICB2 b2lkIGluaXRpYWxpemUoKTsKLQogICAgIHZvaWQgc2V0U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRT aXplJik7CiAgICAgY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgc2l6ZSgpIGNvbnN0IHsgcmV0dXJu IG1fc2l6ZTsgfQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggYjc1NjU0YjFkNDVkNzg2ZjU5ZWMwZTI3NjkxNGM4YzhhNzJhZDRjNC4uNmVlYzE5 MTFmYmE4Y2ViNzhkYzAyMGY1NDBiNDliZWUyYmVkZWNiNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEyLTA5 ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxd IEZpeCB1bmhhbmRsZWQgd2ViIHByb2Nlc3MgbWVzc2FnZSB3aGVuIGxhdW5jaGluZyBNaW5pQnJv d3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUy MDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvQ29vcmRpbmF0ZWRHcmFwaGljcy9XS1ZpZXdVc2Vy Vmlld3BvcnRUb0NvbnRlbnRzLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgor CiAyMDE1LTEyLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjQzCmRpZmYg LS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvQ29vcmRpbmF0ZWRHcmFw aGljcy9XS1ZpZXdVc2VyVmlld3BvcnRUb0NvbnRlbnRzLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Mi9Db29yZGluYXRlZEdyYXBoaWNzL1dLVmlld1VzZXJWaWV3cG9ydFRv Q29udGVudHMuY3BwCmluZGV4IDE1NTUyYTY5OWZlYzgxNGNmN2YzMzA0ZDFmMWM4MGY0NzQ4OTZh MDEuLjI0NDVmZDcxZjU3M2M3YWU5MDE5NDQ4OGZjMzAyYWM3ZjE5NGFjYmUgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9Db29yZGluYXRlZEdyYXBoaWNzL1dL Vmlld1VzZXJWaWV3cG9ydFRvQ29udGVudHMuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Mi9Db29yZGluYXRlZEdyYXBoaWNzL1dLVmlld1VzZXJWaWV3cG9ydFRvQ29u dGVudHMuY3BwCkBAIC00Myw3ICs0Myw3IEBAIFRFU1QoV2ViS2l0MiwgRElTQUJMRURfV0tWaWV3 VXNlclZpZXdwb3J0VG9Db250ZW50cykKIAogICAgIFdLUmV0YWluUHRyPFdLVmlld1JlZj4gd2Vi VmlldyhBZG9wdFdLLCBXS1ZpZXdDcmVhdGUoY29udGV4dC5nZXQoKSwgY29uZmlndXJhdGlvbi5n ZXQoKSkpOwogCi0gICAgV0tWaWV3SW5pdGlhbGl6ZSh3ZWJWaWV3LmdldCgpKTsKKyAgICBXS1Zp ZXdTZXRJc0FjdGl2ZSh3ZWJWaWV3LmdldCgpLCB0cnVlKTsKICAgICBXS1BhZ2VTZXRVc2VGaXhl ZExheW91dChXS1ZpZXdHZXRQYWdlKHdlYlZpZXcuZ2V0KCkpLCBmYWxzZSk7CiAKICAgICBXS1Bv aW50IG91dDsK 266990 2015-12-09 04:24:55 -0800 2015-12-09 06:00:23 -0800 Patch bug-152048-20151209212424.patch text/plain 6608 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2JjNTg2MjlkZGI2NzJm ZmI1MjY1MDRhYzZkMTZhMzE1M2Y0ODkwNC4uYzEzMzQyYzI0YTUwNWEyOTUxOTg0NWU1NmMxNmJj OGQ1NDkzMDYwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTEyLTA5ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtDb29yZGluYXRl ZEdyYXBoaWNzXVtFRkxdIEZpeCB1bmhhbmRsZWQgd2ViIHByb2Nlc3MgbWVzc2FnZSB3aGVuIGxh dW5jaGluZyBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyMDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR3l1eW91bmcgS2ltLgor CisgICAgICAgIFdlYlBhZ2Ugc2hvdWxkIGJlIGluaXRpYWxpemVkIGJlZm9yZSB1cGRhdGluZyBw cmVmZXJlbmNlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9Db29yZGluYXRlZEdyYXBo aWNzL1dLVmlldy5jcHA6CisgICAgICAgIChXS1ZpZXdJbml0aWFsaXplKTogRGVsZXRlZC4KKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XS1ZpZXcuaDoKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcDoKKyAgICAgICAgKEV3a1ZpZXc6 OkV3a1ZpZXcpOgorICAgICAgICBDYWxscyBXS1ZpZXdTZXRJc0FjdGl2ZSBpbnN0ZWFkIG9mIFdL Vmlld0luaXRpYWxpemUgbm90IHRvIGNoYW5nZSB0aGUgYmVoYXZpb3IKKyAgICAgICAgb2YgRUZM IHBvcnQuCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OldlYlZpZXcpOgorICAgICAgICBJbml0aWFs aXplIGp1c3QgYmVmb3JlIGNyZWF0aW5nIFdlYlBhZ2UgYmVjYXVzZSB0aGVyZSBpcyBub3QgdXNl IGNhc2UgdG8gc2VwYXJhdGUKKyAgICAgICAgaW5pdGlhbGl6aW5nIFdlYlBhZ2UgZnJvbSBjcmVh dGluZyBpbiBDb29yZGluYXRlZEdyYXBoaWNzLgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Ojpp bml0aWFsaXplKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFw aGljcy9XZWJWaWV3Lmg6CisKIDIwMTUtMTItMDkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtp bUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdIFJFR1JFU1NJT04ocjE5MzYxNik6IFdLUHJl ZmVyZW5jZXMgdGVzdCBoYXMgYmVlbiBmYWlsZWQgc2luY2UgcjE5MzYxNgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV0tWaWV3 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9Db29yZGluYXRlZEdyYXBoaWNz L1dLVmlldy5jcHAKaW5kZXggOTY1NGQ1ZWZhZGYzYWVkNTcxM2E5YTBmMmRlNDE4NDZiNDFmZjhl NS4uYjE0Yjk5NTAzODFjOWVmM2E2NDNkZDE0YmU5NzdiYTI3NDE4NmEyYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV0tWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvQ29vcmRpbmF0ZWRHcmFw aGljcy9XS1ZpZXcuY3BwCkBAIC0zNiwxMSArMzYsNiBAQCBXS1ZpZXdSZWYgV0tWaWV3Q3JlYXRl KFdLQ29udGV4dFJlZiBjb250ZXh0LCBXS1BhZ2VDb25maWd1cmF0aW9uUmVmIHBhZ2VDb25maWd1 cgogICAgIHJldHVybiB0b0FQSSh3ZWJWaWV3LnJlbGVhc2UoKS5sZWFrUmVmKCkpOwogfQogCi12 b2lkIFdLVmlld0luaXRpYWxpemUoV0tWaWV3UmVmIHZpZXdSZWYpCi17Ci0gICAgdG9JbXBsKHZp ZXdSZWYpLT5pbml0aWFsaXplKCk7Ci19Ci0KIFdLU2l6ZSBXS1ZpZXdHZXRTaXplKFdLVmlld1Jl ZiB2aWV3UmVmKQogewogICAgIHJldHVybiB0b0FQSSh0b0ltcGwodmlld1JlZiktPnNpemUoKSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvQ29vcmRpbmF0ZWRH cmFwaGljcy9XS1ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9Db29yZGlu YXRlZEdyYXBoaWNzL1dLVmlldy5oCmluZGV4IDMxODQyNTgwOTdiZDVkNmNhN2Q4NzVlMWNiMmIy OTAxM2Q2ZjJkYmYuLjYwZjQyMzllMGY2YjA1MDcyNTQ2NTc5ZWE0MDBjN2QyZTg4ZTZkNDEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9Db29yZGluYXRlZEdyYXBo aWNzL1dLVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9Db29yZGlu YXRlZEdyYXBoaWNzL1dLVmlldy5oCkBAIC02Niw4ICs2Niw2IEBAIHR5cGVkZWYgc3RydWN0IFdL Vmlld0NsaWVudFYwIHsKIAogV0tfRVhQT1JUIFdLVmlld1JlZiBXS1ZpZXdDcmVhdGUoV0tDb250 ZXh0UmVmIGNvbnRleHQsIFdLUGFnZUNvbmZpZ3VyYXRpb25SZWYgcGFnZUNvbmZpZ3VyYXRpb24p OwogCi1XS19FWFBPUlQgdm9pZCBXS1ZpZXdJbml0aWFsaXplKFdLVmlld1JlZik7Ci0KIFdLX0VY UE9SVCBXS1NpemUgV0tWaWV3R2V0U2l6ZShXS1ZpZXdSZWYpOwogV0tfRVhQT1JUIHZvaWQgV0tW aWV3U2V0U2l6ZShXS1ZpZXdSZWYsIFdLU2l6ZSBzaXplKTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAppbmRleCBjNjNiOWYyMTFjY2FmYjhiNmNlMzU0 NGVhN2Q3YTRlZWMwZWVmYjc5Li5iMjcxZDY5MGVmODAyYWUxZDkzMWQwY2YyNzI2ZTFkMGU1ZjA1 ZWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcApA QCAtMzMxLDcgKzMzMSw5IEBAIEV3a1ZpZXc6OkV3a1ZpZXcoV0tWaWV3UmVmIHZpZXcsIEV2YXNf T2JqZWN0KiBldmFzT2JqZWN0KQogICAgIH0KIAogICAgIG1fcGVuZGluZ1N1cmZhY2VSZXNpemUg PSBtX2lzQWNjZWxlcmF0ZWQ7Ci0gICAgV0tWaWV3SW5pdGlhbGl6ZSh3a1ZpZXcoKSk7CisKKyAg ICAvLyBGSVhNRTogSXQgc2hvdWxkIGJlIG1vdmVkIHRvIHNvbWUgYmV0dGVyIHBsYWNlIHRvIGNy ZWF0ZSBhbiBpbmFjdGl2ZSBld2tfdmlldy4KKyAgICBXS1ZpZXdTZXRJc0FjdGl2ZSh3a1ZpZXco KSwgdHJ1ZSk7CiAKICAgICBtX3BhZ2VVSUNsaWVudCA9IHN0ZDo6bWFrZV91bmlxdWU8UGFnZVVJ Q2xpZW50RWZsPih0aGlzKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAppbmRleCA4MGJjNzA1YzVjOGU3ZDNj YTgwYzNiOWZmOTJjZjBhOGZmYmZkNjdjLi4xYzhhZGUxMzYwZmM1ZmExNTEzMjIxZGNlN2E4NDUx MzI0YjhiMDFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0 ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29v cmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcApAQCAtNTYsNiArNTYsNyBAQCBXZWJWaWV3OjpX ZWJWaWV3KFdlYlByb2Nlc3NQb29sKiBjb250ZXh0LCBBUEk6OlBhZ2VDb25maWd1cmF0aW9uJiBw YWdlQ29uZmlndXJhdAogewogICAgIC8vIE5lZWQgdG8gY2FsbCBjcmVhdGVXZWJQYWdlIGFmdGVy IG90aGVyIGRhdGEgbWVtYmVycywgc3BlY2lmaWNhbGx5IG1fdmlzaWJsZSwgYXJlIGluaXRpYWxp emVkLgogICAgIG1fcGFnZSA9IGNvbnRleHQtPmNyZWF0ZVdlYlBhZ2UoKnRoaXMsIHBhZ2VDb25m aWd1cmF0aW9uLmNvcHkoKSk7CisgICAgbV9wYWdlLT5pbml0aWFsaXplV2ViUGFnZSgpOwogCiAg ICAgbV9wYWdlLT5wYWdlR3JvdXAoKS5wcmVmZXJlbmNlcygpLnNldEFjY2VsZXJhdGVkQ29tcG9z aXRpbmdFbmFibGVkKHRydWUpOwogICAgIG1fcGFnZS0+cGFnZUdyb3VwKCkucHJlZmVyZW5jZXMo KS5zZXRGb3JjZUNvbXBvc2l0aW5nTW9kZSh0cnVlKTsKQEAgLTc0LDEyICs3NSw2IEBAIFdlYlZp ZXc6On5XZWJWaWV3KCkKICAgICBtX3BhZ2UtPmNsb3NlKCk7CiB9CiAKLXZvaWQgV2ViVmlldzo6 aW5pdGlhbGl6ZSgpCi17Ci0gICAgbV9wYWdlLT5pbml0aWFsaXplV2ViUGFnZSgpOwotICAgIHNl dEFjdGl2ZSh0cnVlKTsKLX0KLQogdm9pZCBXZWJWaWV3OjpzZXRDb250ZW50U2NhbGVGYWN0b3Io ZmxvYXQgc2NhbGVGYWN0b3IpCiB7CiAgICAgbV9wYWdlLT5zY2FsZVBhZ2Uoc2NhbGVGYWN0b3Is IHJvdW5kZWRJbnRQb2ludChjb250ZW50UG9zaXRpb24oKSkpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oCmluZGV4IDc2 YWQ2NzdmMDIxYWQ1ODU3OWRlMzRlMjUwMjlhYmM3NzIzMTQyMjYuLjgzZGU2ZWZlNTc3M2U5MzFm ZjBlMDViOGZmNGIxOWNjNDQwYmJjNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmgKQEAgLTU2LDggKzU2LDYgQEAg cHVibGljOgogCiAgICAgc3RhdGljIFJlZjxXZWJWaWV3PiBjcmVhdGUoV2ViUHJvY2Vzc1Bvb2wq LCBBUEk6OlBhZ2VDb25maWd1cmF0aW9uJik7CiAKLSAgICB2b2lkIGluaXRpYWxpemUoKTsKLQog ICAgIHZvaWQgc2V0U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJik7CiAgICAgY29uc3QgV2Vi Q29yZTo6SW50U2l6ZSYgc2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fc2l6ZTsgfQogCmRpZmYgLS1n aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzRiOGJjYWE3NjA0 OWMwN2YwYzljNzI5NDI2ZTdjM2E5NTdkNjAwZi4uZmQ0YTgyOWM3NzhjNTRjMjkzOGI3ZTNhNjA1 YjFhNDUyOWM0NTgxZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEyLTA5ICBSeXVhbiBDaG9pICA8cnl1YW4u Y2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIEZpeCB1bmhhbmRsZWQgd2ViIHBy b2Nlc3MgbWVzc2FnZSB3aGVuIGxhdW5jaGluZyBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyMDQ4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgR3l1eW91bmcgS2ltLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQyL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV0tWaWV3VXNlclZpZXdwb3J0VG9Db250ZW50cy5jcHA6 CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxNS0xMi0wOSAgTWFyaW8gU2Fu Y2hleiBQcmFkYSAgPG1hcmlvQGVuZGxlc3NtLmNvbT4KIAogICAgICAgICBSZWZhY3RvcmVkIGlu aXRpYWxpemF0aW9uIGNvZGUgaW4gTG9hZFRyYWNraW5nVGVzdC4KZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9Db29yZGluYXRlZEdyYXBoaWNzL1dLVmlld1Vz ZXJWaWV3cG9ydFRvQ29udGVudHMuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQyL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV0tWaWV3VXNlclZpZXdwb3J0VG9Db250ZW50cy5jcHAK aW5kZXggMTU1NTJhNjk5ZmVjODE0Y2Y3ZjMzMDRkMWYxYzgwZjQ3NDg5NmEwMS4uMjQ0NWZkNzFm NTczYzdhZTkwMTk0NDg4ZmMzMDJhYzdmMTk0YWNiZSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXQyL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV0tWaWV3VXNlclZpZXdw b3J0VG9Db250ZW50cy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQy L0Nvb3JkaW5hdGVkR3JhcGhpY3MvV0tWaWV3VXNlclZpZXdwb3J0VG9Db250ZW50cy5jcHAKQEAg LTQzLDcgKzQzLDcgQEAgVEVTVChXZWJLaXQyLCBESVNBQkxFRF9XS1ZpZXdVc2VyVmlld3BvcnRU b0NvbnRlbnRzKQogCiAgICAgV0tSZXRhaW5QdHI8V0tWaWV3UmVmPiB3ZWJWaWV3KEFkb3B0V0ss IFdLVmlld0NyZWF0ZShjb250ZXh0LmdldCgpLCBjb25maWd1cmF0aW9uLmdldCgpKSk7CiAKLSAg ICBXS1ZpZXdJbml0aWFsaXplKHdlYlZpZXcuZ2V0KCkpOworICAgIFdLVmlld1NldElzQWN0aXZl KHdlYlZpZXcuZ2V0KCksIHRydWUpOwogICAgIFdLUGFnZVNldFVzZUZpeGVkTGF5b3V0KFdLVmll d0dldFBhZ2Uod2ViVmlldy5nZXQoKSksIGZhbHNlKTsKIAogICAgIFdLUG9pbnQgb3V0Owo=