152042 2015-12-09 01:01:37 -0800 [TextureMapper] TextureMapperShaderProgram::setMatrix() should use TransformationMatrix::FloatMatrix4 2015-12-09 03:26:58 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cmarcelo commit-queue kondapallykalyan luiz noam yoon oldest_to_newest 1147621 0 zan 2015-12-09 01:01:37 -0800 [TextureMapper] TextureMapperShaderProgram::setMatrix() should use TransformationMatrix::FloatMatrix4 1147623 1 266974 zan 2015-12-09 01:11:32 -0800 Created attachment 266974 Patch 1147624 2 yoon 2015-12-09 01:18:09 -0800 Thanks for this patch! Looks good to me even though I cannot mark it with r+ myself. 1147680 3 266974 zan 2015-12-09 03:26:50 -0800 Comment on attachment 266974 Patch Clearing flags on attachment: 266974 Committed r193819: <http://trac.webkit.org/changeset/193819> 1147681 4 zan 2015-12-09 03:26:58 -0800 All reviewed patches have been landed. Closing bug. 266974 2015-12-09 01:11:32 -0800 2015-12-09 03:26:50 -0800 Patch bug-152042-20151209011100.patch text/plain 2482 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU5Mzc2MTZkYmRmMzgw MGE2ZDIxNmNmMjY3YTAwZTVhZmVkZjU4ZS4uNDllMTAyNjk4N2U1NDc3MmJiMzcxNjc3MjMxNjY2 ZWIyNjcyMGI0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEyLTA5ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbVGV4dHVyZU1hcHBl cl0gVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW06OnNldE1hdHJpeCgpIHNob3VsZCB1c2UgVHJh bnNmb3JtYXRpb25NYXRyaXg6OkZsb2F0TWF0cml4NAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyMDQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVy ZU1hcHBlclNoYWRlclByb2dyYW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBl clNoYWRlclByb2dyYW06OnNldE1hdHJpeCk6IEluc3RlYWQgb2YgbWFudWFsbHkgd3JpdGluZyBv dXQKKyAgICAgICAgdGhlIGNvbXBsZXRlIG1hdHJpeCBpbiBhIEMgYXJyYXksIHNpbXBseSB1c2Ug VHJhbnNmb3JtYXRpb25NYXRyaXg6OkZsb2F0TWF0cml4NAorICAgICAgICBhbmQgZmlsbCB0aGF0 IHZpYSB0aGUgVHJhbnNmb3JtYXRpb25NYXRyaXg6OnRvQ29sdW1uTWFqb3JGbG9hdEFycmF5KCkg bWV0aG9kCisgICAgICAgIGNhbGxlZCBvbiB0aGUgcGFzc2VkLWluIFRyYW5zZm9ybWF0aW9uTWF0 cml4LgorCiAyMDE1LTEyLTA4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29t PgogCiAgICAgICAgIENvbnZlcnQgcmVzZXRBbmltVmFsVG9CYXNlVmFsIHRha2UgYSByZWZlcmVu Y2UgdG8gYSBTVkdBbmltYXRlZFR5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclBy b2dyYW0uY3BwCmluZGV4IDRhNmI0YTg0OWMxYzEyMDliOGY0NjM5ODk0ZTg2N2ZmM2IwMTc0YzAu LjA3YTc0NmQzYjUxZTk4MWM2YjM2YTdkODAyOTcyMzA5NDE5ZDExOTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVy UHJvZ3JhbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L1RleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmNwcApAQCAtNzMsMTQgKzczLDkgQEAgVGV4dHVy ZU1hcHBlclNoYWRlclByb2dyYW06OlRleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtKFBhc3NSZWZQ dHI8R3JhcGhpY3NDb250ZXgKIAogdm9pZCBUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbTo6c2V0 TWF0cml4KEdDM0R1aW50IGxvY2F0aW9uLCBjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0 cml4KQogewotICAgIEdDM0RmbG9hdCBtYXRyaXhBc0Zsb2F0c1tdID0gewotICAgICAgICBHQzNE ZmxvYXQobWF0cml4Lm0xMSgpKSwgR0MzRGZsb2F0KG1hdHJpeC5tMTIoKSksIEdDM0RmbG9hdCht YXRyaXgubTEzKCkpLCBHQzNEZmxvYXQobWF0cml4Lm0xNCgpKSwKLSAgICAgICAgR0MzRGZsb2F0 KG1hdHJpeC5tMjEoKSksIEdDM0RmbG9hdChtYXRyaXgubTIyKCkpLCBHQzNEZmxvYXQobWF0cml4 Lm0yMygpKSwgR0MzRGZsb2F0KG1hdHJpeC5tMjQoKSksCi0gICAgICAgIEdDM0RmbG9hdChtYXRy aXgubTMxKCkpLCBHQzNEZmxvYXQobWF0cml4Lm0zMigpKSwgR0MzRGZsb2F0KG1hdHJpeC5tMzMo KSksIEdDM0RmbG9hdChtYXRyaXgubTM0KCkpLAotICAgICAgICBHQzNEZmxvYXQobWF0cml4Lm00 MSgpKSwgR0MzRGZsb2F0KG1hdHJpeC5tNDIoKSksIEdDM0RmbG9hdChtYXRyaXgubTQzKCkpLCBH QzNEZmxvYXQobWF0cml4Lm00NCgpKQotICAgIH07Ci0KLSAgICBtX2NvbnRleHQtPnVuaWZvcm1N YXRyaXg0ZnYobG9jYXRpb24sIDEsIGZhbHNlLCBtYXRyaXhBc0Zsb2F0cyk7CisgICAgVHJhbnNm b3JtYXRpb25NYXRyaXg6OkZsb2F0TWF0cml4NCBmbG9hdE1hdHJpeDsKKyAgICBtYXRyaXgudG9D b2x1bW5NYWpvckZsb2F0QXJyYXkoZmxvYXRNYXRyaXgpOworICAgIG1fY29udGV4dC0+dW5pZm9y bU1hdHJpeDRmdihsb2NhdGlvbiwgMSwgZmFsc2UsIGZsb2F0TWF0cml4KTsKIH0KIAogR0MzRHVp bnQgVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW06OmdldExvY2F0aW9uKGNvbnN0IEF0b21pY1N0 cmluZyYgbmFtZSwgVmFyaWFibGVUeXBlIHR5cGUpCg==