15203 2007-09-13 09:07:49 -0700 [gtk] Don't use FcBool in backend code 2007-09-14 02:55:18 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) PC OS X 10.4 RESOLVED FIXED P2 Normal --- 0 sven webkit-unassigned richard oldest_to_newest 543 0 sven 2007-09-13 09:07:49 -0700 FcBool is only available if the system provides fontconfig. If webkit/gtk should be portable to other platforms (think of Gtk+/MacOS or GTK+/Win) fontconfig won't be available. Patch follows. 542 1 16278 sven 2007-09-13 09:12:56 -0700 Created attachment 16278 Proposed Patch 524 2 16278 aroben 2007-09-13 09:29:15 -0700 Comment on attachment 16278 Proposed Patch + static bool initialized = false; You don't need to initialize this variable to false (that will happen automatically as a result of it being declared static). Please leave the "Reviewed by NOBODY (OOPS!)." line that prepare-ChangeLog generates for you, as we have pre-commit hooks that prevent anyone from checking in an unreviewed change this way. r=me 525 3 16279 sven 2007-09-13 09:42:04 -0700 Created attachment 16279 Proposed Patch v2 526 4 16279 aroben 2007-09-13 09:50:44 -0700 Comment on attachment 16279 Proposed Patch v2 r=me. Thanks for the fixes! 491 5 mrowe 2007-09-14 02:55:18 -0700 Landed in r25561. 16278 2007-09-13 09:12:56 -0700 2007-09-13 09:42:04 -0700 Proposed Patch fix-15203.patch text/plain 1129 sven ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDI0ZjM2NC4uYjg5NzcwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAwNy0wOS0xMiAgU3ZlbiBIZXJ6YmVy ZyAgPHN2ZW5AaW1lbmRpby5jb20+CisKKyAgICAgICAgRG9uJ3QgdXNlIGZvbnRjb25maWcgdHlw ZXMgaWYgbmVjZXNzYXJ5LCBmaXhlczoKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUyMDMKKworICAgICAgICAqIHBsYXRmb3JtL2dkay9Gb250UGxhdGZv cm1EYXRhLmNwcDogZG9uJ3QgdXNlIGFuIEZjQm9vbCB0byBzdG9yZSB0aGUKKyAgICAgICAgaW5p dGlhbGl6ZWQgc3RhdGUsIHVzZSBhIHBsYWluIGMrKyBib29sIGluc3RlYWQKKwogMjAwNy0wOS0x MiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dkay9Gb250UGxhdGZvcm1EYXRh R2RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0Zm9ybURhdGFHZGsuY3BwCmlu ZGV4IGQ5OTY2M2QuLjRiOTRkODMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0Zv bnRQbGF0Zm9ybURhdGFHZGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0 Zm9ybURhdGFHZGsuY3BwCkBAIC0xMTUsMTAgKzExNSwxMCBAQCBmcmVlUGF0dGVybjoKIAogYm9v bCBGb250UGxhdGZvcm1EYXRhOjppbml0KCkKIHsKLSAgICBzdGF0aWMgRmNCb29sIEZDSW5pdGlh bGl6ZWQ7Ci0gICAgaWYgKEZDSW5pdGlhbGl6ZWQpCisgICAgc3RhdGljIGJvb2wgaW5pdGlhbGl6 ZWQgPSBmYWxzZTsKKyAgICBpZiAoaW5pdGlhbGl6ZWQpCiAgICAgICAgIHJldHVybiB0cnVlOwot ICAgIEZDSW5pdGlhbGl6ZWQgPSBGY1RydWU7CisgICAgaW5pdGlhbGl6ZWQgPSB0cnVlOwogICAg IGlmICghRmNJbml0KCkpIHsKICAgICAgICAgZnByaW50ZihzdGRlcnIsICJDYW4ndCBpbml0IGZv bnQgY29uZmlnIGxpYnJhcnlcbiIpOwogICAgICAgICByZXR1cm4gZmFsc2U7Cg== 16279 2007-09-13 09:42:04 -0700 2007-09-13 09:50:44 -0700 Proposed Patch v2 fix-15203.patch text/plain 1160 sven ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDI0ZjM2NC4uNGUxZTdiNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwNy0wOS0xMiAgU3ZlbiBIZXJ6YmVy ZyAgPHN2ZW5AaW1lbmRpby5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRG9uJ3QgdXNlIGZvbnRjb25maWcgdHlwZXMgaWYgbmVjZXNzYXJ5LCBm aXhlczoKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUy MDMKKworICAgICAgICAqIHBsYXRmb3JtL2dkay9Gb250UGxhdGZvcm1EYXRhLmNwcDogZG9uJ3Qg dXNlIGFuIEZjQm9vbCB0byBzdG9yZSB0aGUKKyAgICAgICAgaW5pdGlhbGl6ZWQgc3RhdGUsIHVz ZSBhIHBsYWluIGMrKyBib29sIGluc3RlYWQKKwogMjAwNy0wOS0xMiAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0uCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dkay9Gb250UGxhdGZvcm1EYXRhR2RrLmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vZ2RrL0ZvbnRQbGF0Zm9ybURhdGFHZGsuY3BwCmluZGV4IGQ5OTY2M2QuLmFkOGEy MjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0Zm9ybURhdGFHZGsu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ2RrL0ZvbnRQbGF0Zm9ybURhdGFHZGsuY3BwCkBA IC0xMTUsMTAgKzExNSwxMCBAQCBmcmVlUGF0dGVybjoKIAogYm9vbCBGb250UGxhdGZvcm1EYXRh Ojppbml0KCkKIHsKLSAgICBzdGF0aWMgRmNCb29sIEZDSW5pdGlhbGl6ZWQ7Ci0gICAgaWYgKEZD SW5pdGlhbGl6ZWQpCisgICAgc3RhdGljIGJvb2wgaW5pdGlhbGl6ZWQ7CisgICAgaWYgKGluaXRp YWxpemVkKQogICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBGQ0luaXRpYWxpemVkID0gRmNUcnVl OworICAgIGluaXRpYWxpemVkID0gdHJ1ZTsKICAgICBpZiAoIUZjSW5pdCgpKSB7CiAgICAgICAg IGZwcmludGYoc3RkZXJyLCAiQ2FuJ3QgaW5pdCBmb250IGNvbmZpZyBsaWJyYXJ5XG4iKTsKICAg ICAgICAgcmV0dXJuIGZhbHNlOwo=