152011 2015-12-08 12:34:54 -0800 DFG::UnificationPhase should merge isProfitableToUnbox, since this may have been set in ByteCodeParser 2015-12-08 13:46:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough benjamin commit-queue ggaren keith_miller mark.lam mhahnenb msaboff nrotem oliver saam sam oldest_to_newest 1147429 0 fpizlo 2015-12-08 12:34:54 -0800 Previously UnificationPhase did not merge this because we used to only set this in FixupPhase, which runs after unification. But now ByteCodeParser may set isProfitableToUnbox, so UnificationPhase needs to merge it after unifying. 1147432 1 266928 fpizlo 2015-12-08 12:37:00 -0800 Created attachment 266928 the patch 1147446 2 266928 msaboff 2015-12-08 13:18:17 -0800 Comment on attachment 266928 the patch r=me 1147456 3 fpizlo 2015-12-08 13:46:37 -0800 Landed in http://trac.webkit.org/changeset/193782 266928 2015-12-08 12:37:00 -0800 2015-12-08 13:18:17 -0800 the patch blah.patch text/plain 3047 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkzNzY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE1LTEyLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpVbmlmaWNhdGlvblBoYXNlIHNob3VsZCBtZXJnZSBpc1Byb2ZpdGFibGVUb1VuYm94LCBz aW5jZSB0aGlzIG1heSBoYXZlIGJlZW4gc2V0IGluIEJ5dGVDb2RlUGFyc2VyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIwMTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5IFVuaWZpY2F0 aW9uUGhhc2UgZGlkIG5vdCBtZXJnZSB0aGlzIGJlY2F1c2Ugd2UgdXNlZCB0byBvbmx5IHNldCB0 aGlzIGluIEZpeHVwUGhhc2UsIHdoaWNoIHJ1bnMgYWZ0ZXIgdW5pZmljYXRpb24uIEJ1dCBub3cK KyAgICAgICAgQnl0ZUNvZGVQYXJzZXIgbWF5IHNldCBpc1Byb2ZpdGFibGVUb1VuYm94IGFzIHBh cnQgb2YgaG93IGl0IGhhbmRsZXMgdGhlIEFyZ3VtZW50Q291bnQgb2YgYW4gaW5saW5lZCB2YXJh cmdzIGNhbGwsIHNvIFVuaWZpY2F0aW9uUGhhc2UKKyAgICAgICAgbmVlZHMgdG8gbWVyZ2UgaXQg YWZ0ZXIgdW5pZnlpbmcuCisKKyAgICAgICAgQWxzbyBjaGFuZ2VkIHRoZSBvcmRlciBvZiB1bmlm aWNhdGlvbiBzaW5jZSB0aGlzIG1ha2VzIHRoZSBidWcgbW9yZSBvYnZpb3VzIGFuZCBlYXNpZXIg dG8gdGVzdC4KKworICAgICAgICAqIGRmZy9ERkdVbmlmaWNhdGlvblBoYXNlLmNwcDoKKyAgICAg ICAgKEpTQzo6REZHOjpVbmlmaWNhdGlvblBoYXNlOjpydW4pOgorICAgICAgICAqIHRlc3RzL3N0 cmVzcy92YXJhcmdzLXdpdGgtdW51c2VkLWNvdW50LmpzOiBBZGRlZC4KKwogMjAxNS0xMi0wNSBB bGVrc2FuZHIgU2thY2hrb3YgICA8Z3NrYWNoa292QGdtYWlsLmNvbT4KIAogICAgICAgICBbRVM2 XSAic3VwZXIiIGFuZCAidGhpcyIgc2hvdWxkIGJlIGxleGljYWxseSBib3VuZCBpbnNpZGUgYW4g YXJyb3cgZnVuY3Rpb24gYW5kIHNob3VsZCBsaXZlIGluIGEgSlNMZXhpY2FsRW52aXJvbm1lbnQK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHVW5pZmljYXRpb25QaGFzZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdVbmlmaWNhdGlvblBo YXNlLmNwcAkocmV2aXNpb24gMTkzNzYxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdVbmlmaWNhdGlvblBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjAsOCArNjAsNyBAQCBw dWJsaWM6CiAgICAgICAgICAgICAgICAgICAgIGlmICghcGhpLT5jaGlsZHJlbi5jaGlsZChjaGls ZElkeCkpCiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAg ICAgCi0gICAgICAgICAgICAgICAgICAgIHBoaS0+dmFyaWFibGVBY2Nlc3NEYXRhKCktPnVuaWZ5 KAotICAgICAgICAgICAgICAgICAgICAgICAgcGhpLT5jaGlsZHJlbi5jaGlsZChjaGlsZElkeCkt PnZhcmlhYmxlQWNjZXNzRGF0YSgpKTsKKyAgICAgICAgICAgICAgICAgICAgcGhpLT5jaGlsZHJl bi5jaGlsZChjaGlsZElkeCktPnZhcmlhYmxlQWNjZXNzRGF0YSgpLT51bmlmeShwaGktPnZhcmlh YmxlQWNjZXNzRGF0YSgpKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KQEAgLTc0LDYgKzczLDcgQEAgcHVibGljOgogICAgICAgICAgICAgZGF0YS0+ZmluZCgp LT5tZXJnZUNoZWNrQXJyYXlIb2lzdGluZ0ZhaWxlZChkYXRhLT5jaGVja0FycmF5SG9pc3RpbmdG YWlsZWQoKSk7CiAgICAgICAgICAgICBkYXRhLT5maW5kKCktPm1lcmdlU2hvdWxkTmV2ZXJVbmJv eChkYXRhLT5zaG91bGROZXZlclVuYm94KCkpOwogICAgICAgICAgICAgZGF0YS0+ZmluZCgpLT5t ZXJnZUlzTG9hZGVkRnJvbShkYXRhLT5pc0xvYWRlZEZyb20oKSk7CisgICAgICAgICAgICBkYXRh LT5maW5kKCktPm1lcmdlSXNQcm9maXRhYmxlVG9VbmJveChkYXRhLT5pc1Byb2ZpdGFibGVUb1Vu Ym94KCkpOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBtX2dyYXBoLm1fdW5pZmljYXRp b25TdGF0ZSA9IEdsb2JhbGx5VW5pZmllZDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90 ZXN0cy9zdHJlc3MvdmFyYXJncy13aXRoLXVudXNlZC1jb3VudC5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3ZhcmFyZ3Mtd2l0aC11bnVzZWQtY291 bnQuanMJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNz L3ZhcmFyZ3Mtd2l0aC11bnVzZWQtY291bnQuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwy MyBAQAorZnVuY3Rpb24gZm9vKHAsIHEsIHIpIHsKKyAgICB3aGlsZSAocikgeworICAgICAgICBp ZiAocCkKKyAgICAgICAgICAgIHJldHVybiAxOworICAgICAgICBlbHNlIGlmIChwKQorICAgICAg ICAgICAgcmV0dXJuIDI7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRocm93ICJlcnJvciI7 CisgICAgfQorfQorCitmdW5jdGlvbiBiYXIoKSB7CisgICAgZm9vLmFwcGx5KHRoaXMsIGFyZ3Vt ZW50cyk7Cit9CisKK2Z1bmN0aW9uIGJheihhLCBiLCBjLCBkKSB7CisgICAgYmFyKGEsIGIsIGMs IGQpOworfQorCitub0lubGluZShiYXopOworCitmb3IgKHZhciBpID0gMDsgaSA8IDEwMDAwOyAr K2kpCisgICAgYmF6KDEsIDIsIDMsIDQpOwo=