151996 2015-12-08 09:59:07 -0800 [iOS] Adopt WebFullScreenVideoRootViewController. 2015-12-08 11:15:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue mitz oldest_to_newest 1147328 0 jer.noble 2015-12-08 09:59:07 -0800 [iOS] Adopt WebFullScreenVideoRootViewController. 1147332 1 266902 jer.noble 2015-12-08 10:03:26 -0800 Created attachment 266902 Patch 1147333 2 commit-queue 2015-12-08 10:04:54 -0800 Attachment 266902 did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:84: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:94: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1147336 3 266902 mitz 2015-12-08 10:09:11 -0800 Comment on attachment 266902 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266902&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:83 > +#if __has_include(<WebKitAdditions/WebFullScreenVideoRootViewController.m>) Instead of checking for the presence of the header, you should check for __IPHONE_OS_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK). 1147338 4 mitz 2015-12-08 10:13:59 -0800 (In reply to comment #3) > Instead of checking for the presence of the header, you should check for > __IPHONE_OS_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK). Sorry, ignore the __IPHONE_OS_VERSION_MIN_REQUIRED part! Just check for USE(APPLE_INTERNAL_SDK). 1147348 5 266907 jer.noble 2015-12-08 10:28:06 -0800 Created attachment 266907 Patch for landing 1147372 6 commit-queue 2015-12-08 11:09:51 -0800 Attachment 266907 did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:84: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:94: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1147373 7 jer.noble 2015-12-08 11:11:29 -0800 Committed r193760: <http://trac.webkit.org/changeset/193760> 266902 2015-12-08 10:03:26 -0800 2015-12-08 10:09:11 -0800 Patch bug-151996-20151208100256.patch text/plain 3248 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAwMTgyMjlkZjBlMzhm MWQ3MDhmNjc5NWZiNGEyMGEyMDYxNjIyNS4uZDZmZjJjZjJiMDMzM2RjYTBhMDllMDQ1MzkyNjQx NGFmOTg1MGY4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFkb3B0IFdlYkZ1 bGxTY3JlZW5WaWRlb1Jvb3RWaWV3Q29udHJvbGxlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTk5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkb3B0IFdlYkZ1bGxTY3JlZW5WaWRlb1Jvb3RWaWV3 Q29udHJvbGxlciBmcm9tIFdlYktpdEFkZGl0aW9ucy4gSWYgaXQgaXMgbm90IGF2YWlsYWJsZSwg Y3JlYXRlIGFuZCB1c2UKKyAgICAgICAgYSBnZW5lcmljIFVJVmlld0NvbnRyb2xsZXIgc3ViY2xh c3MuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl QVZLaXQubW06CisgICAgICAgIChjcmVhdGVGdWxsU2NyZWVuVmlkZW9Sb290Vmlld0NvbnRyb2xs ZXJDbGFzcyk6CisgICAgICAgIChhbGxvY1dlYkZ1bGxTY3JlZW5WaWRlb1Jvb3RWaWV3Q29udHJv bGxlckluc3RhbmNlKToKKyAgICAgICAgKFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0 OjpzZXR1cEZ1bGxzY3JlZW4pOgorCiAyMDE1LTEyLTA0ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIERvIG5vdCBleGl0IGZ1bGxzY3JlZW4gbW9kZSBk dXJpbmcgYXV0by1QaVAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mv V2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KaW5kZXggZjI0Y2Yy YmI5ZDUxZDRiOTE2ZDkwYjM5MmU4ZjRmZmY3MWJkMzk5NC4uNjY1MzE4ZTQ3MWI3NzZlOTUwMzli ZmE3ZmU1Njc2MDI0MjhmZDk4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQpAQCAt ODAsNiArODAsMzIgQEAgc3RhdGljIGNvbnN0IGNoYXIqIGJvb2xTdHJpbmcoYm9vbCB2YWwpCiB9 CiAjZW5kaWYKIAorI2lmIF9faGFzX2luY2x1ZGUoPFdlYktpdEFkZGl0aW9ucy9XZWJGdWxsU2Ny ZWVuVmlkZW9Sb290Vmlld0NvbnRyb2xsZXIubT4pCisjaW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMv V2ViRnVsbFNjcmVlblZpZGVvUm9vdFZpZXdDb250cm9sbGVyLm0+CisjZWxzZQorQGludGVyZmFj ZSBXZWJGdWxsU2NyZWVuVmlkZW9Sb290Vmlld0NvbnRyb2xsZXIgOiBVSVZpZXdDb250cm9sbGVy CistIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhTb3VyY2VXaW5kb3c6KFVJV2luZG93ICopc291cmNl V2luZG93OworQGVuZAorCitzdGF0aWMgQ2xhc3MgY3JlYXRlRnVsbFNjcmVlblZpZGVvUm9vdFZp ZXdDb250cm9sbGVyQ2xhc3MoKQoreworICAgIENsYXNzIG5ld0NsYXNzID0gb2JqY19hbGxvY2F0 ZUNsYXNzUGFpcihnZXRVSVZpZXdDb250cm9sbGVyQ2xhc3MoKSwgIldlYkZ1bGxTY3JlZW5WaWRl b1Jvb3RWaWV3Q29udHJvbGxlciIsIDApOworCisgICAgY2xhc3NfYWRkTWV0aG9kKG5ld0NsYXNz LCBAc2VsZWN0b3IoaW5pdFdpdGhTb3VyY2VXaW5kb3c6KSwgaW1wX2ltcGxlbWVudGF0aW9uV2l0 aEJsb2NrKF4oaWQgc2VsZiwgVUlXaW5kb3cqKXsKKyAgICAgICAgcmV0dXJuIFtzZWxmIGluaXRd OworICAgIH0pLCAiQEA6QCIpOworCisgICAgb2JqY19yZWdpc3RlckNsYXNzUGFpcihuZXdDbGFz cyk7CisgICAgcmV0dXJuIG5ld0NsYXNzOworfQorCitzdGF0aWMgV2ViRnVsbFNjcmVlblZpZGVv Um9vdFZpZXdDb250cm9sbGVyICphbGxvY1dlYkZ1bGxTY3JlZW5WaWRlb1Jvb3RWaWV3Q29udHJv bGxlckluc3RhbmNlKCkKK3sKKyAgICBzdGF0aWMgQ2xhc3MgZnVsbFNjcmVlblZpZGVvUm9vdFZp ZXdDb250cm9sbGVyQ2xhc3MgPSBjcmVhdGVGdWxsU2NyZWVuVmlkZW9Sb290Vmlld0NvbnRyb2xs ZXJDbGFzcygpOworICAgIHJldHVybiBbZnVsbFNjcmVlblZpZGVvUm9vdFZpZXdDb250cm9sbGVy Q2xhc3MgYWxsb2NdOworfQorI2VuZGlmCisKIHN0YXRpYyBjb25zdCBkb3VibGUgRGVmYXVsdFdh dGNoZG9nVGltZXJJbnRlcnZhbCA9IDE7CiAKIEBjbGFzcyBXZWJBVk1lZGlhU2VsZWN0aW9uT3B0 aW9uOwpAQCAtMTA5Niw3ICsxMTIyLDcgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZh Y2VBVktpdDo6c2V0dXBGdWxsc2NyZWVuKFVJVmlldyYgdmlkZW9WaWV3LCBjb25zdAogICAgICAg ICAgICAgbV93aW5kb3cgPSBhZG9wdE5TKFthbGxvY1VJV2luZG93SW5zdGFuY2UoKSBpbml0V2l0 aEZyYW1lOltbZ2V0VUlTY3JlZW5DbGFzcygpIG1haW5TY3JlZW5dIGJvdW5kc11dKTsKICAgICAg ICAgW21fd2luZG93IHNldEJhY2tncm91bmRDb2xvcjpbZ2V0VUlDb2xvckNsYXNzKCkgY2xlYXJD b2xvcl1dOwogICAgICAgICBpZiAoIW1fdmlld0NvbnRyb2xsZXIpCi0gICAgICAgICAgICBtX3Zp ZXdDb250cm9sbGVyID0gYWRvcHROUyhbYWxsb2NVSVZpZXdDb250cm9sbGVySW5zdGFuY2UoKSBp bml0XSk7CisgICAgICAgICAgICBtX3ZpZXdDb250cm9sbGVyID0gYWRvcHROUyhbYWxsb2NXZWJG dWxsU2NyZWVuVmlkZW9Sb290Vmlld0NvbnRyb2xsZXJJbnN0YW5jZSgpIGluaXRXaXRoU291cmNl V2luZG93OltwYXJlbnRWaWV3IHdpbmRvd11dKTsKICAgICAgICAgW1ttX3ZpZXdDb250cm9sbGVy IHZpZXddIHNldEZyYW1lOlttX3dpbmRvdyBib3VuZHNdXTsKICAgICAgICAgW21fdmlld0NvbnRy b2xsZXIgX3NldElnbm9yZUFwcFN1cHBvcnRlZE9yaWVudGF0aW9uczpZRVNdOwogICAgICAgICBb bV93aW5kb3cgc2V0Um9vdFZpZXdDb250cm9sbGVyOm1fdmlld0NvbnRyb2xsZXIuZ2V0KCldOwo= 266907 2015-12-08 10:28:06 -0800 2015-12-08 11:15:16 -0800 Patch for landing bug-151996-20151208102737.patch text/plain 3199 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAwMTgyMjlkZjBlMzhm MWQ3MDhmNjc5NWZiNGEyMGEyMDYxNjIyNS4uMDVmNTBjYTYzYTNhMmUwN2NjYmJkY2IyMDNmMzYz ZDdhM2ViMTY2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFkb3B0IFdlYkZ1 bGxTY3JlZW5WaWRlb1Jvb3RWaWV3Q29udHJvbGxlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTk5NgorCisgICAgICAgIFJldmlld2VkIGJ5IERh biBCZXJuc3RlaW4uCisKKyAgICAgICAgQWRvcHQgV2ViRnVsbFNjcmVlblZpZGVvUm9vdFZpZXdD b250cm9sbGVyIGZyb20gV2ViS2l0QWRkaXRpb25zLiBJZiBpdCBpcyBub3QgYXZhaWxhYmxlLCBj cmVhdGUgYW5kIHVzZQorICAgICAgICBhIGdlbmVyaWMgVUlWaWV3Q29udHJvbGxlciBzdWJjbGFz cy4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdC5tbToKKyAgICAgICAgKGNyZWF0ZUZ1bGxTY3JlZW5WaWRlb1Jvb3RWaWV3Q29udHJvbGxl ckNsYXNzKToKKyAgICAgICAgKGFsbG9jV2ViRnVsbFNjcmVlblZpZGVvUm9vdFZpZXdDb250cm9s bGVySW5zdGFuY2UpOgorICAgICAgICAoV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OnNldHVwRnVsbHNjcmVlbik6CisKIDIwMTUtMTItMDQgIEplciBOb2JsZSAgPGplci5ub2JsZUBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gRG8gbm90IGV4aXQgZnVsbHNjcmVlbiBtb2RlIGR1 cmluZyBhdXRvLVBpUC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9X ZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQppbmRleCBmMjRjZjJi YjlkNTFkNGI5MTZkOTBiMzkyZThmNGZmZjcxYmQzOTk0Li5kMjQ5NjUyNGI5NDlhYWFjZGU0NTY4 YzhiZWVlMmE1MjQ1YmIxMTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p b3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCkBAIC04 MCw2ICs4MCwzMiBAQCBzdGF0aWMgY29uc3QgY2hhciogYm9vbFN0cmluZyhib29sIHZhbCkKIH0K ICNlbmRpZgogCisjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKKyNpbXBvcnQgPFdlYktpdEFk ZGl0aW9ucy9XZWJGdWxsU2NyZWVuVmlkZW9Sb290Vmlld0NvbnRyb2xsZXIubT4KKyNlbHNlCitA aW50ZXJmYWNlIFdlYkZ1bGxTY3JlZW5WaWRlb1Jvb3RWaWV3Q29udHJvbGxlciA6IFVJVmlld0Nv bnRyb2xsZXIKKy0gKGluc3RhbmNldHlwZSlpbml0V2l0aFNvdXJjZVdpbmRvdzooVUlXaW5kb3cg Kilzb3VyY2VXaW5kb3c7CitAZW5kCisKK3N0YXRpYyBDbGFzcyBjcmVhdGVGdWxsU2NyZWVuVmlk ZW9Sb290Vmlld0NvbnRyb2xsZXJDbGFzcygpCit7CisgICAgQ2xhc3MgbmV3Q2xhc3MgPSBvYmpj X2FsbG9jYXRlQ2xhc3NQYWlyKGdldFVJVmlld0NvbnRyb2xsZXJDbGFzcygpLCAiV2ViRnVsbFNj cmVlblZpZGVvUm9vdFZpZXdDb250cm9sbGVyIiwgMCk7CisKKyAgICBjbGFzc19hZGRNZXRob2Qo bmV3Q2xhc3MsIEBzZWxlY3Rvcihpbml0V2l0aFNvdXJjZVdpbmRvdzopLCBpbXBfaW1wbGVtZW50 YXRpb25XaXRoQmxvY2soXihpZCBzZWxmLCBVSVdpbmRvdyopeworICAgICAgICByZXR1cm4gW3Nl bGYgaW5pdF07CisgICAgfSksICJAQDpAIik7CisKKyAgICBvYmpjX3JlZ2lzdGVyQ2xhc3NQYWly KG5ld0NsYXNzKTsKKyAgICByZXR1cm4gbmV3Q2xhc3M7Cit9CisKK3N0YXRpYyBXZWJGdWxsU2Ny ZWVuVmlkZW9Sb290Vmlld0NvbnRyb2xsZXIgKmFsbG9jV2ViRnVsbFNjcmVlblZpZGVvUm9vdFZp ZXdDb250cm9sbGVySW5zdGFuY2UoKQoreworICAgIHN0YXRpYyBDbGFzcyBmdWxsU2NyZWVuVmlk ZW9Sb290Vmlld0NvbnRyb2xsZXJDbGFzcyA9IGNyZWF0ZUZ1bGxTY3JlZW5WaWRlb1Jvb3RWaWV3 Q29udHJvbGxlckNsYXNzKCk7CisgICAgcmV0dXJuIFtmdWxsU2NyZWVuVmlkZW9Sb290Vmlld0Nv bnRyb2xsZXJDbGFzcyBhbGxvY107Cit9CisjZW5kaWYKKwogc3RhdGljIGNvbnN0IGRvdWJsZSBE ZWZhdWx0V2F0Y2hkb2dUaW1lckludGVydmFsID0gMTsKIAogQGNsYXNzIFdlYkFWTWVkaWFTZWxl Y3Rpb25PcHRpb247CkBAIC0xMDk2LDcgKzExMjIsNyBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVl bkludGVyZmFjZUFWS2l0OjpzZXR1cEZ1bGxzY3JlZW4oVUlWaWV3JiB2aWRlb1ZpZXcsIGNvbnN0 CiAgICAgICAgICAgICBtX3dpbmRvdyA9IGFkb3B0TlMoW2FsbG9jVUlXaW5kb3dJbnN0YW5jZSgp IGluaXRXaXRoRnJhbWU6W1tnZXRVSVNjcmVlbkNsYXNzKCkgbWFpblNjcmVlbl0gYm91bmRzXV0p OwogICAgICAgICBbbV93aW5kb3cgc2V0QmFja2dyb3VuZENvbG9yOltnZXRVSUNvbG9yQ2xhc3Mo KSBjbGVhckNvbG9yXV07CiAgICAgICAgIGlmICghbV92aWV3Q29udHJvbGxlcikKLSAgICAgICAg ICAgIG1fdmlld0NvbnRyb2xsZXIgPSBhZG9wdE5TKFthbGxvY1VJVmlld0NvbnRyb2xsZXJJbnN0 YW5jZSgpIGluaXRdKTsKKyAgICAgICAgICAgIG1fdmlld0NvbnRyb2xsZXIgPSBhZG9wdE5TKFth bGxvY1dlYkZ1bGxTY3JlZW5WaWRlb1Jvb3RWaWV3Q29udHJvbGxlckluc3RhbmNlKCkgaW5pdFdp dGhTb3VyY2VXaW5kb3c6W3BhcmVudFZpZXcgd2luZG93XV0pOwogICAgICAgICBbW21fdmlld0Nv bnRyb2xsZXIgdmlld10gc2V0RnJhbWU6W21fd2luZG93IGJvdW5kc11dOwogICAgICAgICBbbV92 aWV3Q29udHJvbGxlciBfc2V0SWdub3JlQXBwU3VwcG9ydGVkT3JpZW50YXRpb25zOllFU107CiAg ICAgICAgIFttX3dpbmRvdyBzZXRSb290Vmlld0NvbnRyb2xsZXI6bV92aWV3Q29udHJvbGxlci5n ZXQoKV07Cg==