151994 2015-12-08 08:53:29 -0800 Light cleanup in TextPainter. 2015-12-08 13:35:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan mmaxfield simon.fraser oldest_to_newest 1147296 0 zalan 2015-12-08 08:53:29 -0800 SSIA. 1147302 1 266894 zalan 2015-12-08 09:04:12 -0800 Created attachment 266894 Patch 1147303 2 commit-queue 2015-12-08 09:05:00 -0800 Attachment 266894 did not pass style-queue: ERROR: Source/WebCore/rendering/TextPainter.cpp:86: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:86: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:87: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:88: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:89: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:90: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:91: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:92: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:93: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:94: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:95: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:96: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:97: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:98: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:99: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:100: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:101: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:102: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/TextPainter.cpp:103: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 19 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1147451 3 zalan 2015-12-08 13:35:39 -0800 Committed r193779: <http://trac.webkit.org/changeset/193779> 266894 2015-12-08 09:04:12 -0800 2015-12-08 13:35:54 -0800 Patch bug-151994-20151208090345.patch text/plain 6366 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM2OTY2MGExNjQ0MDE3 NzdhMjk2MWE4NDRkMWQ1YmI2ZDM0NzJmYy4uZDU0ZTgxMWFjZjE0MzM2ZTliMzUxNzQ2ZGI4MzQ2 NzdlZmQwN2QyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGlnaHQgY2xlYW51cCBpbiBU ZXh0UGFpbnRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1MTk5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVuZGVyaW5nL1Rl eHRQYWludGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRQYWludGVyOjpUZXh0UGFpbnRl cik6CisgICAgICAgICogcmVuZGVyaW5nL1RleHRQYWludGVyLmg6IEFkZHJlc3MgcG9zdCByZXZp ZXcgY29tbWVudC4KKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd0FwcGxpZXI6OmlzTGFzdFNoYWRv d0l0ZXJhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpTaGFkb3dBcHBsaWVyOjpzaGFkb3dJc0Nv bXBsZXRlbHlDb3ZlcmVkQnlUZXh0KToKKwogMjAxNS0xMi0wNyAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgcGFpbnRUZXh0V2l0aFNoYWRvd3MgYSBtZW1i ZXIgZnVuY3Rpb24gKFRleHRQYWludGVyKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9UZXh0UGFpbnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dFBh aW50ZXIuY3BwCmluZGV4IDVkNDlmZmYwYzFlYjJiMmNiOTY5NjI3NTI1ODU2ZTVjNDFlM2IwNjUu LjY4MjlmNzY0OGI1Njg2MzYxMGMzMzVkMzViYzRlZjAxMDA5MTFhYzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcApAQCAtMzEsMzEgKzMxLDYgQEAKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCi1UZXh0UGFpbnRlcjo6VGV4dFBhaW50ZXIoR3JhcGhpY3NDb250ZXh0 JiBjb250ZXh0LCBib29sIHBhaW50U2VsZWN0ZWRUZXh0T25seSwgYm9vbCBwYWludFNlbGVjdGVk VGV4dFNlcGFyYXRlbHksIGNvbnN0IEZvbnRDYXNjYWRlJiBmb250LAotICAgIGludCBzdGFydFBv c2l0aW9uSW5UZXh0UnVuLCBpbnQgZW5kUG9zaXRpb25JblRleHRCb3hTdHJpbmcsIGludCBsZW5n dGgsIGNvbnN0IEF0b21pY1N0cmluZyYgZW1waGFzaXNNYXJrLCBSZW5kZXJDb21iaW5lVGV4dCog Y29tYmluZWRUZXh0LCBUZXh0UnVuJiB0ZXh0UnVuLAotICAgIEZsb2F0UmVjdCYgYm94UmVjdCwg RmxvYXRQb2ludCYgdGV4dE9yaWdpbiwgaW50IGVtcGhhc2lzTWFya09mZnNldCwgY29uc3QgU2hh ZG93RGF0YSogdGV4dFNoYWRvdywgY29uc3QgU2hhZG93RGF0YSogc2VsZWN0aW9uU2hhZG93LAot ICAgIGJvb2wgdGV4dEJveElzSG9yaXpvbnRhbCwgVGV4dFBhaW50U3R5bGUmIHRleHRQYWludFN0 eWxlLCBUZXh0UGFpbnRTdHlsZSYgc2VsZWN0aW9uUGFpbnRTdHlsZSkKLSAgICAgICAgOiBtX2Nv bnRleHQoY29udGV4dCkKLSAgICAgICAgLCBtX3RleHRQYWludFN0eWxlKHRleHRQYWludFN0eWxl KQotICAgICAgICAsIG1fc2VsZWN0aW9uUGFpbnRTdHlsZShzZWxlY3Rpb25QYWludFN0eWxlKQot ICAgICAgICAsIG1fdGV4dFNoYWRvdyh0ZXh0U2hhZG93KQotICAgICAgICAsIG1fc2VsZWN0aW9u U2hhZG93KHNlbGVjdGlvblNoYWRvdykKLSAgICAgICAgLCBtX3BhaW50U2VsZWN0ZWRUZXh0T25s eShwYWludFNlbGVjdGVkVGV4dE9ubHkpCi0gICAgICAgICwgbV9wYWludFNlbGVjdGVkVGV4dFNl cGFyYXRlbHkocGFpbnRTZWxlY3RlZFRleHRTZXBhcmF0ZWx5KQotICAgICAgICAsIG1fZm9udChm b250KQotICAgICAgICAsIG1fc3RhcnRQb3NpdGlvbkluVGV4dFJ1bihzdGFydFBvc2l0aW9uSW5U ZXh0UnVuKQotICAgICAgICAsIG1fZW5kUG9zaXRpb25JblRleHRSdW4oZW5kUG9zaXRpb25JblRl eHRCb3hTdHJpbmcpCi0gICAgICAgICwgbV9sZW5ndGgobGVuZ3RoKQotICAgICAgICAsIG1fZW1w aGFzaXNNYXJrKGVtcGhhc2lzTWFyaykKLSAgICAgICAgLCBtX2NvbWJpbmVkVGV4dChjb21iaW5l ZFRleHQpCi0gICAgICAgICwgbV90ZXh0UnVuKHRleHRSdW4pCi0gICAgICAgICwgbV9ib3hSZWN0 KGJveFJlY3QpCi0gICAgICAgICwgbV90ZXh0T3JpZ2luKHRleHRPcmlnaW4pCi0gICAgICAgICwg bV9lbXBoYXNpc01hcmtPZmZzZXQoZW1waGFzaXNNYXJrT2Zmc2V0KQotICAgICAgICAsIG1fdGV4 dEJveElzSG9yaXpvbnRhbCh0ZXh0Qm94SXNIb3Jpem9udGFsKQotewotfQotCiBTaGFkb3dBcHBs aWVyOjpTaGFkb3dBcHBsaWVyKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgU2hhZG93 RGF0YSogc2hhZG93LCBjb25zdCBGbG9hdFJlY3QmIHRleHRSZWN0LCBib29sIGxhc3RTaGFkb3dJ dGVyYXRpb25TaG91bGREcmF3VGV4dCwgYm9vbCBvcGFxdWUsIEZvbnRPcmllbnRhdGlvbiBvcmll bnRhdGlvbikKICAgICA6IG1fY29udGV4dChjb250ZXh0KQogICAgICwgbV9zaGFkb3coc2hhZG93 KQpAQCAtMTA0LDYgKzc5LDMxIEBAIFNoYWRvd0FwcGxpZXI6On5TaGFkb3dBcHBsaWVyKCkKICAg ICAgICAgbV9jb250ZXh0LmNsZWFyU2hhZG93KCk7CiB9CiAKK1RleHRQYWludGVyOjpUZXh0UGFp bnRlcihHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGJvb2wgcGFpbnRTZWxlY3RlZFRleHRPbmx5 LCBib29sIHBhaW50U2VsZWN0ZWRUZXh0U2VwYXJhdGVseSwgY29uc3QgRm9udENhc2NhZGUmIGZv bnQsIGludCBzdGFydFBvc2l0aW9uSW5UZXh0UnVuLAorICAgIGludCBlbmRQb3NpdGlvbkluVGV4 dEJveFN0cmluZywgaW50IGxlbmd0aCwgY29uc3QgQXRvbWljU3RyaW5nJiBlbXBoYXNpc01hcmss IFJlbmRlckNvbWJpbmVUZXh0KiBjb21iaW5lZFRleHQsIFRleHRSdW4mIHRleHRSdW4sIEZsb2F0 UmVjdCYgYm94UmVjdCwKKyAgICBGbG9hdFBvaW50JiB0ZXh0T3JpZ2luLCBpbnQgZW1waGFzaXNN YXJrT2Zmc2V0LCBjb25zdCBTaGFkb3dEYXRhKiB0ZXh0U2hhZG93LCBjb25zdCBTaGFkb3dEYXRh KiBzZWxlY3Rpb25TaGFkb3csIGJvb2wgdGV4dEJveElzSG9yaXpvbnRhbCwKKyAgICBUZXh0UGFp bnRTdHlsZSYgdGV4dFBhaW50U3R5bGUsIFRleHRQYWludFN0eWxlJiBzZWxlY3Rpb25QYWludFN0 eWxlKQorICAgIDogbV9jb250ZXh0KGNvbnRleHQpCisgICAgLCBtX3RleHRQYWludFN0eWxlKHRl eHRQYWludFN0eWxlKQorICAgICwgbV9zZWxlY3Rpb25QYWludFN0eWxlKHNlbGVjdGlvblBhaW50 U3R5bGUpCisgICAgLCBtX3RleHRTaGFkb3codGV4dFNoYWRvdykKKyAgICAsIG1fc2VsZWN0aW9u U2hhZG93KHNlbGVjdGlvblNoYWRvdykKKyAgICAsIG1fcGFpbnRTZWxlY3RlZFRleHRPbmx5KHBh aW50U2VsZWN0ZWRUZXh0T25seSkKKyAgICAsIG1fcGFpbnRTZWxlY3RlZFRleHRTZXBhcmF0ZWx5 KHBhaW50U2VsZWN0ZWRUZXh0U2VwYXJhdGVseSkKKyAgICAsIG1fZm9udChmb250KQorICAgICwg bV9zdGFydFBvc2l0aW9uSW5UZXh0UnVuKHN0YXJ0UG9zaXRpb25JblRleHRSdW4pCisgICAgLCBt X2VuZFBvc2l0aW9uSW5UZXh0UnVuKGVuZFBvc2l0aW9uSW5UZXh0Qm94U3RyaW5nKQorICAgICwg bV9sZW5ndGgobGVuZ3RoKQorICAgICwgbV9lbXBoYXNpc01hcmsoZW1waGFzaXNNYXJrKQorICAg ICwgbV9jb21iaW5lZFRleHQoY29tYmluZWRUZXh0KQorICAgICwgbV90ZXh0UnVuKHRleHRSdW4p CisgICAgLCBtX2JveFJlY3QoYm94UmVjdCkKKyAgICAsIG1fdGV4dE9yaWdpbih0ZXh0T3JpZ2lu KQorICAgICwgbV9lbXBoYXNpc01hcmtPZmZzZXQoZW1waGFzaXNNYXJrT2Zmc2V0KQorICAgICwg bV90ZXh0Qm94SXNIb3Jpem9udGFsKHRleHRCb3hJc0hvcml6b250YWwpCit7Cit9CisKIHZvaWQg VGV4dFBhaW50ZXI6OmRyYXdUZXh0T3JFbXBoYXNpc01hcmtzKGNvbnN0IEZvbnRDYXNjYWRlJiBm b250LCBjb25zdCBUZXh0UnVuJiB0ZXh0UnVuLCBjb25zdCBBdG9taWNTdHJpbmcmIGVtcGhhc2lz TWFyaywKICAgICBpbnQgZW1waGFzaXNNYXJrT2Zmc2V0LCBjb25zdCBGbG9hdFBvaW50JiB0ZXh0 T3JpZ2luLCBpbnQgc3RhcnRPZmZzZXQsIGludCBlbmRPZmZzZXQpCiB7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dFBhaW50ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9UZXh0UGFpbnRlci5oCmluZGV4IDNhZDY5YTQ5ZmVjODA0YzYxODU5NWUxZWFkNDY5 NjIyZDRlMDViYzAuLmRiNGU5ZmM0NmYxZWJiMGU4MWYwNzA2NjM2ODdlM2Q3OTZjOGUyMWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5oCkBAIC01MCw4ICs1MCw5IEBAIHB1 YmxpYzoKICAgICBib29sIHRleHRCb3hJc0hvcml6b250YWwsIFRleHRQYWludFN0eWxlJiBub25T ZWxlY3Rpb25QYWludFN0eWxlLCBUZXh0UGFpbnRTdHlsZSYgc2VsZWN0aW9uUGFpbnRTdHlsZSk7 CiAgICAgCiAgICAgdm9pZCBwYWludFRleHQoKTsKLQorI2lmIEVOQUJMRShDU1MzX1RFWFRfREVD T1JBVElPTl9TS0lQX0lOSykKICAgICBEYXNoQXJyYXkgZGFzaGVzRm9ySW50ZXJzZWN0aW9uc1dp dGhSZWN0KGNvbnN0IEZsb2F0UmVjdCYgbGluZUV4dGVudHMpOworI2VuZGlmCiAKIHByaXZhdGU6 CiAgICAgdm9pZCBkcmF3VGV4dE9yRW1waGFzaXNNYXJrcyhjb25zdCBGb250Q2FzY2FkZSYsIGNv bnN0IFRleHRSdW4mLCBjb25zdCBBdG9taWNTdHJpbmcmIGVtcGhhc2lzTWFyaywgaW50IGVtcGhh c2lzTWFya09mZnNldCwKQEAgLTYxLDcgKzYyLDYgQEAgcHJpdmF0ZToKICAgICB2b2lkIHBhaW50 VGV4dFdpdGhTdHlsZShjb25zdCBUZXh0UGFpbnRTdHlsZSYsIGludCBzdGFydE9mZnNldCwgaW50 IGVuZE9mZnNldCwgY29uc3QgU2hhZG93RGF0YSopOwogICAgIHZvaWQgcGFpbnRFbXBoYXNpc01h cmtzSWZOZWVkZWQoaW50IHN0YXJ0T2Zmc2V0LCBpbnQgZW5kT2Zmc2V0LCBjb25zdCBUZXh0UGFp bnRTdHlsZSYsIGNvbnN0IFNoYWRvd0RhdGEqKTsKIAotcHJpdmF0ZToKICAgICBHcmFwaGljc0Nv bnRleHQmIG1fY29udGV4dDsKICAgICBUZXh0UGFpbnRTdHlsZSYgbV90ZXh0UGFpbnRTdHlsZTsK ICAgICBUZXh0UGFpbnRTdHlsZSYgbV9zZWxlY3Rpb25QYWludFN0eWxlOwpAQCAtOTEsMTUgKzkx LDggQEAgcHVibGljOgogICAgIH5TaGFkb3dBcHBsaWVyKCk7CiAKIHByaXZhdGU6Ci0gICAgYm9v bCBpc0xhc3RTaGFkb3dJdGVyYXRpb24oKQotICAgIHsKLSAgICAgICAgcmV0dXJuIG1fc2hhZG93 ICYmICFtX3NoYWRvdy0+bmV4dCgpOwotICAgIH0KLQotICAgIGJvb2wgc2hhZG93SXNDb21wbGV0 ZWx5Q292ZXJlZEJ5VGV4dChib29sIHRleHRJc09wYXF1ZSkKLSAgICB7Ci0gICAgICAgIHJldHVy biB0ZXh0SXNPcGFxdWUgJiYgbV9zaGFkb3cgJiYgbV9zaGFkb3ctPmxvY2F0aW9uKCkgPT0gSW50 UG9pbnQoKSAmJiAhbV9zaGFkb3ctPnJhZGl1cygpOwotICAgIH0KKyAgICBib29sIGlzTGFzdFNo YWRvd0l0ZXJhdGlvbigpOworICAgIGJvb2wgc2hhZG93SXNDb21wbGV0ZWx5Q292ZXJlZEJ5VGV4 dChib29sIHRleHRJc09wYXF1ZSk7CiAKICAgICBGbG9hdFNpemUgbV9leHRyYU9mZnNldDsKICAg ICBHcmFwaGljc0NvbnRleHQmIG1fY29udGV4dDsKQEAgLTExMCw2ICsxMDMsMTYgQEAgcHJpdmF0 ZToKICAgICBib29sIG1fZGlkU2F2ZUNvbnRleHQgOiAxOwogfTsKIAoraW5saW5lIGJvb2wgU2hh ZG93QXBwbGllcjo6aXNMYXN0U2hhZG93SXRlcmF0aW9uKCkKK3sKKyAgICByZXR1cm4gbV9zaGFk b3cgJiYgIW1fc2hhZG93LT5uZXh0KCk7Cit9CisKK2lubGluZSBib29sIFNoYWRvd0FwcGxpZXI6 OnNoYWRvd0lzQ29tcGxldGVseUNvdmVyZWRCeVRleHQoYm9vbCB0ZXh0SXNPcGFxdWUpCit7Cisg ICAgcmV0dXJuIHRleHRJc09wYXF1ZSAmJiBtX3NoYWRvdyAmJiBtX3NoYWRvdy0+bG9jYXRpb24o KSA9PSBJbnRQb2ludCgpICYmICFtX3NoYWRvdy0+cmFkaXVzKCk7Cit9CisKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIFRleHRQYWludGVyX2gK