151967 2015-12-07 15:27:24 -0800 Add support for WebViewAdditions 2015-12-07 15:51:25 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue enrica mitz sam thorton oldest_to_newest 1147042 0 bdakin 2015-12-07 15:27:24 -0800 Add support for WebViewAdditions rdar://problem/23639610 1147043 1 266819 bdakin 2015-12-07 15:28:39 -0800 Created attachment 266819 Patch 1147044 2 commit-queue 2015-12-07 15:29:48 -0800 Attachment 266819 did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebViewData.h:176: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1147052 3 bdakin 2015-12-07 15:51:25 -0800 Thanks Sam! http://trac.webkit.org/changeset/193661 266819 2015-12-07 15:28:39 -0800 2015-12-07 15:29:40 -0800 Patch for-review.txt text/plain 3824 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MzY1OSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTA3 ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc3VwcG9ydCBm b3IgV2ViVmlld0FkZGl0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUxOTY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQubW06CisgICAgICAg IChXZWJFZGl0b3JDbGllbnQ6OnJlc3BvbmRUb0NoYW5nZWRTZWxlY3Rpb24pOgorICAgICAgICAq IFdlYlZpZXcvV2ViVmlldy5tbToKKyAgICAgICAgKC1bV2ViVmlldyBfY29tbW9uSW5pdGlhbGl6 YXRpb25XaXRoRnJhbWVOYW1lOmdyb3VwTmFtZTpdKToKKyAgICAgICAgKC1bV2ViVmlldyB1cGRh dGVXZWJWaWV3QWRkaXRpb25zXSk6CisgICAgICAgICogV2ViVmlldy9XZWJWaWV3RGF0YS5oOgor ICAgICAgICAqIFdlYlZpZXcvV2ViVmlld0ludGVybmFsLmg6CisKIDIwMTUtMTItMDcgIEJldGgg RGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEhvb2sgdXAgcmVxdWVzdCBhbmQg c2hvdyBmb3IgdHlwaW5nIGNhbmRpZGF0ZXMgaW4gV0sxCkluZGV4OiBTb3VyY2UvV2ViS2l0L21h Yy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50Lm1tCShyZXZpc2lvbiAx OTM2NDUpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGll bnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTM1MCw4ICszNTAsMTAgQEAgdm9pZCBXZWJFZGl0b3JD bGllbnQ6OnJlc3BvbmRUb0NoYW5nZWRDbwogdm9pZCBXZWJFZGl0b3JDbGllbnQ6OnJlc3BvbmRU b0NoYW5nZWRTZWxlY3Rpb24oRnJhbWUqIGZyYW1lKQogewogICAgIE5TVmlldzxXZWJEb2N1bWVu dFZpZXc+ICpkb2N1bWVudFZpZXcgPSBbW2tpdChmcmFtZSkgZnJhbWVWaWV3XSBkb2N1bWVudFZp ZXddOwotICAgIGlmIChbZG9jdW1lbnRWaWV3IGlzS2luZE9mQ2xhc3M6W1dlYkhUTUxWaWV3IGNs YXNzXV0pCisgICAgaWYgKFtkb2N1bWVudFZpZXcgaXNLaW5kT2ZDbGFzczpbV2ViSFRNTFZpZXcg Y2xhc3NdXSkgewogICAgICAgICBbKFdlYkhUTUxWaWV3ICopZG9jdW1lbnRWaWV3IF9zZWxlY3Rp b25DaGFuZ2VkXTsKKyAgICAgICAgW21fd2ViVmlldyB1cGRhdGVXZWJWaWV3QWRkaXRpb25zXTsK KyAgICB9CiAKICNpZiAhUExBVEZPUk0oSU9TKQogICAgIC8vIEZJWE1FOiBUaGlzIHF1aXJrIGlz IG5lZWRlZCBkdWUgdG8gPHJkYXI6Ly9wcm9ibGVtLzUwMDk2MjU+IC0gV2UgY2FuIHBoYXNlIGl0 IG91dCBvbmNlIEFwZXJ0dXJlIGNhbiBhZG9wdCB0aGUgbmV3IGJlaGF2aW9yIG9uIHRoZWlyIGVu ZApJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24gMTkzNjQw KQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC05MTEsNiArOTExLDggQEAgLSAodm9pZClfY29tbW9uSW5pdGlhbGl6YXRpb25XaXRoRnJh bWVOYQogICAgIH0KICNlbmRpZgogCisgICAgW3NlbGYgdXBkYXRlV2ViVmlld0FkZGl0aW9uc107 CisKICNpZiAhUExBVEZPUk0oSU9TKQogICAgIHN0YXRpYyBib29sIGRpZE9uZVRpbWVJbml0aWFs aXphdGlvbiA9IGZhbHNlOwogI2VuZGlmCkBAIC02NTk3LDYgKzY1OTksMTggQEAgLSAoQk9PTCl2 YWxpZGF0ZVVzZXJJbnRlcmZhY2VJdGVtOihpZCA8TgogCiBAZW5kCiAKKyNpZiBQTEFURk9STShN QUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMjAwICYmIFVTRShB UFBMRV9JTlRFUk5BTF9TREspCisjaW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMvV2ViVmlld0FkZGl0 aW9ucy5tbT4KKyNlbHNlCitAaW1wbGVtZW50YXRpb24gV2ViVmlldyAoVXBkYXRlV2ViVmlld0Fk ZGl0aW9ucykKKworLSAodm9pZCl1cGRhdGVXZWJWaWV3QWRkaXRpb25zCit7Cit9CisKK0BlbmQK KyNlbmRpZiAvLyBQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTAxMjAwICYmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCisKIEBpbXBsZW1lbnRhdGlv biBXZWJWaWV3IChXZWJQZW5kaW5nUHVibGljKQogCiAjaWYgIVBMQVRGT1JNKElPUykKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXdEYXRhLmgJKHJldmlzaW9uIDE5MzY0MCkK KysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEuaAkod29ya2luZyBjb3B5 KQpAQCAtMTcxLDYgKzE3MSwxMSBAQCBAaW50ZXJmYWNlIFdlYlZpZXdQcml2YXRlIDogTlNPYmpl Y3QgewogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMDAwCiAgICAg V2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlciAqaW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlcjsK ICNlbmRpZiAvLyBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTAwMAorCisj aWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEw MTIwMCAmJiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQorICAgICNpbXBvcnQgPFdlYktpdEFkZGl0 aW9ucy9XZWJWaWV3RGF0YUFkZGl0aW9ucy5oPgorI2VuZGlmCisKICAgICBzdGQ6OnVuaXF1ZV9w dHI8V2ViQ29yZTo6VGV4dEluZGljYXRvcldpbmRvdz4gdGV4dEluZGljYXRvcldpbmRvdzsKICAg ICBCT09MIGhhc0luaXRpYWxpemVkTG9va3VwT2JzZXJ2ZXI7CiAgICAgUmV0YWluUHRyPFdlYldp bmRvd1Zpc2liaWxpdHlPYnNlcnZlcj4gd2luZG93VmlzaWJpbGl0eU9ic2VydmVyOwpJbmRleDog U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3SW50ZXJuYWwuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXdJbnRlcm5hbC5oCShyZXZpc2lvbiAx OTM2NDApCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXdJbnRlcm5hbC5oCSh3 b3JraW5nIGNvcHkpCkBAIC0yOTAsMyArMjkwLDcgQEAgQGludGVyZmFjZSBXZWJWaWV3IChXZWJW aWV3T3RoZXJJbnRlcm5hbAogI2VuZGlmCiAKIEBlbmQKKworQGludGVyZmFjZSBXZWJWaWV3IChV cGRhdGVXZWJWaWV3QWRkaXRpb25zKQorLSAodm9pZCl1cGRhdGVXZWJWaWV3QWRkaXRpb25zOwor QGVuZAo=