<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>151944</bug_id>
          
          <creation_ts>2015-12-07 09:16:57 -0800</creation_ts>
          <short_desc>Rename Watchdog::didFire to Watchdog::shouldTerminate because that&apos;s what didFire really meant</short_desc>
          <delta_ts>2015-12-07 10:31:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Java</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1146866</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2015-12-07 09:16:57 -0800</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1146867</commentid>
    <comment_count>1</comment_count>
      <attachid>266779</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2015-12-07 09:18:44 -0800</bug_when>
    <thetext>Created attachment 266779
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1146870</commentid>
    <comment_count>2</comment_count>
      <attachid>266779</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2015-12-07 09:20:40 -0800</bug_when>
    <thetext>Comment on attachment 266779
patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1146894</commentid>
    <comment_count>3</comment_count>
      <attachid>266779</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-12-07 10:31:10 -0800</bug_when>
    <thetext>Comment on attachment 266779
patch

Clearing flags on attachment: 266779

Committed r193636: &lt;http://trac.webkit.org/changeset/193636&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1146895</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-12-07 10:31:13 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>266779</attachid>
            <date>2015-12-07 09:18:44 -0800</date>
            <delta_ts>2015-12-07 10:31:10 -0800</delta_ts>
            <desc>patch</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>3797</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkzNjMwKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA
CisyMDE1LTEyLTA3ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IFJlbmFtZSBXYXRjaGRvZzo6ZGlkRmlyZSB0byBXYXRjaGRvZzo6c2hvdWxkVGVybWluYXRlIGJl
Y2F1c2UgdGhhdCdzIHdoYXQgZGlkRmlyZSByZWFsbHkgbWVhbnQKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTk0NAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIu
Y3BwOgorICAgICAgICAoSlNDOjpJbnRlcnByZXRlcjo6ZXhlY3V0ZSk6CisgICAgICAgICogcnVu
dGltZS9WTUlubGluZXMuaDoKKyAgICAgICAgKEpTQzo6Vk06OnNob3VsZFRyaWdnZXJUZXJtaW5h
dGlvbik6CisgICAgICAgICogcnVudGltZS9XYXRjaGRvZy5jcHA6CisgICAgICAgIChKU0M6Oldh
dGNoZG9nOjp0ZXJtaW5hdGVTb29uKToKKyAgICAgICAgKEpTQzo6V2F0Y2hkb2c6OnNob3VsZFRl
cm1pbmF0ZVNsb3cpOgorICAgICAgICAoSlNDOjpXYXRjaGRvZzo6ZGlkRmlyZVNsb3cpOiBEZWxl
dGVkLgorICAgICAgICAqIHJ1bnRpbWUvV2F0Y2hkb2cuaDoKKyAgICAgICAgKEpTQzo6V2F0Y2hk
b2c6OnNob3VsZFRlcm1pbmF0ZSk6CisgICAgICAgIChKU0M6OldhdGNoZG9nOjpkaWRGaXJlKTog
RGVsZXRlZC4KKwogMjAxNS0xMi0wNyAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtp
dC5vcmc+CiAKICAgICAgICAgW0VGTF0gSW1wbGVtZW50IHNjaGVkdWxlVGltZXIgYW5kIGNhbmNl
bFRpbWVyIGluIEluY3JlbWVudGFsU3dlZXBlciBjbGFzcwpJbmRleDogU291cmNlL0phdmFTY3Jp
cHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCShyZXZpc2lvbiAxOTM2
MjkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3Bw
CSh3b3JraW5nIGNvcHkpCkBAIC0xMzA0LDcgKzEzMDQsNyBAQCBKU1ZhbHVlIEludGVycHJldGVy
OjpleGVjdXRlKE1vZHVsZVByb2dyCiAgICAgICAgIHJldHVybiBjaGVja2VkUmV0dXJuKGNhbGxG
cmFtZS0+dm0oKS50aHJvd0V4Y2VwdGlvbihjYWxsRnJhbWUsIGNvbXBpbGVFcnJvcikpOwogICAg
IE1vZHVsZVByb2dyYW1Db2RlQmxvY2sqIGNvZGVCbG9jayA9IGV4ZWN1dGFibGUtPmNvZGVCbG9j
aygpOwogCi0gICAgaWYgKFVOTElLRUxZKHZtLndhdGNoZG9nICYmIHZtLndhdGNoZG9nLT5kaWRG
aXJlKGNhbGxGcmFtZSkpKQorICAgIGlmIChVTkxJS0VMWSh2bS5zaG91bGRUcmlnZ2VyVGVybWlu
YXRpb24oY2FsbEZyYW1lKSkpCiAgICAgICAgIHJldHVybiB0aHJvd1Rlcm1pbmF0ZWRFeGVjdXRp
b25FeGNlcHRpb24oY2FsbEZyYW1lKTsKIAogICAgIEFTU0VSVChjb2RlQmxvY2stPm51bVBhcmFt
ZXRlcnMoKSA9PSAxKTsgLy8gMSBwYXJhbWV0ZXIgZm9yICd0aGlzJy4KSW5kZXg6IFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNSW5saW5lcy5oCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNSW5saW5lcy5oCShyZXZpc2lvbiAxOTM2MjkpCisrKyBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTUlubGluZXMuaAkod29ya2luZyBjb3B5KQpA
QCAtMzUsNyArMzUsNyBAQCBib29sIFZNOjpzaG91bGRUcmlnZ2VyVGVybWluYXRpb24oRXhlY1N0
CiB7CiAgICAgaWYgKCF3YXRjaGRvZykKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIHJldHVy
biB3YXRjaGRvZy0+ZGlkRmlyZShleGVjKTsKKyAgICByZXR1cm4gd2F0Y2hkb2ctPnNob3VsZFRl
cm1pbmF0ZShleGVjKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgSlNDCkluZGV4OiBTb3VyY2UvSmF2
YVNjcmlwdENvcmUvcnVudGltZS9XYXRjaGRvZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph
dmFTY3JpcHRDb3JlL3J1bnRpbWUvV2F0Y2hkb2cuY3BwCShyZXZpc2lvbiAxOTM2MjkpCisrKyBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XYXRjaGRvZy5jcHAJKHdvcmtpbmcgY29weSkK
QEAgLTgzLDcgKzgzLDcgQEAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBXYXRjaGRvZzo6dGVybWlu
YQogICAgIG1fdGltZXJEaWRGaXJlID0gdHJ1ZTsKIH0KIAotYm9vbCBXYXRjaGRvZzo6ZGlkRmly
ZVNsb3coRXhlY1N0YXRlKiBleGVjKQorYm9vbCBXYXRjaGRvZzo6c2hvdWxkVGVybWluYXRlU2xv
dyhFeGVjU3RhdGUqIGV4ZWMpCiB7CiAgICAgewogICAgICAgICBMb2NrSG9sZGVyIGxvY2tlciht
X2xvY2spOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2F0Y2hkb2cuaAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XYXRjaGRvZy5oCShy
ZXZpc2lvbiAxOTM2MjkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XYXRjaGRv
Zy5oCSh3b3JraW5nIGNvcHkpCkBAIC00NywxMSArNDcsMTEgQEAgcHVibGljOgogICAgIHZvaWQg
c2V0VGltZUxpbWl0KHN0ZDo6Y2hyb25vOjptaWNyb3NlY29uZHMgbGltaXQsIFNob3VsZFRlcm1p
bmF0ZUNhbGxiYWNrID0gMCwgdm9pZCogZGF0YTEgPSAwLCB2b2lkKiBkYXRhMiA9IDApOwogICAg
IEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgdGVybWluYXRlU29vbigpOwogCi0gICAgYm9vbCBkaWRG
aXJlKEV4ZWNTdGF0ZSogZXhlYykKKyAgICBib29sIHNob3VsZFRlcm1pbmF0ZShFeGVjU3RhdGUq
IGV4ZWMpCiAgICAgewogICAgICAgICBpZiAoIW1fdGltZXJEaWRGaXJlKQogICAgICAgICAgICAg
cmV0dXJuIGZhbHNlOwotICAgICAgICByZXR1cm4gZGlkRmlyZVNsb3coZXhlYyk7CisgICAgICAg
IHJldHVybiBzaG91bGRUZXJtaW5hdGVTbG93KGV4ZWMpOwogICAgIH0KIAogICAgIGJvb2wgaGFz
VGltZUxpbWl0KCk7CkBAIC02Niw3ICs2Niw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBzdGFydFRp
bWVyKExvY2tIb2xkZXImLCBzdGQ6OmNocm9ubzo6bWljcm9zZWNvbmRzIHRpbWVMaW1pdCk7CiAg
ICAgdm9pZCBzdG9wVGltZXIoTG9ja0hvbGRlciYpOwogCi0gICAgYm9vbCBkaWRGaXJlU2xvdyhF
eGVjU3RhdGUqKTsKKyAgICBib29sIHNob3VsZFRlcm1pbmF0ZVNsb3coRXhlY1N0YXRlKik7CiAK
ICAgICAvLyBtX3RpbWVyRGlkRmlyZSBpbmRpY2F0ZXMgd2hldGhlciB0aGUgdGltZXIgZmlyZWQu
IFRoZSBXYXRjaGRvZwogICAgIC8vIHN0aWxsIG5lZWRzIHRvIGNoZWNrIGlmIHRoZSBhbGxvd2Vk
IENQVSB0aW1lIGhhcyBlbGFwc2VkLiBJZiBzbywgdGhlbgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>