151934 2015-12-07 02:17:25 -0800 [EFL] MiniBrowser doesn't exit when called ewk_view_try_close() 2015-12-07 03:46:51 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue gyuyoung.kim lucas.de.marchi ossy oldest_to_newest 1146787 0 ryuan.choi 2015-12-07 02:17:25 -0800 Bug 151567 reported the regression of r192053(In fact, it's the regression since r192528) It's because tryClose() returned immediately without calling close callback when the page does not have onbeforeunload callback since r192528. 1146800 1 266761 ryuan.choi 2015-12-07 02:44:03 -0800 Created attachment 266761 Patch 1146803 2 266761 ossy 2015-12-07 02:51:38 -0800 Comment on attachment 266761 Patch rs=me 1146820 3 266761 commit-queue 2015-12-07 03:46:47 -0800 Comment on attachment 266761 Patch Clearing flags on attachment: 266761 Committed r193619: <http://trac.webkit.org/changeset/193619> 1146821 4 commit-queue 2015-12-07 03:46:51 -0800 All reviewed patches have been landed. Closing bug. 266761 2015-12-07 02:44:03 -0800 2015-12-07 03:46:47 -0800 Patch bug-151934-20151207194334.patch text/plain 3754 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDgzNmQxMWE2NWI4NTRm NjcxZTI5MGRjODY1NGM3YjVhZTJmMmVjZC4uYjg3YTcxY2Y4NWYzY2Y1MGM0OTdkNDkzNGEwZDJh ZGEwZWIzMzRkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTEyLTA3ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIE1pbmlC cm93c2VyIGRvZXNuJ3QgZXhpdCB3aGVuIGNhbGxlZCBld2tfdmlld190cnlfY2xvc2UoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxOTM0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld190cnlfY2xvc2UpOgorICAg ICAgICBDYWxsZWQgd2luZG93X2Nsb3NlIGNhbGxiYWNrIGltbWVkaWF0ZWx5IHdoZW4gV0tQYWdl VHJ5Q2xvc2UgcmV0dXJucyB0cnVlLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3Rz L3Rlc3RfZXdrMl92aWV3LmNwcDoKKyAgICAgICAgKFRFU1RfRik6IEltcHJvdmVkIHRlc3QgY2Fz ZXMgZm9yIHRyeV9jbG9zZSB0byB0ZXN0IHdoZW4gY29udGVudCBkb2VzIG5vdCBjb250YWluCisg ICAgICAgIG9uYmVmb3JldW5sb2FkIGNhbGxiYWNrLgorCiAyMDE1LTEyLTA3ICBKYWVodW4gTGlt ICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gTW92aW5nIHByZWZl cmVuY2Ugc2V0dGluZ3MgZnJvbSBFd2tWaWV3IHRvIFdlYlByZWZlcmVuY2VzRWZsCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKaW5kZXggMmI5ZTk4MDc3 MGQ2NGQzYzU3MWQ5MmUzNGY3NWM3Mjc2OTI0MzBlMy4uOTFlNmFmMDhhNDU3OWRkZjVlMDM5NDg3 ZTc1Yjg3ZTgzMTlhZjhlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcApAQCAtMTU1LDcgKzE1NSw4IEBAIHZvaWQgZXdrX3ZpZXdfdHJ5X2Nsb3Nl KEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVS Tihld2tWaWV3LCBpbXBsKTsKIAotICAgIFdLUGFnZVRyeUNsb3NlKGltcGwtPndrUGFnZSgpKTsK KyAgICBpZiAoV0tQYWdlVHJ5Q2xvc2UoaW1wbC0+d2tQYWdlKCkpKQorICAgICAgICBpbXBsLT5j bG9zZSgpOwogfQogCiBFd2tfQ29udGV4dCogZXdrX3ZpZXdfY29udGV4dF9nZXQoY29uc3QgRXZh c19PYmplY3QqIGV3a1ZpZXcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKaW5kZXggNTMxZDhhNjQ3OTczNmQ2 NDdhZGZhNWQ2NjgxMmZlMGYyN2Y1ZGQ5My4uMTIzNGJmZTI2YzY1MzRmZDgyNmM1NjY3NjA0ZTQ4 NTNkZjQzYjVhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv dGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcApAQCAtMjg5LDYgKzI4OSwxNCBAQCBURVNU X0YoRVdLMlZpZXdUZXN0LCBld2tfdmlld190cnlfY2xvc2UpCiAKICAgICBld2tfdmlld190cnlf Y2xvc2Uod2ViVmlldygpKTsKICAgICBBU1NFUlRfVFJVRSh3YWl0VW50aWxUcnVlKHdpbmRvd0Ns b3NlQ2FsbGJhY2tDYWxsZWQpKTsKKworICAgIHdpbmRvd0Nsb3NlQ2FsbGJhY2tDYWxsZWQgPSBm YWxzZTsKKyAgICBjb25zdCBjaGFyIGNvbnRlbnRXaXRob3V0QmVmb3JlVW5sb2FkW10gPSAiPCFk b2N0eXBlIGh0bWw+PGJvZHk+bm8gY2FsbGJhY2tzIGZvciBiZWZvcmV1bmxvYWQ8L2JvZHk+IjsK KyAgICBld2tfdmlld19odG1sX3N0cmluZ19sb2FkKHdlYlZpZXcoKSwgY29udGVudFdpdGhvdXRC ZWZvcmVVbmxvYWQsIDAsIDApOworICAgIEFTU0VSVF9UUlVFKHdhaXRVbnRpbExvYWRGaW5pc2hl ZCgpKTsKKworICAgIGV3a192aWV3X3RyeV9jbG9zZSh3ZWJWaWV3KCkpOworICAgIEFTU0VSVF9U UlVFKHdhaXRVbnRpbFRydWUod2luZG93Q2xvc2VDYWxsYmFja0NhbGxlZCkpOwogfQogCiBURVNU X0YoRVdLMlZpZXdUZXN0LCBld2tfdmlld191cmxfZ2V0KQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDgwODRlNDJjN2JkOWE2Mjk2NTgzMjMxNzFi MDJmNjYyY2E5OWMwM2EuLmU5Zjg0Mjk0NmM0MjA3OTJlZGE0MTc5NDkxZDI5YWRmMTE5OTUzNTYg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0xMi0wNyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAbmF2ZXJjb3Jw LmNvbT4KKworICAgICAgICBbRUZMXSBNaW5pQnJvd3NlciBkb2Vzbid0IGV4aXQgd2hlbiBjYWxs ZWQgZXdrX3ZpZXdfdHJ5X2Nsb3NlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1MTkzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKG9uX3dp bmRvd19kZWxldGlvbik6IFJldmVydCB0aGUgY2hhbmdlcyBvZiByMTkyNzY3LgorCiAyMDE1LTEy LTA2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgVGVzdE5l dHNjYXBlUGx1Z0luOiBGaXggbGVha3MgZm91bmQgYnkgc3RhdGljIGFuYWx5emVyCmRpZmYgLS1n aXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZs L21haW4uYwppbmRleCA3ZmE0NWUyZWE5ZjhmOTZlMzJhNzVhMTBkYzNiZTYxMzc4MDAzN2NiLi4x NjAzMWQ0NmZjNzczZTQ4ODExNThlOWQ0NDIwNGFhM2E0MmYyNmI3IDEwMDY0NAotLS0gYS9Ub29s cy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWlu LmMKQEAgLTIwMzcsNyArMjAzNyw4IEBAIG9uX2hvbWVfYnV0dG9uX2NsaWNrZWQodm9pZCAqdXNl cl9kYXRhLCBFdmFzX09iamVjdCAqaG9tZV9idXR0b24sIHZvaWQgKmV2ZW50X2luCiBzdGF0aWMg dm9pZAogb25fd2luZG93X2RlbGV0aW9uKHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKmVs bV93aW5kb3csIHZvaWQgKmV2ZW50X2luZm8pCiB7Ci0gICAgd2luZG93X2Nsb3NlKHdpbmRvd19m aW5kX3dpdGhfZWxtX3dpbmRvdyhlbG1fd2luZG93KSk7CisgICAgQnJvd3Nlcl9XaW5kb3cgKndp bmRvdyA9IChCcm93c2VyX1dpbmRvdyAqKXVzZXJfZGF0YTsKKyAgICBld2tfdmlld190cnlfY2xv c2Uod2luZG93LT5ld2tfdmlldyk7CiB9CiAKIHN0YXRpYyBFdmFzX09iamVjdCAqCg==