151924 2015-12-06 14:46:29 -0800 Web Inspector: Regression (r192936) - changing selectors in the visual styles sidebar is broken 2015-12-07 17:01:38 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1146701 0 hi 2015-12-06 14:46:29 -0800 Looks like one of the older WebInspector.TreeOutline.prototype.onselect was left behind during the transition in: https://bugs.webkit.org/show_bug.cgi?id=148067 1146702 1 webkit-bug-importer 2015-12-06 14:47:12 -0800 <rdar://problem/23777298> 1146705 2 266738 hi 2015-12-06 14:55:00 -0800 Created attachment 266738 Patch 1146764 3 266738 bburg 2015-12-06 22:59:46 -0800 Comment on attachment 266738 Patch r=me 1146765 4 266738 commit-queue 2015-12-06 23:45:45 -0800 Comment on attachment 266738 Patch Clearing flags on attachment: 266738 Committed r193615: <http://trac.webkit.org/changeset/193615> 1146766 5 commit-queue 2015-12-06 23:45:47 -0800 All reviewed patches have been landed. Closing bug. 1147114 6 266738 joepeck 2015-12-07 17:01:38 -0800 Comment on attachment 266738 Patch Nice find and fix! 266738 2015-12-06 14:55:00 -0800 2015-12-06 23:45:45 -0800 Patch bug-151924-20151206145433.patch text/plain 2320 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUxOWExOWI0M2E5OGI4ZTZhNjgzNTEzYjRiYzhl YWMxYjU1NmM0N2MuLjhkYTczZmY3MWU5ZDAwNTI2Y2NiYjRhN2EzMzRlMTQ0YTFkY2IxMzEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTA2ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFJlZ3Jlc3Npb24gKHIxOTI5MzYpIC0gY2hhbmdpbmcgc2VsZWN0b3JzIGluIHRoZSB2 aXN1YWwgc3R5bGVzIHNpZGViYXIgaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE5MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVT ZWxlY3RvclNlY3Rpb24uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVTZWxl Y3RvclNlY3Rpb24pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxlU2VsZWN0b3JT ZWN0aW9uLnByb3RvdHlwZS5fc2VsZWN0b3JDaGFuZ2VkKToKKyAgICAgICAgTm93IHVzZXMgYW4g ZXZlbnQgbGlzdGVuZXIgaW5zdGVhZCBvZiBhbiAib25zZWxlY3QiIGZ1bmN0aW9uLgorCiAyMDE1 LTEyLTA0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTkzNDg2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVTZWxlY3RvclNlY3Rp b24uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxT dHlsZVNlbGVjdG9yU2VjdGlvbi5qcwppbmRleCA4ZDFjNDU2NDRiMmE2OWE4NmNhOWNlNDllMmI0 MzkyMmRhNmFkY2MxLi42YzY0ZDdhNDM2YjllNmEzYWZiZjM1YzUwNTgxYmZiM2M5M2Y3Yzc1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1 YWxTdHlsZVNlbGVjdG9yU2VjdGlvbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVNlbGVjdG9yU2VjdGlvbi5qcwpAQCAtNTUsNyAr NTUsOCBAQCBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVTZWxlY3RvclNlY3Rpb24gPSBjbGFzcyBW aXN1YWxTdHlsZVNlbGVjdG9yU2VjdGlvbiBleHRlbgogICAgICAgICBzZWxlY3RvclNlY3Rpb24u ZWxlbWVudC5hcHBlbmRDaGlsZChzZWxlY3Rvckxpc3RFbGVtZW50KTsKIAogICAgICAgICB0aGlz Ll9zZWxlY3RvcnMgPSBuZXcgV2ViSW5zcGVjdG9yLlRyZWVPdXRsaW5lKHNlbGVjdG9yTGlzdEVs ZW1lbnQpOwotICAgICAgICB0aGlzLl9zZWxlY3RvcnMub25zZWxlY3QgPSB0aGlzLl9zZWxlY3Rv ckNoYW5nZWQuYmluZCh0aGlzKTsKKyAgICAgICAgdGhpcy5fc2VsZWN0b3JzLmFkZEV2ZW50TGlz dGVuZXIoV2ViSW5zcGVjdG9yLlRyZWVPdXRsaW5lLkV2ZW50LlNlbGVjdGlvbkRpZENoYW5nZSwg dGhpcy5fc2VsZWN0b3JDaGFuZ2VkLCB0aGlzKTsKKwogICAgICAgICB0aGlzLl9mb2N1c05leHRO ZXdJbnNwZWN0b3JSdWxlID0gZmFsc2U7CiAKICAgICAgICAgbGV0IGFkZEdseXBoRWxlbWVudCA9 IHVzZVNWR1N5bWJvbCgiSW1hZ2VzL1BsdXMxMy5zdmciLCAidmlzdWFsLXN0eWxlLXNlbGVjdG9y LXNlY3Rpb24tYWRkLXJ1bGUiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNsaWNrIHRvIGFkZCBh IG5ldyBydWxlLiIpKTsKQEAgLTIwOSw5ICsyMTAsOSBAQCBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5 bGVTZWxlY3RvclNlY3Rpb24gPSBjbGFzcyBWaXN1YWxTdHlsZVNlbGVjdG9yU2VjdGlvbiBleHRl bgogCiAgICAgLy8gUHJpdmF0ZQogCi0gICAgX3NlbGVjdG9yQ2hhbmdlZChzZWxlY3RlZFRyZWVF bGVtZW50KQorICAgIF9zZWxlY3RvckNoYW5nZWQoZXZlbnQpCiAgICAgewotICAgICAgICBjb25z b2xlLmFzc2VydChzZWxlY3RlZFRyZWVFbGVtZW50KTsKKyAgICAgICAgbGV0IHNlbGVjdGVkVHJl ZUVsZW1lbnQgPSBldmVudC5kYXRhLnNlbGVjdGVkRWxlbWVudDsKICAgICAgICAgaWYgKCFzZWxl Y3RlZFRyZWVFbGVtZW50KQogICAgICAgICAgICAgcmV0dXJuOwogCg==