151896 2015-12-04 17:08:40 -0800 Web Inspector: Uncaught Exception with Reload shortcut in JSContext Inspector 2015-12-04 19:20:58 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1146503 0 joepeck 2015-12-04 17:08:40 -0800 * SUMMARY Uncaught Exception with Reload shortcut in JSContext Inspector * STEPS TO REPRODUCE 1. Open JSContext Inspector 2. Cmd+R => Uncaught exception * NOTES We should just not do anything if there is no PageAgent. 1146504 1 webkit-bug-importer 2015-12-04 17:09:07 -0800 <rdar://problem/23770400> 1146506 2 266687 joepeck 2015-12-04 17:12:26 -0800 Created attachment 266687 [PATCH] Proposed Fix 1146554 3 266687 commit-queue 2015-12-04 19:20:54 -0800 Comment on attachment 266687 [PATCH] Proposed Fix Clearing flags on attachment: 266687 Committed r193507: <http://trac.webkit.org/changeset/193507> 1146555 4 commit-queue 2015-12-04 19:20:58 -0800 All reviewed patches have been landed. Closing bug. 266687 2015-12-04 17:12:26 -0800 2015-12-04 19:20:54 -0800 [PATCH] Proposed Fix reloads.patch text/plain 2845 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA2ODVlNWEuLjBiMWU1ZjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTEyLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9uIHdpdGggUmVsb2FkIHNob3J0Y3V0IGluIEpTQ29udGV4dCBJbnNwZWN0b3IK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTg5Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuY29udGVudExvYWRl ZCk6CisgICAgICAgIERvIG5vdCBpbXBsaWNpdGx5IHByZXZlbnQgZGVmYXVsdCBvbiB0aGVzZSBr ZXlib2FyZCBzaG9ydGN1dHMKKyAgICAgICAgc28gd2UgY2FuIHN5c3RlbSBiZWVwIGlmIHdlIGRv IG5vdCBkbyBhbnl0aGluZy4KKworICAgICAgICAoV2ViSW5zcGVjdG9yLl9yZWxvYWRQYWdlKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5fcmVsb2FkUGFnZUlnbm9yaW5nQ2FjaGUpOgorICAgICAg ICBCYWlsIGlmIHRoZXJlIGlzIG5vIFBhZ2VBZ2VudCB3aXRob3V0IHByZXZlbnRpbmcgZGVmYXVs dCBmb3IKKyAgICAgICAgYSBiZWVwIHN5c3RlbSBiZWVwLiBQcmV2ZW50IGRlZmF1bHQgaWYgd2Ug ZGlkIHNvbWV0aGluZy4KKwogMjAxNS0xMi0wNCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBzdXBwb3J0IHJ1bnRpbWUgcmVnaXN0cmF0aW9u IG9mIHRhYiB0eXBlIGFzc29jaWF0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDkyM2I4YTEuLjAwN2YwZTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTI2 OCw2ICsyNjgsNyBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKIAog ICAgIHRoaXMuX3JlbG9hZFBhZ2VLZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5L ZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNv bW1hbmRPckNvbnRyb2wsICJSIiwgdGhpcy5fcmVsb2FkUGFnZS5iaW5kKHRoaXMpKTsKICAgICB0 aGlzLl9yZWxvYWRQYWdlSWdub3JpbmdDYWNoZUtleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2ViSW5z cGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9k aWZpZXIuQ29tbWFuZE9yQ29udHJvbCB8IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1v ZGlmaWVyLlNoaWZ0LCAiUiIsIHRoaXMuX3JlbG9hZFBhZ2VJZ25vcmluZ0NhY2hlLmJpbmQodGhp cykpOworICAgIHRoaXMuX3JlbG9hZFBhZ2VLZXlib2FyZFNob3J0Y3V0LmltcGxpY2l0bHlQcmV2 ZW50c0RlZmF1bHQgPSB0aGlzLl9yZWxvYWRQYWdlSWdub3JpbmdDYWNoZUtleWJvYXJkU2hvcnRj dXQgPSBmYWxzZTsKIAogICAgIHRoaXMuX2NvbnNvbGVUYWJLZXlib2FyZFNob3J0Y3V0ID0gbmV3 IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0Lk1vZGlmaWVyLk9wdGlvbiB8IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlm aWVyLkNvbW1hbmRPckNvbnRyb2wsICJDIiwgdGhpcy5fc2hvd0NvbnNvbGVUYWIuYmluZCh0aGlz KSk7CiAgICAgdGhpcy5fcXVpY2tDb25zb2xlS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2Rp Zmllci5Db250cm9sLCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuQXBvc3Ryb3Bo ZSwgdGhpcy5fZm9jdXNDb25zb2xlUHJvbXB0LmJpbmQodGhpcykpOwpAQCAtMTY5NCw3ICsxNjk1 LDExIEBAIFdlYkluc3BlY3Rvci5fZG93bmxvYWRXZWJBcmNoaXZlID0gZnVuY3Rpb24oZXZlbnQp CiAKIFdlYkluc3BlY3Rvci5fcmVsb2FkUGFnZSA9IGZ1bmN0aW9uKGV2ZW50KQogeworICAgIGlm ICghd2luZG93LlBhZ2VBZ2VudCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgUGFnZUFnZW50LnJl bG9hZCgpOworICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiB9OwogCiBXZWJJbnNwZWN0b3Iu X3JlbG9hZFBhZ2VDbGlja2VkID0gZnVuY3Rpb24oZXZlbnQpCkBAIC0xNzA1LDcgKzE3MTAsMTEg QEAgV2ViSW5zcGVjdG9yLl9yZWxvYWRQYWdlQ2xpY2tlZCA9IGZ1bmN0aW9uKGV2ZW50KQogCiBX ZWJJbnNwZWN0b3IuX3JlbG9hZFBhZ2VJZ25vcmluZ0NhY2hlID0gZnVuY3Rpb24oZXZlbnQpCiB7 CisgICAgaWYgKCF3aW5kb3cuUGFnZUFnZW50KQorICAgICAgICByZXR1cm47CisKICAgICBQYWdl QWdlbnQucmVsb2FkKHRydWUpOworICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiB9OwogCiBX ZWJJbnNwZWN0b3IuX3VwZGF0ZVJlbG9hZFRvb2xiYXJCdXR0b24gPSBmdW5jdGlvbigpCg==