151889 2015-12-04 15:46:33 -0800 [iOS] Do not exit fullscreen mode during auto-PiP. 2015-12-08 11:30:01 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue oldest_to_newest 1146442 0 jer.noble 2015-12-04 15:46:33 -0800 [iOS] Do not exit fullscreen mode during auto-PiP. 1146448 1 266671 jer.noble 2015-12-04 15:54:08 -0800 Created attachment 266671 Patch 1146451 2 commit-queue 2015-12-04 15:54:55 -0800 Attachment 266671 did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1065: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1367: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1147390 3 266671 commit-queue 2015-12-08 11:29:59 -0800 Comment on attachment 266671 Patch Clearing flags on attachment: 266671 Committed r193762: <http://trac.webkit.org/changeset/193762> 1147391 4 commit-queue 2015-12-08 11:30:01 -0800 All reviewed patches have been landed. Closing bug. 266671 2015-12-04 15:54:08 -0800 2015-12-08 11:29:59 -0800 Patch bug-151889-20151204155342.patch text/plain 4364 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTFkNWNkMDEwNDlkZjBi M2MyNjkzNjdjNjc0ZTU2ZTkwNjg2Mjc1MC4uMDAwMTgyMjlkZjBlMzhmMWQ3MDhmNjc5NWZiNGEy MGEyMDYxNjIyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTA0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIERvIG5vdCBleGl0 IGZ1bGxzY3JlZW4gbW9kZSBkdXJpbmcgYXV0by1QaVAuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE4ODkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGF1dG8tUGlQaW5nLCBkbyBub3QgZXhpdCBm dWxsc2NyZWVuIG1vZGUsIGFzIHRoYXQgY2F1c2VzIGEgdHdvLXN0ZXAgYW5pbWF0aW9uIHVwb24g cmV0dXJpbmcgZnJvbSBhdXRvLVBpUC4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJWaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbToKKyAgICAgICAgKFdlYlZpZGVvRnVsbHNjcmVl bkludGVyZmFjZUFWS2l0OjphcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2ZSk6IEhhbmRsZSB0aGUg Y2FzZSB3aGVyZSB3ZSBvcGVuIFNhZmFyaSBhZnRlciBhbgorICAgICAgICAgICAgYXV0by1QaVAg YnkgY2xpY2tpbmcgb24gYSBsaW5rOyBpZiBzbywgaGlkZSB0aGUgZnVsbHNjcmVlbiB3aW5kb3cu CisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZGlkU3RhcnRQaWN0 dXJlSW5QaWN0dXJlKTogRG8gbm90IGV4aXQgZnVsbHNjcmVlbiBkdXJpbmcgYXV0by1QaVAuCisg ICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6c2hvdWxkRXhpdEZ1bGxz Y3JlZW5XaXRoUmVhc29uKTogRGl0dG8uCisKIDIwMTUtMTItMDMgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgT2JqZWN0aXZlLUMgR0Mgc3Vw cG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVs bHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dl YlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCmluZGV4IGEzNmQwMDhjOGJhYjY3ODll ZGFkNzRhNGJlYTlkMTgzMWE0MjBhNmYuLmYyNGNmMmJiOWQ1MWQ0YjkxNmQ5MGIzOTJlOGY0ZmZm NzFiZDM5OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KQEAgLTEwNTMsOCArMTA1 MywyMCBAQCBib29sIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojp3aXJlbGVzc1Zp ZGVvUGxheWJhY2tEaXNhYmxlZCgpIGNvbnN0CiB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVy ZmFjZUFWS2l0OjphcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2ZSgpCiB7CiAgICAgTE9HKEZ1bGxz Y3JlZW4sICJXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6YXBwbGljYXRpb25EaWRC ZWNvbWVBY3RpdmUoJXApIiwgdGhpcyk7Ci0gICAgaWYgKG1fc2hvdWxkUmV0dXJuVG9GdWxsc2Ny ZWVuQWZ0ZXJFbnRlcmluZ0ZvcmVncm91bmQgJiYgbV92aWRlb0Z1bGxzY3JlZW5Nb2RlbCAmJiBt X3ZpZGVvRnVsbHNjcmVlbk1vZGVsLT5pc1Zpc2libGUoKSkKKyAgICBpZiAobV9zaG91bGRSZXR1 cm5Ub0Z1bGxzY3JlZW5BZnRlckVudGVyaW5nRm9yZWdyb3VuZCAmJiBtX3ZpZGVvRnVsbHNjcmVl bk1vZGVsICYmIG1fdmlkZW9GdWxsc2NyZWVuTW9kZWwtPmlzVmlzaWJsZSgpKSB7CiAgICAgICAg IFttX3BsYXllclZpZXdDb250cm9sbGVyIHN0b3BQaWN0dXJlSW5QaWN0dXJlXTsKKyAgICAgICAg cmV0dXJuOworICAgIH0KKworICAgIC8vIElmIHdlIGFyZSBib3RoIGluIFBpUCBhbmQgaW4gRnVs bHNjcmVlbiAoaS5lLiwgdmlhIGF1dG8tUGlQKSwgYW5kIHdlIGRpZCBub3Qgc3RvcCBmdWxsc2Ny ZWVuIHVwb24gcmV0dXJuaW5nLCBpdCBtdXN0IGJlCisgICAgLy8gYmVjYXVzZSB0aGUgb3JpZ2lu YXRpbmcgdmlldyBpcyBub3QgdmlzaWJsZSwgc28gaGlkZSB0aGUgZnVsbHNjcmVlbiB3aW5kb3cu CisgICAgaWYgKGlzTW9kZShIVE1MTWVkaWFFbGVtZW50RW51bXM6OlZpZGVvRnVsbHNjcmVlbk1v ZGVTdGFuZGFyZCB8IEhUTUxNZWRpYUVsZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZVBp Y3R1cmVJblBpY3R1cmUpKSB7CisgICAgICAgIFJlZlB0cjxXZWJWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VBVktpdD4gc3Ryb25nVGhpcyh0aGlzKTsKKyAgICAgICAgW21fcGxheWVyVmlld0NvbnRy b2xsZXIgZXhpdEZ1bGxTY3JlZW5BbmltYXRlZDpOTyBjb21wbGV0aW9uSGFuZGxlcjpbc3Ryb25n VGhpcywgdGhpc10gKEJPT0wsIE5TRXJyb3IqKSB7CisgICAgICAgICAgICBbbV93aW5kb3cgc2V0 SGlkZGVuOllFU107CisgICAgICAgICAgICBbW21fcGxheWVyVmlld0NvbnRyb2xsZXIgdmlld10g c2V0SGlkZGVuOllFU107CisgICAgICAgIH1dOworICAgIH0KIH0KIAogQGludGVyZmFjZSBVSVdp bmRvdyAoKQpAQCAtMTM1MCwxMSArMTM2MiwxMyBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbklu dGVyZmFjZUFWS2l0OjpkaWRTdGFydFBpY3R1cmVJblBpY3R1cmUoKQogICAgIFttX3BsYXllclZp ZXdDb250cm9sbGVyIHNldFNob3dzUGxheWJhY2tDb250cm9sczpZRVNdOwogCiAgICAgaWYgKG1f bW9kZSAmIEhUTUxNZWRpYUVsZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZVN0YW5kYXJk KSB7Ci0gICAgICAgIFJlZlB0cjxXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdD4gc3Ry b25nVGhpcyh0aGlzKTsKLSAgICAgICAgW21fcGxheWVyVmlld0NvbnRyb2xsZXIgZXhpdEZ1bGxT Y3JlZW5BbmltYXRlZDpZRVMgY29tcGxldGlvbkhhbmRsZXI6W3N0cm9uZ1RoaXMsIHRoaXNdIChC T09MLCBOU0Vycm9yKikgewotICAgICAgICAgICAgW21fd2luZG93IHNldEhpZGRlbjpZRVNdOwot ICAgICAgICAgICAgW1ttX3BsYXllclZpZXdDb250cm9sbGVyIHZpZXddIHNldEhpZGRlbjpZRVNd OwotICAgICAgICB9XTsKKyAgICAgICAgaWYgKCFbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciBwaWN0 dXJlSW5QaWN0dXJlV2FzU3RhcnRlZFdoZW5FbnRlcmluZ0JhY2tncm91bmRdKSB7CisgICAgICAg ICAgICBSZWZQdHI8V2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ+IHN0cm9uZ1RoaXMo dGhpcyk7CisgICAgICAgICAgICBbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciBleGl0RnVsbFNjcmVl bkFuaW1hdGVkOllFUyBjb21wbGV0aW9uSGFuZGxlcjpbc3Ryb25nVGhpcywgdGhpc10gKEJPT0ws IE5TRXJyb3IqKSB7CisgICAgICAgICAgICAgICAgW21fd2luZG93IHNldEhpZGRlbjpZRVNdOwor ICAgICAgICAgICAgICAgIFtbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciB2aWV3XSBzZXRIaWRkZW46 WUVTXTsKKyAgICAgICAgICAgIH1dOworICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAg W21fd2luZG93IHNldEhpZGRlbjpZRVNdOwogICAgICAgICBbW21fcGxheWVyVmlld0NvbnRyb2xs ZXIgdmlld10gc2V0SGlkZGVuOllFU107CkBAIC0xNDUzLDYgKzE0NjcsOSBAQCBib29sIFdlYlZp ZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzaG91bGRFeGl0RnVsbHNjcmVlbldpdGhSZWFz b24oV2ViVmlkZW9GdQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIGlmIChyZWFzb24gPT0g RXhpdEZ1bGxTY3JlZW5SZWFzb246OlBpY3R1cmVJblBpY3R1cmVTdGFydGVkKSB7CisgICAgICAg IGlmIChbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciBwaWN0dXJlSW5QaWN0dXJlV2FzU3RhcnRlZFdo ZW5FbnRlcmluZ0JhY2tncm91bmRdKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAg ICAgIG1fc2hvdWxkUmV0dXJuVG9GdWxsc2NyZWVuV2hlblN0b3BwaW5nUGlQID0gaGFzTW9kZShI VE1MTWVkaWFFbGVtZW50RW51bXM6OlZpZGVvRnVsbHNjcmVlbk1vZGVTdGFuZGFyZCk7CiAgICAg ICAgIGNsZWFyTW9kZShIVE1MTWVkaWFFbGVtZW50RW51bXM6OlZpZGVvRnVsbHNjcmVlbk1vZGVT dGFuZGFyZCk7CiAgICAgICAgIHJldHVybiB0cnVlOwo=