151884 2015-12-04 14:04:56 -0800 [Cocoa] Some fonts cause CTFontCopyAvailableTables() to return nullptr 2016-01-04 13:27:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino fred.wang jonlee simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1146392 0 mmaxfield 2015-12-04 14:04:56 -0800 [Cocoa] Some fonts cause CTFontCopyAvailableTables() to return nullptr 1146393 1 266659 mmaxfield 2015-12-04 14:05:47 -0800 Created attachment 266659 Patch 1146394 2 mmaxfield 2015-12-04 14:06:54 -0800 <rdar://problem/23752253> 1146395 3 266660 mmaxfield 2015-12-04 14:07:25 -0800 Created attachment 266660 Patch 1146401 4 mmaxfield 2015-12-04 14:14:38 -0800 fredw says there may be similar code elsewhere that needs to be updated. 1146402 5 mmaxfield 2015-12-04 14:16:34 -0800 fontHasVerticalGlyphs() 1146420 6 266660 bburg 2015-12-04 15:03:08 -0800 Comment on attachment 266660 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266660&action=review rs=me > Source/WebCore/platform/graphics/opentype/OpenTypeCG.cpp:44 > CFIndex numTables = CFArrayGetCount(tableTags.get()); I would add a newline below the return. Not sure how dense your corner of WebKit is. :) 1146446 7 266660 commit-queue 2015-12-04 15:52:44 -0800 Comment on attachment 266660 Patch Clearing flags on attachment: 266660 Committed r193484: <http://trac.webkit.org/changeset/193484> 1146447 8 commit-queue 2015-12-04 15:52:47 -0800 All reviewed patches have been landed. Closing bug. 1152487 9 mmaxfield 2016-01-04 13:27:29 -0800 Committed r194551: <http://trac.webkit.org/changeset/194551> 266659 2015-12-04 14:05:47 -0800 2015-12-04 14:07:22 -0800 Patch bug-151884-20151204140521.patch text/plain 1589 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzNDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE0MTFiZGRhN2VmYjY0 ZDRkZWVjNmZiZDEzNTdiMGMwNzEyZDhkMS4uNTcxNTBhMTY5ZjkyZTM1ZDJlZjk2ZjRkN2Q2NTBi NDg1OTIzZDM4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTA0ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBT b21lIGZvbnRzIGNhdXNlIENURm9udENvcHlBdmFpbGFibGVUYWJsZXMoKSB0byByZXR1cm4gbnVs bHB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUx ODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5 cGVDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpPcGVuVHlwZTo6Zm9udEhhc01hdGhUYWJsZSk6 CisKIDIwMTUtMTItMDQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAg ICAgIE1vZGVybiBJREI6IHN0b3JhZ2UvaW5kZXhlZGRiL2N1cnNvci11cGRhdGUuaHRtbCBmYWls cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW50eXBl L09wZW5UeXBlQ0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5 cGUvT3BlblR5cGVDRy5jcHAKaW5kZXggODI4MjZmNWMwNjJjMmUxZGIzNjdhYTAwYzUxMjI0YTJm ODVkMDlkNi4uYzdkYjdkZDYzOWNmNGE5NTA5Y2RhYWUzMzc2MDk3YWMxYzc4ZDBiZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVD Ry5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3Bl blR5cGVDRy5jcHAKQEAgLTM5LDYgKzM5LDggQEAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGxvbmcg a0NURm9udFRhYmxlT1MyID0gJ09TLzInOwogYm9vbCBmb250SGFzTWF0aFRhYmxlKENURm9udFJl ZiBjdEZvbnQpCiB7CiAgICAgUmV0YWluUHRyPENGQXJyYXlSZWY+IHRhYmxlVGFncyA9IGFkb3B0 Q0YoQ1RGb250Q29weUF2YWlsYWJsZVRhYmxlcyhjdEZvbnQsIGtDVEZvbnRUYWJsZU9wdGlvbk5v T3B0aW9ucykpOworICAgIGlmICghdGFibGVUYWdzKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgQ0ZJbmRleCBudW1UYWJsZXMgPSBDRkFycmF5R2V0Q291bnQodGFibGVUYWdzLmdldCgpKTsK ICAgICBmb3IgKENGSW5kZXggaW5kZXggPSAwOyBpbmRleCA8IG51bVRhYmxlczsgKytpbmRleCkg ewogICAgICAgICBDVEZvbnRUYWJsZVRhZyB0YWcgPSAoQ1RGb250VGFibGVUYWcpKHVpbnRwdHJf dClDRkFycmF5R2V0VmFsdWVBdEluZGV4KHRhYmxlVGFncy5nZXQoKSwgaW5kZXgpOwo= 266660 2015-12-04 14:07:25 -0800 2015-12-04 15:52:44 -0800 Patch bug-151884-20151204140659.patch text/plain 1624 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzNDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE0MTFiZGRhN2VmYjY0 ZDRkZWVjNmZiZDEzNTdiMGMwNzEyZDhkMS4uNzViMGNlYmM4NzNiNDJiZjM1Y2FiZmZlZmE4YTdh NTljZmMzZGViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEyLTA0ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBT b21lIGZvbnRzIGNhdXNlIENURm9udENvcHlBdmFpbGFibGVUYWJsZXMoKSB0byByZXR1cm4gbnVs bHB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUx ODg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMzc1MjI1Mz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9PcGVuVHlwZUNHLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok9wZW5UeXBlOjpmb250SGFzTWF0aFRhYmxlKToKKwogMjAxNS0xMi0wNCAgQnJhZHkg RWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9kZXJuIElEQjogc3RvcmFn ZS9pbmRleGVkZGIvY3Vyc29yLXVwZGF0ZS5odG1sIGZhaWxzLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVDRy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9PcGVuVHlwZUNHLmNwcAppbmRl eCA4MjgyNmY1YzA2MmMyZTFkYjM2N2FhMDBjNTEyMjRhMmY4NWQwOWQ2Li5jN2RiN2RkNjM5Y2Y0 YTk1MDljZGFhZTMzNzYwOTdhYzFjNzhkMGJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9PcGVuVHlwZUNHLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9PcGVuVHlwZUNHLmNwcApAQCAtMzksNiAr MzksOCBAQCBzdGF0aWMgY29uc3QgdW5zaWduZWQgbG9uZyBrQ1RGb250VGFibGVPUzIgPSAnT1Mv Mic7CiBib29sIGZvbnRIYXNNYXRoVGFibGUoQ1RGb250UmVmIGN0Rm9udCkKIHsKICAgICBSZXRh aW5QdHI8Q0ZBcnJheVJlZj4gdGFibGVUYWdzID0gYWRvcHRDRihDVEZvbnRDb3B5QXZhaWxhYmxl VGFibGVzKGN0Rm9udCwga0NURm9udFRhYmxlT3B0aW9uTm9PcHRpb25zKSk7CisgICAgaWYgKCF0 YWJsZVRhZ3MpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBDRkluZGV4IG51bVRhYmxlcyA9 IENGQXJyYXlHZXRDb3VudCh0YWJsZVRhZ3MuZ2V0KCkpOwogICAgIGZvciAoQ0ZJbmRleCBpbmRl eCA9IDA7IGluZGV4IDwgbnVtVGFibGVzOyArK2luZGV4KSB7CiAgICAgICAgIENURm9udFRhYmxl VGFnIHRhZyA9IChDVEZvbnRUYWJsZVRhZykodWludHB0cl90KUNGQXJyYXlHZXRWYWx1ZUF0SW5k ZXgodGFibGVUYWdzLmdldCgpLCBpbmRleCk7Cg==