151877 2015-12-04 11:23:52 -0800 [iOS] Bail out if the page proxy is invalid when WebPageProxy::processWillBecome{Foreground, Suspended}() are called 2015-12-09 18:50:55 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build iPhone / iPad iOS 9.0 RESOLVED FIXED P2 Normal --- 1 dbates dbates andersca barraclough oldest_to_newest 1146350 0 dbates 2015-12-04 11:23:52 -0800 Assume you have a single web page p open in MobileSafari (or nothing open - about:blank is implicitly loaded, though the favorites screen is showing). Suppose the web page crashes. Then the WebPageProxy p' associated with p will be marked as invalid (WebPageProxy::m_isValid == false) and the ProcessThrottler of the WebProcessProxy associated with p will schedule a process suspension timer (since there are no foreground or background processes - the foreground web page crashed). Assuming the process suspension timer fires before the WebPageProxy object associated with the crashed web page reattaches to a new web process then WebPageProxy::processWillBecomeSuspended() will be called on p' and the assertion ASSERT(m_isValid) will fail. 1146351 1 266645 dbates 2015-12-04 11:28:33 -0800 Created attachment 266645 Patch 1148026 2 266645 dbates 2015-12-09 18:50:50 -0800 Comment on attachment 266645 Patch Clearing flags on attachment: 266645 Committed r193883: <http://trac.webkit.org/changeset/193883> 1148027 3 dbates 2015-12-09 18:50:55 -0800 All reviewed patches have been landed. Closing bug. 266645 2015-12-04 11:28:33 -0800 2015-12-09 18:50:50 -0800 Patch bug-151877-20151204112807.patch text/plain 2129 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjkyYzRkOTExZWY0ZDUz ZDhkMDIyZDAwMzdlMWYwMGVjN2Q2MGZhZC4uNjljMWVmYjQwNmFjYTE5MTVkZmM1MWZkZDczNjJi MzVhMTQzNmE3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTA0ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBCYWlsIG91dCBp ZiB0aGUgcGFnZSBwcm94eSBpcyBpbnZhbGlkIHdoZW4gV2ViUGFnZVByb3h5Ojpwcm9jZXNzV2ls bEJlY29tZXtGb3JlZ3JvdW5kLCBTdXNwZW5kZWR9KCkgYXJlIGNhbGxlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxODc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY2Fubm90IGFzc3VtZSB0aGF0 IGEgV2ViUGFnZVByb3h5IGlzIGluIGEgdmFsaWQgc3RhdGUgd2hlbiBXZWJQYWdlUHJveHk6OnBy b2Nlc3NXaWxsQmVjb21le0ZvcmVncm91bmQsIFN1c3BlbmRlZH0oKQorICAgICAgICBhcmUgY2Fs bGVkIGJlY2F1c2UgdGhlc2UgY2FsbGJhY2tzIG1heSBvY2N1ciBhZnRlciB0aGUgd2ViIHByb2Nl c3MgY3Jhc2hlZCBhbmQgYmVmb3JlIGEKKyAgICAgICAgV2ViUGFnZVByb3h5IGF0dGFjaGVzIHRv IGEgbmV3IHdlYiBwcm9jZXNzIChhbmQgaGVuY2UgaXMgY29uc2lkZXJlZCBpbiBhIHZhbGlkIHN0 YXRlKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OnByb2Nlc3NXaWxsQmVjb21lU3VzcGVuZGVkKTogRWFybHkg cmV0dXJuIGlmIHRoZSBwYWdlIHByb3h5IGlzIGludmFsaWQuCisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6cHJvY2Vzc1dpbGxCZWNvbWVGb3JlZ3JvdW5kKTogRGl0dG8uCisKIDIwMTUt MTItMDMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Nd W1dLMl0gU3VzcGVuZC9yZXN1bWUgYWN0aXZlIERPTSBvYmplY3RzIHdoZW4gcHJvY2VzcyBpcyB0 aHJvdHRsZWQgb3Igd2hlbiBhcHAgbGVhdmVzIHRoZSBmb3JlZ3JvdW5kCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDU5ZGNmMDhhYzFmMDg1YmQ5N2IwOTM0 ZWMzOTdiZmIxOGNiYzVmYTkuLjQxNDQzNzc3MWYwNjA1MmI1YWI3ZDBkNTg1MzFiNzkwNjJlMTlj MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC00OTAy LDcgKzQ5MDIsOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6cHJvY2Vzc0RpZENyYXNoKCkKICNpZiBQ TEFURk9STShJT1MpCiB2b2lkIFdlYlBhZ2VQcm94eTo6cHJvY2Vzc1dpbGxCZWNvbWVTdXNwZW5k ZWQoKQogewotICAgIEFTU0VSVChtX2lzVmFsaWQpOworICAgIGlmICghaXNWYWxpZCgpKQorICAg ICAgICByZXR1cm47CiAKICAgICBtX2hhc05ldHdvcmtSZXF1ZXN0c09uU3VzcGVuZGVkID0gbV9w YWdlTG9hZFN0YXRlLm5ldHdvcmtSZXF1ZXN0c0luUHJvZ3Jlc3MoKTsKICAgICBpZiAobV9oYXNO ZXR3b3JrUmVxdWVzdHNPblN1c3BlbmRlZCkKQEAgLTQ5MTEsNyArNDkxMiw4IEBAIHZvaWQgV2Vi UGFnZVByb3h5Ojpwcm9jZXNzV2lsbEJlY29tZVN1c3BlbmRlZCgpCiAKIHZvaWQgV2ViUGFnZVBy b3h5Ojpwcm9jZXNzV2lsbEJlY29tZUZvcmVncm91bmQoKQogewotICAgIEFTU0VSVChtX2lzVmFs aWQpOworICAgIGlmICghaXNWYWxpZCgpKQorICAgICAgICByZXR1cm47CiAKICAgICBpZiAobV9o YXNOZXR3b3JrUmVxdWVzdHNPblN1c3BlbmRlZCkgewogICAgICAgICBzZXROZXR3b3JrUmVxdWVz dHNJblByb2dyZXNzKHRydWUpOwo=