151852 2015-12-03 23:33:27 -0800 [JSC] Extend the strength reduction of B3's BitAnd with booleans 2015-12-14 18:18:10 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1146226 0 benjamin 2015-12-03 23:33:27 -0800 [JSC] Extend the strength reduction of B3's BitAnd with booleans 1146227 1 266606 benjamin 2015-12-03 23:35:15 -0800 Created attachment 266606 Patch 1146239 2 266606 saam 2015-12-04 00:59:07 -0800 Comment on attachment 266606 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266606&action=review r=me > Source/JavaScriptCore/b3/B3ReduceStrength.cpp:578 > + && m_value->child(0)->child(1)->asInt() & 1 I think you could also do: "m_value->child(0)-> 1146240 3 266606 saam 2015-12-04 01:00:00 -0800 Comment on attachment 266606 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266606&action=review >> Source/JavaScriptCore/b3/B3ReduceStrength.cpp:578 >> + && m_value->child(0)->child(1)->asInt() & 1 > > I think you could also do: "m_value->child(0)-> Oops I meant to delete that. 1146366 4 266606 commit-queue 2015-12-04 12:31:29 -0800 Comment on attachment 266606 Patch Clearing flags on attachment: 266606 Committed r193436: <http://trac.webkit.org/changeset/193436> 1146367 5 commit-queue 2015-12-04 12:31:32 -0800 All reviewed patches have been landed. Closing bug. 1149167 6 266606 fpizlo 2015-12-14 18:18:10 -0800 Comment on attachment 266606 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266606&action=review > Source/JavaScriptCore/b3/B3ReduceStrength.cpp:869 > + // Turn this: Branch(BitAnd(bool, xyb1), then, else) > + // Into this: Branch(bool, then, else) > + if (branch->child(0)->opcode() == BitAnd > + && branch->child(0)->child(1)->hasInt() > + && branch->child(0)->child(1)->asInt() & 1 > + && branch->child(0)->child(0)->returnsBool()) { > + branch->child(0) = branch->child(0)->child(0); > + m_changed = true; > + } > + You could have made this a rule that converts BitAnd(bool, xyb1) to bool, regardless of the user of the BitAnd. 266606 2015-12-03 23:35:15 -0800 2015-12-04 12:31:29 -0800 Patch bug-151852-20151203233450.patch text/plain 5262 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzNDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDgzMWVjOWU0NWYzZmU3Y2FiMWU5ZjVhMTllNzJjODVkMjBhNzllLi4xYzA5YTQ0NGMxNDg3MWNj Yzc4M2U1YTZiMmY3OGI0MGNlZDFlMWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNS0xMi0wMyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBFeHRlbmQgdGhlIHN0cmVuZ3RoIHJlZHVjdGlvbiBvZiBC MydzIEJpdEFuZCB3aXRoIGJvb2xlYW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTE4NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAxKSBNYXNraW5nIGEgYm9vbGVhbiB3aXRoIGFueSBwYXR0ZXJuIHRo YXQgaGFzIHRoZSBsc2Igc2V0CisgICAgICAgICAgIHJlbWFpbnMgYSBib29sZWFuLgorICAgICAg ICAyKSBSZWR1Y2VTdHJlbmd0aCBvbiB0aGF0IHBhcnRpY3VsYXIgcGF0dGVybiBvZiBCaXRBbmQu CisKKyAgICAgICAgKiBiMy9CM1JlZHVjZVN0cmVuZ3RoLmNwcDoKKyAgICAgICAgKiBiMy9CM1Zh bHVlLmNwcDoKKyAgICAgICAgKEpTQzo6QjM6OlZhbHVlOjpyZXR1cm5zQm9vbCk6CisgICAgICAg ICogYjMvdGVzdGIzLmNwcDoKKyAgICAgICAgKEpTQzo6QjM6OnRlc3RCaXRBbmRXaXRoTWFza1Jl dHVybnNCb29sZWFucyk6CisgICAgICAgIChKU0M6OkIzOjpydW4pOgorCiAyMDE1LTEyLTAzICBG aWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQjMgUGF0Y2hwb2ludCBh bmQgQ2hlY2sgb3Bjb2RlcyBzaG91bGQgYmUgYWJsZSB0byBzcGVjaWZ5IFdhcm1BbnksIENvbGRB bnksIGFuZCBMYXRlQ29sZEFueQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Iz L0IzUmVkdWNlU3RyZW5ndGguY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzUmVkdWNl U3RyZW5ndGguY3BwCmluZGV4IGY5NmE2NDg5N2ZlMzQ4NmQzNDllNzA2OWJmZmQ4M2VmYTU2MTEw MTYuLjhjMjc2NGYwYjRjZDVjNjFmYmQzNTZhOTEzNzVlNDEwYmZjMmFkMDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1JlZHVjZVN0cmVuZ3RoLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvQjNSZWR1Y2VTdHJlbmd0aC5jcHAKQEAgLTU3MSw2ICs1NzEs MTcgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KIAor ICAgICAgICAgICAgLy8gVHVybiB0aGlzOiBTZWxlY3QoQml0QW5kKGJvb2wsIHh5ejEpLCBhLCBi KQorICAgICAgICAgICAgLy8gSW50byB0aGlzOiBTZWxlY3QoYm9vbCwgYSwgYikKKyAgICAgICAg ICAgIGlmIChtX3ZhbHVlLT5jaGlsZCgwKS0+b3Bjb2RlKCkgPT0gQml0QW5kCisgICAgICAgICAg ICAgICAgJiYgbV92YWx1ZS0+Y2hpbGQoMCktPmNoaWxkKDEpLT5oYXNJbnQoKQorICAgICAgICAg ICAgICAgICYmIG1fdmFsdWUtPmNoaWxkKDApLT5jaGlsZCgxKS0+YXNJbnQoKSAmIDEKKyAgICAg ICAgICAgICAgICAmJiBtX3ZhbHVlLT5jaGlsZCgwKS0+Y2hpbGQoMCktPnJldHVybnNCb29sKCkp IHsKKyAgICAgICAgICAgICAgICBtX3ZhbHVlLT5jaGlsZCgwKSA9IG1fdmFsdWUtPmNoaWxkKDAp LT5jaGlsZCgwKTsKKyAgICAgICAgICAgICAgICBtX2NoYW5nZWQgPSB0cnVlOworICAgICAgICAg ICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQorCiAgICAgICAgICAgICAvLyBUdXJuIHRoaXM6 IFNlbGVjdChzdHVmZiwgeCwgeCkKICAgICAgICAgICAgIC8vIEludG8gdGhpczogeAogICAgICAg ICAgICAgaWYgKG1fdmFsdWUtPmNoaWxkKDEpID09IG1fdmFsdWUtPmNoaWxkKDIpKSB7CkBAIC04 NDUsNyArODU2LDE3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgc3RkOjpzd2FwKGJyYW5j aC0+dGFrZW4oKSwgYnJhbmNoLT5ub3RUYWtlbigpKTsKICAgICAgICAgICAgICAgICBtX2NoYW5n ZWQgPSB0cnVlOwogICAgICAgICAgICAgfQotICAgICAgICAgICAgCisKKyAgICAgICAgICAgIC8v IFR1cm4gdGhpczogQnJhbmNoKEJpdEFuZChib29sLCB4eWIxKSwgdGhlbiwgZWxzZSkKKyAgICAg ICAgICAgIC8vIEludG8gdGhpczogQnJhbmNoKGJvb2wsIHRoZW4sIGVsc2UpCisgICAgICAgICAg ICBpZiAoYnJhbmNoLT5jaGlsZCgwKS0+b3Bjb2RlKCkgPT0gQml0QW5kCisgICAgICAgICAgICAg ICAgJiYgYnJhbmNoLT5jaGlsZCgwKS0+Y2hpbGQoMSktPmhhc0ludCgpCisgICAgICAgICAgICAg ICAgJiYgYnJhbmNoLT5jaGlsZCgwKS0+Y2hpbGQoMSktPmFzSW50KCkgJiAxCisgICAgICAgICAg ICAgICAgJiYgYnJhbmNoLT5jaGlsZCgwKS0+Y2hpbGQoMCktPnJldHVybnNCb29sKCkpIHsKKyAg ICAgICAgICAgICAgICBicmFuY2gtPmNoaWxkKDApID0gYnJhbmNoLT5jaGlsZCgwKS0+Y2hpbGQo MCk7CisgICAgICAgICAgICAgICAgbV9jaGFuZ2VkID0gdHJ1ZTsKKyAgICAgICAgICAgIH0KKwog ICAgICAgICAgICAgVHJpU3RhdGUgdHJpU3RhdGUgPSBicmFuY2gtPmNoaWxkKDApLT5hc1RyaVN0 YXRlKCk7CiAKICAgICAgICAgICAgIC8vIFR1cm4gdGhpczogQnJhbmNoKDAsIHRoZW4sIGVsc2Up CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNWYWx1ZS5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvQjNWYWx1ZS5jcHAKaW5kZXggYTZkYTNkODliZDAzYzQ4Mjll ODZlNDBiMTg3ZjNjMzdhMGJiMzhkYy4uNDAxNmU3NTRlZTc5MTk4NGRjOGNiMDZjNzMwZjc0YzZh MGExMDNjNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzVmFsdWUuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1ZhbHVlLmNwcApAQCAtMjY2LDcgKzI2 Niw3IEBAIGJvb2wgVmFsdWU6OnJldHVybnNCb29sKCkgY29uc3QKICAgICBjYXNlIENvbnN0MzI6 CiAgICAgICAgIHJldHVybiBhc0ludDMyKCkgPT0gMCB8fCBhc0ludDMyKCkgPT0gMTsKICAgICBj YXNlIEJpdEFuZDoKLSAgICAgICAgcmV0dXJuIGNoaWxkKDEpLT5pc0ludDMyKDEpOworICAgICAg ICByZXR1cm4gY2hpbGQoMSktPmhhc0ludCgpICYmIGNoaWxkKDEpLT5hc0ludCgpICYgMTsKICAg ICBjYXNlIEVxdWFsOgogICAgIGNhc2UgTm90RXF1YWw6CiAgICAgY2FzZSBMZXNzVGhhbjoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjMuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2IzL3Rlc3RiMy5jcHAKaW5kZXggM2NhMGM4MDBlMGNjMzNhZTY1ZWM0ZDY3 NjkyZjI0YmNlNWMxYjMxNS4uZDVlYjViZTZmNmJiN2MyMmY2NTc5OWI2MGU4ZDU1ODIzNzVhMGQ3 ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiMy5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiMy5jcHAKQEAgLTk5OCw2ICs5OTgsMjkgQEAg dm9pZCB0ZXN0Qml0QW5kSW1tQml0QW5kQXJnSW1tMzIoaW50IGEsIGludCBiLCBpbnQgYykKICAg ICBDSEVDSyhjb21waWxlQW5kUnVuPGludD4ocHJvYywgYikgPT0gKGEgJiAoYiAmIGMpKSk7CiB9 CiAKK3ZvaWQgdGVzdEJpdEFuZFdpdGhNYXNrUmV0dXJuc0Jvb2xlYW5zKGludDY0X3QgYSwgaW50 NjRfdCBiKQoreworICAgIFByb2NlZHVyZSBwcm9jOworICAgIEJhc2ljQmxvY2sqIHJvb3QgPSBw cm9jLmFkZEJsb2NrKCk7CisgICAgVmFsdWUqIGFyZzAgPSByb290LT5hcHBlbmROZXc8QXJndW1l bnRSZWdWYWx1ZT4ocHJvYywgT3JpZ2luKCksIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CisgICAg VmFsdWUqIGFyZzEgPSByb290LT5hcHBlbmROZXc8QXJndW1lbnRSZWdWYWx1ZT4ocHJvYywgT3Jp Z2luKCksIEdQUkluZm86OmFyZ3VtZW50R1BSMSk7CisgICAgVmFsdWUqIGVxdWFsID0gcm9vdC0+ YXBwZW5kTmV3PFZhbHVlPihwcm9jLCBFcXVhbCwgT3JpZ2luKCksIGFyZzAsIGFyZzEpOworICAg IFZhbHVlKiBtYXNrZWRFcXVhbCA9IHJvb3QtPmFwcGVuZE5ldzxWYWx1ZT4ocHJvYywgQml0QW5k LCBPcmlnaW4oKSwKKyAgICAgICAgcm9vdC0+YXBwZW5kTmV3PENvbnN0MzJWYWx1ZT4ocHJvYywg T3JpZ2luKCksIDB4NSksCisgICAgICAgIGVxdWFsKTsKKyAgICBWYWx1ZSogaW52ZXJ0ZWQgPSBy b290LT5hcHBlbmROZXc8VmFsdWU+KHByb2MsIEJpdFhvciwgT3JpZ2luKCksCisgICAgICAgIHJv b3QtPmFwcGVuZE5ldzxDb25zdDMyVmFsdWU+KHByb2MsIE9yaWdpbigpLCAweDEpLAorICAgICAg ICBtYXNrZWRFcXVhbCk7CisgICAgVmFsdWUqIHNlbGVjdCA9IHJvb3QtPmFwcGVuZE5ldzxWYWx1 ZT4ocHJvYywgU2VsZWN0LCBPcmlnaW4oKSwgaW52ZXJ0ZWQsCisgICAgICAgIHJvb3QtPmFwcGVu ZE5ldzxDb25zdDY0VmFsdWU+KHByb2MsIE9yaWdpbigpLCA0MiksCisgICAgICAgIHJvb3QtPmFw cGVuZE5ldzxDb25zdDY0VmFsdWU+KHByb2MsIE9yaWdpbigpLCAtNSkpOworCisgICAgcm9vdC0+ YXBwZW5kTmV3PENvbnRyb2xWYWx1ZT4ocHJvYywgUmV0dXJuLCBPcmlnaW4oKSwgc2VsZWN0KTsK KworICAgIGludDY0X3QgZXhwZWN0ZWQgPSAoYSA9PSBiKSA/IC01IDogNDI7CisgICAgQ0hFQ0so Y29tcGlsZUFuZFJ1bjxpbnQ2NF90Pihwcm9jLCBhLCBiKSA9PSBleHBlY3RlZCk7Cit9CisKIHZv aWQgdGVzdEJpdE9yQXJncyhpbnQ2NF90IGEsIGludDY0X3QgYikKIHsKICAgICBQcm9jZWR1cmUg cHJvYzsKQEAgLTU3ODEsNiArNTgwNCw3IEBAIHZvaWQgcnVuKGNvbnN0IGNoYXIqIGZpbHRlcikK ICAgICBSVU4odGVzdEJpdEFuZEltbUJpdEFuZEFyZ0ltbTMyKDcsIDIsIDMpKTsKICAgICBSVU4o dGVzdEJpdEFuZEltbUJpdEFuZEFyZ0ltbTMyKDYsIDEsIDYpKTsKICAgICBSVU4odGVzdEJpdEFu ZEltbUJpdEFuZEFyZ0ltbTMyKDI0LCAweGZmZmYsIDcpKTsKKyAgICBSVU5fQklOQVJZKHRlc3RC aXRBbmRXaXRoTWFza1JldHVybnNCb29sZWFucywgaW50NjRPcGVyYW5kcygpLCBpbnQ2NE9wZXJh bmRzKCkpOwogCiAgICAgUlVOKHRlc3RCaXRPckFyZ3MoNDMsIDQzKSk7CiAgICAgUlVOKHRlc3RC aXRPckFyZ3MoNDMsIDApKTsK