151834 2015-12-03 16:25:41 -0800 [JSC] Some more cleanup of FTLB3Output 2015-12-04 18:57:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1146121 0 benjamin 2015-12-03 16:25:41 -0800 [JSC] Some more cleanup of FTLB3Output 1146122 1 266574 benjamin 2015-12-03 16:26:09 -0800 Created attachment 266574 Patch 1146471 2 266574 fpizlo 2015-12-04 16:24:53 -0800 Comment on attachment 266574 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266574&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9849 > +#if FTL_USES_B3 > + // FIXME: Add B3 support. > + UNUSED_PARAM(probeFunc); > +#else // !FTL_USES_B3 > uint32_t stackmapID = m_stackmapIDs++; > m_ftlState.probes.append(ProbeDescriptor(stackmapID, probeFunc)); > m_out.call(m_out.voidType, m_out.stackmapIntrinsic(), m_out.constInt64(stackmapID), m_out.constInt32(sizeOfProbe())); > +#endif // !FTL_USES_B3 I'm not sure about this. This code isn't right for B3. 1146552 3 benjamin 2015-12-04 18:57:17 -0800 Committed r193506: <http://trac.webkit.org/changeset/193506> 266574 2015-12-03 16:26:09 -0800 2015-12-04 16:24:53 -0800 Patch bug-151834-20151203162544.patch text/plain 2820 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzMzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 ZDA5MGIwYTM2ODc2MjJhZjEwMDE0NmU1Yzc1YmU1N2RmYjNlN2YxLi5kM2M1ZGI5M2NjZTYxNzg1 YzQ1YTdmNTY3ZmUzNjliNTJlODI1MmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0xMi0wMyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBTb21lIG1vcmUgY2xlYW51cCBvZiBGVExCM091dHB1dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxODM0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmdGwvRlRM QjNPdXRwdXQuaDoKKyAgICAgICAgKEpTQzo6RlRMOjpPdXRwdXQ6OnRyYXApOgorICAgICAgICAo SlNDOjpGVEw6Ok91dHB1dDo6c3RhY2ttYXBJbnRyaW5zaWMpOiBEZWxldGVkLgorICAgICAgICAo SlNDOjpGVEw6Ok91dHB1dDo6ZnJhbWVBZGRyZXNzSW50cmluc2ljKTogRGVsZXRlZC4KKyAgICAg ICAgKEpTQzo6RlRMOjpPdXRwdXQ6OnBhdGNocG9pbnRJbnQ2NEludHJpbnNpYyk6IERlbGV0ZWQu CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0OjpwYXRjaHBvaW50Vm9pZEludHJpbnNpYyk6IERl bGV0ZWQuCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpT Qzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZNOjpwcm9iZSk6CisKIDIwMTUtMTItMDMgIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBCMyBwYXRjaHBvaW50cyBzaG91 bGQgYWxsb3cgc3BlY2lmeWluZyBvdXRwdXQgY29uc3RyYWludHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQjNPdXRwdXQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMQjNPdXRwdXQuaAppbmRleCBiN2VjMjdlNjVjNTg1Njg4YjE0M2IzMDQwMTNlMmJj OWE1YTdlZGMyLi4zYzFlOTgyNTc2YjRjYjg3MzJlNWQ4ZWQ2OTA2N2MzODBjNzA3YmQ2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEIzT3V0cHV0LmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExCM091dHB1dC5oCkBAIC00MDksNyArNDA5LDEwIEBA IHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6UGF0Y2hwb2lu dFZhbHVlPihtX3Byb2MsIHR5cGUsIG9yaWdpbigpKTsKICAgICB9CiAKLSAgICB2b2lkIHRyYXAo KSB7IENSQVNIKCk7IH0KKyAgICB2b2lkIHRyYXAoKQorICAgIHsKKyAgICAgICAgbV9ibG9jay0+ YXBwZW5kTmV3PEIzOjpDb250cm9sVmFsdWU+KG1fcHJvYywgQjM6Ok9vcHMsIG9yaWdpbigpKTsK KyAgICB9CiAKICAgICBWYWx1ZUZyb21CbG9jayBhbmNob3IoTFZhbHVlIHZhbHVlKQogICAgIHsK QEAgLTQxNywxMyArNDIwLDYgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gVmFsdWVGcm9tQmxv Y2sodXBzaWxvbiwgbV9ibG9jayk7CiAgICAgfQogCi0jcHJhZ21hIG1hcmsgLSBJbnRyaW5zaWNz Ci0KLSAgICBMVmFsdWUgc3RhY2ttYXBJbnRyaW5zaWMoKSB7IENSQVNIKCk7IH0KLSAgICBMVmFs dWUgZnJhbWVBZGRyZXNzSW50cmluc2ljKCkgeyBDUkFTSCgpOyB9Ci0gICAgTFZhbHVlIHBhdGNo cG9pbnRJbnQ2NEludHJpbnNpYygpIHsgQ1JBU0goKTsgfQotICAgIExWYWx1ZSBwYXRjaHBvaW50 Vm9pZEludHJpbnNpYygpIHsgQ1JBU0goKTsgfQotCiAjcHJhZ21hIG1hcmsgLSBTdGF0ZXMKICAg ICBCMzo6UHJvY2VkdXJlJiBtX3Byb2M7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0 bC9GVExMb3dlckRGR1RvTExWTS5jcHAKaW5kZXggNzc3ODdkMWI2ZTgyMzJjNDE3N2YzMWUyYzkx ZmJlNDFlMzAzMDg3MC4uNzQ1MDE0YWYwMTUwZWEwMGUwN2MzZjEyNjcyNGRiMjUxZjNiMDUzNCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAK QEAgLTk4MzksOSArOTgzOSwxNCBAQCBwcml2YXRlOgogI2lmIEVOQUJMRShNQVNNX1BST0JFKQog ICAgIHZvaWQgcHJvYmUoc3RkOjpmdW5jdGlvbjx2b2lkIChDQ2FsbEhlbHBlcnM6OlByb2JlQ29u dGV4dCopPiBwcm9iZUZ1bmMpCiAgICAgeworI2lmIEZUTF9VU0VTX0IzCisgICAgICAgIC8vIEZJ WE1FOiBBZGQgQjMgc3VwcG9ydC4KKyAgICAgICAgVU5VU0VEX1BBUkFNKHByb2JlRnVuYyk7Cisj ZWxzZSAvLyAhRlRMX1VTRVNfQjMKICAgICAgICAgdWludDMyX3Qgc3RhY2ttYXBJRCA9IG1fc3Rh Y2ttYXBJRHMrKzsKICAgICAgICAgbV9mdGxTdGF0ZS5wcm9iZXMuYXBwZW5kKFByb2JlRGVzY3Jp cHRvcihzdGFja21hcElELCBwcm9iZUZ1bmMpKTsKICAgICAgICAgbV9vdXQuY2FsbChtX291dC52 b2lkVHlwZSwgbV9vdXQuc3RhY2ttYXBJbnRyaW5zaWMoKSwgbV9vdXQuY29uc3RJbnQ2NChzdGFj a21hcElEKSwgbV9vdXQuY29uc3RJbnQzMihzaXplT2ZQcm9iZSgpKSk7CisjZW5kaWYgLy8gIUZU TF9VU0VTX0IzCiAgICAgfQogI2VuZGlmCiAK