151829 2015-12-03 15:10:00 -0800 Remove the use of GraphicsContextStateSaver from RenderLayer::paintLayerByApplyingTransform 2015-12-03 16:50:07 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser webkit-bug-importer oldest_to_newest 1146090 0 sabouhallawa 2015-12-03 15:10:00 -0800 Saving/Restoring the GraphicsContext is an expensive operation. It should be used when the number to save/restore options in the context is large. But when only one option is set and later is restored, it is a lot cheaper to do that save/restore explicitly. Here are some results: When using GraphicsContextStateSaver in RenderLayer::paintLayerByApplyingTransform: Test Name Score Complexity FPS Avg. W.5% Std. % Avg. W.5% Std. % CSS bouncing circles 419.84 444.72 396.34 25.86 5.82 49.53 44.73 2.30 4.65 When removing GraphicsContextStateSaver from RenderLayer::paintLayerByApplyingTransform: Test Name Score Complexity FPS Avg. W.5% Std. % Avg. W.5% Std. % CSS bouncing circles 491.74 532.11 454.44 38.40 7.22 48.66 43.87 2.84 5.83 1146093 1 266566 sabouhallawa 2015-12-03 15:15:31 -0800 Created attachment 266566 Patch 1146094 2 webkit-bug-importer 2015-12-03 15:16:33 -0800 <rdar://problem/23751015> 1146135 3 266566 commit-queue 2015-12-03 16:50:04 -0800 Comment on attachment 266566 Patch Clearing flags on attachment: 266566 Committed r193390: <http://trac.webkit.org/changeset/193390> 1146136 4 commit-queue 2015-12-03 16:50:07 -0800 All reviewed patches have been landed. Closing bug. 266566 2015-12-03 15:15:31 -0800 2015-12-03 16:50:04 -0800 Patch bug-151829-20151203151506.patch text/plain 2339 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MzM4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTEyLTAzICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHRo ZSB1c2Ugb2YgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBmcm9tIFJlbmRlckxheWVyOjpwYWlu dExheWVyQnlBcHBseWluZ1RyYW5zZm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUxODI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2V0IHRoZSBDVE0gb2YgdGhlIEdyYXBoaWNzQ29udGV4dCB0byBp dHMgb3JpZ2luYWwgdmFsdWUgYmVmb3JlIGNoYW5naW5nCisgICAgICAgIGl0LiBUaGlzIGlzIGEg bG90IGNoZWFwZXIgdGhhbiB1c2luZyBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHRvIHNhdmUg dGhlCisgICAgICAgIHdob2xlIHN0YXRlIG9mIHRoZSBHcmFwaGljc0NvbnRleHQgYW5kIHJlc3Rv cmUgaXQgYmFjazsKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6cGFpbnRMYXllckJ5QXBwbHlpbmdUcmFuc2Zvcm0p OgorCiAyMDE1LTEyLTAzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVtb3ZlIE9iamVjdGl2ZS1DIEdDIHN1cHBvcnQKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24gMTkzMzYyKQorKysgU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQw NSw3ICs0NDA1LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRMYXllckJ5QXBwbHlpbmdUcgog ICAgIC8vIFRyYW5zbGF0ZSB0aGUgZ3JhcGhpY3MgY29udGV4dCB0byB0aGUgc25hcHBpbmcgcG9z aXRpb24gdG8gYXZvaWQgb2ZmLWRldmljZS1waXhlbCBwb3NpdGluZy4KICAgICB0cmFuc2Zvcm0u dHJhbnNsYXRlUmlnaHQoZGV2aWNlUGl4ZWxTbmFwcGVkT2Zmc2V0Rm9yVGhpc0xheWVyLndpZHRo KCksIGRldmljZVBpeGVsU25hcHBlZE9mZnNldEZvclRoaXNMYXllci5oZWlnaHQoKSk7CiAgICAg Ly8gQXBwbHkgdGhlIHRyYW5zZm9ybS4KLSAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0 YXRlU2F2ZXIoY29udGV4dCk7CisgICAgQWZmaW5lVHJhbnNmb3JtIG9sZFRyYW5zZnJvbSA9IGNv bnRleHQuZ2V0Q1RNKCk7CiAgICAgY29udGV4dC5jb25jYXRDVE0odHJhbnNmb3JtLnRvQWZmaW5l VHJhbnNmb3JtKCkpOwogCiAgICAgLy8gTm93IGRvIGEgcGFpbnQgd2l0aCB0aGUgcm9vdCBsYXll ciBzaGlmdGVkIHRvIGJlIHVzLgpAQCAtNDQxMyw2ICs0NDEzLDcgQEAgdm9pZCBSZW5kZXJMYXll cjo6cGFpbnRMYXllckJ5QXBwbHlpbmdUcgogICAgIExheWVyUGFpbnRpbmdJbmZvIHRyYW5zZm9y bWVkUGFpbnRpbmdJbmZvKHRoaXMsIExheW91dFJlY3QoZW5jbG9zZVJlY3RUb0RldmljZVBpeGVs cyh0cmFuc2Zvcm0uaW52ZXJzZSgpLnZhbHVlT3IoQWZmaW5lVHJhbnNmb3JtKCkpLm1hcFJlY3Qo cGFpbnRpbmdJbmZvLnBhaW50RGlydHlSZWN0KSwgZGV2aWNlU2NhbGVGYWN0b3IpKSwKICAgICAg ICAgcGFpbnRpbmdJbmZvLnBhaW50QmVoYXZpb3IsIGFkanVzdGVkU3VicGl4ZWxBY2N1bXVsYXRp b24sIHBhaW50aW5nSW5mby5zdWJ0cmVlUGFpbnRSb290LCBwYWludGluZ0luZm8ub3ZlcmxhcFRl c3RSZXF1ZXN0cyk7CiAgICAgcGFpbnRMYXllckNvbnRlbnRzQW5kUmVmbGVjdGlvbihjb250ZXh0 LCB0cmFuc2Zvcm1lZFBhaW50aW5nSW5mbywgcGFpbnRGbGFncyk7CisgICAgY29udGV4dC5zZXRD VE0ob2xkVHJhbnNmcm9tKTsKIH0KIAogdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRMaXN0KFZlY3Rv cjxSZW5kZXJMYXllcio+KiBsaXN0LCBHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGNvbnN0IExh eWVyUGFpbnRpbmdJbmZvJiBwYWludGluZ0luZm8sIFBhaW50TGF5ZXJGbGFncyBwYWludEZsYWdz KQo=