151826 2015-12-03 14:43:37 -0800 It should be possible to use version 6 of the WKPageUIClient without adopting the new createNewPage 2015-12-03 14:54:54 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 1146067 0 sam 2015-12-03 14:43:37 -0800 It should be possible to use version 6 of the WKPageUIClient without adopting the new createNewPage 1146071 1 266561 sam 2015-12-03 14:44:51 -0800 Created attachment 266561 Patch 1146079 2 sam 2015-12-03 14:54:54 -0800 Committed r193380: <http://trac.webkit.org/changeset/193380> 266561 2015-12-03 14:44:51 -0800 2015-12-03 14:45:41 -0800 Patch bug-151826-20151203144427.patch text/plain 5528 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MzM3OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTAzICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRv IHVzZSB2ZXJzaW9uIDYgb2YgdGhlIFdLUGFnZVVJQ2xpZW50IHdpdGhvdXQgYWRvcHRpbmcgdGhl IG5ldyBjcmVhdGVOZXdQYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTE4MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwOgorICAgICAgICAoV0tQYWdl U2V0UGFnZVVJQ2xpZW50KToKKyAgICAgICAgUGljayB3aGljaCB2YXJpYW50IG9mIGNyZWF0ZU5l d1BhZ2UgdG8gdXNlIGJhc2VkIG9uIHdoaWNoIGZ1bmN0aW9uIHBvaW50ZXIgaXMgYXZhaWxhYmxl LAorICAgICAgICBub3QgdGhlIHZlcnNpb24gbnVtYmVyLgorCiAyMDE1LTEyLTAzICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIE9iamVjdGl2 ZS1DIEdDIHN1cHBvcnQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1Bh Z2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1Bh Z2UuY3BwCShyZXZpc2lvbiAxOTMzNjcpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0MvV0tQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYzNSwxMyArMTYzNSwyMSBAQCB2b2lk IFdLUGFnZVNldFBhZ2VVSUNsaWVudChXS1BhZ2VSZWYgcGFnCiAgICAgcHJpdmF0ZToKICAgICAg ICAgdmlydHVhbCBQYXNzUmVmUHRyPFdlYlBhZ2VQcm94eT4gY3JlYXRlTmV3UGFnZShXZWJQYWdl UHJveHkqIHBhZ2UsIFdlYkZyYW1lUHJveHkqIGluaXRpYXRpbmdGcmFtZSwgY29uc3QgU2VjdXJp dHlPcmlnaW5EYXRhJiBzZWN1cml0eU9yaWdpbkRhdGEsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYg cmVzb3VyY2VSZXF1ZXN0LCBjb25zdCBXaW5kb3dGZWF0dXJlcyYgd2luZG93RmVhdHVyZXMsIGNv bnN0IE5hdmlnYXRpb25BY3Rpb25EYXRhJiBuYXZpZ2F0aW9uQWN0aW9uRGF0YSkgb3ZlcnJpZGUK ICAgICAgICAgewotICAgICAgICAgICAgaWYgKG1fY2xpZW50LmJhc2UudmVyc2lvbiA8IDYpIHsK LSAgICAgICAgICAgICAgICBpZiAoIW1fY2xpZW50LmJhc2UudmVyc2lvbiAmJiAhbV9jbGllbnQu Y3JlYXRlTmV3UGFnZV9kZXByZWNhdGVkRm9yVXNlV2l0aFYwKQotICAgICAgICAgICAgICAgICAg ICByZXR1cm4gbnVsbHB0cjsKKyAgICAgICAgICAgIGlmIChtX2NsaWVudC5jcmVhdGVOZXdQYWdl KSB7CisgICAgICAgICAgICAgICAgYXV0byBjb25maWd1cmF0aW9uID0gcGFnZS0+Y29uZmlndXJh dGlvbigpLmNvcHkoKTsKKyAgICAgICAgICAgICAgICBjb25maWd1cmF0aW9uLT5zZXRSZWxhdGVk UGFnZShwYWdlKTsKIAotICAgICAgICAgICAgICAgIGlmICghbV9jbGllbnQuY3JlYXRlTmV3UGFn ZV9kZXByZWNhdGVkRm9yVXNlV2l0aFYxKQotICAgICAgICAgICAgICAgICAgICByZXR1cm4gbnVs bHB0cjsKKyAgICAgICAgICAgICAgICBhdXRvIHNvdXJjZUZyYW1lSW5mbyA9IEFQSTo6RnJhbWVJ bmZvOjpjcmVhdGUoKmluaXRpYXRpbmdGcmFtZSwgc2VjdXJpdHlPcmlnaW5EYXRhLnNlY3VyaXR5 T3JpZ2luKCkpOwogCisgICAgICAgICAgICAgICAgYm9vbCBzaG91bGRPcGVuQXBwTGlua3MgPSAh aG9zdHNBcmVFcXVhbChXZWJDb3JlOjpVUkwoV2ViQ29yZTo6UGFyc2VkVVJMU3RyaW5nLCBpbml0 aWF0aW5nRnJhbWUtPnVybCgpKSwgcmVzb3VyY2VSZXF1ZXN0LnVybCgpKTsKKyAgICAgICAgICAg ICAgICBhdXRvIGFwaU5hdmlnYXRpb25BY3Rpb24gPSBBUEk6Ok5hdmlnYXRpb25BY3Rpb246OmNy ZWF0ZShuYXZpZ2F0aW9uQWN0aW9uRGF0YSwgc291cmNlRnJhbWVJbmZvLnB0cigpLCBudWxscHRy LCByZXNvdXJjZVJlcXVlc3QsIFdlYkNvcmU6OlVSTCgpLCBzaG91bGRPcGVuQXBwTGlua3MpOwor CisgICAgICAgICAgICAgICAgYXV0byBhcGlXaW5kb3dGZWF0dXJlcyA9IEFQSTo6V2luZG93RmVh dHVyZXM6OmNyZWF0ZSh3aW5kb3dGZWF0dXJlcyk7CisKKyAgICAgICAgICAgICAgICByZXR1cm4g YWRvcHRSZWYodG9JbXBsKG1fY2xpZW50LmNyZWF0ZU5ld1BhZ2UodG9BUEkocGFnZSksIHRvQVBJ KGNvbmZpZ3VyYXRpb24ucHRyKCkpLCB0b0FQSShhcGlOYXZpZ2F0aW9uQWN0aW9uLnB0cigpKSwg dG9BUEkoYXBpV2luZG93RmVhdHVyZXMucHRyKCkpLCBtX2NsaWVudC5iYXNlLmNsaWVudEluZm8p KSk7CisgICAgICAgICAgICB9CisgICAgICAgIAorICAgICAgICAgICAgaWYgKG1fY2xpZW50LmNy ZWF0ZU5ld1BhZ2VfZGVwcmVjYXRlZEZvclVzZVdpdGhWMSB8fCBtX2NsaWVudC5jcmVhdGVOZXdQ YWdlX2RlcHJlY2F0ZWRGb3JVc2VXaXRoVjApIHsKICAgICAgICAgICAgICAgICBBUEk6OkRpY3Rp b25hcnk6Ok1hcFR5cGUgbWFwOwogICAgICAgICAgICAgICAgIGlmICh3aW5kb3dGZWF0dXJlcy54 KQogICAgICAgICAgICAgICAgICAgICBtYXAuc2V0KCJ4IiwgQVBJOjpEb3VibGU6OmNyZWF0ZSgq d2luZG93RmVhdHVyZXMueCkpOwpAQCAtMTY2MSwyNyArMTY2OSwxNiBAQCB2b2lkIFdLUGFnZVNl dFBhZ2VVSUNsaWVudChXS1BhZ2VSZWYgcGFnCiAgICAgICAgICAgICAgICAgbWFwLnNldCgiZGlh bG9nIiwgQVBJOjpCb29sZWFuOjpjcmVhdGUod2luZG93RmVhdHVyZXMuZGlhbG9nKSk7CiAgICAg ICAgICAgICAgICAgUmVmPEFQSTo6RGljdGlvbmFyeT4gZmVhdHVyZXNNYXAgPSBBUEk6OkRpY3Rp b25hcnk6OmNyZWF0ZShXVEY6Om1vdmUobWFwKSk7CiAKLSAgICAgICAgICAgICAgICBpZiAoIW1f Y2xpZW50LmJhc2UudmVyc2lvbikKLSAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGFkb3B0UmVm KHRvSW1wbChtX2NsaWVudC5jcmVhdGVOZXdQYWdlX2RlcHJlY2F0ZWRGb3JVc2VXaXRoVjAodG9B UEkocGFnZSksIHRvQVBJKGZlYXR1cmVzTWFwLnB0cigpKSwgdG9BUEkobmF2aWdhdGlvbkFjdGlv bkRhdGEubW9kaWZpZXJzKSwgdG9BUEkobmF2aWdhdGlvbkFjdGlvbkRhdGEubW91c2VCdXR0b24p LCBtX2NsaWVudC5iYXNlLmNsaWVudEluZm8pKSk7Ci0KLSAgICAgICAgICAgICAgICBSZWY8QVBJ OjpVUkxSZXF1ZXN0PiByZXF1ZXN0ID0gQVBJOjpVUkxSZXF1ZXN0OjpjcmVhdGUocmVzb3VyY2VS ZXF1ZXN0KTsKLSAgICAgICAgICAgICAgICByZXR1cm4gYWRvcHRSZWYodG9JbXBsKG1fY2xpZW50 LmNyZWF0ZU5ld1BhZ2VfZGVwcmVjYXRlZEZvclVzZVdpdGhWMSh0b0FQSShwYWdlKSwgdG9BUEko cmVxdWVzdC5wdHIoKSksIHRvQVBJKGZlYXR1cmVzTWFwLnB0cigpKSwgdG9BUEkobmF2aWdhdGlv bkFjdGlvbkRhdGEubW9kaWZpZXJzKSwgdG9BUEkobmF2aWdhdGlvbkFjdGlvbkRhdGEubW91c2VC dXR0b24pLCBtX2NsaWVudC5iYXNlLmNsaWVudEluZm8pKSk7CisgICAgICAgICAgICAgICAgaWYg KG1fY2xpZW50LmNyZWF0ZU5ld1BhZ2VfZGVwcmVjYXRlZEZvclVzZVdpdGhWMSkgeworICAgICAg ICAgICAgICAgICAgICBSZWY8QVBJOjpVUkxSZXF1ZXN0PiByZXF1ZXN0ID0gQVBJOjpVUkxSZXF1 ZXN0OjpjcmVhdGUocmVzb3VyY2VSZXF1ZXN0KTsKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJu IGFkb3B0UmVmKHRvSW1wbChtX2NsaWVudC5jcmVhdGVOZXdQYWdlX2RlcHJlY2F0ZWRGb3JVc2VX aXRoVjEodG9BUEkocGFnZSksIHRvQVBJKHJlcXVlc3QucHRyKCkpLCB0b0FQSShmZWF0dXJlc01h cC5wdHIoKSksIHRvQVBJKG5hdmlnYXRpb25BY3Rpb25EYXRhLm1vZGlmaWVycyksIHRvQVBJKG5h dmlnYXRpb25BY3Rpb25EYXRhLm1vdXNlQnV0dG9uKSwgbV9jbGllbnQuYmFzZS5jbGllbnRJbmZv KSkpOworICAgICAgICAgICAgICAgIH0KKyAgICAKKyAgICAgICAgICAgICAgICBBU1NFUlQobV9j bGllbnQuY3JlYXRlTmV3UGFnZV9kZXByZWNhdGVkRm9yVXNlV2l0aFYwKTsKKyAgICAgICAgICAg ICAgICByZXR1cm4gYWRvcHRSZWYodG9JbXBsKG1fY2xpZW50LmNyZWF0ZU5ld1BhZ2VfZGVwcmVj YXRlZEZvclVzZVdpdGhWMCh0b0FQSShwYWdlKSwgdG9BUEkoZmVhdHVyZXNNYXAucHRyKCkpLCB0 b0FQSShuYXZpZ2F0aW9uQWN0aW9uRGF0YS5tb2RpZmllcnMpLCB0b0FQSShuYXZpZ2F0aW9uQWN0 aW9uRGF0YS5tb3VzZUJ1dHRvbiksIG1fY2xpZW50LmJhc2UuY2xpZW50SW5mbykpKTsKICAgICAg ICAgICAgIH0KIAotICAgICAgICAgICAgaWYgKCFtX2NsaWVudC5jcmVhdGVOZXdQYWdlKQotICAg ICAgICAgICAgICAgIHJldHVybiBudWxscHRyOwotCi0gICAgICAgICAgICBhdXRvIGNvbmZpZ3Vy YXRpb24gPSBwYWdlLT5jb25maWd1cmF0aW9uKCkuY29weSgpOwotICAgICAgICAgICAgY29uZmln dXJhdGlvbi0+c2V0UmVsYXRlZFBhZ2UocGFnZSk7Ci0KLSAgICAgICAgICAgIGF1dG8gc291cmNl RnJhbWVJbmZvID0gQVBJOjpGcmFtZUluZm86OmNyZWF0ZSgqaW5pdGlhdGluZ0ZyYW1lLCBzZWN1 cml0eU9yaWdpbkRhdGEuc2VjdXJpdHlPcmlnaW4oKSk7Ci0KLSAgICAgICAgICAgIGJvb2wgc2hv dWxkT3BlbkFwcExpbmtzID0gIWhvc3RzQXJlRXF1YWwoV2ViQ29yZTo6VVJMKFdlYkNvcmU6OlBh cnNlZFVSTFN0cmluZywgaW5pdGlhdGluZ0ZyYW1lLT51cmwoKSksIHJlc291cmNlUmVxdWVzdC51 cmwoKSk7Ci0gICAgICAgICAgICBhdXRvIGFwaU5hdmlnYXRpb25BY3Rpb24gPSBBUEk6Ok5hdmln YXRpb25BY3Rpb246OmNyZWF0ZShuYXZpZ2F0aW9uQWN0aW9uRGF0YSwgc291cmNlRnJhbWVJbmZv LnB0cigpLCBudWxscHRyLCByZXNvdXJjZVJlcXVlc3QsIFdlYkNvcmU6OlVSTCgpLCBzaG91bGRP cGVuQXBwTGlua3MpOwotCi0gICAgICAgICAgICBhdXRvIGFwaVdpbmRvd0ZlYXR1cmVzID0gQVBJ OjpXaW5kb3dGZWF0dXJlczo6Y3JlYXRlKHdpbmRvd0ZlYXR1cmVzKTsKLQotICAgICAgICAgICAg cmV0dXJuIGFkb3B0UmVmKHRvSW1wbChtX2NsaWVudC5jcmVhdGVOZXdQYWdlKHRvQVBJKHBhZ2Up LCB0b0FQSShjb25maWd1cmF0aW9uLnB0cigpKSwgdG9BUEkoYXBpTmF2aWdhdGlvbkFjdGlvbi5w dHIoKSksIHRvQVBJKGFwaVdpbmRvd0ZlYXR1cmVzLnB0cigpKSwgbV9jbGllbnQuYmFzZS5jbGll bnRJbmZvKSkpOworICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgICAgIH0KIAogICAg ICAgICB2aXJ0dWFsIHZvaWQgc2hvd1BhZ2UoV2ViUGFnZVByb3h5KiBwYWdlKSBvdmVycmlkZQo=