151803 2015-12-03 07:01:55 -0800 [WinCairo][MediaFoundation] Main thread can block when session is destroyed. 2015-12-03 11:33:45 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham oldest_to_newest 1145919 0 peavo 2015-12-03 07:01:55 -0800 I thought I fixed this in http://trac.webkit.org/changeset/192578, but it turns out it wasn't fixed properly. This time for real :) 1145920 1 266528 peavo 2015-12-03 07:08:09 -0800 Created attachment 266528 Patch 1145943 2 266528 achristensen 2015-12-03 10:04:30 -0800 Comment on attachment 266528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266528&action=review > Source/WebCore/ChangeLog:8 > + Set flag make sure that the scheduler thread stops when the session ends. ...to make sure... 1145980 3 peavo 2015-12-03 11:32:55 -0800 (In reply to comment #2) > Comment on attachment 266528 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266528&action=review > > > Source/WebCore/ChangeLog:8 > > + Set flag make sure that the scheduler thread stops when the session ends. > > ...to make sure... Will fix, thanks for reviewing :) 1145983 4 peavo 2015-12-03 11:33:45 -0800 Committed r193353: <http://trac.webkit.org/changeset/193353>. 266528 2015-12-03 07:08:09 -0800 2015-12-03 10:04:30 -0800 Patch bug-151803-20151203160751.patch text/plain 4432 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5Mjk5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTEyLTAzICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dW01lZGlh Rm91bmRhdGlvbl0gTWFpbiB0aHJlYWQgY2FuIGJsb2NrIHdoZW4gc2Vzc2lvbiBpcyBkZXN0cm95 ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE4 MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQg ZmxhZyBtYWtlIHN1cmUgdGhhdCB0aGUgc2NoZWR1bGVyIHRocmVhZCBzdG9wcyB3aGVuIHRoZSBz ZXNzaW9uIGVuZHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6VmlkZW9TY2hlZHVsZXI6OnN0b3BTY2hlZHVsZXIp OgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpW aWRlb1NjaGVkdWxlcjo6cHJvY2Vzc1NhbXBsZXNJblF1ZXVlKToKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6VmlkZW9TY2hlZHVsZXI6OnNjaGVk dWxlclRocmVhZFByb2NQcml2YXRlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4v TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmg6CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OlZpZGVvU2NoZWR1bGVyOjpzdG9wVGhy ZWFkKToKKwogMjAxNS0xMi0wMiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAK ICAgICAgICAgTW92ZSBSZXNvdXJjZUxvYWRTY2hlZHVsZXIgdG8gV2ViS2l0MQpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlh Rm91bmRhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAJKHJldmlzaW9u IDE5Mjk5NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBs YXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjAyLDE0 ICsyMjAyLDggQEAgSFJFU1VMVCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpbwogICAg IGlmICghbV9zY2hlZHVsZXJUaHJlYWQuaXNWYWxpZCgpKQogICAgICAgICByZXR1cm4gU19PSzsK IAotICAgIHsKLSAgICAgICAgLy8gQ2xlYXJpbmcgdGhlIHNhbXBsZSBxdWV1ZSBiZWZvcmUgd2Ug cG9zdCB0aGUgdGhyZWFkIHRlcm1pbmF0ZSBtZXNzYWdlIHdpbGwgbWFrZSBzdXJlCi0gICAgICAg IC8vIHRoZSB0aHJlYWQgZXhpdHMgcXVpY2tseSwgYW5kIHdlIHdpbGwgbm90IGJlIHN0dWNrIHdh aXRpbmcgZm9yIGl0IHRvIGZpbmlzaC4KLSAgICAgICAgTG9ja0hvbGRlciBsb2NrZXIobV9sb2Nr KTsKLSAgICAgICAgbV9zY2hlZHVsZWRTYW1wbGVzLmNsZWFyKCk7Ci0gICAgfQotCiAgICAgLy8g VGVybWluYXRlIHRoZSBzY2hlZHVsZXIgdGhyZWFkCisgICAgc3RvcFRocmVhZCgpOwogICAgIDo6 UG9zdFRocmVhZE1lc3NhZ2UobV90aHJlYWRJRCwgRXZlbnRUZXJtaW5hdGUsIDAsIDApOwogCiAg ICAgLy8gV2FpdCBmb3IgdGhlIHNjaGVkdWxlciB0aHJlYWQgdG8gZmluaXNoLgpAQCAtMjIxNyw2 ICsyMjExLDcgQEAgSFJFU1VMVCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpbwogCiAg ICAgTG9ja0hvbGRlciBsb2NrZXIobV9sb2NrKTsKIAorICAgIG1fc2NoZWR1bGVkU2FtcGxlcy5j bGVhcigpOwogICAgIG1fc2NoZWR1bGVyVGhyZWFkLmNsZWFyKCk7CiAgICAgbV9mbHVzaEV2ZW50 LmNsZWFyKCk7CiAKQEAgLTIyODEsNyArMjI3Niw3IEBAIEhSRVNVTFQgTWVkaWFQbGF5ZXJQcml2 YXRlTWVkaWFGb3VuZGF0aW8KIAogICAgIC8vIFByb2Nlc3Mgc2FtcGxlcyBhcyBsb25nIGFzIHRo ZXJlIGFyZSBzYW1wbGVzIGluIHRoZSBxdWV1ZSwgYW5kIHRoZXkgaGF2ZSBub3QgYXJyaXZlZCB0 b28gZWFybHkuCiAKLSAgICB3aGlsZSAodHJ1ZSkgeworICAgIHdoaWxlICghbV9leGl0VGhyZWFk KSB7CiAgICAgICAgIENPTVB0cjxJTUZTYW1wbGU+IHNhbXBsZTsKIAogICAgICAgICBpZiAodHJ1 ZSkgewpAQCAtMjQwMCwxNSArMjM5NSwxNSBAQCBEV09SRCBNZWRpYVBsYXllclByaXZhdGVNZWRp YUZvdW5kYXRpb246CiAgICAgU2V0RXZlbnQobV90aHJlYWRSZWFkeUV2ZW50LmdldCgpKTsKIAog ICAgIExPTkcgd2FpdCA9IElORklOSVRFOwotICAgIGJvb2wgZXhpdFRocmVhZCA9IGZhbHNlOwot ICAgIHdoaWxlICghZXhpdFRocmVhZCkgeworICAgIG1fZXhpdFRocmVhZCA9IGZhbHNlOworICAg IHdoaWxlICghbV9leGl0VGhyZWFkKSB7CiAgICAgICAgIC8vIFdhaXQgZm9yIG1lc3NhZ2VzCiAg ICAgICAgIERXT1JEIHJlc3VsdCA9IE1zZ1dhaXRGb3JNdWx0aXBsZU9iamVjdHMoMCwgbnVsbHB0 ciwgRkFMU0UsIHdhaXQsIFFTX1BPU1RNRVNTQUdFKTsKIAogICAgICAgICBpZiAocmVzdWx0ID09 IFdBSVRfVElNRU9VVCkgewogICAgICAgICAgICAgaHIgPSBwcm9jZXNzU2FtcGxlc0luUXVldWUo d2FpdCk7CiAgICAgICAgICAgICBpZiAoRkFJTEVEKGhyKSkKLSAgICAgICAgICAgICAgICBleGl0 VGhyZWFkID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBtX2V4aXRUaHJlYWQgPSB0cnVlOwogICAg ICAgICB9CiAKICAgICAgICAgd2hpbGUgKFBlZWtNZXNzYWdlKCZtc2csIG51bGxwdHIsIDAsIDAs IFBNX1JFTU9WRSkpIHsKQEAgLTI0MTYsNyArMjQxMSw3IEBAIERXT1JEIE1lZGlhUGxheWVyUHJp dmF0ZU1lZGlhRm91bmRhdGlvbjoKIAogICAgICAgICAgICAgc3dpdGNoIChtc2cubWVzc2FnZSkg ewogICAgICAgICAgICAgY2FzZSBFdmVudFRlcm1pbmF0ZToKLSAgICAgICAgICAgICAgICBleGl0 VGhyZWFkID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBtX2V4aXRUaHJlYWQgPSB0cnVlOwogICAg ICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgICAgICBjYXNlIEV2ZW50Rmx1c2g6CkBAIC0y NDMyLDcgKzI0MjcsNyBAQCBEV09SRCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246 CiAgICAgICAgICAgICAgICAgaWYgKHByb2Nlc3NTYW1wbGVzKSB7CiAgICAgICAgICAgICAgICAg ICAgIGhyID0gcHJvY2Vzc1NhbXBsZXNJblF1ZXVlKHdhaXQpOwogICAgICAgICAgICAgICAgICAg ICBpZiAoRkFJTEVEKGhyKSkKLSAgICAgICAgICAgICAgICAgICAgICAgIGV4aXRUaHJlYWQgPSB0 cnVlOworICAgICAgICAgICAgICAgICAgICAgICAgbV9leGl0VGhyZWFkID0gdHJ1ZTsKICAgICAg ICAgICAgICAgICAgICAgcHJvY2Vzc1NhbXBsZXMgPSAod2FpdCAhPSBJTkZJTklURSk7CiAgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGJyZWFrOwpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlv bi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9N ZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uaAkocmV2aXNpb24gMTkyOTk0KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1l ZGlhRm91bmRhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMzEsNiArMjMxLDEwIEBAIHByaXZh dGU6CiAgICAgICAgIGZsb2F0IG1fcGxheWJhY2tSYXRlIHsgMS4wZiB9OwogICAgICAgICBNRlRJ TUUgbV9mcmFtZUR1cmF0aW9uIHsgMCB9OwogICAgICAgICBNRlRJTUUgbV9sYXN0U2FtcGxlVGlt ZSB7IDAgfTsKKworICAgICAgICBzdGQ6OmF0b21pYzxib29sPiBtX2V4aXRUaHJlYWQgeyBmYWxz ZSB9OworCisgICAgICAgIHZvaWQgc3RvcFRocmVhZCgpIHsgbV9leGl0VGhyZWFkID0gdHJ1ZTsg fQogICAgIH07CiAKICAgICBjbGFzcyBEaXJlY3QzRFByZXNlbnRlciB7Cg==