151797 2015-12-03 00:09:43 -0800 [GTK] Test /webkit2/WebKitWebResource/get-data is flaky 2015-12-03 23:45:28 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned lforschler mrobinson pnormand zan oldest_to_newest 1145880 0 cgarcia 2015-12-03 00:09:43 -0800 Since we switched to use the network process to run the unit tests the test /webkit2/WebKitWebResource/get-data sometimes fails and sometimes passes: ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:194:void ResourcesTest::checkResourceData(WebKitWebResource*): code should not be reached FAIL This is because now the FIXME there doesn't seem to apply anymore: // FIXME: this should be 4 instead of 3, but we don't get the css image resource // due to bug https://bugs.webkit.org/show_bug.cgi?id=78510. test->waitUntilResourcesLoaded(3); We are now also getting the notification for the css image. Since we wait for 3 resources, sometimes the css image is loaded before and then checkResourceData is called for it, but not handled. When the css image is the last one loaded the test passes. So, we just need to wait for the 4 resources. 1145881 1 266515 cgarcia 2015-12-03 00:13:55 -0800 Created attachment 266515 Patch 1146228 2 cgarcia 2015-12-03 23:45:28 -0800 Committed r193412: <http://trac.webkit.org/changeset/193412> 266515 2015-12-03 00:13:55 -0800 2015-12-03 01:52:14 -0800 Patch wk2-get-data-flaky.diff text/plain 2803 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZTBh M2MyLi5mMzgwM2I0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTUtMTItMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2Vi S2l0V2ViUmVzb3VyY2UvZ2V0LWRhdGEgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTc5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHdlIHN3aXRjaGVkIHRvIHVzZSB0aGUgbmV0 d29yayBwcm9jZXNzIHRvIHJ1biB0aGUgdW5pdCB0ZXN0cworICAgICAgICB0aGUgdGVzdCAvd2Vi a2l0Mi9XZWJLaXRXZWJSZXNvdXJjZS9nZXQtZGF0YSBzb21ldGltZXMgZmFpbHMgYW5kCisgICAg ICAgIHNvbWV0aW1lcyBwYXNzZXMuIFdlIGFyZSBub3cgYWxzbyBnZXR0aW5nIHRoZSBub3RpZmlj YXRpb24gZm9yIHRoZQorICAgICAgICBjc3MgaW1hZ2UuIFNpbmNlIHdlIHdhaXQgZm9yIDMgcmVz b3VyY2VzLCBzb21ldGltZXMgdGhlIGNzcyBpbWFnZQorICAgICAgICBpcyBsb2FkZWQgYmVmb3Jl IGFuZCB0aGVuIGNoZWNrUmVzb3VyY2VEYXRhIGlzIGNhbGxlZCBmb3IgaXQsIGJ1dAorICAgICAg ICBub3QgaGFuZGxlZC4gV2hlbiB0aGUgY3NzIGltYWdlIGlzIHRoZSBsYXN0IG9uZSBsb2FkZWQg dGhlIHRlc3QKKyAgICAgICAgcGFzc2VzLiBTbywgd2UganVzdCBuZWVkIHRvIHdhaXQgZm9yIHRo ZSA0IHJlc291cmNlcy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0 ay9UZXN0UmVzb3VyY2VzLmNwcDoKKyAgICAgICAgKHRlc3RXZWJSZXNvdXJjZUdldERhdGEpOgor CiAyMDE1LTExLTMwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgTWFrZSBQcm9jZXNzTW9kZWwgYWx3YXlzIE11bHRpcGxlU2Vjb25kYXJ5UHJv Y2Vzc2VzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsv VGVzdFJlc291cmNlcy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsv VGVzdFJlc291cmNlcy5jcHAKaW5kZXggNzA1YWQ1Yi4uMTUxMGU1ZCAxMDA2NDQKLS0tIGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RSZXNvdXJjZXMuY3BwCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0UmVzb3VyY2VzLmNwcApA QCAtMTkwLDYgKzE5MCwxMyBAQCBwdWJsaWM6CiAgICAgICAgIH0gZWxzZSBpZiAodXJpID09IGtT ZXJ2ZXItPmdldFVSSUZvclBhdGgoIi9qYXZhc2NyaXB0LmpzIikpIHsKICAgICAgICAgICAgIGdf YXNzZXJ0X2NtcGludChtX3Jlc291cmNlRGF0YVNpemUsID09LCBzdHJsZW4oa0phdmFzY3JpcHQp KTsKICAgICAgICAgICAgIGdfYXNzZXJ0KCFzdHJuY21wKG1fcmVzb3VyY2VEYXRhLmdldCgpLCBr SmF2YXNjcmlwdCwgbV9yZXNvdXJjZURhdGFTaXplKSk7CisgICAgICAgIH0gZWxzZSBpZiAodXJp ID09IGtTZXJ2ZXItPmdldFVSSUZvclBhdGgoIi9ibGFuay5pY28iKSkgeworICAgICAgICAgICAg R1VuaXF1ZVB0cjxjaGFyPiBmaWxlUGF0aChnX2J1aWxkX2ZpbGVuYW1lKFRlc3Q6OmdldFJlc291 cmNlc0RpcigpLmRhdGEoKSwgImJsYW5rLmljbyIsIG51bGxwdHIpKTsKKyAgICAgICAgICAgIEdV bmlxdWVPdXRQdHI8Y2hhcj4gY29udGVudHM7CisgICAgICAgICAgICBnc2l6ZSBjb250ZW50c0xl bmd0aDsKKyAgICAgICAgICAgIGdfZmlsZV9nZXRfY29udGVudHMoZmlsZVBhdGguZ2V0KCksICZj b250ZW50cy5vdXRQdHIoKSwgJmNvbnRlbnRzTGVuZ3RoLCBudWxscHRyKTsKKyAgICAgICAgICAg IGdfYXNzZXJ0X2NtcGludChtX3Jlc291cmNlRGF0YVNpemUsID09LCBjb250ZW50c0xlbmd0aCk7 CisgICAgICAgICAgICBnX2Fzc2VydCghbWVtY21wKG1fcmVzb3VyY2VEYXRhLmdldCgpLCBjb250 ZW50cy5nZXQoKSwgY29udGVudHNMZW5ndGgpKTsKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAg ICBnX2Fzc2VydF9ub3RfcmVhY2hlZCgpOwogICAgICAgICBtX3Jlc291cmNlRGF0YS5yZXNldCgp OwpAQCAtNTE4LDkgKzUyNSw3IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJSZXNvdXJjZUFjdGl2ZVVS SShSZXNvdXJjZVVSSVRyYWNraW5nVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlCiBzdGF0aWMgdm9p ZCB0ZXN0V2ViUmVzb3VyY2VHZXREYXRhKFJlc291cmNlc1Rlc3QqIHRlc3QsIGdjb25zdHBvaW50 ZXIpCiB7CiAgICAgdGVzdC0+bG9hZFVSSShrU2VydmVyLT5nZXRVUklGb3JQYXRoKCIvIikuZGF0 YSgpKTsKLSAgICAvLyBGSVhNRTogdGhpcyBzaG91bGQgYmUgNCBpbnN0ZWFkIG9mIDMsIGJ1dCB3 ZSBkb24ndCBnZXQgdGhlIGNzcyBpbWFnZSByZXNvdXJjZQotICAgIC8vIGR1ZSB0byBidWcgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NTEwLgotICAgIHRlc3QtPndh aXRVbnRpbFJlc291cmNlc0xvYWRlZCgzKTsKKyAgICB0ZXN0LT53YWl0VW50aWxSZXNvdXJjZXNM b2FkZWQoNCk7CiAKICAgICBXZWJLaXRXZWJSZXNvdXJjZSogcmVzb3VyY2UgPSB3ZWJraXRfd2Vi X3ZpZXdfZ2V0X21haW5fcmVzb3VyY2UodGVzdC0+bV93ZWJWaWV3KTsKICAgICBnX2Fzc2VydChy ZXNvdXJjZSk7Cg==