151792 2015-12-02 21:05:26 -0800 REGRESSION(r192753): Remote Web Inspector: Enabling Remote Inspection on Auto Inspect candidate Debuggable doesn't show up in debuggers 2015-12-03 10:56:11 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1145857 0 joepeck 2015-12-02 21:05:26 -0800 * SUMMARY Remote Web Inspector: Allowing Remote Inspection on a Debuggable doesn't make it appear * STEPS TO REPRODUCE 1. Start Application 1.1: JSRemoteInspectorSetInspectionEnabledByDefault(false); 1.2: Create a JSContext 1.3: -[JSContext _setRemoteInspectionEnabled:YES] 2. Launch Safari => Develop menu doesn't show the JSContext * NOTES - Probably also happens if you just toggle RemoteInspectionEnabled NO then YES. - RemoteInspector::updateAutomaticInspectionCandidate should be identical to RemoteInspector::updateTarget and create the listing if it didn't exist. 1145858 1 webkit-bug-importer 2015-12-02 21:05:59 -0800 <rdar://problem/23737525> 1145859 2 266509 joepeck 2015-12-02 21:07:48 -0800 Created attachment 266509 [PATCH] Proposed Fix 1145945 3 266509 bburg 2015-12-03 10:11:28 -0800 Comment on attachment 266509 [PATCH] Proposed Fix r=me 1145964 4 266509 commit-queue 2015-12-03 10:56:09 -0800 Comment on attachment 266509 [PATCH] Proposed Fix Clearing flags on attachment: 266509 Committed r193188: <http://trac.webkit.org/changeset/193188> 1145965 5 commit-queue 2015-12-03 10:56:11 -0800 All reviewed patches have been landed. Closing bug. 266509 2015-12-02 21:07:48 -0800 2015-12-03 10:56:09 -0800 [PATCH] Proposed Fix fix-4.patch text/plain 2096 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGEzYTc1MGEuLjdkM2Y4MjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTEyLTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTihyMTkyNzUzKTog UmVtb3RlIFdlYiBJbnNwZWN0b3I6IEVuYWJsaW5nIFJlbW90ZSBJbnNwZWN0aW9uIG9uIEF1dG8g SW5zcGVjdCBjYW5kaWRhdGUgRGVidWdnYWJsZSBkb2Vzbid0IHNob3cgdXAgaW4gZGVidWdnZXJz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE3OTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3Bl Y3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tOgorICAgICAgICAoSW5zcGVjdG9yOjpSZW1v dGVJbnNwZWN0b3I6OnVwZGF0ZUF1dG9tYXRpY0luc3BlY3Rpb25DYW5kaWRhdGUpOgorICAgICAg ICBXaGVuIG1fZGVidWdnYWJsZXNNYXAgd2FzIHNwbGl0IGludG8gYm90aCBtX3RhcmdldE1hcCBh bmQgbV9saXN0aW5nTWFwCisgICAgICAgIHRoaXMgcGFydGljdWxhciBjYXNlIHdhcyBtaXNzZWQg aW4gdXBkYXRpbmcgYm90aCB0aGUgdGFyZ2V0IGFuZCBsaXN0aW5nCisgICAgICAgIHdoZW4gdGhl IHRhcmdldCBpcyB1cGRhdGVkLiBXZSBzaG91bGQgbWF0Y2ggUmVtb3RlSW5zcGVjdG9yOjp1cGRh dGVUYXJnZXQKKyAgICAgICAgYW5kIHVwZGF0ZSB0aGUgbGlzdGluZyBtYXAgYXMgdGhlIGRlYnVn Z2FibGUgbWF5IGhhdmUgY2hhbmdlZCB0byBiZQorICAgICAgICBhbGxvd2VkIHRvIGRlYnVnLgor CisyMDE1LTEyLTAyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAg ICAgICAgUkVHUkVTU0lPTjoocjE5Mjc1Myk6IFJlbW90ZSBXZWIgSW5zcGVjdG9yOiBSZW1vdGVJ bnNwZWN0b3I6OnNlbmRNZXNzYWdlVG9SZW1vdGUgd2l0aCBudWxsIGNvbm5lY3Rpb24KICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTc4OQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNw ZWN0b3IubW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJ bnNwZWN0b3IubW0KaW5kZXggYWQ1ZTUzYi4uMGZkYWFlOSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbQpA QCAtMjAwLDYgKzIwMCwxMCBAQCB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6dXBkYXRlQXV0b21hdGlj SW5zcGVjdGlvbkNhbmRpZGF0ZShSZW1vdGVJbnNwZWN0aW9uVGFyZ2V0KgogICAgICAgICBhdXRv IHJlc3VsdCA9IG1fdGFyZ2V0TWFwLnNldChpZGVudGlmaWVyLCB0YXJnZXQpOwogICAgICAgICBB U1NFUlRfVU5VU0VEKHJlc3VsdCwgIXJlc3VsdC5pc05ld0VudHJ5KTsKIAorICAgICAgICAvLyBJ ZiB0aGUgdGFyZ2V0IGhhcyBqdXN0IGFsbG93ZWQgcmVtb3RlIGNvbnRyb2wsIHRoZW4gdGhlIGxp c3Rpbmcgd29uJ3QgZXhpc3QgeWV0LgorICAgICAgICBpZiAoUmV0YWluUHRyPE5TRGljdGlvbmFy eT4gbGlzdGluZyA9IGxpc3RpbmdGb3JUYXJnZXQoKnRhcmdldCkpCisgICAgICAgICAgICBtX2xp c3RpbmdNYXAuc2V0KGlkZW50aWZpZXIsIGxpc3RpbmcpOworCiAgICAgICAgIC8vIERvbid0IGFs bG93IGF1dG9tYXRpYyBpbnNwZWN0aW9uIHVubGVzcyBpdCBpcyBhbGxvd2VkIG9yIHdlIGFyZSBz dG9wcGVkLgogICAgICAgICBpZiAoIW1fYXV0b21hdGljSW5zcGVjdGlvbkVuYWJsZWQgfHwgIW1f ZW5hYmxlZCkgewogICAgICAgICAgICAgcHVzaExpc3RpbmdzU29vbigpOwo=