151789 2015-12-02 19:40:58 -0800 REGRESSION(r192753): Remote Web Inspector: RemoteInspector::sendMessageToRemote with null connection 2015-12-03 11:33:33 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1145831 0 joepeck 2015-12-02 19:40:58 -0800 * SUMMARY Remote Web Inspector: RemoteInspector::sendMessageToRemote with null connection. * STEPS TO REPRODUCE 1. Launch Application with JSContext 2. Launch Safari 3. Safari: Develop > Current Machine > App > Context 4. Close Remote Inspection window while doing stuff => Possible CRASH * NOTES Previously the connection was null checked (as it could have been removed by another thread). It seems we lost the null check. (lldb) p connection (Inspector::RemoteConnectionToTarget *) $3 = 0x0000000000000000 > void RemoteInspector::sendMessageToRemote(unsigned identifier, const String& message) > { > ... > auto connection = m_connectionMap.get(identifier); > > NSDictionary *userInfo = @{ > WIRRawDataKey: [static_cast<NSString *>(message) dataUsingEncoding:NSUTF8StringEncoding], > WIRConnectionIdentifierKey: connection->connectionIdentifier(), > WIRDestinationKey: connection->destination() > }; > ... > } 1145832 1 webkit-bug-importer 2015-12-02 19:41:12 -0800 <rdar://problem/23737051> 1145833 2 266501 joepeck 2015-12-02 19:42:53 -0800 Created attachment 266501 [PATCH] Proposed Fix 1145981 3 266501 commit-queue 2015-12-03 11:33:30 -0800 Comment on attachment 266501 [PATCH] Proposed Fix Clearing flags on attachment: 266501 Committed r193355: <http://trac.webkit.org/changeset/193355> 1145982 4 commit-queue 2015-12-03 11:33:33 -0800 All reviewed patches have been landed. Closing bug. 266501 2015-12-02 19:42:53 -0800 2015-12-03 11:33:30 -0800 [PATCH] Proposed Fix crasher.patch text/plain 1514 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDgzYmQwNGYuLmEzYTc1MGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTEyLTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTjoocjE5Mjc1Myk6 IFJlbW90ZSBXZWIgSW5zcGVjdG9yOiBSZW1vdGVJbnNwZWN0b3I6OnNlbmRNZXNzYWdlVG9SZW1v dGUgd2l0aCBudWxsIGNvbm5lY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1MTc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IubW06Cisg ICAgICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6c2VuZE1lc3NhZ2VUb1JlbW90ZSk6 CisgICAgICAgIEJhaWwgaWYgdGhlIGNvbm5lY3Rpb24gaXMgbm8gbG9uZ2VyIGF2YWlsYWJsZS4g SXQgbWF5IGhhdmUKKyAgICAgICAgYmVlbiBjbG9zZWQgcmVtb3RlbHkuCisKKzIwMTUtMTItMDIg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBSRUdSRVNT SU9OOihyMTkyNzUzKTogUmVtb3RlIFdlYiBJbnNwZWN0b3I6IFdpbmRvdyBpbW1lZGlhdGVseSBj bG9zZXMgYWZ0ZXIgb3BlbmluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUxNzg4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbQppbmRleCA3ZDI3ZWFiLi5hZDVl NTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9S ZW1vdGVJbnNwZWN0b3IubW0KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9y ZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCkBAIC0yNjQsNiArMjY0LDggQEAgdm9pZCBSZW1vdGVJ bnNwZWN0b3I6OnNlbmRNZXNzYWdlVG9SZW1vdGUodW5zaWduZWQgaWRlbnRpZmllciwgY29uc3Qg U3RyaW5nJiBtZXMKICAgICAgICAgcmV0dXJuOwogCiAgICAgYXV0byBjb25uZWN0aW9uID0gbV9j b25uZWN0aW9uTWFwLmdldChpZGVudGlmaWVyKTsKKyAgICBpZiAoIWNvbm5lY3Rpb24pCisgICAg ICAgIHJldHVybjsKIAogICAgIE5TRGljdGlvbmFyeSAqdXNlckluZm8gPSBAewogICAgICAgICBX SVJSYXdEYXRhS2V5OiBbc3RhdGljX2Nhc3Q8TlNTdHJpbmcgKj4obWVzc2FnZSkgZGF0YVVzaW5n RW5jb2Rpbmc6TlNVVEY4U3RyaW5nRW5jb2RpbmddLAo=