151787 2015-12-02 18:48:13 -0800 REGRESSION(r192753): Remote Web Inspector: Applications and Debuggables not showing up in debuggers 2015-12-02 20:05:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1145810 0 joepeck 2015-12-02 18:48:13 -0800 * SUMMARY Applications and Debuggables not showing up in debuggers. * STEPS TO REPRODUCE 1. Launch application with JSContext 2. Launch Safari 3. Show Develop menu 4. Hover the JSContext (to trigger Indication) 5. Quit Safari 6. Launch Safari again 7. Show Develop menu => Application and JSContext not listed * NOTES Sampling the application with JSContext results in unexpected time hanging in receivedIndicateMessage: > 2526 Inspector::RemoteInspectorXPCConnection::handleEvent > 2526 Inspector::RemoteInspector::xpcConnectionReceivedMessage > 2526 Inspector::RemoteInspector::receivedIndicateMessage > 2526 WTF::LockBase::lockSlow > 2526 WTF::ParkingLot::parkConditionally > 2526 std::__1::condition_variable::wait > 2526 _pthread_cond_wait > 2526 __psynch_cvwait Seems there was an errant lock_guard added to RemoteInspector::receivedIndicateMessage that did nothing, but caused this. 1145811 1 joepeck 2015-12-02 18:48:25 -0800 <rdar://problem/23728977> 1145812 2 266494 joepeck 2015-12-02 18:50:16 -0800 Created attachment 266494 [PATCH] Proposed Fix 1145840 3 266494 commit-queue 2015-12-02 20:05:23 -0800 Comment on attachment 266494 [PATCH] Proposed Fix Clearing flags on attachment: 266494 Committed r192991: <http://trac.webkit.org/changeset/192991> 1145841 4 commit-queue 2015-12-02 20:05:28 -0800 All reviewed patches have been landed. Closing bug. 266494 2015-12-02 18:50:16 -0800 2015-12-02 20:05:23 -0800 [PATCH] Proposed Fix remove-lock.patch text/plain 1448 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDViY2U0OTQuLjIzYWUwNDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTkyNzUzKTog UmVtb3RlIFdlYiBJbnNwZWN0b3I6IEFwcGxpY2F0aW9ucyBhbmQgRGVidWdnYWJsZXMgbm90IHNo b3dpbmcgdXAgaW4gZGVidWdnZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTE3ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGluc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tOgorICAg ICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVkSW5kaWNhdGVNZXNzYWdl KToKKyAgICAgICAgUmVtb3ZlZCBsb2NrIHRoYXQgd2FzIHVubmVjZXNzYXJpbHkgYWRkZWQgaW4g cjE5Mjc1My4gSXQgd2FzCisgICAgICAgIHByb3RlY3Rpbmcgbm90aGluZy4KKwogMjAxNS0xMi0w MSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbRVM2 XSBJbXBsZW1lbnQgTExJbnQvQmFzZWxpbmUgU3VwcG9ydCBmb3IgRVM2IEdlbmVyYXRvcnMgYW5k IGVuYWJsZSB0aGlzIGZlYXR1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbQppbmRleCAxYjMwYjBmLi45ODI0 ZmJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9S ZW1vdGVJbnNwZWN0b3IubW0KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9y ZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCkBAIC02ODUsOCArNjg1LDYgQEAgdm9pZCBSZW1vdGVJ bnNwZWN0b3I6OnJlY2VpdmVkSW5kaWNhdGVNZXNzYWdlKE5TRGljdGlvbmFyeSAqdXNlckluZm8p CiAKICAgICBCT09MIGluZGljYXRlRW5hYmxlZCA9IFtbdXNlckluZm8gb2JqZWN0Rm9yS2V5OldJ UkluZGljYXRlRW5hYmxlZEtleV0gYm9vbFZhbHVlXTsKIAotICAgIHN0ZDo6bG9ja19ndWFyZDxM b2NrPiBsb2NrKG1fbXV0ZXgpOwotCiAgICAgY2FsbE9uV2ViVGhyZWFkT3JEaXNwYXRjaEFzeW5j T25NYWluVGhyZWFkKF57CiAgICAgICAgIFJlbW90ZUNvbnRyb2xsYWJsZVRhcmdldCogdGFyZ2V0 ID0gbnVsbHB0cjsKICAgICAgICAgewo=