151775 2015-12-02 14:20:10 -0800 Fix authentication requests with NetworkSession and canHandleHTTPSServerTrustEvaluation true 2015-12-02 15:51:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1145727 0 achristensen 2015-12-02 14:20:10 -0800 Fix authentication requests with NetworkSession and canHandleHTTPSServerTrustEvaluation true 1145728 1 266471 achristensen 2015-12-02 14:24:27 -0800 Created attachment 266471 Patch 1145755 2 achristensen 2015-12-02 15:17:12 -0800 rdar://problem/23586265 1145757 3 266471 cdumez 2015-12-02 15:18:38 -0800 Comment on attachment 266471 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266471&action=review r=me with suggestion > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:-284 > - notImplemented(); I would just do a: "auto completionHandler = WTF::move(m_completionHandler);" here, to avoid having to nullify m_completionHandler in all the branches. 1145768 4 achristensen 2015-12-02 15:51:30 -0800 http://trac.webkit.org/changeset/192982 266471 2015-12-02 14:24:27 -0800 2015-12-02 15:18:38 -0800 Patch bug-151775-20151202142403.patch text/plain 6210 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5Mjk2NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTEyLTAyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGF1dGhl bnRpY2F0aW9uIHJlcXVlc3RzIHdpdGggTmV0d29ya1Nlc3Npb24gYW5kIGNhbkhhbmRsZUhUVFBT U2VydmVyVHJ1c3RFdmFsdWF0aW9uIHRydWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MTc3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTA5NjggSSBjb3BpZWQgZnVuY3Rpb25hbGl0eSBmcm9tIAorICAgICAgICBOZXR3b3Jr TG9hZDo6Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZUFzeW5jIGludG8gTmV0 d29ya0xvYWQ6OmRpZFJlY2VpdmVDaGFsbGVuZ2UKKyAgICAgICAgYnV0IEkgb3Zlcmxvb2tlZCB0 aGUgY2FsbCB0byBtX2NsaWVudC5jYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNl QXN5bmMgd2hpY2ggaXMgbmVlZGVkCisgICAgICAgIGlmIGNhbkhhbmRsZUhUVFBTU2VydmVyVHJ1 c3RFdmFsdWF0aW9uIGlzIHRydWUuICBUaGlzIGFkZHMgdGhhdCBjYWxsIGFuZCBtb3ZlcyB3aGF0 IHNob3VsZCBoYXBwZW4KKyAgICAgICAgYWZ0ZXIgdGhhdCB0byBOZXR3b3JrTG9hZDo6Y29udGlu dWVDYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlLgorCisgICAgICAgICogTmV0 d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrTG9h ZDo6ZGlkUmVjZWl2ZUNoYWxsZW5nZSk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtMb2FkOjpk aWRSZWNlaXZlUmVzcG9uc2UpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrTG9hZDo6Y29udGlu dWVDYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKToKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5oOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdv cmtTZXNzaW9uLmg6CisgICAgICAgICogU2hhcmVkL0F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0 aW9uTWFuYWdlci5oOgorCiAyMDE1LTEyLTAxICBIdW5zZW9wIEplb25nICA8aHM4NS5qZW9uZ0Bz YW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggYnVpbGQgYWZ0ZXIgcjE5Mjkz MS4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5j cHAJKHJldmlzaW9uIDE5Mjg5NykKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05l dHdvcmtMb2FkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc3LDEyICsxNzcsOSBAQCB2b2lkIE5l dHdvcmtMb2FkOjpkaWRSZWNlaXZlQ2hhbGxlbmdlKGNvCiAgICAgICAgIHJldHVybjsKICAgICB9 CiAKLSAgICBpZiAobV9wYXJhbWV0ZXJzLmNsaWVudENyZWRlbnRpYWxQb2xpY3kgPT0gRG9Ob3RB c2tDbGllbnRGb3JBbnlDcmVkZW50aWFscykgewotICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihB dXRoZW50aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0aW9uOjpVc2VDcmVkZW50aWFsLCBDcmVkZW50 aWFsKCkpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgTmV0d29ya1Byb2Nlc3M6OnNp bmdsZXRvbigpLmF1dGhlbnRpY2F0aW9uTWFuYWdlcigpLmRpZFJlY2VpdmVBdXRoZW50aWNhdGlv bkNoYWxsZW5nZShtX3BhcmFtZXRlcnMud2ViUGFnZUlELCBtX3BhcmFtZXRlcnMud2ViRnJhbWVJ RCwgY2hhbGxlbmdlLCBjb21wbGV0aW9uSGFuZGxlcik7CisgICAgbV9jb21wbGV0aW9uSGFuZGxl ciA9IGNvbXBsZXRpb25IYW5kbGVyOworICAgIG1fY2hhbGxlbmdlID0gY2hhbGxlbmdlOworICAg IG1fY2xpZW50LmNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2VBc3luYyhjaGFs bGVuZ2UucHJvdGVjdGlvblNwYWNlKCkpOwogfQogCiB2b2lkIE5ldHdvcmtMb2FkOjpkaWRSZWNl aXZlUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UsIHN0ZDo6ZnVuY3Rp b248dm9pZChXZWJDb3JlOjpQb2xpY3lBY3Rpb24pPiBjb21wbGV0aW9uSGFuZGxlcikKQEAgLTI4 MCw4ICsyNzcsMjEgQEAgdm9pZCBOZXR3b3JrTG9hZDo6Y2FuQXV0aGVudGljYXRlQWdhaW5zdAog dm9pZCBOZXR3b3JrTG9hZDo6Y29udGludWVDYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlv blNwYWNlKGJvb2wgcmVzdWx0KQogewogI2lmIFVTRShORVRXT1JLX1NFU1NJT04pCi0gICAgLy8g RklYTUU6IERvIHNvbWV0aGluZyBoZXJlLgotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgQVNT RVJUKG1fY29tcGxldGlvbkhhbmRsZXIpOworICAgIGlmICghcmVzdWx0KSB7CisgICAgICAgIG1f Y29tcGxldGlvbkhhbmRsZXIoQXV0aGVudGljYXRpb25DaGFsbGVuZ2VEaXNwb3NpdGlvbjo6UGVy Zm9ybURlZmF1bHRIYW5kbGluZywgQ3JlZGVudGlhbCgpKTsKKyAgICAgICAgbV9jb21wbGV0aW9u SGFuZGxlciA9IG51bGxwdHI7CisgICAgICAgIHJldHVybjsKKyAgICB9CisgICAgCisgICAgaWYg KG1fcGFyYW1ldGVycy5jbGllbnRDcmVkZW50aWFsUG9saWN5ID09IERvTm90QXNrQ2xpZW50Rm9y QW55Q3JlZGVudGlhbHMpIHsKKyAgICAgICAgbV9jb21wbGV0aW9uSGFuZGxlcihBdXRoZW50aWNh dGlvbkNoYWxsZW5nZURpc3Bvc2l0aW9uOjpVc2VDcmVkZW50aWFsLCBDcmVkZW50aWFsKCkpOwor ICAgICAgICBtX2NvbXBsZXRpb25IYW5kbGVyID0gbnVsbHB0cjsKKyAgICAgICAgcmV0dXJuOwor ICAgIH0KKyAgICAKKyAgICBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9uKCkuYXV0aGVudGljYXRp b25NYW5hZ2VyKCkuZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG1fcGFyYW1ldGVy cy53ZWJQYWdlSUQsIG1fcGFyYW1ldGVycy53ZWJGcmFtZUlELCBtX2NoYWxsZW5nZSwgbV9jb21w bGV0aW9uSGFuZGxlcik7CisgICAgbV9jb21wbGV0aW9uSGFuZGxlciA9IG51bGxwdHI7CiAjZWxz ZQogICAgIG1faGFuZGxlLT5jb250aW51ZUNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9u U3BhY2UocmVzdWx0KTsKICNlbmRpZgpJbmRleDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvTmV0d29ya0xvYWQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrTG9hZC5oCShyZXZpc2lvbiAxOTI4OTcpCisrKyBTb3VyY2UvV2ViS2l0Mi9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw2ICszMiw3 IEBACiAKICNpZiBVU0UoTkVUV09SS19TRVNTSU9OKQogI2luY2x1ZGUgIk5ldHdvcmtTZXNzaW9u LmgiCisjaW5jbHVkZSA8V2ViQ29yZS9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZS5oPgogI2Vsc2UK ICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlSGFuZGxlQ2xpZW50Lmg+CiAjZW5kaWYKQEAgLTEx NSw2ICsxMTYsOCBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxSZW1vdGVOZXR3b3JraW5nQ29udGV4 dD4gbV9uZXR3b3JraW5nQ29udGV4dDsKICNpZiBVU0UoTkVUV09SS19TRVNTSU9OKQogICAgIFJl ZjxOZXR3b3JrRGF0YVRhc2s+IG1fdGFzazsKKyAgICBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNo YWxsZW5nZSBtX2NoYWxsZW5nZTsKKyAgICBDaGFsbGVuZ2VDb21wbGV0aW9uSGFuZGxlciBtX2Nv bXBsZXRpb25IYW5kbGVyOwogI2Vsc2UKICAgICBSZWZQdHI8V2ViQ29yZTo6UmVzb3VyY2VIYW5k bGU+IG1faGFuZGxlOwogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrU2Vzc2lvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL05ldHdvcmtTZXNzaW9uLmgJKHJldmlzaW9uIDE5Mjg5NykKKysrIFNvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtTZXNzaW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTYy LDcgKzYyLDggQEAgY2xhc3MgTmV0d29ya1Nlc3Npb247CiBjbGFzcyBOZXR3b3JrU2Vzc2lvblRh c2tDbGllbnQgewogcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCB3aWxsUGVyZm9ybUhUVFBSZWRp cmVjdGlvbihjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiwgY29uc3QgV2ViQ29yZTo6 UmVzb3VyY2VSZXF1ZXN0Jiwgc3RkOjpmdW5jdGlvbjx2b2lkKGNvbnN0IFdlYkNvcmU6OlJlc291 cmNlUmVxdWVzdCYpPikgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlQ2hhbGxlbmdl KGNvbnN0IFdlYkNvcmU6OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJiwgc3RkOjpmdW5jdGlvbjx2 b2lkKEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlRGlzcG9zaXRpb24sIGNvbnN0IFdlYkNvcmU6OkNy ZWRlbnRpYWwmKT4pID0gMDsKKyAgICB0eXBlZGVmIHN0ZDo6ZnVuY3Rpb248dm9pZChBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0aW9uLCBjb25zdCBXZWJDb3JlOjpDcmVkZW50aWFsJik+ IENoYWxsZW5nZUNvbXBsZXRpb25IYW5kbGVyOworICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZl Q2hhbGxlbmdlKGNvbnN0IFdlYkNvcmU6OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJiwgQ2hhbGxl bmdlQ29tcGxldGlvbkhhbmRsZXIpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZVJl c3BvbnNlKGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmLCBzdGQ6OmZ1bmN0aW9uPHZv aWQoV2ViQ29yZTo6UG9saWN5QWN0aW9uKT4pID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVj ZWl2ZURhdGEoUmVmUHRyPFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcj4mJikgPSAwOwogICAgIHZpcnR1 YWwgdm9pZCBkaWRDb21wbGV0ZVdpdGhFcnJvcihjb25zdCBXZWJDb3JlOjpSZXNvdXJjZUVycm9y JikgPSAwOwpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0F1dGhlbnRpY2F0aW9uL0F1dGhl bnRpY2F0aW9uTWFuYWdlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9B dXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdGlvbk1hbmFnZXIuaAkocmV2aXNpb24gMTkyODk3KQor KysgU291cmNlL1dlYktpdDIvU2hhcmVkL0F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uTWFu YWdlci5oCSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw3IEBAIHB1YmxpYzoKICAgICBzdGF0 aWMgY29uc3QgY2hhciogc3VwcGxlbWVudE5hbWUoKTsKIAogI2lmIFVTRShORVRXT1JLX1NFU1NJ T04pCi0gICAgdHlwZWRlZiBzdGQ6OmZ1bmN0aW9uPHZvaWQoQXV0aGVudGljYXRpb25DaGFsbGVu Z2VEaXNwb3NpdGlvbiwgY29uc3QgV2ViQ29yZTo6Q3JlZGVudGlhbCYpPiBDaGFsbGVuZ2VDb21w bGV0aW9uSGFuZGxlcjsKKyAgICB0eXBlZGVmIE5ldHdvcmtTZXNzaW9uVGFza0NsaWVudDo6Q2hh bGxlbmdlQ29tcGxldGlvbkhhbmRsZXIgQ2hhbGxlbmdlQ29tcGxldGlvbkhhbmRsZXI7CiAgICAg dm9pZCBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UodWludDY0X3QgcGFnZUlELCB1 aW50NjRfdCBmcmFtZUlELCBjb25zdCBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYs IENoYWxsZW5nZUNvbXBsZXRpb25IYW5kbGVyKTsKICNlbmRpZgogICAgIC8vIENhbGxlZCBmb3Ig cmVzb3VyY2VzIGluIHRoZSBXZWJQcm9jZXNzIChOZXR3b3JrUHJvY2VzcyBkaXNhYmxlZCkK