15176 2007-09-11 02:56:39 -0700 run-launcher overwrites LD_LIBRARY_PATH 2007-09-11 09:42:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) PC OS X 10.4 RESOLVED FIXED P2 Normal --- 1 sven webkit-unassigned ddkilzer richard oldest_to_newest 677 0 sven 2007-09-11 02:56:39 -0700 The run-launcher script contains this line of code which breaks running webkit against libraries that also need to specify LD_LIBRARY_PATH: $ENV{LD_LIBRARY_PATH} = $productDir; I'm going to attach a fix for this. 678 1 16249 sven 2007-09-11 02:59:34 -0700 Created attachment 16249 Proposed Patch 676 2 richard 2007-09-11 03:05:20 -0700 And while at it, shouldn't the directory really be $productDir/lib? 675 3 ddkilzer 2007-09-11 06:47:32 -0700 (In reply to comment #2) > And while at it, shouldn't the directory really be $productDir/lib? Please file a separate bug for this, or check with Gtk developers on IRC using irc.freenode.net on the #webkit channel. The existing script appears to be working, so I'm hesitant to mix that change with this one. 674 4 16249 ddkilzer 2007-09-11 06:52:38 -0700 Comment on attachment 16249 Proposed Patch Using $ENV{LD_LIBRARY_PATH} without checking to see if it's set will cause a "Use of uninitialized value" warning to be printed in the case where it's not set. You should do something like: $ENV{LD_LIBRARY_PATH} = $ENV{LD_LIBRARY_PATH} ? "$productDir:$ENV{LD_LIBRARY_PATH}" : $productDir; Setting review- flag to fix this issue. Please set the "review?" flag on patches in the future if you'd like them to be reviewed. (There is no need to set a email address with the review flag.) Also, please create a ChangeLog entry with the patch. (The description you have in your git commit message is great!) http://webkit.org/coding/contributing.html Thanks for reporting this bug! 664 5 16255 sven 2007-09-11 08:35:58 -0700 Created attachment 16255 Final Patch 663 6 16255 ddkilzer 2007-09-11 09:22:35 -0700 Comment on attachment 16255 Final Patch Great! r=me 658 7 ddkilzer 2007-09-11 09:42:32 -0700 $ svn commit WebKitTools/ChangeLog WebKitTools/Scripts/run-launcher Sending WebKitTools/ChangeLog Sending WebKitTools/Scripts/run-launcher Transmitting file data .. Committed revision 25492. 16249 2007-09-11 02:59:34 -0700 2007-09-11 08:35:58 -0700 Proposed Patch 0001-Fixed-the-library-path-in-the-launcher-script.patch text/plain 1037 sven RnJvbSA5YzFjZGU4NWI0M2Q0NTNlNGMyYmU3YzFjNWJmM2E0YmRlNjY3MTNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdmVuIEhlcnpiZXJnIDxzdmVuQGltZW5kaW8uY29tPgpEYXRl OiBUdWUsIDExIFNlcCAyMDA3IDExOjUxOjA4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4ZWQg dGhlIGxpYnJhcnkgcGF0aCBpbiB0aGUgbGF1bmNoZXIgc2NyaXB0CgoJKiBXZWJLaXRUb29scy9T Y3JpcHRzL3J1bi1sYXVuY2hlcjogZG9uJ3QgcmVwbGFjZSBMRF9MSUJSQVJZX1BBVEggd2l0aAoJ JHByb2plY3REaXIsIGJ1dCBwcmVwZW5kICRwcm9qZWN0RGlyIHRvIExEX0xJQlJBUllfUEFUSCAo dG8gcHJlc2VydmUKCW90aGVyIHBhdGhzIGVnLiBmcm9tIGpoYnVpbGQpCi0tLQogV2ViS2l0VG9v bHMvU2NyaXB0cy9ydW4tbGF1bmNoZXIgfCAgICAyICstCiAxIGZpbGVzIGNoYW5nZWQsIDEgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp cHRzL3J1bi1sYXVuY2hlciBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCmluZGV4 IDIzNDZlZGUuLjQ1ZTI3MGYgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLWxh dW5jaGVyCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCkBAIC00Niw3ICs0 Niw3IEBAIGNoZWNrRnJhbWV3b3JrcygpOwogcHJpbnQgIlN0YXJ0aW5nIHdlYmtpdCBsYXVuY2hl ciB3aXRoIExEX0xJQlJBUllfUEFUSCBzZXQgdG8gcG9pbnQgdG8gYnVpbHQgV2ViS2l0IGluICRw cm9kdWN0RGlyLlxuIjsKIAogbXkgQGFyZ3MgPSBAQVJHVjsKLSRFTlZ7TERfTElCUkFSWV9QQVRI fSA9ICRwcm9kdWN0RGlyOworJEVOVntMRF9MSUJSQVJZX1BBVEh9ID0gIiRwcm9kdWN0RGlyOiRF TlZ7TERfTElCUkFSWV9QQVRIfSI7CiAKIGlmIChpc0dkaygpKSB7CiAgICRsYXVuY2hlclBhdGgg PSAiJGxhdW5jaGVyUGF0aC9XZWJLaXRUb29scy9HZGtMYXVuY2hlci9HZGtMYXVuY2hlciI7Ci0t IAoxLjUuMi4zCgo= 16255 2007-09-11 08:35:58 -0700 2007-09-11 09:22:35 -0700 Final Patch final-patch.diff text/plain 1180 sven ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3MDgzMzNhLi4wMjU5YmMwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDkt MTEgIFN2ZW4gSGVyemJlcmcgIDxzdmVuQGltZW5kaW8uY29tPgorCisgICAgICAgIERvbid0IG92 ZXJ3cml0ZSBMRF9MSUJSQVJZX1BBVEgsIHByZXBlbmQgdG8gaXQuIEZpeGVzOgorICAgICAgICBo dHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE3NgorCisgICAgICAgICog U2NyaXB0cy9ydW4tbGF1bmNoZXI6IGRvbid0IHJlcGxhY2UgTERfTElCUkFSWV9QQVRIIHdpdGgK KyAgICAgICAgJHByb2plY3REaXIsIGJ1dCBwcmVwZW5kICRwcm9qZWN0RGlyIHRvIExEX0xJQlJB UllfUEFUSCAodG8gcHJlc2VydmUKKyAgICAgICAgb3RoZXIgcGF0aHMgZWcuIGZyb20gamhidWls ZCkKKwogMjAwNy0wOS0xMCAgS2V2aW4gTWNDdWxsb3VnaCAgPGttY2N1bGxvdWdoQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9ydW4tbGF1bmNoZXIgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi1sYXVuY2hlcgpp bmRleCAyMzQ2ZWRlLi5kNTg5YThlIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1 bi1sYXVuY2hlcgorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi1sYXVuY2hlcgpAQCAtNDYs NyArNDYsNyBAQCBjaGVja0ZyYW1ld29ya3MoKTsKIHByaW50ICJTdGFydGluZyB3ZWJraXQgbGF1 bmNoZXIgd2l0aCBMRF9MSUJSQVJZX1BBVEggc2V0IHRvIHBvaW50IHRvIGJ1aWx0IFdlYktpdCBp biAkcHJvZHVjdERpci5cbiI7CiAKIG15IEBhcmdzID0gQEFSR1Y7Ci0kRU5We0xEX0xJQlJBUllf UEFUSH0gPSAkcHJvZHVjdERpcjsKKyRFTlZ7TERfTElCUkFSWV9QQVRIfSA9ICRFTlZ7TERfTElC UkFSWV9QQVRIfSA/ICIkcHJvZHVjdERpcjokRU5We0xEX0xJQlJBUllfUEFUSH0iIDogJHByb2R1 Y3REaXI7CiAKIGlmIChpc0dkaygpKSB7CiAgICRsYXVuY2hlclBhdGggPSAiJGxhdW5jaGVyUGF0 aC9XZWJLaXRUb29scy9HZGtMYXVuY2hlci9HZGtMYXVuY2hlciI7Cg==