151757 2015-12-02 10:44:01 -0800 [WinCairo][MediaFoundation] Video is not rendered correctly on some graphics cards. 2015-12-02 11:46:43 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue oldest_to_newest 1145608 0 peavo 2015-12-02 10:44:01 -0800 We need to make sure we use the same bitmap format as in the Direct3D surface in video memory when copying surface data and rendering with Cairo. 1145612 1 266453 peavo 2015-12-02 10:47:51 -0800 Created attachment 266453 Patch 1145623 2 266453 achristensen 2015-12-02 11:03:42 -0800 Comment on attachment 266453 Patch This makes the video play on my NVIDIA GeForce GT 750M graphics card. It didn't work before. 1145638 3 peavo 2015-12-02 11:19:29 -0800 (In reply to comment #2) > Comment on attachment 266453 [details] > Patch > > This makes the video play on my NVIDIA GeForce GT 750M graphics card. It > didn't work before. Good news! Thanks for reviewing :) 1145646 4 266453 commit-queue 2015-12-02 11:46:40 -0800 Comment on attachment 266453 Patch Clearing flags on attachment: 266453 Committed r192951: <http://trac.webkit.org/changeset/192951> 1145647 5 commit-queue 2015-12-02 11:46:43 -0800 All reviewed patches have been landed. Closing bug. 266453 2015-12-02 10:47:51 -0800 2015-12-02 11:46:40 -0800 Patch bug-151757-20151202194732.patch text/plain 3641 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5Mjk0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTEyLTAyICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dW01lZGlh Rm91bmRhdGlvbl0gVmlkZW8gaXMgbm90IHJlbmRlcmVkIGNvcnJlY3RseSBvbiBzb21lIGdyYXBo aWNzIGNhcmRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTUxNzU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2UgbmVlZCB0byBtYWtlIHN1cmUgd2UgdXNlIHRoZSBzYW1lIGJpdG1hcCBmb3JtYXQgYXMg aW4gdGhlIERpcmVjdDNEIHN1cmZhY2UKKyAgICAgICAgaW4gdmlkZW8gbWVtb3J5IHdoZW4gY29w eWluZyBzdXJmYWNlIGRhdGEgYW5kIHJlbmRlcmluZyB3aXRoIENhaXJvLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246 OkRpcmVjdDNEUHJlc2VudGVyOjpwcmVzZW50U2FtcGxlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6RGlyZWN0M0RQcmVzZW50ZXI6OnBhaW50 Q3VycmVudEZyYW1lKToKKwogMjAxNS0xMi0wMiAgUGVyIEFybmUgVm9sbGFuICA8cGVhdm9Ab3V0 bG9vay5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBDb21waWxlIGVycm9yLgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlh Rm91bmRhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAJKHJldmlzaW9u IDE5Mjk0NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBs YXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjc3LDcg KzI2NzcsMTEgQEAgSFJFU1VMVCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpbwogCiAg ICAgICAgIGlmICh3aWR0aCA+IDAgJiYgaGVpZ2h0ID4gMCkgewogICAgICAgICAgICAgaWYgKCFt X21lbVN1cmZhY2UgfHwgbV93aWR0aCAhPSB3aWR0aCB8fCBtX2hlaWdodCAhPSBoZWlnaHQpIHsK LSAgICAgICAgICAgICAgICBociA9IG1fZGV2aWNlLT5DcmVhdGVPZmZzY3JlZW5QbGFpblN1cmZh Y2Uod2lkdGgsIGhlaWdodCwgRDNERk1UX0E4UjhHOEI4LCBEM0RQT09MX1NZU1RFTU1FTSwgJm1f bWVtU3VyZmFjZSwgbnVsbHB0cik7CisgICAgICAgICAgICAgICAgRDNERk9STUFUIGZvcm1hdCA9 IEQzREZNVF9BOFI4RzhCODsKKyAgICAgICAgICAgICAgICBEM0RTVVJGQUNFX0RFU0MgZGVzYzsK KyAgICAgICAgICAgICAgICBpZiAoU1VDQ0VFREVEKHN1cmZhY2UtPkdldERlc2MoJmRlc2MpKSkK KyAgICAgICAgICAgICAgICAgICAgZm9ybWF0ID0gZGVzYy5Gb3JtYXQ7CisgICAgICAgICAgICAg ICAgaHIgPSBtX2RldmljZS0+Q3JlYXRlT2Zmc2NyZWVuUGxhaW5TdXJmYWNlKHdpZHRoLCBoZWln aHQsIGZvcm1hdCwgRDNEUE9PTF9TWVNURU1NRU0sICZtX21lbVN1cmZhY2UsIG51bGxwdHIpOwog ICAgICAgICAgICAgICAgIG1fd2lkdGggPSB3aWR0aDsKICAgICAgICAgICAgICAgICBtX2hlaWdo dCA9IGhlaWdodDsKICAgICAgICAgICAgIH0KQEAgLTI3MjgsMTEgKzI3MzIsMzQgQEAgdm9pZCBN ZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OgogICAgICAgICB2b2lkKiBkYXRhID0g bG9ja2VkUmVjdC5wQml0czsKICAgICAgICAgaW50IHBpdGNoID0gbG9ja2VkUmVjdC5QaXRjaDsK ICNpZiBVU0UoQ0FJUk8pCi0gICAgICAgIFdlYkNvcmU6OlBsYXRmb3JtQ29udGV4dENhaXJvKiBj dHh0ID0gY29udGV4dC5wbGF0Zm9ybUNvbnRleHQoKTsKLSAgICAgICAgY2Fpcm9fc3VyZmFjZV90 KiBpbWFnZSA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zvcl9kYXRhKHN0YXRpY19jYXN0 PHVuc2lnbmVkIGNoYXIqPihkYXRhKSwgQ0FJUk9fRk9STUFUX0FSR0IzMiwgd2lkdGgsIGhlaWdo dCwgcGl0Y2gpOworICAgICAgICBEM0RGT1JNQVQgZm9ybWF0ID0gRDNERk1UX1VOS05PV047Cisg ICAgICAgIEQzRFNVUkZBQ0VfREVTQyBkZXNjOworICAgICAgICBpZiAoU1VDQ0VFREVEKG1fbWVt U3VyZmFjZS0+R2V0RGVzYygmZGVzYykpKQorICAgICAgICAgICAgZm9ybWF0ID0gZGVzYy5Gb3Jt YXQ7CisKKyAgICAgICAgY2Fpcm9fZm9ybWF0X3QgY2Fpcm9Gb3JtYXQgPSBDQUlST19GT1JNQVRf SU5WQUxJRDsKKworICAgICAgICBzd2l0Y2ggKGZvcm1hdCkgeworICAgICAgICBjYXNlIEQzREZN VF9BOFI4RzhCODoKKyAgICAgICAgICAgIGNhaXJvRm9ybWF0ID0gQ0FJUk9fRk9STUFUX0FSR0Iz MjsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEQzREZNVF9YOFI4RzhCODoKKyAg ICAgICAgICAgIGNhaXJvRm9ybWF0ID0gQ0FJUk9fRk9STUFUX1JHQjI0OworICAgICAgICAgICAg YnJlYWs7CisgICAgICAgIH0KKworICAgICAgICBBU1NFUlQoY2Fpcm9Gb3JtYXQgIT0gQ0FJUk9f Rk9STUFUX0lOVkFMSUQpOworCisgICAgICAgIGNhaXJvX3N1cmZhY2VfdCogaW1hZ2UgPSBudWxs cHRyOworICAgICAgICBpZiAoY2Fpcm9Gb3JtYXQgIT0gQ0FJUk9fRk9STUFUX0lOVkFMSUQpCisg ICAgICAgICAgICBpbWFnZSA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zvcl9kYXRhKHN0 YXRpY19jYXN0PHVuc2lnbmVkIGNoYXIqPihkYXRhKSwgY2Fpcm9Gb3JtYXQsIHdpZHRoLCBoZWln aHQsIHBpdGNoKTsKKwogICAgICAgICBGbG9hdFJlY3Qgc3JjUmVjdCgwLCAwLCB3aWR0aCwgaGVp Z2h0KTsKLSAgICAgICAgY3R4dC0+ZHJhd1N1cmZhY2VUb0NvbnRleHQoaW1hZ2UsIGRlc3RSZWN0 LCBzcmNSZWN0LCBjb250ZXh0KTsKLSAgICAgICAgY2Fpcm9fc3VyZmFjZV9kZXN0cm95KGltYWdl KTsKKyAgICAgICAgaWYgKGltYWdlKSB7CisgICAgICAgICAgICBXZWJDb3JlOjpQbGF0Zm9ybUNv bnRleHRDYWlybyogY3R4dCA9IGNvbnRleHQucGxhdGZvcm1Db250ZXh0KCk7CisgICAgICAgICAg ICBjdHh0LT5kcmF3U3VyZmFjZVRvQ29udGV4dChpbWFnZSwgZGVzdFJlY3QsIHNyY1JlY3QsIGNv bnRleHQpOworICAgICAgICAgICAgY2Fpcm9fc3VyZmFjZV9kZXN0cm95KGltYWdlKTsKKyAgICAg ICAgfQogI2Vsc2UKICNlcnJvciAiUGxhdGZvcm0gbmVlZHMgdG8gaW1wbGVtZW50IGRyYXdpbmcg b2YgRGlyZWN0M0Qgc3VyZmFjZSB0byBncmFwaGljcyBjb250ZXh0ISIKICNlbmRpZgo=